- 04 Jun, 2004 16 commits
-
-
Alexander Viro authored
-
Alexander Viro authored
The rest of ->ifr_data cleanups. A bunch of drivers use address of ifr->ifr_ifru, but spell that as &ifr->ifr_data, which expands to &ifr->ifr_ifru.ifru_data. ifr_ifru is a union and in effect they sneak in a private field into that union; ifr_ifru.ifru_data is a field in that union and it has nothing to do with the things they want to do. Cleaned up by explicit use of &ifr->ifr_ifru. Several places where we really use ->ifr_data (i.e. use its value and use it as __user pointer) annotated.
-
Alexander Viro authored
From: Jeff Garzik Jeff's patch adds a helper for obtaining mii_ioctl_data from ifreq and switches drivers to it. It's almost a "move common expression into inline helper", except that instead of (struct mii_ioctl_data *)&rq->ifr_ifru.ifru_data it does (struct mii_ioctl_data *)&rq->ifr_ifru - pointer to union instead of pointer to a field of union that has nothing to do with mii_ioctl_data *and* adds confusion by being a pointer itself.
-
Bartlomiej Zolnierkiewicz authored
Some boards don't support C1 Halt Disconnect. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
assorted minor bits in drivers/* - all independent, but there's some limit to splitting stuff...
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
several pointers in ioctl structures marked as userland ones. And that's it with this patchset. A couple more of those and we'll be done with the noise warnings ;-)
-
- 03 Jun, 2004 24 commits
-
-
Alexander Viro authored
s2io.c: bogus initializer ({{"a"},{"b"}} has too many braces for two-dimensional array of char - strings are arrays themselves). de4x5.h: missing __user on a pointer in ioctl structure. airo.c: cleaned up and fixed procfs ->read() and ->write()
-
Alexander Viro authored
osst.c, st.c, scsi_debug.c annotated.
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
selinuxfs.c annotated
-
Alexander Viro authored
-
Alexander Viro authored
b44.c: ->ioctl() is broken, since it uses &ifr->ifr_data instead of ifr->ifr_data itself. Surprise, surprise, copy_from_user() on that address doesn't do any good... baycom_epp.c: does get_user() of the first word of structure, then immediately does copy_from_user() on the entire thing and completely ignores the value read by get_user() (it uses the same value in copied structure instead). Bogus get_user() call removed.
-
Alexander Viro authored
->ifr_data users annotated.
-
Paul Mackerras authored
Some code that is used on iSeries (do_hash_page_DSI in head.S) was clearing the RI (recoverable interrupt) bit in the MSR when it shouldn't. We were getting SLB miss interrupts following that which were panicking because they appeared to have occurred at a bad place. This patch fixes the problem. In fact it isn't necessary for do_hash_page_DSI to do anything to RI, so the patch changes the code to not set or clear it. Signed-off-by: Paul Mackerras <paulus@samba.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
net/bridge partially annotated. There are nasty problems with net/bridge/netfilter/* and they'll need to be dealt with at some point - it mixes kernel and userland pointers a lot and while it seems to avoid obvious breakage, it's not a nice code.
-
Alexander Viro authored
-
Alexander Viro authored
econet partially annotated. It's still badly broken - it mixes userland and kernel chunks in the same iovec, then does set_fs(KERNEL_FS) and sends that to sock_sendmsg(). Do we still want to support that protocol family, anyway?
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-