1. 23 Oct, 2018 6 commits
    • Johan Hovold's avatar
      power: supply: twl4030-charger: fix OF sibling-node lookup · 9844fb2e
      Johan Hovold authored
      Use the new of_get_compatible_child() helper to lookup the usb sibling
      node instead of using of_find_compatible_node(), which searches the
      entire tree from a given start node and thus can return an unrelated
      (non-sibling) node.
      
      This also addresses a potential use-after-free (e.g. after probe
      deferral) as the tree-wide helper drops a reference to its first
      argument (i.e. the parent device node).
      
      While at it, also fix the related phy-node reference leak.
      
      Fixes: f5e4edb8 ("power: twl4030_charger: find associated phy by more reliable means.")
      Cc: stable <stable@vger.kernel.org>     # 4.2
      Cc: NeilBrown <neilb@suse.de>
      Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
      Cc: Sebastian Reichel <sre@kernel.org>
      Reviewed-by: default avatarSebastian Reichel <sre@kernel.org>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      9844fb2e
    • Johan Hovold's avatar
      NFC: nfcmrvl_uart: fix OF child-node lookup · 5bf59773
      Johan Hovold authored
      Use the new of_get_compatible_child() helper to lookup the nfc child
      node instead of using of_find_compatible_node(), which searches the
      entire tree from a given start node and thus can return an unrelated
      (i.e. non-child) node.
      
      This also addresses a potential use-after-free (e.g. after probe
      deferral) as the tree-wide helper drops a reference to its first
      argument (i.e. the parent node).
      
      Fixes: e097dc62 ("NFC: nfcmrvl: add UART driver")
      Fixes: d8e018c0 ("NFC: nfcmrvl: update device tree bindings for Marvell NFC")
      Cc: stable <stable@vger.kernel.org>     # 4.2
      Cc: Vincent Cuissard <cuissard@marvell.com>
      Cc: Samuel Ortiz <sameo@linux.intel.com>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      5bf59773
    • Johan Hovold's avatar
      net: stmmac: dwmac-sun8i: fix OF child-node lookup · ac63043d
      Johan Hovold authored
      Use the new of_get_compatible_child() helper to lookup the mdio-internal
      child node instead of using of_find_compatible_node(), which searches
      the entire tree from a given start node and thus can return an unrelated
      (i.e. non-child) node.
      
      This also addresses a potential use-after-free (e.g. after probe
      deferral) as the tree-wide helper drops a reference to its first
      argument (i.e. the mdio-mux node). Fortunately, this was inadvertently
      balanced by a failure to drop the mdio-mux reference after lookup.
      
      While at it, also fix the related mdio-internal- and phy-node reference
      leaks.
      
      Fixes: 634db83b ("net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs")
      Tested-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
      Cc: Andrew Lunn <andrew@lunn.ch>
      Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
      Cc: Alexandre Torgue <alexandre.torgue@st.com>
      Cc: Jose Abreu <joabreu@synopsys.com>
      Cc: David S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      ac63043d
    • Johan Hovold's avatar
      net: bcmgenet: fix OF child-node lookup · d397dbe6
      Johan Hovold authored
      Use the new of_get_compatible_child() helper to lookup the mdio child
      node instead of using of_find_compatible_node(), which searches the
      entire tree from a given start node and thus can return an unrelated
      (i.e. non-child) node.
      
      This also addresses a potential use-after-free (e.g. after probe
      deferral) as the tree-wide helper drops a reference to its first
      argument (i.e. the node of the device being probed).
      
      Fixes: aa09677c ("net: bcmgenet: add MDIO routines")
      Cc: stable <stable@vger.kernel.org>     # 3.15
      Cc: David S. Miller <davem@davemloft.net>
      Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      d397dbe6
    • Johan Hovold's avatar
      drm/msm: fix OF child-node lookup · f9a70823
      Johan Hovold authored
      Use the new of_get_compatible_child() helper to lookup the legacy
      pwrlevels child node instead of using of_find_compatible_node(), which
      searches the entire tree from a given start node and thus can return an
      unrelated (i.e.  non-child) node.
      
      This also addresses a potential use-after-free (e.g. after probe
      deferral) as the tree-wide helper drops a reference to its first
      argument (i.e. the probed device's node).
      
      While at it, also fix the related child-node reference leak.
      
      Fixes: e2af8b6b ("drm/msm: gpu: Use OPP tables if we can")
      Cc: stable <stable@vger.kernel.org>     # 4.12
      Cc: Jordan Crouse <jcrouse@codeaurora.org>
      Cc: Rob Clark <robdclark@gmail.com>
      Cc: David Airlie <airlied@linux.ie>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      f9a70823
    • Johan Hovold's avatar
      drm/mediatek: fix OF sibling-node lookup · ceff2f4d
      Johan Hovold authored
      Use the new of_get_compatible_child() helper to lookup the sibling
      instead of using of_find_compatible_node(), which searches the entire
      tree from a given start node and thus can return an unrelated (i.e.
      non-sibling) node.
      
      This also addresses a potential use-after-free (e.g. after probe
      deferral) as the tree-wide helper drops a reference to its first
      argument (i.e. the parent device node).
      
      While at it, also fix the related cec-node reference leak.
      
      Fixes: 8f83f268 ("drm/mediatek: Add HDMI support")
      Cc: stable <stable@vger.kernel.org>     # 4.8
      Cc: Junzhi Zhao <junzhi.zhao@mediatek.com>
      Cc: Philipp Zabel <p.zabel@pengutronix.de>
      Cc: CK Hu <ck.hu@mediatek.com>
      Cc: David Airlie <airlied@linux.ie>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      ceff2f4d
  2. 22 Oct, 2018 1 commit
  3. 17 Oct, 2018 1 commit
  4. 15 Oct, 2018 9 commits
  5. 12 Oct, 2018 1 commit
  6. 11 Oct, 2018 3 commits
  7. 05 Oct, 2018 1 commit
  8. 04 Oct, 2018 4 commits
  9. 02 Oct, 2018 9 commits
    • Rob Herring's avatar
      microblaze: enable building all dtbs · 92f687f4
      Rob Herring authored
      Enable the 'dtbs' target for microblaze. As microblaze only has one dts
      file, always enable it.
      
      Cc: Michal Simek <monstr@monstr.eu>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      92f687f4
    • Rob Herring's avatar
      c6x: enable building all dtbs · 626f92a0
      Rob Herring authored
      Enable the 'dtbs' target for c6x. This allows building all the dts
      files in arch/c6x/boot/dts/ for enabled platforms or when
      COMPILE_TEST and OF_ALL_DTBS are enabled.
      
      Cc: Mark Salter <msalter@redhat.com>
      Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
      Cc: linux-c6x-dev@linux-c6x.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      626f92a0
    • Rob Herring's avatar
      powerpc: enable building all dtbs · 27e88af4
      Rob Herring authored
      Enable the 'dtbs' target for powerpc. This allows building all the dts
      files in arch/powerpc/boot/dts/ when COMPILE_TEST and OF_ALL_DTBS are
      enabled.
      
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: linuxppc-dev@lists.ozlabs.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      27e88af4
    • Rob Herring's avatar
      kbuild: consolidate Devicetree dtb build rules · 37c8a5fa
      Rob Herring authored
      There is nothing arch specific about building dtb files other than their
      location under /arch/*/boot/dts/. Keeping each arch aligned is a pain.
      The dependencies and supported targets are all slightly different.
      Also, a cross-compiler for each arch is needed, but really the host
      compiler preprocessor is perfectly fine for building dtbs. Move the
      build rules to a common location and remove the arch specific ones. This
      is done in a single step to avoid warnings about overriding rules.
      
      The build dependencies had been a mixture of 'scripts' and/or 'prepare'.
      These pull in several dependencies some of which need a target compiler
      (specifically devicetable-offsets.h) and aren't needed to build dtbs.
      All that is really needed is dtc, so adjust the dependencies to only be
      dtc.
      
      This change enables support 'dtbs_install' on some arches which were
      missing the target.
      Acked-by: default avatarWill Deacon <will.deacon@arm.com>
      Acked-by: default avatarPaul Burton <paul.burton@mips.com>
      Acked-by: default avatarLey Foon Tan <ley.foon.tan@intel.com>
      Acked-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Cc: Michal Marek <michal.lkml@markovi.net>
      Cc: Vineet Gupta <vgupta@synopsys.com>
      Cc: Russell King <linux@armlinux.org.uk>
      Cc: Catalin Marinas <catalin.marinas@arm.com>
      Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
      Cc: Michal Simek <monstr@monstr.eu>
      Cc: Ralf Baechle <ralf@linux-mips.org>
      Cc: James Hogan <jhogan@kernel.org>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Chris Zankel <chris@zankel.net>
      Cc: Max Filippov <jcmvbkbc@gmail.com>
      Cc: linux-kbuild@vger.kernel.org
      Cc: linux-snps-arc@lists.infradead.org
      Cc: linux-arm-kernel@lists.infradead.org
      Cc: uclinux-h8-devel@lists.sourceforge.jp
      Cc: linux-mips@linux-mips.org
      Cc: nios2-dev@lists.rocketboards.org
      Cc: linuxppc-dev@lists.ozlabs.org
      Cc: linux-xtensa@linux-xtensa.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      37c8a5fa
    • Rob Herring's avatar
      c6x: use common built-in dtb support · be7cd2df
      Rob Herring authored
      Using the common build support for built-in dtb files just requires
      adding a .dtb.o target to obj-y.
      
      The dtb now needs to be copied when unflattened because an init section
      is used now.
      
      Cc: Mark Salter <msalter@redhat.com>
      Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
      Cc: linux-c6x-dev@linux-c6x.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      be7cd2df
    • Rob Herring's avatar
      nios2: fix building all dtbs · a91c6145
      Rob Herring authored
      nios2 has a 'dtbs' target, but nothing is added to 'dtb-*' targets and
      no dtbs were getting built. This enables building all the dts files in
      arch/nios2/boot/dts/ when COMPILE_TEST and OF_ALL_DTBS are enabled.
      
      Cc: Ley Foon Tan <lftan@altera.com>
      Cc: nios2-dev@lists.rocketboards.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      a91c6145
    • Rob Herring's avatar
      nios2: use common rules to build built-in dtb · 1b4f9e2b
      Rob Herring authored
      Using the common build support for built-in dtb files just requires
      adding a .dtb.o target to obj-y.
      
      This has the side effect that CONFIG_NIOS2_DTB_SOURCE should now be just
      the dts filename in arch/nios2/boot/dts/ directory. Before any path was
      supported, but if you want to build in your dtb to the kernel, it should
      be in the kernel tree.
      
      Cc: Ley Foon Tan <lftan@altera.com>
      Cc: nios2-dev@lists.rocketboards.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      1b4f9e2b
    • Rob Herring's avatar
      nios2: build .dtb files in dts directory · 11886486
      Rob Herring authored
      Align nios2 with other architectures which build the dtb files in the
      same directory as the dts files. This is also in line with most other
      build targets which are located in the same directory as the source.
      This move will help enable the 'dtbs' target which builds all the dtbs
      regardless of kernel config.
      
      This transition could break some scripts if they expect dtb files in
      the old location.
      
      Cc: Ley Foon Tan <lftan@altera.com>
      Cc: nios2-dev@lists.rocketboards.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      11886486
    • Rob Herring's avatar
      powerpc: build .dtb files in dts directory · 1acf1cf8
      Rob Herring authored
      Align powerpc with other architectures which build the dtb files in the
      same directory as the dts files. This is also in line with most other
      build targets which are located in the same directory as the source.
      This move will help enable the 'dtbs' target which builds all the dtbs
      regardless of kernel config.
      
      This transition could break some scripts if they expect dtb files in the
      old location.
      
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: linuxppc-dev@lists.ozlabs.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      1acf1cf8
  10. 28 Sep, 2018 5 commits