- 13 Sep, 2021 40 commits
-
-
Martin Kaiser authored
btcoex_rfon is always false in this driver. Remove the variable and code that will never be executed. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20210911141521.24901-2-martin@kaiser.cxSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Pavel Skripkin authored
While testing latest updates I hit lockdep warning: [ 42.694425] ============================================ [ 42.694785] WARNING: possible recursive locking detected [ 42.695120] 5.14.0+ #25 Tainted: G C [ 42.695422] -------------------------------------------- [ 42.695747] RTW_CMD_THREAD/317 is trying to acquire lock: [ 42.696078] ffffc900006c90b0 (&pqueue->lock){+.-.}-{3:3}, at: _rtw_alloc_network+0x1e/0x321 [r8188eu] [ 42.696686] [ 42.696686] but task is already holding lock: [ 42.697148] ffffc900006c9100 (&pqueue->lock){+.-.}-{3:3}, at: rtw_update_scanned_network+0x31/0x76b [r8188eu] [ 42.697758] [ 42.697758] other info that might help us debug this: [ 42.698326] Possible unsafe locking scenario: [ 42.698326] [ 42.698696] CPU0 [ 42.698847] ---- [ 42.698997] lock(&pqueue->lock); [ 42.699209] lock(&pqueue->lock); [ 42.699418] [ 42.699418] *** DEADLOCK *** [ 42.699418] [ 42.699768] May be due to missing lock nesting notation It's false positive, since all queue spinlocks are initialized via private API which has pqueue as agrument. Fix it by making _rtw_init_queue a macro instead of function + removed unneeded _ prefix. Signed-off-by:Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/20210908194309.9086-1-paskripkin@gmail.comSigned-off-by:
-
Ojaswin Mujoo authored
Replace function typedefs with the equivalent declarations to better align with the linux kenel coding style The following typedefs were changed: * VCHIQ_CONNECTED_CALLBACK_T * vchiq_userdata_term Signed-off-by:
Ojaswin Mujoo <ojaswin98@gmail.com> Link: https://lore.kernel.org/r/a8e4e0457b5fcc88c7f297f9d669dfb7e7d91ed5.1631366317.git.ojaswin98@gmail.comSigned-off-by:
-
Michael Straube authored
After the removal of some pointers from struct hal_ops the function rtl8188e_set_hal_ops() is empty now. Remove it. Acked-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210910205033.3778-8-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Remove write_rfreg from struct hal_ops and its wrapper rtw_hal_write_rfreg(). Call rtl8188e_PHY_SetRFReg() directly instead. Acked-by:
-
Michael Straube authored
Remove read_rfreg from struct hal_ops and its wrapper rtw_hal_read_rfreg(). Call rtl8188e_PHY_QueryRFReg() directly instead. Acked-by:
-
Michael Straube authored
Remove write_bbreg from struct hal_ops and its wrapper rtw_hal_write_bbreg(). Call rtl8188e_PHY_SetBBReg() directly instead. Acked-by:
-
Michael Straube authored
Remove read_bbreg from struct hal_ops and its wrapper rtw_hal_read_bbreg(). Call rtl8188e_PHY_QueryBBReg() directly instead. Acked-by:
-
Michael Straube authored
Remove hal_xmit from struct hal_ops and its wrapper rtw_hal_xmit(). Call rtl8188eu_hal_xmit() directly instead. Acked-by:
-
Michael Straube authored
Remove mgnt_xmit from struct hal_ops and its wrapper rtw_hal_mgnt_xmit(). Call rtl8188eu_mgnt_xmit() directly instead. Acked-by:
-
Michael Straube authored
Function ODM_InitAllTimers() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_CancelAllTimers() is unused and it is the only caller of function ODM_CancelTimer(). Remove both. Acked-by:
-
Michael Straube authored
The function prototype ODM_InitializeTimer() is not used, remove it. Acked-by:
-
Michael Straube authored
Function ODM_AllocateMemory() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_FreeMemory() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_Read2Byte() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_SetTimer() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_IsWorkItemScheduled() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_ScheduleWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_FreeWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_StopWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_StartWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_InitializeWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_sleep_us() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_FillH2CCmd() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_ReleaseSpinLock() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_AcquireSpinLock() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_ReleaseTimer() is empty and its only caller is ODM_ReleaseAllTimers(). Remove both functions. Acked-by:
-
Saurav Girepunje authored
Remove unused variable ret and pwrpriv. Remove the condition with no effect (if == else) in usb_intf.c file. Remove rtw_resume_process() and move whole thing to rtw_resume(). Remove the padapter NULL check which couldn't NULL in rtw_resume function. Signed-off-by:
Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YTshmPcZr/aVclHK@userSigned-off-by:
-
Martin Kaiser authored
Remove the last bunch of unused RT_usb_endpoint_... functions. Acked-by:
-
Martin Kaiser authored
RT_usb_endpoint_num is unused. Remove this function. Acked-by:
-
Martin Kaiser authored
Remove the RT_usb_endpoint_is_bulk_in function which is not used. RT_usb_endpoint_dir_in is no longer used either and can also be removed. Acked-by:
-
Martin Kaiser authored
The usb_endpoint_is_int is not used and can be removed. RT_usb_endpoint_xfer_int was used only by usb_endpoint_is_int. Remove this function as well. Acked-by:
-
Saurav Girepunje authored
Remove unused variable Adapter from rtw_IOL_cmd_buf_dump function. Signed-off-by:
-
Saurav Girepunje authored
Remove unused variable padapter from mp_init_xmit_attrib(). Reviewed-by:
-
Martin Kaiser authored
bLCKInProgress in struct odm_rf_cal is never read. Remove it. Acked-by:
-
Michael Straube authored
Function rtw_IOL_append_LLT_cmd() just returns _SUCCESS and the only caller does not use the return value. Remove it. Signed-off-by:
-
Michael Straube authored
Function rtw_IOL_exec_cmds_sync() is just a wrapper around rtl8188e_IOL_exec_cmds_sync(). Remove it. Signed-off-by:
-
Michael Straube authored
Remove IOL_exec_cmds_sync() from struct hal_ops and its wrapper rtw_hal_iol_cmd(). Call rtl8188e_IOL_exec_cmds_sync() directly instead. Signed-off-by:
-
Michael Straube authored
These macros are not used in the driver, remove them. Found with GCC -Wunused-macros. Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
-
