- 21 Aug, 2016 40 commits
-
-
Binoy Jayan authored
The semaphore 'wx_sem' in the rtllib_device is a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by:
Binoy Jayan <binoy.jayan@linaro.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Arnd Bergmann authored
There is one remaining warning about a type limit check in rtl8192e: staging/rtl8192e/rtl819x_TSProc.c:326:14: error: comparison is always true due to limited range of data type [-Werror=type-limits] This changes a macro into a local function to clarify the types and simplify the check while removing the warning. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Acked-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Arnd Bergmann authored
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always false due to limited range of data type [-Werror=type-limits] staging/rtl8192e/rtl8192e/r8192E_phy.c:1104:36: error: comparison is always false due to limited range of data type [-Werror=type-limits] staging/rtl8192e/rtl8192e/rtl_core.c:1987:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] staging/rtl8192e/rtl8192e/rtl_dm.c:782:37: error: comparison is always false due to limited range of data type [-Werror=type-limits] staging/rtl8192e/rtllib_softmac_wx.c:465:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] This patch changes all uses of 'char' in this driver that refer to 8-bit integers to use 's8' instead, which is signed on all architectures. Signed-off-by:
-
Arnd Bergmann authored
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192u/r8192U_core.c:4150:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] staging/rtl8192u/r8192U_dm.c:646:50: error: comparison is always false due to limited range of data type [-Werror=type-limits] This patch changes all uses of 'char' in this driver that refer to 8-bit integers to use 's8' instead, which is signed on all architectures. Signed-off-by:
-
Ivan Safonov authored
This enumeration does not used. Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
Ivan Safonov authored
This function does not used. Signed-off-by:
-
Ivan Safonov authored
staging: rtl8188eu: replace EFUSE_GetEfuseDefinition(..., TYPE_AVAILABLE_EFUSE_BYTES_BANK, &a) call with a = (EFUSE_REAL_CONTENT_LEN_88E - EFUSE_OOB_PROTECT_BYTES_88E) This makes the code easier to read. Signed-off-by:
-
Ivan Safonov authored
staging: rtl8188eu: replace EFUSE_GetEfuseDefinition(..., TYPE_EFUSE_MAX_SECTION, &a) with a = EFUSE_MAX_SECTION_88E This makes the code easier to read. Signed-off-by:
-
Ivan Safonov authored
This variable does not used after assigning value. Signed-off-by:
-
Ivan Safonov authored
staging: rtl8188eu: replace EFUSE_GetEfuseDefinition(..., TYPE_EFUSE_MAP_LEN, ...) call with it's result (EFUSE_MAP_LEN_88E) This makes the code easier to read. Signed-off-by:
-
Binoy Jayan authored
The semaphores xmit_sema, terminate_xmitthread_sema and tx_retevt have no users, hence remove all references to them. Signed-off-by:
-
Binoy Jayan authored
The semaphore 'lock' in pwrctrl_priv is a simple mutex, so it should be written as one. Semaphores are going away in the future. _enter_pwrlock was using down_interruptible(), so the lock could be broken by sending a signal. This could be a bug, because nothing checks the return code here. Hence, using mutex_lock instead of the interruptible version. Also, remove the now unused wrappers _init_pwrlock, _enter_pwrlock, _exit_pwrlock and _rtw_down_sema. Signed-off-by:
-
Binoy Jayan authored
The semaphore 'terminate_cmdthread_sema' is used as completion, so convert it to struct completion. Signed-off-by:
-
Binoy Jayan authored
The semaphore 'cmd_queue_sema' is used as completion, so convert it to struct completion. Signed-off-by:
-
Colin Ian King authored
A null pointer dereference will occur when skb is null and skb->dev->name is printed. Replace the skb->dev->name with plain text "ks_wlan" to fix this. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Nicholas Mc Guire authored
Private functions in ks_hostif.c can be declared static. Fixes: 13a9930d ("staging: ks7010: add driver from Nanonote extra-repository") Signed-off-by:
Nicholas Mc Guire <hofrat@osadl.org> Reviewed-by:
Wolfram Sang <wsa@the-dreams.de> Signed-off-by:
-
Nicholas Mc Guire authored
wait_for_completion_interruptible_timeout return 0 on timeout and -ERESTARTSYS if interrupted. The check for !wait_for_completion_interruptible_timeout() would report an interrupt as timeout. Further, while HZ/50 will work most of the time it could fail for HZ < 50, so this is switched to msecs_to_jiffies(20). Fixes: 13a9930d ("staging: ks7010: add driver from Nanonote extra-repository") Signed-off-by:
-
Anson Jacob authored
Fix checkpatch.pl warning for trailing */ on a separate line Remove '+' postfix and '-' prefix from the start and end of block comments Signed-off-by:
Anson Jacob <ansonjacob.aj@gmail.com> Signed-off-by:
-
Anson Jacob authored
Fix warning by checkpatch.pl Add * for block comments on subsequent lines Signed-off-by:
-
Anson Jacob authored
This patch fixes the following checkpatch.pl warnings: WARNING: Block comments use * on subsequent lines + /* TX_PE will reserve 3 us for MAX2829 A mode only, + it is for better TX throughput */ WARNING: Block comments use a trailing */ on a separate line + it is for better TX throughput */ Signed-off-by:
-
Rithvik Patibandla authored
The following patch fixes "Alignment should match open parantheses" check thrown by checkpatch.pl Signed-off-by:
Rithvik Patibandla <rithvikp98@gmail.com> Signed-off-by:
-
Rithvik Patibandla authored
The following patch fixes two checks thrown by checkpatch.pl, "Spaces preferred around '+'" and "No space is necessary after a cast" Signed-off-by:
-
Rithvik Patibandla authored
This patch fixes "Alignment should match open parantheses" check thrown by checkpatch.pl Signed-off-by:
-
Rithvik Patibandla authored
Fix "Alignment should match open paranthesis" check thrown by checkpatch.pl Signed-off-by:
-
Rithvik Patibandla authored
Fix "Avoid camel case" issue thrown by checkpatch.pl Signed-off-by:
-
Rithvik Patibandla authored
Fix "Please use a blank line after function declaration" check thrown by checkpatch.pl Signed-off-by:
-
Rithvik Patibandla authored
Fix "Blank lines aren't necessary after an open brace" check thrown by checkpatch.pl Signed-off-by:
-
Rithvik Patibandla authored
Fix "Alignment should match with open paranthesis" check thrown by checkpatch.pl Signed-off-by:
-
Rithvik Patibandla authored
Fix "Block comments use * on subsequent lines" and "Block comments use */ on trailing lines" warnings thrown by checkpatch.pl Signed-off-by:
-
Edward Lipinsky authored
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by:
Edward Lipinsky <ellipinsky@gmail.com> Signed-off-by:
-
Stefan Wolz authored
Split lines over 80 characters and separated assignments. Signed-off-by:
Stefan Wolz <wolzstefan@web.de> Signed-off-by:
Christian Halder <christian.halder@fau.de> Signed-off-by:
Sebastian Handwerker <sebastian.handwerker@posteo.de> Signed-off-by:
-
Stefan Wolz authored
Fixed multiline comments to meet style standards, fixed typos and split comment lines over 80 characters. Signed-off-by:
-
Stefan Wolz authored
Deleted unnecessary newlines and added whitespaces around operators. Signed-off-by:
-
Stefan Wolz authored
Fixed alignment in multiline declarations. Signed-off-by:
-
yeongjun Kim authored
WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
yeongjun Kim <iam.yeongjunkim@gmail.com> Signed-off-by:
-
Moshe Green authored
This is a patch to the ddk750_chip.c file that fixes up two block comment coding style warnings found by the checkpatch.pl tool Signed-off-by:
Moshe Green <mgmoshes@gmail.com> Signed-off-by:
-
Moshe Green authored
This is a patch to the ddk750_chip.c file that fixes up a line length warning found by the checkpatch.pl tool Signed-off-by:
-
Moshe Green authored
This is a patch to the ddk750_chip.c file that fixes up a line length warning found by the checkpatch.pl tool. Signed-off-by:
Moshe Green <paledirac@gmail.com> Signed-off-by:
-
Samuele Baisi authored
Removed a blankline after an opening bracket. Signed-off-by:
Samuele Baisi <ciccio87@gmail.com> Acked-by:
Luis de Bethencourt <luisbg@osg.samsung.com> Signed-off-by:
-
Binoy Jayan authored
Replace semaphore netlink_mutex with mutex. Semaphores are going away in the future. Signed-off-by:
-
