- 04 Nov, 2016 3 commits
-
-
Dhinakaran Pandiyan authored
According to BSpec, cdclk for BDW has to be not less than 432 MHz with DP audio enabled, port width x4, and link rate HBR2 (5.4 GHz). With cdclk less than 432 MHz, enabling audio leads to pipe FIFO underruns and displays cycling on/off. Let's apply this work around to GEN9 platforms too, as it fixes the same issue. v2: Move drm_device to drm_i915_private conversion Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97907 Cc: stable@vger.kernel.org Cc: Libin Yang <libin.yang@linux.intel.com> Signed-off-by:
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> Reviewed-by:
Jani Nikula <jani.nikula@intel.com> Signed-off-by:
-
Dhinakaran Pandiyan authored
According to BSpec, cdclk for BDW has to be not less than 432 MHz with DP audio enabled, port width x4, and link rate HBR2 (5.4 GHz). With cdclk less than 432 MHz, enabling audio leads to pipe FIFO underruns and displays cycling on/off. From BSpec: "Display» BDW-SKL» dpr» [Register] DP_TP_CTL [BDW+,EXCLUDE(CHV)] Workaround : Do not use DisplayPort with CDCLK less than 432 MHz, audio enabled, port width x4, and link rate HBR2 (5.4 GHz), or else there may be audio corruption or screen corruption." Since, some DP configurations (e.g., MST) use port width x4 and HBR2 link rate, let's increase the cdclk to >= 432 MHz to enable audio for those cases. v4: Changed commit message v3: Combine BDW pixel rate adjustments into a function (Jani) v2: Restrict fix to BDW Retain the set cdclk across modesets (Ville) Cc: stable@vger.kernel.org Signed-off-by:Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by:
-
Chris Wilson authored
commit bc0629a7 ("drm/i915: Track pages pinned due to swizzling quirk") fixed one problem, but revealed a whole lot more. The root cause of the pin count mismatch for the swizzle quirk (for L-shaped memory on gen3/4) was that we were incrementing the pages_pin_count upon getting the backing pages but then overwriting the pages_pin_count to set it to 1 afterwards. With a little bit of adjustment to satisfy the GEM_BUG_ON sanitychecks, the fix is to replace the explicit atomic_set with an atomic_inc. v2: Consistently use atomics (not mix atomics and helpers) within the lowlevel get_pages routines. This makes the atomic operations much clearer. Fixes: 1233e2db ("drm/i915: Move object backing storage manipulation") Signed-off-by:
Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20161104103001.27643-1-chris@chris-wilson.co.ukReviewed-by:
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
-
- 03 Nov, 2016 4 commits
-
-
Chris Wilson authored
When supplying a view to vma_compare() it is required that the supplied i915_address_space is the global GTT. I tested the VMA instead (which is the current position in the rbtree and maybe from any address space). Reported-by:
Matthew Auld <matthew.auld@intel.com> Tested-by:
-
Chris Wilson authored
Use i915_gem_object_pin_map() for the guc client's lifetime to replace the peristent kmap + frequent kmap_atomic with a permanent vmapping. This avoids taking the obj->mm.lock mutex whilst inside irq context later. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98571 Fixes: 96d77634 ("drm/i915: Use a radixtree for random access..."); Signed-off-by:
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
-
Tvrtko Ursulin authored
We can use the preferred KMEM_CACHE helper for brevity. Also simplifiy error unwind by only setting the ENOMEM error code once. v2: Add forgotten changes. (Joonas Lahtinen) Signed-off-by:
-
Joonas Lahtinen authored
Move has_64bit_reloc into dev_priv->info. This will make it visible in the feature listing debug output. v2: - Keep the struct member to keep GCC fragile but happy (Chris) v3: - More detailed commit message (Chris) - Include forgotten CHV and BXT (Chris) Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by:
-
- 02 Nov, 2016 6 commits
-
-
Chris Wilson authored
When looking at freezes whilst working on execlists, knowing the order of the pending requests in the driver is useful. Signed-off-by:
-
Joonas Lahtinen authored
$ sed -i -r 's/\bglobal_list\b/global_link/g' *.c *.h Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by:
-
Mika Kuoppala authored
Create new file for hangcheck specific code, intel_hangcheck.c, and move all related code in it. v2: s/intel_engine_hangcheck/intel_engine (Chris) No functional changes. Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Signed-off-by:
Mika Kuoppala <mika.kuoppala@intel.com> Reviewed-by:
-
Mika Kuoppala authored
Now when clearing ptes can modify upper level pdp's, we need to mark them dirty so that they will be flushed correctly. Reviewed-by:
-
Mika Kuoppala authored
Comparing pte index to a number of entries is wrong when clearing a range of pte entries. Use end marker of 'one past' to correctly point adequate number of ptes to the scratch page. v2: assert early instead of warning late (Chris) v3: removed consts (Joonas) Fixes: d209b9c3 ("drm/i915/gtt: Split gen8_ppgtt_clear_pte_range") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98282 Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Michel Thierry <michel.thierry@intel.com> Cc: Michał Winiarski <michal.winiarski@intel.com> Reported-by:
Mike Lothian <mike@fireburn.co.uk> Signed-off-by:
-
Ander Conselvan de Oliveira authored
Hardware engineers confirmed that writing to it has no effect, as implied by the FIXME comment. v2: Also remove comment from bxt_ddi_phy_verify_state(). (Imre) Cc: Imre Deak <imre.deak@intel.com> Signed-off-by:
Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Reviewed-by:
Imre Deak <imre.deak@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1478069096-11209-1-git-send-email-ander.conselvan.de.oliveira@intel.com
-
- 01 Nov, 2016 27 commits
-
-
Tvrtko Ursulin authored
Commit 1bec9b0b ("drm/i915/shrinker: Only shmemfs objects are backed by swap") stopped considering the userptr objects in shrinker callbacks. Restore that so idle userptr objects can be discarded in order to free up memory. One change further to what was introduced in 1bec9b0b is to start considering userptr objects in oom but that should also be a correct thing to do. v2: Introduce I915_GEM_OBJECT_IS_SHRINKABLE. (Chris Wilson) Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Replace the open coded dev_priv->pipe_to_crtc_mapping[] usage with intel_get_crtc_for_pipe(). Mostly done with coccinelle, with a few manual tweaks @@ expression E1, E2; @@ ( - E1->pipe_to_crtc_mapping[E2] + intel_get_crtc_for_pipe(E1, E2) | - E1->plane_to_crtc_mapping[E2] + intel_get_crtc_for_plane(E1, E2) ) Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
Ville Syrjälä authored
A lot of users of the {pipe,plane}_to_crtc_mapping[] will end up casting the result to intel_crtc, so let's just store the intel_crtc pointer in the first place. Signed-off-by: -
Ville Syrjälä authored
Unify our approach to things by using intel_crtc instead of drm_crtc. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around intel_crtc instead of drm_crtc. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around intel_crtc instead of drm_crtc. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. While at it let's do some house cleaning: s/intel_foo/foo/ and move things into tighter scope. Signed-off-by:
-
Ville Syrjälä authored
Unify our approach to things by passing around dev_priv instead of dev. Signed-off-by:
-
