- 17 Feb, 2016 2 commits
-
-
Arnd Bergmann authored
The newly added afe4403 driver implements suspend/resume using the SIMPLE_DEV_PM_OPS() macro, which leaves out references to the actual functions when CONFIG_PM is disabled, causing a harmless warning: health/afe4403.c:509:12: error: 'afe4403_suspend' defined but not used health/afe4403.c:530:12: error: 'afe4403_resume' defined but not used This marks the functions as __maybe_unused so we don't get those warnings. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Fixes: eec96d1e ("iio: health: Add driver for the TI AFE4403 heart monitor") Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Arnd Bergmann authored
The newly added afe4403 driver uses the regmap facility to abstract the I2C and SPI access. However, it fails to ensure that regmap_spi is actually present: drivers/iio/built-in.o: In function `afe4403_probe': :(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi' This adds a Kconfig select statement like the afe4404 I2C driver has. Signed-off-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
-
- 15 Feb, 2016 38 commits
-
-
Shraddha Barke authored
Coherent mapping guarantees that the device and CPU are in sync. Signed-off-by:
Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Janani Ravichandran authored
Fix comments to use trailing */ on separate lines. Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Add missing blank line after declaration of variables. Issue found by checkpatch. Signed-off-by:
-
Janani Ravichandran authored
Improve readability by fitting all parts of the function header on the same line. Signed-off-by:
-
Amitoj Kaur Chawla authored
The return value of devm_kzalloc on failure of allocation of memory should be -ENOMEM and not -1. Found using Coccinelle. A simplified version of the semantic patch used is: //<smpl> @@ expression *e; @@ e = devm_kzalloc(...); if (e == NULL) { ... return - -1 + -ENOMEM ; } //</smpl> The single call site does not perform any checks on the return value, hence no change is required at the call site. Signed-off-by:Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
With concurrency managed workqueues, use of dedicated workqueues can be replaced by using system_wq. Drop mux_rx_wq by using system_wq. Since there is only one work item per mux_dev and different mux_devs do not need to be ordered, increase of concurrency level by switching to system_wq should not break anything. cancel_work_sync() is used to ensure that work is not pending or executing on any CPU. Lastly, since all devices are suspended, which shutdowns the work item before the driver can be unregistered, it is guaranteed that no work item is pending or executing by the time exit path runs. Signed-off-by:
-
Tomás Tormo authored
Modify the nvec_write_sync function to return the error code instead of the received message. The received message is now returned as an output parameter. Signed-off-by:
Tomás Tormo <tomas.tormo@gmail.com> Signed-off-by:
-
Aaro Koskinen authored
Support official DT bindings alongside with the deprecated ones. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Support fixed-link PHYs. This allows to remove some of the board-specific link cvmx_helper code in the future. Signed-off-by:
-
Janani Ravichandran authored
Use trailing */ on a separate line when it is a block comment. This patch fixes the last of the checkpatch warnings for the file. Signed-off-by:
-
Laura Garcia Liebana authored
Align arguments with the open parenthesis. Checkpatch found this issue. Signed-off-by:
Laura Garcia Liebana <nevola@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of multiple blank lines. Checkpatch found this issue. Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of multiple assignments in a single line. Checkpatch found this issue. Signed-off-by:
-
Bhumika Goyal authored
Remove function ieee80211_wep_null from the file as is it blank and remove its declaration from the header file. Also remove its function call as it is of no use calling this function. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
The headers <asm/uaccess.h>,<asm/atomic.h>,<asm/atomic.h> should not be directly included so replace them. Warning generated by checkpatch.pl. Signed-off-by:
-
Janani Ravichandran authored
This patch clears the checkpatch warning about suspect code indent for conditional statements in the file. Signed-off-by:
-
Janani Ravichandran authored
This patch removes commented out code in the file. Signed-off-by:
-
Janani Ravichandran authored
Remove unnecessary braces in if...else statements where both branches have a single statement each. Signed-off-by:
-
Bhumika Goyal authored
Remove the commented out places where macros PlatformAcquireSpinLock and PlatformReleaseSpinLock are called as these macros are no longer used. Signed-off-by:
-
Bhumika Goyal authored
The macros PlatformAcquireSpinLock and PlatformReleaseSpinLock are not used anywhere so remove them. Used grep to find occurences. Signed-off-by:
-
Joseph Bisch authored
Since the variable ret is set at the beginning of the function and never changes its value, we can just return the value it was set to. Found using coccinelle with misc/returnvar.cocci. Signed-off-by:
Joseph Bisch <joseph.bisch@gmail.com> Signed-off-by:
-
Rakhi Sharma authored
WARNING: Comparisons should place the constant on the right side of the test Fixed this warning by placing the constant on right side. Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>- Signed-off-by: -
Bhumika Goyal authored
In this file,function names are otherwise used as pointers without &. Found using coccinelle. // <smpl> @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // </smpl> Signed-off-by: -
Bhumika Goyal authored
In this file,function names are otherwise used as pointers without &. Found using coccinelle. // <smpl> @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // </smpl> Signed-off-by: -
Bhumika Goyal authored
In this file,function names are otherwise used as pointers without &. Found using coccinelle. // <smpl> @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // </smpl> Signed-off-by: -
Janani Ravichandran authored
Constants should be placed on the right hand side of comparisons. This issue was identified by checkpatch. Signed-off-by:
-
Bhumika Goyal authored
The function vfree test whether the argument is NULL and return immediately. SO NULL test is not needed before vfree. Signed-off-by:
-
Bhumika Goyal authored
The function rtw_free_netdev test whether its argument is NULL and return immediately. So NULL test before this function is not needed. Signed-off-by:
-
Janani Ravichandran authored
This patch changes some C99-style "//..." comments to C89 "/* ... */" style. Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove driver specific macro msleep_interruptible_rsl as it has been replaced by a direct call to msleep_interruptible in the single instance referencing it. Signed-off-by:
Vaishali Thakkar <vaishali.thakkar@oracle.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
staging: rtl8192u: ieee80211: ieee80211_softmac: Replace driver specific macro msleep_interruptible_rsl Replace driver specific msleep_interruptible_rsl macro with direct call to msleep_interruptible. Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove driver specific macro MSECS since all instances of this macro have been replaced by direct calls to msecs_to_jiffies(). Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace driver specific macro MSECS with msecs_to_jiffies(). This was found using the following Coccinelle semantic patch: //<smpl> @@ expression e; @@ - MSECS(e) + msecs_to_jiffies(e) //</smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace driver specific macro MSECS with msecs_to_jiffies(). This was found using the following Coccinelle semantic patch: //<smpl> @@ expression e; @@ - MSECS(e) + msecs_to_jiffies(e) //</smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace driver specific macro MSECS with msecs_to_jiffies(). This was found using the following Coccinelle semantic patch: //<smpl> @@ expression e; @@ - MSECS(e) + msecs_to_jiffies(e) //</smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace driver specific macro MSECS with msecs_to_jiffies(). This was found using the following Coccinelle semantic patch: //<smpl> @@ expression e; @@ - MSECS(e) + msecs_to_jiffies(e) //</smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace driver specific macro MSECS with msecs_to_jiffies(). This was found using the following Coccinelle semantic patch: //<smpl> @@ expression e; @@ - MSECS(e) + msecs_to_jiffies(e) //</smpl> Signed-off-by:
-
Paul Gortmaker authored
In commit 8a004484 ("staging/android: create a 'sync' dir for debugfs information"), modular references were introduced to this file. However if we look, we find: drivers/staging/android/Makefile:obj-$(CONFIG_SYNC) += sync.o sync_debug.o drivers/staging/android/Kconfig:config SYNC drivers/staging/android/Kconfig: bool "Synchronization framework" This file isn't currently buildable as a module, and hence the code for module_exit is just dead code. Remove it and the module.h include. Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:
-
