- 20 May, 2020 22 commits
-
-
Mauro Carvalho Chehab authored
Add a runtime check to use the proper wdt timer init at runtime, depending on the chipset revision. For now, we can't get rid of the remaining version checks, as the rest of the code is not prepared yet to detect the ISP version on runtime. Signed-off-by:Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-
Mauro Carvalho Chehab authored
Replace #ifdef occurrences there with runtime checks. Signed-off-by: -
Mauro Carvalho Chehab authored
Those ifs can easily be removed without breaking the code. Signed-off-by: -
Mauro Carvalho Chehab authored
There's a dependency on this header for the ISP model. While this sounds really weird (as just one resolution needs it), as we don't know what's the right value, let's just keep it. Signed-off-by: -
Mauro Carvalho Chehab authored
The logic there has lots of ifdef dependencies if the hardware is either ISP2400 or ISP2041. Replace them by runtime checks. Signed-off-by: -
Mauro Carvalho Chehab authored
The atomisp supports two different chipsets: ISP2400 and ISP2401. Right now, this is controlled by ugly #defines inside the driver. Add a global bolean to identify the type of hardware. While this is hacky, it would be a quick way to start removing the ugly ifdefs. Signed-off-by: -
Mauro Carvalho Chehab authored
There are some uneeded defines there. Simplify it, and make it independent of defines. Signed-off-by: -
Mauro Carvalho Chehab authored
There are several parts of atomisp that are meant to be built on different environments, tested using ifdefs. Remove some of them, as this code should build only on Linux. Signed-off-by: -
Mauro Carvalho Chehab authored
Use some auto-reformat tools to make the atomisp style a little better. There are still lots of weird things there, but this will hopefully reduce the number of pure coding style patches submitted upstream. Signed-off-by: -
Mauro Carvalho Chehab authored
Use checkpatch.pl --fix-inplace --strict to solve several coding style issues, manually reviewing the produced code and fixing some troubles caused by checkpatch. Signed-off-by: -
Mauro Carvalho Chehab authored
Running checkpatch.pl codespell logic found several typos at atomisp driver. Fix them using --fix-inline. Signed-off-by: -
Mauro Carvalho Chehab authored
This driver needs IOSF_MBI in order to talk with some PM registers. Select it at compile time. Signed-off-by: -
Mauro Carvalho Chehab authored
The atomisp driver builds again. So, remove depends on BROKEN. Signed-off-by: -
Mauro Carvalho Chehab authored
There's a typo at the compat32 code, with forgot to get the pointer address, causing the driver to not build. Not sure why this didn't produce an error back when the driver got removed. Signed-off-by: -
Mauro Carvalho Chehab authored
The old ida API got replaced by a new one, with avoids locking issues. As the old API was removed, start using the new one, as defined by changeset b03f8e43 ("ida: Remove old API"). Fixes: b03f8e43 ("ida: Remove old API") Signed-off-by:
-
Mauro Carvalho Chehab authored
Those functions got renamed. Update them on atomisp driver. Fixes: 67b06ba0 ("PM: QoS: Drop PM_QOS_CPU_DMA_LATENCY and rename related functions") Signed-off-by:
-
Mauro Carvalho Chehab authored
The time 64 API patchset changed the ts stamp to u64. Update this driver accordingly. Fixes: 15a40b27 ("media: videobuf: use u64 for the timestamp internally") Signed-off-by:
-
Mauro Carvalho Chehab authored
This type was renamed in the past by a more meaningul name. Change it on atomisp too. Fixes: 238e4a5b ("media: rename VFL_TYPE_GRABBER to _VIDEO") Signed-off-by:
-
Mauro Carvalho Chehab authored
Fix the usage of totalram_pages, as this is now a function. Fixes: ca79b0c2 ("mm: convert totalram_pages and totalhigh_pages variables to atomic") Signed-off-by:
-
Mauro Carvalho Chehab authored
This macro had its first parameter lost. Remove it. While on it, fix the alignments where this macro is used. Fixes: 96d4f267 ("Remove 'type' argument from access_ok() function") Signed-off-by:
-
Mauro Carvalho Chehab authored
From now on, I'll be maintaining the atomisp driver, and Sakari will be reviewing it. Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
There are some interest on having this driver back, and I can probably dedicate some time to address its issue. So, let's ressurect it. For now, the driver causes a recursive error and doesn't build, so, make it depend on BROKEN. This reverts commit 51b8dc51. Signed-off-by:
-
- 18 May, 2020 18 commits
-
-
Jacopo Mondi authored
Parse device properties and register controls for them using the newly introduced helpers. Signed-off-by:
Jacopo Mondi <jacopo@jmondi.org> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:
-
Jacopo Mondi authored
Parse device properties and register controls for them using the newly introduced helpers. Signed-off-by:
-
Jacopo Mondi authored
Parse device properties and register controls for them using the newly introduced helpers. Signed-off-by:
-
Jacopo Mondi authored
Add an helper function to v4l2-ctrls to register controls associated with a device property. Signed-off-by:
-
Jacopo Mondi authored
Before adding a new include directive, sort the existing ones in alphabetical order. Signed-off-by:
-
Jacopo Mondi authored
Before adding a new forward declaration to the v4l2-ctrls.h header file, sort the existing ones alphabetically. Signed-off-by:
-
Jacopo Mondi authored
Add an helper function to parse common device properties in the same way as v4l2_fwnode_endpoint_parse() parses common endpoint properties. Parse the 'rotation' and 'orientation' properties from the firmware interface. Signed-off-by:
-
Jacopo Mondi authored
Add support for the newly defined V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION read-only controls used to report the camera device mounting position and orientation respectively. Reviewed-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Jacopo Mondi authored
Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera control. The newly added read-only control reports the rotation correction to be applied to images before displaying them to the user. Signed-off-by:
-
Jacopo Mondi authored
Add documentation for the V4L2_CID_CAMERA_ORIENTATION camera control. The newly added read-only control reports the camera device orientation relative to the usage orientation of the system the camera is installed on. Signed-off-by:
-
Jacopo Mondi authored
Replace the 'rotation' property description by providing a definition relative to the camera sensor pixel array coordinate system and the captured scene. Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Jacopo Mondi authored
Add the 'orientation' device property, used to specify the device mounting position. The property is particularly meaningful for mobile devices with a well defined usage orientation. Reviewed-by:
Tomasz Figa <tfiga@chromium.org> Signed-off-by:
-
Steve Longerbeam authored
Remove the TODO items regarding media link creation, these issues are resolved by moving media link creation to individual entity bound callbacks and the implementation of the get_fwnode_pad operation. Signed-off-by:
Steve Longerbeam <slongerbeam@gmail.com> Signed-off-by:
-
Steve Longerbeam authored
Convert to dev_dbg the "subdev bound" and IPU-internal media-link creation messages. Signed-off-by:
-
Steve Longerbeam authored
The entities external to the i.MX6 IPU and i.MX7 now create the links to their fwnode-endpoint connected entities in their notifier bound callbacks. Which means imx_media_create_of_links() and imx_media_create_csi_of_links() are no longer needed and are removed. However there is still one case in which imx-media needs to create fwnode-endpoint based links at probe completion. The v4l2-async framework does not allow multiple subdevice notifiers to contain a duplicate subdevice in their asd_list. Only the first subdev notifier that discovers and adds that one subdevice to its asd_list will receive a bound callback for it. Other subdevices that also have firmware endpoint connections to this duplicate subdevice will not have it in their asd_list, and thus will never receive a bound callback for it. In the case of imx-media, the one duplicate subdevice in question is the i.MX6 MIPI CSI-2 receiver. Until there is a solution to that problem, rewrite imx_media_create_links() to add the missing links from the CSI-2 receiver to the CSIs and CSI muxes. The function is renamed imx_media_create_csi2_links(). Signed-off-by:
-
Steve Longerbeam authored
Fix the 1:1 port-id:pad-index assumption for the upstream subdevice, by searching the upstream subdevice's endpoints for one that maps to the pad's index. This is carried out by a new reverse mapping function imx_media_get_pad_fwnode(). Signed-off-by:
-
Steve Longerbeam authored
For i.MX5/6, if the bound subdev is a video mux, it must be one of the CSI muxes, and for i.MX7, the bound subdev must always be a CSI mux. So if the bound subdev is a video mux, mark it as a CSI mux with a new group id IMX_MEDIA_GRP_ID_CSI_MUX. In the process use the new group id in csi_get_upstream_endpoint(), and do some cleanup in that function for better readability. Suggested-by:
Rui Miguel Silva <rmfrfs@gmail.com> Signed-off-by:
-
Steve Longerbeam authored
The function imx7_csi_get_upstream_endpoint() is not necessary for imx7. First, the imx7 CSI only receives from the CSI mux, so much of the code in there is pointless. Second, it is only used to determine whether the CSI mux has selected the CSI-2 input or the parallel input. This can be accomplished much more simply by getting the function type of selected input entity to the CSI mux. Signed-off-by:
-
