- 21 Jan, 2017 1 commit
-
-
Colin Ian King authored
acpi_match_device can potentially return NULL, so it is prudent to check if acpi_id is null before it is dereferenced. Add a check and an error message to indicate the failure. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Reviewed-by:
Pali Rohár <pali.rohar@gmail.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
- 20 Jan, 2017 7 commits
-
-
Liam Breck authored
Add breathing room in probe() out* section. Signed-off-by:
Liam Breck <kernel@networkimprov.net> Acked-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Liam Breck authored
Reading both fault and status registers and logging any fault should take priority over handling status register update. Fix by moving the status handling to later in interrupt routine. Fixes: d7bf353f ("bq24190_charger: Add support for TI BQ24190 Battery Charger") Signed-off-by:
Liam Breck <kernel@networkimprov.net> Acked-by:
Mark Greer <mgreer@animalcreek.com> Acked-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Liam Breck authored
Caching the fault register after a single I2C read may not keep an accurate value. Fix by doing two reads in irq_handle_thread() and using the cached value elsewhere. If a safety timer fault later clears itself, we apparently don't get an interrupt (INT), however other interrupts would refresh the register cache. From the data sheet: "When a fault occurs, the charger device sends out INT and keeps the fault state in REG09 until the host reads the fault register. Before the host reads REG09 and all the faults are cleared, the charger device would not send any INT upon new faults. In order to read the current fault status, the host has to read REG09 two times consecutively. The 1st reads fault register status from the last read [1] and the 2nd reads the current fault register status." [1] presumably a typo; should be "last fault" Fixes: d7bf353f ("bq24190_charger: Add support for TI BQ24190 Battery Charger") Signed-off-by:
Liam Breck <kernel@networkimprov.net> Acked-by:
Mark Greer <mgreer@animalcreek.com> Acked-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Liam Breck authored
We wrongly get uevents for bq24190-charger and bq24190-battery on every register change. Fix by checking the association with charger and battery before emitting uevent(s). Fixes: d7bf353f ("bq24190_charger: Add support for TI BQ24190 Battery Charger") Signed-off-by:
Liam Breck <kernel@networkimprov.net> Acked-by:
Mark Greer <mgreer@animalcreek.com> Acked-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Liam Breck authored
The device specific data is not fully initialized on request_threaded_irq(). This may cause a crash when the IRQ handler tries to reference them. Fix the issue by installing IRQ handler at the end of the probe. Fixes: d7bf353f ("bq24190_charger: Add support for TI BQ24190 Battery Charger") Signed-off-by:
Liam Breck <kernel@networkimprov.net> Acked-by:
Mark Greer <mgreer@animalcreek.com> Acked-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Liam Breck authored
pm_resume() does a register_reset() which clears charger host mode. Fix by calling set_mode_host() after the reset. Fixes: d7bf353f ("bq24190_charger: Add support for TI BQ24190 Battery Charger") Signed-off-by:
Liam Breck <kernel@networkimprov.net> Acked-by:
Mark Greer <mgreer@animalcreek.com> Acked-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Liam Breck authored
The interrupt signal is TRIGGER_FALLING. This is is specified in the data sheet PIN FUNCTIONS: "The INT pin sends active low, 256us pulse to host to report charger device status and fault." Also the direction can be seen in the data sheet Figure 37 "BQ24190 with D+/D- Detection and USB On-The-Go (OTG)" which shows a 10k pull-up resistor installed for the sample configurations. Fixes: d7bf353f ("bq24190_charger: Add support for TI BQ24190 Battery Charger") Signed-off-by:
Liam Breck <kernel@networkimprov.net> Acked-by:
Mark Greer <mgreer@animalcreek.com> Acked-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
- 18 Jan, 2017 3 commits
-
-
Arnd Bergmann authored
The added regulator dependency in the smbb driver causes build errors when regulators are disabled, e.g. in randconfig build testing: drivers/power/supply/qcom_smbb.o: In function `smbb_chg_otg_is_enabled': qcom_smbb.c:(.text.smbb_chg_otg_is_enabled+0x18): undefined reference to `rdev_get_drvdata' drivers/power/supply/qcom_smbb.o: In function `smbb_charger_probe': qcom_smbb.c:(.text.smbb_charger_probe+0x410): undefined reference to `devm_regulator_register' This adds a Kconfig dependency to avoid the link error. Fixes: 61274eff ("power: supply: qcom_smbb: Add otg regulator for control of vbus") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Alexandre Belloni authored
commit eacd8d09 ("power/reset: at91-reset: remove useless at91_reset_platform_probe()") removed non DT probe support but forgot to remove the now useless id_table. Do that now. Signed-off-by:
Alexandre Belloni <alexandre.belloni@free-electrons.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Szemző András authored
Add samx7 support. It is lacking a few bits and needs a new reset function. Signed-off-by:
Szemző András <sza@esh.hu> Signed-off-by:
Alexandre Belloni <alexandre.belloni@free-electrons.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
- 17 Jan, 2017 1 commit
-
-
kbuild test robot authored
drivers/power/supply/max14656_charger_detector.c:317:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alexander Kurz <akurz@blala.de> Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
- 16 Jan, 2017 9 commits
-
-
Gustavo A. R. Silva authored
Simplify return logic to avoid unnecessary variable assignments. These issues were detected using Coccinelle and the following semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by:
Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Gustavo A. R. Silva authored
Simplify return logic to avoid unnecessary variable assignments. These issues were detected using Coccinelle and the following semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by:
Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Sebastian Reichel authored
-
Alexandre Belloni authored
LPDDR memories can only handle up to 400 uncontrolled power off. Ensure the proper power off sequence is used before shutting down the platform. Cc: <stable@vger.kernel.org> # 4.4+ Signed-off-by:
Alexandre Belloni <alexandre.belloni@free-electrons.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Alexandre Belloni authored
The Atmel MPDDR controller support LPDDR2 and LPDDR3 memories, add their types. Cc: <stable@vger.kernel.org> # 4.4+ Signed-off-by:
Alexandre Belloni <alexandre.belloni@free-electrons.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Alexander Kurz authored
The MAX14656 USB charger detector, also known as "AL32" is used to detect the presence and capabilities of attached USB chargers. The device is attached via I2C plus one interrupt line to signalize events. The device can be found in LG smartphones like LS665 and LS770, compatible devices are present in 4th/5th generation Amazon Kindle readers referenced in source code packages as "Maxim AL32". The initial version of this driver has been extracted from LG source code package LGLS665_Android_Lollipop_LS665ZV3, enriched with information from the Kindle_src_4.1.3 source code package and adapted to the current power class sysfs interface. Non-Standard Apple chargers which the device may detect are mapped to the USB Battery Charging Specification Revision 1.2 class USB_DCP. Signed-off-by:
Alexander Kurz <akurz@blala.de> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Alexander Kurz authored
Signed-off-by:
Alexander Kurz <akurz@blala.de> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Bird, Tim authored
Add a regulator to control the OTG chargepath switch. This is used by USB code to control VBUS direction - out for host mode on the OTG port, and in for charging mode. Signed-off-by:
Tim Bird <tim.bird@sonymobile.com> Acked-by:
Bjorn Andersson <bjorn.andersson@sonymobile.com> Reviewed-by:
Andy Gross <andy.gross@linaro.org> [stephen.boyd@linaro.org: Fix supply name, constify ops, drop machine.h and of_regulator.h includes] Signed-off-by:
Stephen Boyd <stephen.boyd@linaro.org> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Bird, Tim authored
Add a binding for the regulator which controls the OTG chargepath switch. The OTG switch gets its power from pm8941_5vs1, and that should be expressed as a usb_otg_in-supply property in the DT node for the charger driver. The regulator name is "otg-vbus". Signed-off-by:
Tim Bird <tim.bird@sonymobile.com> Acked-by:
Bjorn Andersson <bjorn.andersson@sonymobile.com> Reviewed-by:
Andy Gross <andy.gross@linaro.org> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Stephen Boyd <stephen.boyd@linaro.org> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
- 12 Jan, 2017 12 commits
-
-
Chris Lapa authored
The bq27xxx binding is a standard i2c style binding, however the deprecated compatible fields and different revisions warrant its own documentation. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
This commit adds the BQ27520G4 chip definition to specifically match the bq27520-G4 functionality as described in the datasheet. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
This commit adds the BQ27520G3 chip definition to specifically match the bq27520-G3 functionality as described in the datasheet. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
This commit adds the BQ27520G2 chip definition to specifically match the bq27520-G2 functionality as described in the datasheet. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
This commit adds the BQ27520G1 chip definition to specifically match the bq27520-G1 functionality as described in the datasheet. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
This commit adds the BQ27510G3 chip definition to specifically match the bq27510-G3 functionality as described in the datasheet. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Tested-by:
Chris Lapa <chris@lapa.com.au> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
This commit adds the BQ27510G2 chip definition to specifically match the bq27510-G2 functionality as described in the datasheet. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
This commit adds the BQ27510G1 chip definition to specifically match the bq27510-G1 functionality as described in the datasheet. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
This commit adds the BQ27500 chip definition to specifically match the bq27500/1 functionality as described in the datasheet. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
The BQ2751X definition exists only to satisfy backwards compatibility. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Chris Lapa authored
The BQ2750X definition exists only to satisfy backwards compatibility. Signed-off-by:
Chris Lapa <chris@lapa.com.au> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Michal Suchanek authored
Casting of_device_get_match_data return value to int causes warning on 64bit architectures. ../drivers/power/supply/axp20x_usb_power.c: In function 'axp20x_usb_power_probe': ../drivers/power/supply/axp20x_usb_power.c:297:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Fixes: 0dcc70ca ("power: supply: axp20x_usb_power: use of_device_id data field instead of device_is_compatible") Signed-off-by:
Michal Suchanek <msuchanek@suse.de> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
- 10 Jan, 2017 2 commits
-
-
Chris Lapa authored
This is done for readability as the upcoming commits will add a lot of cases. tested: no Signed-off-by:
Chris Lapa <chris@lapa.com.au> Acked-by:
Pali Rohár <pali.rohar@gmail.com> Reviewed-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Milo Kim authored
Add interrupt specifiers for USB and AC charger input. Interrupt numbers are from the datasheet. Fix wrong property for compatible string. Signed-off-by:
Milo Kim <woogyom.kim@gmail.com> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
- 05 Jan, 2017 1 commit
-
-
Andy Shevchenko authored
The Moorestown support was removed by commit 1a8359e4 ("x86/mid: Remove Intel Moorestown"). Remove this leftover. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
- 04 Jan, 2017 4 commits
-
-
Linus Walleij authored
The GPIO charger is using a mix of the legacy GPIO interface and <linux/of_gpio.h> which is not the modern way to use GPIOs. Refactor like this: - Use a GPIO descriptor for the GPIO line used to monitor the charger. - Fetch the descriptor with devm_gpiod_get() as the first method. - If this fails and we are *not* using device tree, then start looking to see if we can use platform data instead. - After looking up and requesting a GPIO number with the legacy API, convert it to a descriptor. This way we can later isolate and drop the legacy code as more platforms move over to using descriptors. Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Cc: Heiko Stuebner <heiko@sntech.de> Cc: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Colin Ian King authored
trivial fix to spelling mistake in comments in the headers Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Colin Ian King authored
pdata is being null checked twice, the 2nd check is redundant code and can be removed. Fixes CoverityScan CID 1392340 "Logically dead code" Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-
Hans de Goede authored
Setting the irq_enable bits is taken care of by the irq chip when we request the irqs and the driver should not be meddling with the irq?_en registers itself. Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Sebastian Reichel <sre@kernel.org>
-