- 04 Jul, 2002 17 commits
-
-
Andrew Morton authored
In mpage_writepage(), use __GFP_HIGH when allocating the BIO: writeback is a memory reclaim function and is entitle to dip into the page reserves to get its IO underway.
-
Andrew Morton authored
This patch reinstates __GFP_HIGH functionality. __GFP_HIGH means "able to dip into the emergency pools". However, somewhere along the line this got broken. __GFP_HIGH ceased to do anything. Instead, !__GFP_WAIT is used to tell the page allocator to try harder. __GFP_HIGH makes sense. The concepts of "unable to sleep" and "should try harder" are quite separate, and overloading !__GFP_WAIT to mean "should access emergency pools" seems wrong. This patch fixes a problem in mempool_alloc(). mempool_alloc() tries the first allocation with __GFP_WAIT cleared. If that fails, it tries again with __GFP_WAIT enabled (if the caller can support __GFP_WAIT). So it is currently performing an atomic allocation first, even though the caller said that they're prepared to go in and call the page stealer. I thought this was a mempool bug, but Ingo said: > no, it's not GFP_ATOMIC. The important difference is __GFP_HIGH, which > triggers the intrusive highprio allocation mode. Otherwise gfp_nowait is > just a nonblocking allocation of the same type as the original gfp_mask. > ... > what i've added is a bit more subtle allocation method, with both > performance and balancing-correctness in mind: > > 1. allocate via gfp_mask, but nonblocking > 2. if failure => try to get from the pool if the pool is 'full enough'. > 3. if failure => allocate with gfp_mask [which might block] > > there is performance data that this method improves bounce-IO performance > significantly, because even under VM pressure (when gfp_mask would block) > we can still use up to 50% of the memory pool without blocking (and > without endangering deadlock-free allocation). Ie. the memory pool is also > a fast 'frontside cache' of memory elements. Ingo was assuming that __GFP_HIGH was still functional. It isn't, and the mempool design wants it.
-
Andrew Morton authored
Yet another SetPageDirty/set_page_dirty bugfix: mark_dirty_kiobuf needs to run set_page_dirty() so the page goes onto its mapping's dirty_pages list.
-
Andrew Morton authored
For O_DIRECT opens we're currently checking that the fs supports O_DIRECT at write(2)-time. This is a forward-port of Andrea's patch which moves the check to open() time. Seems more sensible.
-
Andrew Morton authored
It seems that the yield() macro requires state TASK_RUNNING, but practically none of the callers remember to do that. The patch turns yield() into a real function which sets state TASK_RUNNING before scheduling.
-
Andrew Morton authored
do_select() does set_current_state(TASK_INTERRUPTIBLE) then calls __pollwait() which calls __get_free_page() and the cond_resched() which I added to the pagecache reclaim code never returns. The patch makes cond_resched() more useful by setting current->state to TASK_RUNNING before scheduling.
-
Andrew Morton authored
A little cleanup: Most callers of list_splice() immediately reinitialise the source list_head after calling list_splice(). So create a new list_splice_init() which does all that.
-
Andrew Morton authored
A shmem cleanup/bugfix patch from Hugh Dickins. - Minor: in try_to_unuse(), only wait on writeout if we actually started new writeout. Otherwise, there is no need because a wait_on_page_writeback() has already been executed against this page. And it's locked, so no new writeback can start. - Minor: in shmem_unuse_inode(): remove all the wait_on_page_writeback() logic. We already did that in try_to_unuse(), adn the page is locked so no new writeback can start. - Less minor: add a missing a page_cache_release() to shmem_get_page_locked() in the uncommon case where the page was found to be under writeout.
-
Andrew Morton authored
Patch from Christoph Hellwig removes swap_get_block(). I was sort-of hanging onto this function because it is a standard get_block function, and maybe perhaps it could be used to make swap use the regular filesystem I/O functions. We don't want to do that, so kill it.
-
Andrew Morton authored
Writeback/pdflush cleanup patch from Steven Augart * Exposes nr_pdflush_threads as /proc/sys/vm/nr_pdflush_threads, read-only. (I like this - I expect that management of the pdflush thread pool will be important for many-spindle machines, and this is a neat way of getting at the info). * Adds minimum and maximum checking to the five writable pdflush and fs-writeback parameters. * Minor indentation fix in sysctl.c * mm/pdflush.c now includes linux/writeback.h, which prototypes pdflush_operation. This is so that the compiler can automatically check that the prototype matches the definition. * Adds a few comments to existing code.
-
Andrew Morton authored
- Comment and documentation fixlets - Remove some unneeded fields from swapper_inode (these are a leftover from when I had swap using the filesystem IO functions). - fix a printk bug in pci/pool.c: when dma_addr_t is 64 bit it generates a compile warning, and will print out garbage. Cast it to unsigned long long. - Convert some writeback #defines into enums (Steven Augart)
-
Andrew Morton authored
Having just fiddled with the refcounts of blockdev buffers, I want some way of assuring that the code is correct and is not leaking buffer_heads. There's no easy way to do this: if a blockdev page has pinned buffers then truncate_complete_page just cuts it loose and we leak memory. The patch adds a bit of debug code to catch these leaks. This code, PF_RADIX_TREE and buffer_error() need to be removed later on.
-
Andrew Morton authored
Removes ext3's open-coded inode and allocation bitmap LRUs. This patch includes a cleanup to ext3_new_block(). The local variables `bh', `bh2', `i', `j', `k' and `tmp' have been renamed to something more palatable.
-
Andrew Morton authored
Remove ext2's open-coded bitmap LRUs. Core kernel does this for it now.
-
Andrew Morton authored
ext2 and ext3 implement a custom LRU cache of buffer_heads - the eight most-recently-used inode bitmap buffers and the eight MRU block bitmap buffers. I don't like them, for a number of reasons: - The code is duplicated between filesystems - The functionality is unavailable to other filesystems - The LRU only applies to bitmap buffers. And not, say, indirects. - The LRUs are subtly dependent upon lock_super() for protection: without lock_super protection a bitmap could be evicted and freed while in use. And removing this dependence on lock_super() gets us one step on the way toward getting that semaphore out of the ext2 block allocator - it causes significant contention under some loads and should be a spinlock. - The LRUs pin 64 kbytes per mounted filesystem. Now, we could just delete those LRUs and rely on the VM to manage the memory. But that would introduce significant lock contention in __find_get_block - the blockdev mapping's private_lock and page_lock are heavily used. So this patch introduces a transparent per-CPU bh lru which is hidden inside __find_get_block(), __getblk() and __bread(). It is designed to shorten code paths and to reduce lock contention. It uses a seven-slot LRU. It achieves a 99% hit rate in `dbench 64'. It provides benefit to all filesystems. The next patches remove the open-coded LRUs from ext2 and ext3. Taken together, these patches are a code cleanup (300-400 lines gone), and they reduce lock contention. Anton tested these patches on the 32-way and demonstrated a throughput improvement of up to 15% on RAM-only dbench runs. See http://samba.org/~anton/linux/2.5.24/dbench/ Most of this benefit is from avoiding find_get_page() on the blockdev mapping. Because the generic LRU copes with indirect blocks as well as bitmaps.
-
Andrew Morton authored
Fix from Rahul Karnik and Donald Becker - some new 3c566B mini-PCI NICs refuse to power up the transceiver unless we tickle an undocumented bit in an undocumented register. They worked this out by before-and-after diffing of the register contents when it was set up by the Windows driver.
-
Andrew Morton authored
If allocation of a BIO for swap writeout fails, mark the page dirty again to save it from eviction.
-
- 20 Jun, 2002 23 commits
-
-
Linus Torvalds authored
-
Linus Torvalds authored
-
Andi Kleen authored
The last changes did trigger another latent bug in the inline assembly. akpm noticed it because he compiles his kernels with frame pointers.
-
http://gkernel.bkbits.net/irda-2.5Linus Torvalds authored
into home.transmeta.com:/home/torvalds/v2.5/linux
-
Jens Axboe authored
Uninline elv_next_request() and move it to elevator.c, where it belongs. Because of CURRENT declaration, this actually saves lots of space. From Andrew.
-
Robert Kuebel authored
init_rootfs() (from ramfs) doesn't appear in any header file. I didn't see any that looked like a good home, so lets put a prototype at the top of fs/namespace.c. This only use of this function is in namespace.c.
-
Robert Kuebel authored
This patch makes sure the 3c509 module license is always GPL. Currently the MODULE_LICENSE() marco is only used when CONFIG_ISAPNP or CONFIG_ISAPNP_MODULE is defined. I have moved MODULE_LICENSE() to the #ifdef MODULE section at the bottom of 3c509.c. Same is true for the MODULE_DEVICE_TABLE() macro.
-
William Lee Irwin III authored
Not sure why I forgot to do this, but here is a small bit of tidying up of some leftover parentheses from the memlist macro removal. The parentheses are just noise and should go.
-
William Lee Irwin III authored
page_alloc.c does not use either slab.h or swapctl.h. This removes the inclusion of those headers from page_alloc.c
-
William Lee Irwin III authored
nr_free_pages() is overly verbose. The following is perhaps clearer and gets to the point with fewer lines of code and inside of 80 columns.
-
William Lee Irwin III authored
-
William Lee Irwin III authored
-
Stephen Rothwell authored
14 of our 17 architectures define sys_pause exactly the same way. The other three don't define it at all. I assume glibc translates pause() into sigsuspend() or something.
-
Rusty Russell authored
In favour of those now in kernel.h..
-
Rusty Russell authored
-
James Mayer authored
-
James Mayer authored
-
James Mayer authored
-
Greg Banks authored
Three arch-determining symbols in drivers/mtd/maps/Config.in are wrong. They have apparently been generated using the sensible pattern "CONFIG_FOO" for an architecture "foo"; unfortunately the architectures are not sensible. CONFIG_SPARC should be CONFIG_SPARC32 CONFIG_I386 should be CONFIG_X86 CONFIG_SH should be CONFIG_SUPERH
-
Greg Banks authored
Removed a spurious menu definition which was both a duplicate and had no matching "endmenu".
-
Greg Banks authored
Removed an "endmenu" for which there was no opening "mainmenu_option".
-
Greg Banks authored
The config language is *not* shell. The construct "[ foo ] || [ bar ]" is legal in shell but not in the config language, where we should use the equivalent "[ foo -o bar ]"
-
Greg Banks authored
The format for the "choice" statement is: choice 'prompt' "{sub-prompt sub-symbol}*" default-value and the following is *not* legal config language (note the positioning of the closing double quote): choice 'prompt' "{sub-prompt sub-symbol}* default-value" It only happens to work because of a combination of accidental side effects of the current parsers: * unpaired sub-words inside the 2nd word are silently ignored * the missing last word is silently treated as if empty
-