1. 08 Jun, 2011 1 commit
  2. 07 Jun, 2011 5 commits
    • Greg Kroah-Hartman's avatar
      Revert "USB: option: add ID for ZTE MF 330" · 3095ec89
      Greg Kroah-Hartman authored
      This reverts commit a559d2c8.
      
      Turns out that device id 0x1d6b:0x0002 is a USB hub, which causes havoc
      when the option driver tries to bind to it.
      
      So revert this as it doesn't seem to be needed at all.
      
      Thanks to Michael Tokarev and Paweł Drobek for working on resolving this
      issue.
      
      Cc: Paweł Drobek <pawel.drobek@gmail.com>
      Cc: Michael Tokarev <mjt@tls.msk.ru>
      Cc: Dominik Brodowski <linux@dominikbrodowski.net>
      Cc: stable <stable@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      3095ec89
    • Julia Lawall's avatar
      drivers/usb/host/ohci-pxa27x.c: add missing clk_put · 7febe2be
      Julia Lawall authored
      Add a label before the call to clk_put and jump to that in the error
      handling code that occurs after the call to clk_get has succeeded.
      
      A simplified version of the semantic match that finds this problem is as
      follows: (http://coccinelle.lip6.fr/)
      
      // <smpl>
      @r exists@
      expression e1,e2;
      statement S;
      @@
      
      e1 = clk_get@p1(...);
      ... when != e1 = e2
          when != clk_put(e1)
          when any
      if (...) { ... when != clk_put(e1)
                     when != if (...) { ... clk_put(e1) ... }
      * return@p3 ...;
       } else S
      // </smpl>
      Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
      Acked-by: default avatarEric Miao <eric.y.miao@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      7febe2be
    • Alan Stern's avatar
      USB: CONFIG_USB_GADGET_DUALSPEED is not user-configurable · 97b2f900
      Alan Stern authored
      This patch (as1468) changes the Kconfig definition for
      USB_GADGET_DUALSPEED.  This option is determined entirely by which
      device controller drivers are to be built, through Select statements;
      it does not need to be (and should not be) configurable by the user.
      
      Also, the "default n" line is superfluous -- everything defaults to N.
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Acked-by: default avatarFelipe Balbi <balbi@ti.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      97b2f900
    • Alan Stern's avatar
      USB: dummy-hcd needs the has_tt flag · c5c69f3f
      Alan Stern authored
      Like with other host controllers capable of operating at both high
      speed and full speed, we need to indicate that the emulated controller
      presented by dummy-hcd has this ability.  Otherwise usbcore will not
      accept full-speed gadgets under dummy-hcd.  This patch (as1469) sets
      the appropriate has_tt flag.
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      c5c69f3f
    • Alan Stern's avatar
      usb-storage: redo incorrect reads · 21c13a4f
      Alan Stern authored
      Some USB mass-storage devices have bugs that cause them not to handle
      the first READ(10) command they receive correctly.  The Corsair
      Padlock v2 returns completely bogus data for its first read (possibly
      it returns the data in encrypted form even though the device is
      supposed to be unlocked).  The Feiya SD/SDHC card reader fails to
      complete the first READ(10) command after it is plugged in or after a
      new card is inserted, returning a status code that indicates it thinks
      the command was invalid, which prevents the kernel from retrying the
      read.
      
      Since the first read of a new device or a new medium is for the
      partition sector, the kernel is unable to retrieve the device's
      partition table.  Users have to manually issue an "hdparm -z" or
      "blockdev --rereadpt" command before they can access the device.
      
      This patch (as1470) works around the problem.  It adds a new quirk
      flag, US_FL_INVALID_READ10, indicating that the first READ(10) should
      always be retried immediately, as should any failing READ(10) commands
      (provided the preceding READ(10) command succeeded, to avoid getting
      stuck in a loop).  The patch also adds appropriate unusual_devs
      entries containing the new flag.
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Tested-by: default avatarSven Geggus <sven-usbst@geggus.net>
      Tested-by: default avatarPaul Hartman <paul.hartman+linux@gmail.com>
      CC: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
      CC: <stable@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      21c13a4f
  3. 06 Jun, 2011 22 commits
  4. 04 Jun, 2011 12 commits