1. 30 May, 2012 9 commits
    • Jim Meyering's avatar
      Btrfs: NUL-terminate path buffer in DEV_INFO ioctl result · a27202fb
      Jim Meyering authored
      A device with name of length BTRFS_DEVICE_PATH_NAME_MAX or longer
      would not be NUL-terminated in the DEV_INFO ioctl result buffer.
      Signed-off-by: default avatarJim Meyering <meyering@redhat.com>
      a27202fb
    • Jim Meyering's avatar
      Btrfs: avoid buffer overrun in btrfs_printk · f07c9a79
      Jim Meyering authored
      The buffer read-overrun would be triggered by a printk format
      starting with <N>, where N is a single digit.  NUL-terminate
      after strncpy.  Use memcpy, not strncpy, since we know the
      string we're copying fits in the destination buffer and
      contains no NUL byte.
      Signed-off-by: default avatarJim Meyering <meyering@redhat.com>
      f07c9a79
    • Daniel J Blueman's avatar
      Fix minor type issues · 2eec6c81
      Daniel J Blueman authored
      Address some minor type issues identified by sparse checker.
      Signed-off-by: default avatarDaniel J Blueman <daniel@quora.org>
      2eec6c81
    • Sergei Trofimovich's avatar
      btrfs: allow changing 'thread_pool' size at remount time · 0d2450ab
      Sergei Trofimovich authored
      Changing 'mount -oremount,thread_pool=2 /' didn't make any effect:
      
      maximum amount of worker threads is specified in 2 places:
      - in 'strict btrfs_fs_info::thread_pool_size'
      - in each worker struct: 'struct btrfs_workers::max_workers'
      
      'mount -oremount' updated only 'btrfs_fs_info::thread_pool_size'.
      
      Fix it by pushing new maximum value to all created worker structures
      as well.
      
      Cc: Josef Bacik <josef@redhat.com>
      Cc: Chris Mason <chris.mason@oracle.com>
      Reviewed-by: default avatarJosef Bacik <josef@redhat.com>
      Signed-off-by: default avatarSergei Trofimovich <slyfox@gentoo.org>
      0d2450ab
    • Josef Bacik's avatar
      Btrfs: do not do filemap_write_and_wait_range in fsync · 0885ef5b
      Josef Bacik authored
      We already do the btrfs_wait_ordered_range which will do this for us, so
      just remove this call so we don't call it twice.  Thanks,
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      0885ef5b
    • Josef Bacik's avatar
      Btrfs: remove useless waiting and extra filemap work · 551ebb2d
      Josef Bacik authored
      In btrfs_wait_ordered_range we have been calling filemap_fdata_write() twice
      because compression does strange things and then waiting.  Then we look up
      ordered extents and if we find any we will always schedule_timeout(); once
      and then loop back around and do it all again.  We will even check to see if
      there is delalloc pages on this range and loop again.  So this patch gets
      rid of the multipe fdata_write() calls and just does
      filemap_write_and_wait().  In the case of compression we will still find the
      ordered extents and start those individually if we need to so that is ok,
      but in the normal buffered case we avoid all this weird overhead.
      
      Then in the case of the schedule_timeout(1), we don't need it.  All callers
      either 1) don't care, they just want to make sure what they just wrote maeks
      it to disk or 2) are doing the lock()->lookup ordered->unlock->flush thing
      in which case it will lock and check for ordered extents _anyway_ so get
      back to them as quickly as possible.  The delaloc check is simply not
      needed, this only catches the case where we write to the file again since
      doing the filemap_write_and_wait() and if the caller truly cares about that
      it will take care of everything itself.  Thanks,
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      551ebb2d
    • Josef Bacik's avatar
      Btrfs: fix compile warnings in extent_io.c · d7dbe9e7
      Josef Bacik authored
      These warnings are bogus since we will always have at least one page in an
      eb, but to make the compiler happy just set ret = 0 in these two cases.
      Thanks,
      Btrfs: fix compile warnings in extent_io.c
      
      These warnings are bogus since we will always have at least one page in an
      eb, but to make the compiler happy just set ret = 0 in these two cases.
      Thanks,
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      d7dbe9e7
    • Josef Bacik's avatar
      Btrfs: cache no acl on new inodes · 30f8fe3e
      Josef Bacik authored
      When running compilebench I noticed we were spending some time looking up
      acls on new inodes, which shouldn't be happening since there were no acls.
      This is because when we init acls on the inode after creating them we don't
      cache the fact there are no acls if there aren't any.  Doing this adds a
      little bit of a bump to my compilebench runs.  Thanks,
      Btrfs: cache no acl on new inodes
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      30f8fe3e
    • Josef Bacik's avatar
      Btrfs: use i_version instead of our own sequence · 0c4d2d95
      Josef Bacik authored
      We've been keeping around the inode sequence number in hopes that somebody
      would use it, but nobody uses it and people actually use i_version which
      serves the same purpose, so use i_version where we used the incore inode's
      sequence number and that way the sequence is updated properly across the
      board, and not just in file write.  Thanks,
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      0c4d2d95
  2. 11 May, 2012 7 commits
  3. 06 May, 2012 5 commits
  4. 05 May, 2012 10 commits
  5. 04 May, 2012 9 commits