- 14 Sep, 2021 2 commits
-
-
Martin Kaiser authored
Remove some unused defines and macros related to power states. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20210913185110.3065-3-martin@kaiser.cxSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Martin Kaiser authored
After we dropped the call to set HW_VAR_SET_RPWM, the rtw_set_rpwm function doesn't do anything useful. Remove the function and the rpwm component of struct pwrctrl_priv, which is not used outside of rtw_set_rpwm. Signed-off-by:
-
- 13 Sep, 2021 38 commits
-
-
Gaston Gonzalez authored
Fix code alignment issues. Reported by checkpatch.pl Signed-off-by:
Gaston Gonzalez <gascoar@gmail.com> Link: https://lore.kernel.org/r/20210912133751.269885-2-gascoar@gmail.comSigned-off-by:
-
Gaston Gonzalez authored
Remove unnecessary braces from if block. Reported by checkpatch.pl Signed-off-by:
-
Michael Straube authored
After removing unused register definitions from odm_reg.h there are only two definitions left. Move them into odm.h and remove odm_reg.h. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210913090831.13803-2-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Remove unused register definitions from odm_reg.h. Signed-off-by:
-
Saurav Girepunje authored
Remove unused function rtw_set_tx_chksum_offload. Signed-off-by:
Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YT4xcJvvlPSIS+T6@userSigned-off-by:
-
Michael Straube authored
Replace and remove the macro GET_EEPROM_EFUSE_PRIV to get one step closer to remove hal_intf.h. Signed-off-by:
-
Michael Straube authored
The header file HalHWImg8188E_FW.h is not used in the driver. Remove it. Signed-off-by:
-
Martin Kaiser authored
The bHWPwrPindetect cleanup removed the only call to rtw_hw_suspend. Signed-off-by:
-
Martin Kaiser authored
The bHWPwrPindetect component of struct pwrctrl_priv is never initialised explicitly, it remains at its default value 0. Remove bHWPwrPindetect itself and code that depends on bHWPwrPindetect != 0. Signed-off-by:
-
Martin Kaiser authored
tog in struct pwrctrl_priv is never read. Remove it. Signed-off-by:
-
Martin Kaiser authored
cpwm in struct pwrctrl_priv is never read. Remove it. Signed-off-by:
-
Martin Kaiser authored
Setting the HW_VAR_SET_RPWM "hardware variable" is an empty operation. Remove the call to set HW_VAR_SET_RPWM, the calculation of the value to be set and the definition of HW_VAR_SET_RPWM itself. Signed-off-by:
-
Martin Kaiser authored
btcoex_rfon is always false in this driver. Remove the variable and code that will never be executed. Signed-off-by:
-
Pavel Skripkin authored
While testing latest updates I hit lockdep warning: [ 42.694425] ============================================ [ 42.694785] WARNING: possible recursive locking detected [ 42.695120] 5.14.0+ #25 Tainted: G C [ 42.695422] -------------------------------------------- [ 42.695747] RTW_CMD_THREAD/317 is trying to acquire lock: [ 42.696078] ffffc900006c90b0 (&pqueue->lock){+.-.}-{3:3}, at: _rtw_alloc_network+0x1e/0x321 [r8188eu] [ 42.696686] [ 42.696686] but task is already holding lock: [ 42.697148] ffffc900006c9100 (&pqueue->lock){+.-.}-{3:3}, at: rtw_update_scanned_network+0x31/0x76b [r8188eu] [ 42.697758] [ 42.697758] other info that might help us debug this: [ 42.698326] Possible unsafe locking scenario: [ 42.698326] [ 42.698696] CPU0 [ 42.698847] ---- [ 42.698997] lock(&pqueue->lock); [ 42.699209] lock(&pqueue->lock); [ 42.699418] [ 42.699418] *** DEADLOCK *** [ 42.699418] [ 42.699768] May be due to missing lock nesting notation It's false positive, since all queue spinlocks are initialized via private API which has pqueue as agrument. Fix it by making _rtw_init_queue a macro instead of function + removed unneeded _ prefix. Signed-off-by:Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/20210908194309.9086-1-paskripkin@gmail.comSigned-off-by:
-
Ojaswin Mujoo authored
Replace function typedefs with the equivalent declarations to better align with the linux kenel coding style The following typedefs were changed: * VCHIQ_CONNECTED_CALLBACK_T * vchiq_userdata_term Signed-off-by:
Ojaswin Mujoo <ojaswin98@gmail.com> Link: https://lore.kernel.org/r/a8e4e0457b5fcc88c7f297f9d669dfb7e7d91ed5.1631366317.git.ojaswin98@gmail.comSigned-off-by:
-
Michael Straube authored
After the removal of some pointers from struct hal_ops the function rtl8188e_set_hal_ops() is empty now. Remove it. Acked-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Signed-off-by:
-
Michael Straube authored
Remove write_rfreg from struct hal_ops and its wrapper rtw_hal_write_rfreg(). Call rtl8188e_PHY_SetRFReg() directly instead. Acked-by:
-
Michael Straube authored
Remove read_rfreg from struct hal_ops and its wrapper rtw_hal_read_rfreg(). Call rtl8188e_PHY_QueryRFReg() directly instead. Acked-by:
-
Michael Straube authored
Remove write_bbreg from struct hal_ops and its wrapper rtw_hal_write_bbreg(). Call rtl8188e_PHY_SetBBReg() directly instead. Acked-by:
-
Michael Straube authored
Remove read_bbreg from struct hal_ops and its wrapper rtw_hal_read_bbreg(). Call rtl8188e_PHY_QueryBBReg() directly instead. Acked-by:
-
Michael Straube authored
Remove hal_xmit from struct hal_ops and its wrapper rtw_hal_xmit(). Call rtl8188eu_hal_xmit() directly instead. Acked-by:
-
Michael Straube authored
Remove mgnt_xmit from struct hal_ops and its wrapper rtw_hal_mgnt_xmit(). Call rtl8188eu_mgnt_xmit() directly instead. Acked-by:
-
Michael Straube authored
Function ODM_InitAllTimers() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_CancelAllTimers() is unused and it is the only caller of function ODM_CancelTimer(). Remove both. Acked-by:
-
Michael Straube authored
The function prototype ODM_InitializeTimer() is not used, remove it. Acked-by:
-
Michael Straube authored
Function ODM_AllocateMemory() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_FreeMemory() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_Read2Byte() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_SetTimer() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_IsWorkItemScheduled() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_ScheduleWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_FreeWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_StopWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_StartWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_InitializeWorkItem() is unused and empty, remove it. Acked-by:
-
Michael Straube authored
Function ODM_sleep_us() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_FillH2CCmd() is unused, remove it. Acked-by:
-
Michael Straube authored
Function ODM_ReleaseSpinLock() is unused and empty, remove it. Acked-by:
-
