1. 08 Aug, 2019 28 commits
  2. 07 Aug, 2019 9 commits
    • Himanshu Madhani's avatar
    • Quinn Tran's avatar
      scsi: qla2xxx: Allow NVMe IO to resume with short cable pull · 03cc44bf
      Quinn Tran authored
      Current driver report dev_loss_tmo to 0 for NVMe devices with short cable
      pull.  This causes NVMe controller to be freed along with NVMe namespace.
      The side affect is IO would stop.  By not setting dev_loss_tmo to 0, NVMe
      namespace would stay until cable is plugged back in.  This allows IO to
      resume afterward.
      
      [mkp: commit desc]
      Signed-off-by: default avatarArun Easi <aeasi@marvell.com>
      Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
      Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      03cc44bf
    • Quinn Tran's avatar
      scsi: qla2xxx: Fix hang in fcport delete path · f00b3428
      Quinn Tran authored
      A hang was observed in the fcport delete path when the device was
      responding slow and an issue-lip path (results in session termination) was
      taken.
      
      Fix this by issuing logo requests unconditionally.
      
      PID: 19491  TASK: ffff8e23e67bb150  CPU: 0   COMMAND: "kworker/0:0"
       #0 [ffff8e2370297bf8] __schedule at ffffffffb4f7dbb0
       #1 [ffff8e2370297c88] schedule at ffffffffb4f7e199
       #2 [ffff8e2370297c98] schedule_timeout at ffffffffb4f7ba68
       #3 [ffff8e2370297d40] msleep at ffffffffb48ad9ff
       #4 [ffff8e2370297d58] qlt_free_session_done at ffffffffc0c32052 [qla2xxx]
       #5 [ffff8e2370297e20] process_one_work at ffffffffb48bcfdf
       #6 [ffff8e2370297e68] worker_thread at ffffffffb48bdca6
       #7 [ffff8e2370297ec8] kthread at ffffffffb48c4f81
      Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
      Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      f00b3428
    • Andrew Vasquez's avatar
      scsi: qla2xxx: Use common update-firmware-options routine for ISP27xx+ · a36f1443
      Andrew Vasquez authored
      Leverage the generic routine, qla24xx_update_fw_options(), for the
      configuration of firmware options for ISP27xx/ISP28xx.
      Signed-off-by: default avatarAndrew Vasquez <andrewv@marvell.com>
      Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      a36f1443
    • Arun Easi's avatar
      scsi: qla2xxx: Fix NVMe port discovery after a short device port loss · 9e744591
      Arun Easi authored
      The following sequence of event leads to NVME port disappearing:
      
          - device port shut
          - nvme_fc_unregister_remoteport
          - device port online
          - remote port delete completes
          - relogin is scheduled
          - "post gidpn" message appears due to rscn generation # mismatch
      
      In short, if a device comes back online sooner than an unregister
      completion, a mismatch in rscn generation number occurs, which is not
      handled correctly during device relogin. Fix this by starting with a redo
      of GNL.
      
      When ql2xextended_error_logging is enabled, the re-plugged device's
      discovery stops with the following messages printed:
      
      --8<--
      qla2xxx [0000:41:00.0]-480d:3: Relogin scheduled.
      qla2xxx [0000:41:00.0]-4800:3: DPC handler sleeping.
      qla2xxx [0000:41:00.0]-2902:3: qla24xx_handle_relogin_event 21:00:00:24:ff:17:9e:91 DS 0 LS 7 P 0 del 2 cnfl
         (null) rscn 1|2 login 1|2 fl 1
      qla2xxx [0000:41:00.0]-28e9:3: qla24xx_handle_relogin_event 1666 21:00:00:24:ff:17:9e:91 post gidpn
      qla2xxx [0000:41:00.0]-480e:3: Relogin end.
      --8<--
      Signed-off-by: default avatarArun Easi <aeasi@marvell.com>
      Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      9e744591
    • Andrew Vasquez's avatar
      scsi: qla2xxx: Correct error handling during initialization failures · 26a77799
      Andrew Vasquez authored
      Current code misses or fails to account for proper recovery during early
      initialization failures:
      
       - Properly unwind allocations during probe() failures.
      
       - Protect against non-initialization memory allocations during
         unwinding.
      
       - Propagate error status during HW initialization.
      
       - Release SCSI host reference when memory allocations fail.
      Signed-off-by: default avatarAndrew Vasquez <andrewv@marvell.com>
      Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      26a77799
    • Quinn Tran's avatar
      scsi: qla2xxx: Retry fabric Scan on IOCB queue full · f0cecc1e
      Quinn Tran authored
      when fabric scan thread encounters IOCB Q Full, schedule a delayed work to
      retry fabric scan.
      Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
      Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      f0cecc1e
    • Quinn Tran's avatar
      scsi: qla2xxx: Fix premature timer expiration · 3a4b6cc7
      Quinn Tran authored
      For any qla2xxx async command, the SRB buffer is used to send it. In
      setting up the SRB buffer, the timer for this command is started before all
      memory allocation has finished.  Under low memory pressure, memory alloc
      can go to sleep and not wake up before the timer expires. Once timer has
      expired, the timer thread will access uninitialize fields resulting into
      NULL pointer crash.
      
      This patch fixes this crash by moving the start of timer after everything
      is setup.
      
      backtrace shows following
      
      PID: 3720   TASK: ffff996928401040  CPU: 0   COMMAND: "qla2xxx_1_dpc"
      0 [ffff99652751b698] __schedule at ffffffff965676c7
      1 [ffff99652751b728] schedule at ffffffff96567bc9
      2 [ffff99652751b738] schedule_timeout at ffffffff965655e8
      3 [ffff99652751b7e0] io_schedule_timeout at ffffffff9656726d
      4 [ffff99652751b810] congestion_wait at ffffffff95fd8d12
      5 [ffff99652751b870] isolate_migratepages_range at ffffffff95fddaf3
      6 [ffff99652751b930] compact_zone at ffffffff95fdde96
      7 [ffff99652751b980] compact_zone_order at ffffffff95fde0bc
      8 [ffff99652751ba20] try_to_compact_pages at ffffffff95fde481
      9 [ffff99652751ba80] __alloc_pages_direct_compact at ffffffff9655cc31
      10 [ffff99652751bae0] __alloc_pages_slowpath at ffffffff9655d101
      11 [ffff99652751bbd0] __alloc_pages_nodemask at ffffffff95fc0e95
      12 [ffff99652751bc80] dma_generic_alloc_coherent at ffffffff95e3217f
      13 [ffff99652751bcc8] x86_swiotlb_alloc_coherent at ffffffff95e6b7a1
      14 [ffff99652751bcf8] qla2x00_rft_id at ffffffffc055b5e0 [qla2xxx]
      15 [ffff99652751bd50] qla2x00_loop_resync at ffffffffc0533e71 [qla2xxx]
      16 [ffff99652751be68] qla2x00_do_dpc at ffffffffc05210ca [qla2xxx]
      
      PID: 0      TASK: ffffffff96a18480  CPU: 0   COMMAND: "swapper/0"
       0 [ffff99652fc03ae0] machine_kexec at ffffffff95e63674
       1 [ffff99652fc03b40] __crash_kexec at ffffffff95f1ce12
       2 [ffff99652fc03c10] crash_kexec at ffffffff95f1cf00
       3 [ffff99652fc03c28] oops_end at ffffffff9656c758
       4 [ffff99652fc03c50] no_context at ffffffff9655aa7e
       5 [ffff99652fc03ca0] __bad_area_nosemaphore at ffffffff9655ab15
       6 [ffff99652fc03cf0] bad_area_nosemaphore at ffffffff9655ac86
       7 [ffff99652fc03d00] __do_page_fault at ffffffff9656f6b0
       8 [ffff99652fc03d70] do_page_fault at ffffffff9656f915
       9 [ffff99652fc03da0] page_fault at ffffffff9656b758
          [exception RIP: unknown or invalid address]
          RIP: 0000000000000000  RSP: ffff99652fc03e50  RFLAGS: 00010202
          RAX: 0000000000000000  RBX: ffff99652b79a600  RCX: ffff99652b79a760
          RDX: ffff99652b79a600  RSI: ffffffffc0525ad0  RDI: ffff99652b79a600
          RBP: ffff99652fc03e60   R8: ffffffff96a18a18   R9: ffffffff96ee3c00
          R10: 0000000000000002  R11: ffff99652fc03de8  R12: ffff99652b79a760
          R13: 0000000000000100  R14: ffffffffc0525ad0  R15: ffff99652b79a600
          ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0018
      10 [ffff99652fc03e50] qla2x00_sp_timeout at ffffffffc0525af8 [qla2xxx]
      11 [ffff99652fc03e68] call_timer_fn at ffffffff95ea7f58
      12 [ffff99652fc03ea0] run_timer_softirq at ffffffff95eaa3bd
      13 [ffff99652fc03f18] __do_softirq at ffffffff95ea0f05
      14 [ffff99652fc03f88] call_softirq at ffffffff9657832c
      15 [ffff99652fc03fa0] do_softirq at ffffffff95e2e675
      16 [ffff99652fc03fc0] irq_exit at ffffffff95ea1285
      17 [ffff99652fc03fd8] smp_apic_timer_interrupt at ffffffff965796c8
      18 [ffff99652fc03ff0] apic_timer_interrupt at ffffffff96575df2
      Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
      Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      3a4b6cc7
    • Quinn Tran's avatar
      scsi: qla2xxx: Fix Relogin to prevent modifying scan_state flag · 8b5292bc
      Quinn Tran authored
      Relogin fails to move forward due to scan_state flag indicating device is
      not there. Before relogin process, Session delete process accidently
      modified the scan_state flag.
      
      [mkp: typos plus corrected Fixes: sha as reported by sfr]
      
      Fixes: 2dee5521 ("scsi: qla2xxx: Fix login state machine freeze")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
      Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      8b5292bc
  3. 30 Jul, 2019 3 commits