1. 19 Sep, 2009 4 commits
    • Paul E. McKenney's avatar
      rcu: Fix whitespace inconsistencies · a71fca58
      Paul E. McKenney authored
      Fix a number of whitespace ^Ierrors in the include/linux/rcu*
      and the kernel/rcu* files.
      Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Cc: laijs@cn.fujitsu.com
      Cc: dipankar@in.ibm.com
      Cc: akpm@linux-foundation.org
      Cc: mathieu.desnoyers@polymtl.ca
      Cc: josh@joshtriplett.org
      Cc: dvhltc@us.ibm.com
      Cc: niv@us.ibm.com
      Cc: peterz@infradead.org
      Cc: rostedt@goodmis.org
      Cc: Valdis.Kletnieks@vt.edu
      LKML-Reference: <20090918172819.GA24405@linux.vnet.ibm.com>
      [ did more checkpatch fixlets ]
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      a71fca58
    • Paul E. McKenney's avatar
      rcu: Fix thinko, actually initialize full tree · 49e29126
      Paul E. McKenney authored
      Commit de078d87 ("rcu: Need to update rnp->gpnum if preemptable RCU
      is to be reliable") repeatedly and incorrectly initializes the root
      rcu_node structure's ->gpnum field rather than initializing the
      ->gpnum field of each node in the tree.  Fix this.  Also add an
      additional consistency check to catch this in the future.
      Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Cc: laijs@cn.fujitsu.com
      Cc: dipankar@in.ibm.com
      Cc: akpm@linux-foundation.org
      Cc: mathieu.desnoyers@polymtl.ca
      Cc: josh@joshtriplett.org
      Cc: dvhltc@us.ibm.com
      Cc: niv@us.ibm.com
      Cc: peterz@infradead.org
      Cc: rostedt@goodmis.org
      Cc: Valdis.Kletnieks@vt.edu
      LKML-Reference: <125329262011-git-send-email->
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      49e29126
    • Paul E. McKenney's avatar
      rcu: Apply results of code inspection of kernel/rcutree_plugin.h · e7d8842e
      Paul E. McKenney authored
      o Drop the calls to cpu_quiet() from the online/offline code.
        These are unnecessary, since force_quiescent_state() will
        clean up, and removing them simplifies the code a bit.
      
      o Add a warning to check that we don't enqueue the same blocked
        task twice onto the ->blocked_tasks[] lists.
      
      o Rework the phase computation in rcu_preempt_note_context_switch()
        to be more readable, as suggested by Josh Triplett.
      
      o Disable irqs to close a race between the scheduling clock
        interrupt and rcu_preempt_note_context_switch() WRT the
        ->rcu_read_unlock_special field.
      
      o Add comments to rnp->lock acquisition and release within
        rcu_read_unlock_special() noting that irqs are already
        disabled.
      Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Cc: laijs@cn.fujitsu.com
      Cc: dipankar@in.ibm.com
      Cc: akpm@linux-foundation.org
      Cc: mathieu.desnoyers@polymtl.ca
      Cc: josh@joshtriplett.org
      Cc: dvhltc@us.ibm.com
      Cc: niv@us.ibm.com
      Cc: peterz@infradead.org
      Cc: rostedt@goodmis.org
      Cc: Valdis.Kletnieks@vt.edu
      LKML-Reference: <12532926201851-git-send-email->
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      e7d8842e
    • Paul E. McKenney's avatar
      rcu: Add WARN_ON_ONCE() consistency checks covering state transitions · 28ecd580
      Paul E. McKenney authored
      o Verify that qsmask bits stay clear through GP
        initialization.
      
      o Verify that cpu_quiet_msk_finish() is never invoked unless
        there actually is an RCU grace period in progress.
      
      o Verify that all internal-node rcu_node structures have empty
        blocked_tasks[] lists.
      
      o Verify that child rcu_node structure's bits remain clear after
        acquiring parent's lock.
      Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Cc: laijs@cn.fujitsu.com
      Cc: dipankar@in.ibm.com
      Cc: akpm@linux-foundation.org
      Cc: mathieu.desnoyers@polymtl.ca
      Cc: josh@joshtriplett.org
      Cc: dvhltc@us.ibm.com
      Cc: niv@us.ibm.com
      Cc: peterz@infradead.org
      Cc: rostedt@goodmis.org
      Cc: Valdis.Kletnieks@vt.edu
      LKML-Reference: <12532926191947-git-send-email->
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      28ecd580
  2. 17 Sep, 2009 36 commits