- 10 Nov, 2004 5 commits
-
-
Hanna V. Linder authored
This can be converted to pci_dev_present as the dev returned is never used. Compile tested. Signed-off-by: Hanna Linder <hannal@us.ibm.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Hanna V. Linder authored
Patch to replace the soon to be defunct pci_find_device with the new function pci_dev_present. I found 8 .c files (outside of /drivers/net) that used pci_find_device without the dev it returned. therefore it was replaceable with the new function. Signed-off-by: Hanna Linder <hannal@us.ibm.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Hanna V. Linder authored
As pci_find_device is going away it needs to be replaced. In this case the dev returned from pci_find_device was not being used so pci_dev_present was the appropriate replacement. This has been compile and boot tested on a T22. Signed-off-by: Hanna Linder <hannal@us.ibm.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Hanna V. Linder authored
--On Thursday, September 30, 2004 10:27:48 AM +0200 Gerd Knorr <kraxel@bytesex.org> wrote: >> The whole driver is CONFIG_BROKEN anyway... I only verified my changes >> didn't add new compiler errors. What part should I remove? Just this check? > > pci/quirks.c does these checks and sets the flags. > Replacing with a check for "pci_pci_problems & PCIPCI_TRITON" should do. > > bttv does simliar things in bttv_check_chipset() (bttv-cards.c), > you might want to have a look there ... > Thanks a lot for your help. Is this what you were thinking? Signed-off-by: Hanna Linder <hannal@us.ibm.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Tom L. Nguyen authored
Here I have attached pci mmconfig fix for 2.6.9 kernel. This will fix the flush error in pci_mmcfg_write. When pci_mmcfg_write is used to program the PMCSR in the Power Management Capability structure of PCI config space in the PCI Express device to a different power state, the dummy readl to flush the previous write violates the transition delay specified in the PCI power management spec. Please see PCI Power Management Spec. 1.2 Table 5-6. For example, while changing the power state of the device through PMCSR register, a transition delay of 10msec is required before any access can be made to the device. Since the configuration write access for PCI Express is non posted, flushing is not necessary and it will be safe to remove the dummy readl. This patch will remove dummy readl function implemented in "pci_mmcfg_write" and use set_fixmap_nocahe instead of set_fixmap. Signed-off-by: Sundarapandian Durairaj <sundarapandian.duraijai@intel.com> Signed-off-by: T. Long Nguyen <tom.l.nguyen@intel.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
- 05 Nov, 2004 10 commits
-
-
Hanna V. Linder authored
As pci_find_device is going away I've replaced it with pci_get_device. If someone with this hardware could test it I would appreciate it. Signed-off-by: Hanna Linder <hannal@us.ibm.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Jon Smirl authored
Linus has requested that the sysfs rom attribute be changed to require enabling before it works. echo "0" to the attribute to disable, echoing anything else enables the rom output. The concern is that something like a file browser could inadvertently read the attribute and change the state of the hardware without the user's knowledge. The attached patch includes the previous patch plus the enabling logic. [root@smirl 0000:02:02.0]# [root@smirl 0000:02:02.0]# cat rom cat: rom: Invalid argument [root@smirl 0000:02:02.0]# echo "1" >rom [root@smirl 0000:02:02.0]# hexdump -C -n 20 rom 00000000 55 aa 60 e9 d6 01 00 00 00 00 00 00 00 00 00 00 |U.`.............| 00000010 00 00 00 00 |....| 00000014 [root@smirl 0000:02:02.0]# echo "0" >rom [root@smirl 0000:02:02.0]# hexdump -C -n 20 rom hexdump: rom: Invalid argument [root@smirl 0000:02:02.0]# Signed-off-by: Jon Smirl <jonsmirl@gmail.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Dely Sy authored
This is the ASPM patch against 2.6.10-rc1-mm2. As mentioned in my last email, this patch has a slight difference than the one for 2.6.10-rc1, because the irqbalance quirk was moved from drivers/pci/quirks.c in 2.6.10-rc1 to arch/i386/kernel/quirks.c in 2.6.10-rc1-mm2. Signed-off-by: Dely Sy <dely.l.sy@intel.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Thomas Gleixner authored
To make spinlock/rwlock initialization consistent all over the kernel, this patch converts explicit lock-initializers into spin_lock_init() and rwlock_init() calls. Currently, spinlocks and rwlocks are initialized in two different ways: lock = SPIN_LOCK_UNLOCKED spin_lock_init(&lock) rwlock = RW_LOCK_UNLOCKED rwlock_init(&rwlock) this patch converts all explicit lock initializations to spin_lock_init() or rwlock_init(). (Besides consistency this also helps automatic lock validators and debugging code.) The conversion was done with a script, it was verified manually and it was reviewed, compiled and tested as far as possible on x86, ARM, PPC. There is no runtime overhead or actual code change resulting out of this patch, because spin_lock_init() and rwlock_init() are macros and are thus equivalent to the explicit initialization method. That's the second batch of the unifying patches. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Matthew Wilcox authored
Port Ivan's early PCI fixups patch to 2.6.10-rc1. Also fix some indentation to make it less than 80 columns. From: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Adrian Bunk authored
There's not much value in shipping a changelog who's last update was five years ago. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Greg Kroah-Hartman authored
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Greg Kroah-Hartman authored
into kroah.com:/home/greg/linux/BK/pci-2.6
-
Linus Torvalds authored
Too much cut-and-paste, hidden by the fact that without debugging, "dev_dbg()" doesn't even look at its arguments.
-
Linus Torvalds authored
It apparently really confuses some things (Apple keyboard internal hub for one, but possibly others).
-
- 04 Nov, 2004 21 commits
-
-
Jean Tourrilhes authored
This tiny bit of the last WE-17 patch was lost between me and you. I initially decided to wait to resubmit, but Chris Wedgwood reported that the MadWifi driver needs it. Sorry for not having pushed harder. I recreated this patch, and tested with 2.6.10-rc1, and Chris tested it with MadWifi. Would you mind pushing that up to Linus ? Changelog : o remove unneeded const o spelling + comments Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
-
Andries E. Brouwer authored
Experimented a bit more with mounting a bad ext2 filesystem. An immediate crash was caused by zero EXT2_BLOCKS_PER_GROUP(sb). The patch below (relative to 2.6.9) adds a few checks to make sure that things we divide by are not zero.
-
bk://kernel.bkbits.net/gregkh/linux/driver-2.6Linus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
bk://kernel.bkbits.net/gregkh/linux/usb-2.6Linus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
Maneesh Soni authored
On Thu, Nov 04, 2004 at 12:52:38PM -0800, Greg KH wrote: > Hi, > > I get the following BUG in the sysfs code when I do: > - plug in a usb-serial device. > - open the port with 'cat /dev/ttyUSB0' > - unplug the device. > - stop the 'cat' process with control-C > > This used to work just fine before your big sysfs changes. There is a similar problem reported by s390 people where we see parent kobject (directory) going away before child kobject (sub-directory). It seems kobject code is able to handle this, but not the sysfs. What could be happening that in sysfs_remove_dir() of parent directory, we try to remove its contents. It works well with the regular files as it is the final removal for sysfs_dirent corresponding to the files. But in case of sub-directory we are doing an extra sysfs_put(). Once while removing parent and the other one being the one from when sysfs_remove_dir() is called for the child. The following patch worked for the s390 people, I hope same will work in this case also. o Do not remove sysfs_dirents corresponding to the sub-directory in sysfs_remove_dir(). They will be removed in the sysfs_remove_dir() call for the specific sub-directory. Signed-off-by: Maneesh Soni <maneesh@in.ibm.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Andrew Morton authored
The spin_unlock() in rotate_reclaimable_page() is not a sufficient memory barrier. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Linus Torvalds authored
"clear_buffer_locked()" is just a nicer name for a clear-bit, and on x86 (and others) we don't need any expensive memory barriers after that.
-
Greg Kroah-Hartman authored
into kroah.com:/home/greg/linux/BK/driver-2.6
-
Greg Kroah-Hartman authored
into kroah.com:/home/greg/linux/BK/usb-2.6
-
Martin Waitz authored
kfifo_alloc tries to round up the buffer size to the next power of two. But it accidently uses the original size when calling kfifo_init, which will BUG. Acked-by: Stelian Pop <stelian@popies.net> Signed-off-by: Martin Waitz <tali@admingilde.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Pete Zaitcev authored
This is a relatively small changeset, to address small nagging problems. Andrew pointed me at the double registration specifically, so I had to do something about it. At least now Fabio's box won't collapse if he configures UB by mistake. Also, a few people complained that the help text was misleading. I have not done anything about the oops on disconnect which happens to Martin Schlemmer. It's next. After that I can get to Peter Jones' CD burning patch and doing resets. - Fix double kobject registration and eventual oops on unplug if a device is not cooperating. - Add a reference to usb-storage into the configuration help. - Just upping timeouts fixes my ZIP drive. - Max out the diag (trace) file size. - Set capacity to zero in case the media is absent. It works in 2.4.10-rc1. Either Al fixed the block layer, or the whole thing was a bug in ub.c (and sd.c) and a big misunderstanding. Signed-off-by: Pete Zaitcev <zaitcev@redhat.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Robert Love authored
Attached patch adds a MAINTAINER entry for the kernel event layer. Signed-Off-By: Robert Love <rml@novell.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Robert Love authored
Looks like kobject_uevent_init is executed before netlink_proto_init and consequently always fails. Not cool. Attached patch switches the initialization over from core_initcall (init level 1) to postcore_initcall (init level 2). Netlink's initialization is done in core_initcall, so this should fix the problem. We should be fine waiting until postcore_initcall. Also a couple white space changes mixed in, because I am anal. Signed-Off-By: Robert Love <rml@novell.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Greg Kroah-Hartman authored
Thanks to Serge Hallyn <serue@us.ibm.com> for pointing this out. Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Linus Torvalds authored
This clarifies more of the x86 caller/callee stack ownership issues by making the exception and interrupt handler assembler interfaces use register calling conventions. System calls still use the stack. Tested with "crashme" on UP/SMP.
-
Tejun Heo authored
df_05_device_add_ref_fix.patch In device_add(), @dev wan't put'd properly when it has zero length bus_id (error path). Fixed. Signed-off-by: Tejun Heo <tj@home-tj.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Tejun Heo authored
df_04_kobject_add_ref_fix.patch In kobject_add(), @kobj wasn't put'd properly on error path. This patch fixes it. Signed-off-by: Tejun Heo <tj@home-tj.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Tejun Heo authored
df_03_sysfs_release_fix.patch Some attributes are allocated dynamically (e.g. module and device parameters) and are usually deallocated when the assoicated kobject is released. So, it's not safe to access attr after putting the kobject. Signed-off-by: Tejun Heo <tj@home-tj.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Tejun Heo authored
df_02_bus_rescan_devcies_fix.patch bus_rescan_devices() eventually calls device_attach() and thus requires write locking the corresponding bus. The original code just called bus_for_each_dev() which only read locks the bus. This patch separates __bus_for_each_dev() and __bus_for_each_drv(), which don't do locking themselves, out from the original functions and call them with read lock in the original functions and with write lock in bus_rescan_devices(). Signed-off-by: Tejun Heo <tj@home-tj.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Tejun Heo authored
df_01_driver_attach_comment_fix.patch bus_match() was renamed to driver_probe_device() but the comment for device_attach() wasn't updated. This patch updates it. Signed-off-by: Tejun Heo <tj@home-tj.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Kay Sievers authored
Add the sysfs path of the physical device to the hotplug event of class and block devices. This should solve the userspace issue not to know if the device is a virtual one and the "device" symlink will never be created, but we sit there and wait for it to show up not knowing when we should give up. Also the bus name is added to the hotplug event, so we don't need to reverse lookup in the /sys/bus/* directory which bus our physical device belongs to. This is e.g. the value matched against the BUS= key, that may be used in an udev rule. This is a PCI network card: ACTION=add SUBSYSTEM=net DEVPATH=/class/net/eth0 PHYSDEVPATH=/devices/pci0000:00/0000:00:1e.0/0000:02:01.0 PHYSDEVBUS=pci INTERFACE=eth0 SEQNUM=827 PATH=/sbin:/bin:/usr/sbin:/usr/bin HOME=/ This is a IDE CDROM: ACTION=add SUBSYSTEM=block DEVPATH=/block/hdc PHYSDEVPATH=/devices/pci0000:00/0000:00:1f.1/ide1/1.0 PHYSDEVBUS=ide SEQNUM=1017 PATH=/sbin:/bin:/usr/sbin:/usr/bin HOME=/ This is an USB-stick partition: ACTION=add SUBSYSTEM=block DEVPATH=/block/sda/sda1 PHYSDEVPATH=/devices/pci0000:00/0000:00:1d.1/usb3/3-1/3-1:1.0/host1/target1:0:0/1:0:0:0 PHYSDEVBUS=scsi SEQNUM=1032 PATH=/sbin:/bin:/usr/sbin:/usr/bin HOME=/ Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
- 03 Nov, 2004 4 commits
-
-
Jens Axboe authored
We need to open the gap between congestion on/off a little bit, or we risk burning many cycles continually putting processes on a wait queue only to wake them up again immediately. This was observed with CFQ at least, which showed way excessive sys time. Patch is from Arjan. Signed-off-by: Jens Axboe <axboe@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Jens Axboe authored
Patch is from Daniel Drake <dsd@gentoo.org> Signed-off-by: Jens Axboe <axboe@suse.de> Signed-off-by: Daniel Drake <dsd@gentoo.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
bk://kernel.bkbits.net/davem/net-2.6Linus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
David S. Miller authored
Signed-off-by: David S. Miller <davem@davemloft.net>
-