- 14 Apr, 2022 1 commit
-
-
Dan Carpenter authored
If lookup_event_by_id() returns a NULL "ev" pointer then the spin_lock(&ev->lock) will crash. This was detected by Smatch: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_events.c:644 kfd_set_event() error: we previously assumed 'ev' could be null (see line 639) Fixes: 5273e82c ("drm/amdkfd: Improve concurrency of event handling") Signed-off-by:Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
- 13 Apr, 2022 6 commits
-
-
Mukul Joshi authored
Currently, the IO-links to the device being removed from topology, are not cleared. As a result, there would be dangling links left in the KFD topology. This patch aims to fix the following: 1. Cleanup all IO links to the device being removed. 2. Ensure that node numbering in sysfs and nodes proximity domain values are consistent after the device is removed: a. Adding a device and removing a GPU device are made mutually exclusive. b. The global proximity domain counter is no longer required to be an atomic counter. A normal 32-bit counter can be used instead. 3. Update generation_count to let user-mode know that topology has changed due to device removal. CC: Shuotao Xu <shuotaoxu@microsoft.com> Reviewed-by:Shuotao Xu <shuotaoxu@microsoft.com> Reviewed-by:
Mukul Joshi <mukul.joshi@amd.com> Signed-off-by:
-
Yongqiang Sun authored
MS_HYPERV with vega10 doesn't have the interface to process request init data msg. Check hypervisor type to not send the request for MS_HYPERV. Signed-off-by:
Yongqiang Sun <yongqiang.sun@amd.com> Reviewed-by:
Alice Wong <shiwei.wong@amd.com> Acked-by:
-
Lang Yu authored
A MAX_GPU_INSTANCE bits bitmap will suffice. Signed-off-by:
Lang Yu <Lang.Yu@amd.com> Reviewed-by:
-
Wenjing Liu authored
[why] Extract update stream allocation table into link hwss as part of the link hwss refactor work. Reviewed-by:
George Shen <George.Shen@amd.com> Reviewed-by:
Fangzhi Zuo <Jerry.Zuo@amd.com> Acked-by:
Pavle Kotarac <Pavle.Kotarac@amd.com> Signed-off-by:
Wenjing Liu <wenjing.liu@amd.com> Signed-off-by:
-
David Zhang authored
[why] creating a generic helper for AMD specific PSR-SU sink validation. Moving the function to the power module to reference it across all OS. [how] - drop PSRSU specific sink validation helper and move to power module by reading PSR version and other PSR caps - call the new helper from linux DM (amdgpu_dm_psr) Acked-by:
Tom Chung <chiahsuan.chung@amd.com> Signed-off-by:
David Zhang <dingchen.zhang@amd.com> Signed-off-by:
-
David Zhang authored
[why & how] As per eDP 1.5 spec, add the below two DPCD bit fields for PSR-SU support and capability: 1. DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 2. DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED changes in v2 ------------------ * fixed the typo * explicitly list what DPCD bit fields are added Signed-off-by:
Harry Wentland <harry.wentland@amd.com> Signed-off-by:
-
- 12 Apr, 2022 15 commits
-
-
Aric Cyr authored
Title: DC Patches Apri 6, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: *Disabling Z10 on DCN31 *Fix issue breaking 32bit Linux build *Fix inconsistent timestamp type *Add DCN30 support FEC init *Fix crash on setting VRR with no display connected *Disable FEC if DSC not supported for EDP *Add odm seamless boot support *Select correct DTO source *Power down hardware if timer not trigger Acked-by:
Aric Cyr <aric.cyr@amd.com> Signed-off-by:
-
Dillon Varone authored
[WHY&HOW] Change criteria for setting DTO source value, and always set it regardless of the signal type. Reviewed-by:
Ariel Bernstein <Eric.Bernstein@amd.com> Acked-by:
Dillon Varone <dillon.varone@amd.com> Signed-off-by:
-
Felix Kuehling authored
The synchronize_rcu call in destroy_events can take several ms, which noticeably slows down applications destroying many events. Use kfree_rcu to free the event structure asynchronously and eliminate the synchronize_rcu call in the user thread. Signed-off-by:
Philip Yang <Philip.Yang@amd.com> Signed-off-by:
-
hersen wu authored
[Why] within dc link detecion, dp link training will be executed for external sst dp. for debug purpose, we may need skip dp link training. [How] expose dc debug option to skip_detection_link_training to debugfs Reviewed-by:
Roman Li <Roman.Li@amd.com> Acked-by:
hersen wu <hersenxs.wu@amd.com> Signed-off-by:
-
Dillon Varone authored
Reviewed-by:
-
Angus Wang authored
[WHY] An unsigned int timestamp variable is assigned with an unsigned long long value. Also, the assignment directly converts the tick value to us without using built-in get elapsed time function. [HOW] Cast the assigned value correctly and also use built-in function to get the timestamp in the unit we want. v2: squash in 64 bit division fix Reviewed-by:
Angus Wang <Angus.Wang@amd.com> Signed-off-by:
-
Jingwen Zhu authored
[Why] FEC init used on DCN30. [How] Check fec active when HW init. Co-authored-by:
Jingwen Zhu <Jingwen.Zhu@amd.com> Reviewed-by:
-
Duncan Ma authored
[WHY] Implement changes to transition from Pre-OS odm to Post-OS odm support. Seamless boot case is also considered. [HOW] Revised validation logic when marking for seamless boot. Init resources accordingly when Pre-OS has odm enabled. Reset odm and det size when transitioning Pre-OS odm to Post-OS non-odm to avoid corruption. Apply logic to set odm accordingly upon commit. Reviewed-by:
Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com> Acked-by:
Duncan Ma <Duncan.Ma@amd.com> Signed-off-by:
-
Oliver Logush authored
[why] Need to update the update_clock sequence to a fully tested sequence for dcn30 [how] Removed the check to see if clock is lowered Reviewed-by:
Charlene Liu <Charlene.Liu@amd.com> Acked-by:
Oliver Logush <oliver.logush@amd.com> Signed-off-by:
-
Oliver Logush authored
[why] Make sure smu is not busy before sending another request, this is to prevent stress failures from MS. [how] Check to make sure the SMU fw busy signal is cleared before sending another request Reviewed-by:
-
Paul Hsieh authored
[WHY] In headless systems, if SetMode/Power down timer is not called, hardware will not be powered down causing HW/SW discrepancies. Powering down hardware on SetPowerState to D3 will ensure SW/HW state is accurate. [HOW] 1. If PowerDownThread timer is not trigger but OS call SetPowerState to D3, power down hardware. 2. Update HDMI hang w/a to apply to all TMDS signals on headless system Reviewed-by:
Martin Leung <Martin.Leung@amd.com> Acked-by:
Paul Hsieh <paul.hsieh@amd.com> Signed-off-by:
-
Charlene Liu authored
[why] dcn316's dtbclk is from non_ss clock source. no compensation required here. Reviewed-by:
Chris Park <Chris.Park@amd.com> Acked-by:
-
Evgenii Krasnikov authored
[HOW&WHY] Make sure psr_force_static() can always be called regardless of psr_allow_active value. Reviewed-by:
Harry Vanzylldejong <harry.vanzylldejong@amd.com> Reviewed-by:
Evgenii Krasnikov <Evgenii.Krasnikov@amd.com> Reviewed-by:
Nicholas Choi <Nicholas.Choi@amd.com> Acked-by:
-
Harry VanZyllDeJong authored
[HOW&WHY] VRR was getting set at the same time the timing generator would be null when there was no display connected. Added null check to the timing generator variable so it does not get referenced if it is null. Reviewed-by:
Harry VanZyllDeJong <hvanzyll@amd.com> Signed-off-by:
-
Iswara Nagulendran authored
[WHY] Screen was seen corrupted for a few ms when switching both ways. There was also not enough bandwidth for HDR to be enabled in HG disabled mode. This was due to FEC being enabled although DSC was not supported or disabled for the EDP. [HOW] Check for EDP DSC support in DC caps or if DSC should be disabled for EDP before enabling FEC for EDP. Reviewed-by:
Iswara Nagulendran <inagulen@amd.com> Signed-off-by:
-
- 11 Apr, 2022 13 commits
-
-
Tom Rix authored
The only use of the global variables in r600_blit_shaders.c were in the old drivers/gpu/drm/radeon/r600_blit.c This file was removed in commit 8333f607 ("drm/radeon: remove UMS support") So remove the r600_blit_shaders.[c|h] files Signed-off-by:
Tom Rix <trix@redhat.com> Signed-off-by:
-
Max Erenberg authored
[WHY] The dGPU cannot enter PSR when it is not connected to a panel. [HOW] Added a check to dc_link_set_psr_allow_active which returns early if panel is disconnected. Reviewed-by:
Max Erenberg <merenber@amd.com> Signed-off-by:
-
Saaem Rizvi authored
[WHY] Z10 is should not be enabled by default on DCN31. [HOW] Using DC debug flags to disable Z10 by default on DCN31. Reviewed-by:
Eric Yang <Eric.Yang2@amd.com> Acked-by:
Saaem Rizvi <syerizvi@amd.com> Signed-off-by:
-
Josip Pavic authored
[Why] When booting, the driver waits for the MPC idle bit to be set as part of pipe initialization. However, on some systems this occurs before OTG is enabled, and since the MPC idle bit won't be set until the vupdate signal occurs (which requires OTG to be enabled), this never happens and the wait times out. This can add hundreds of milliseconds to the boot time. [How] Do not wait for mpc idle if tg is disabled Reviewed-by:
Jun Lei <Jun.Lei@amd.com> Acked-by:
Josip Pavic <Josip.Pavic@amd.com> Signed-off-by:
-
Eric Yang authored
[Why] Z10 and S0i3 have some shared path. Previous code clean up , incorrectly removed these pointers, which breaks s0i3 restore [How] Do not clear the function pointers based on Z10 disable. Reviewed-by:
-
Stanley.Yang authored
In order to debug ras error, driver will print IPID/SYND/MISC0 register value if detect correctable or uncorrectable error. Provide umc_query_error_status_helper function to reduce code redundancy. Signed-off-by:
Stanley.Yang <Stanley.Yang@amd.com> Reviewed-by:
Tao Zhou <tao.zhou1@amd.com> Reviewed-by:
Hawking Zhang <Hawking.Zhang@amd.com> Signed-off-by:
-
Alex Deucher authored
Use div_u64() rather than a a 64 bit divide. Fixes: 3fe5739d ("drm/amd/display: Add flip interval workaround") Reviewed-by:
Nathan Chancellor <nathan@kernel.org> Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
Grigory Vasilyev authored
Instead of the 'amdgpu_ring_priority_level' type, the 'amdgpu_gfx_pipe_priority' type was used, which is an error when setting ring priority. This is a minor error, but may cause problems in the future. Instead of AMDGPU_RING_PRIO_2 = 2, we can use AMDGPU_RING_PRIO_MAX = 3, but AMDGPU_RING_PRIO_2 = 2 is used for compatibility with AMDGPU_GFX_PIPE_PRIO_HIGH = 2, and not change the behavior of the code. Signed-off-by:
Grigory Vasilyev <h0tc0d3@gmail.com> Signed-off-by:
-
Tom Rix authored
cayman_default_state and cayman_default_size are only used in ni.c. Single file symbols should be static. So move their definitions to cayman_blit_shaders.h and change their storage-class-specifier to static. Remove unneeded cayman_blit_shader.c cayman_ps/vs definitions were removed with commit 4f862967 ("drm/radeon/kms: remove r6xx+ blit copy routines") So their declarations in cayman_blit_shader.h are not needed, so remove them. Signed-off-by:
-
Tom St Denis authored
The data revision was not changed to 5 from 4 when the CG flags were extended to 64-bits. Since this was missed I took the opportunity to add future upper 64-bits of PG flags as well so we don't need to bump it again when that comes. Signed-off-by:
Tom St Denis <tom.stdenis@amd.com> Reviewed-by:
-
Yongqiang Sun authored
Add CONFIG_X86 check to fix the build error. Fixes: 49aa98ca ("drm/amd/amdgpu: Only reserve vram for firmware with vega9 MS_HYPERV host.") Reported-by:
-
Philip Yang authored
Application could change XNACK enabled to disabled while KFD is draining stale retry fault, therefore the check for whether to drain retry faults must be before the check for whether xnack_enabled, to avoid report incorrect vm fault after application changes XNACK mode. Signed-off-by:
-
Lijo Lazar authored
Use flexible array member in ip discovery struct as recommended[1]. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays v2: squash in struct_size fixes Signed-off-by:
Lijo Lazar <lijo.lazar@amd.com> Reviewed-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
-
- 08 Apr, 2022 1 commit
-
-
Evan Quan authored
With this, we can support more CG flags. Signed-off-by:
Evan Quan <evan.quan@amd.com> Acked-by:
-
- 07 Apr, 2022 4 commits
-
-
Yongqiang Sun authored
driver loading failed on VEGA10 SRIOV VF with linux host due to a wide range of stolen reserved vram. Since VEGA10 SRIOV VF need to reserve vram for firmware with windows Hyper_V host specifically, check hypervisor type to only reserve memory for it, and the range of the reserved vram can be limited to between 5M-7M area. Fixes: faad5cca ("drm/amdgpu: Add stolen reserved memory for MI25 SRIOV.") Signed-off-by:
-
Felix Kuehling authored
Check that adev->gfx.ras is valid before using it. Fixes: 6475ae2b ("drm/amdgpu: add UTCL2 RAS poison query for Aldebaran (v2)") CC: Tao Zhou <tao.zhou1@amd.com> Signed-off-by:
-
Tom Rix authored
Smatch reports this issue hdcp1_execution.c:500:29: warning: function 'mod_hdcp_hdcp1_dp_execution' with external linkage has definition The storage-class-specifier extern is not needed in a definition, so remove it. Reviewed-by:
-
Tomasz Moń authored
Enabling gfxoff quirk results in perfectly usable graphical user interface on MacBook Pro (15-inch, 2019) with Radeon Pro Vega 20 4 GB. Without the quirk, X server is completely unusable as every few seconds there is gpu reset due to ring gfx timeout. Signed-off-by:
Tomasz Moń <desowin@gmail.com> Signed-off-by:
-
