- 09 Jan, 2018 3 commits
-
-
chenxiang authored
The status of SAS PHY is in sas_phy->enabled. There is an issue that the status of a remote SAS PHY may be initialized incorrectly: if disable remote SAS PHY through sysfs interface (such as echo 0 > /sys/class/sas_phy/phy-1:0:0/enable), then reboot the system, and we will find the status of remote SAS PHY which is disabled before is 1 (cat /sys/class/sas_phy/phy-1:0:0/enable). But actually the status of remote SAS PHY is disabled and the device attached is not found. In SAS protocol, NEGOTIATED LOGICAL LINK RATE field of DISCOVER response is 0x1 when remote SAS PHY is disabled. So initialize sas_phy->enabled according to the value of NEGOTIATED LOGICAL LINK RATE field. Signed-off-by:
chenxiang <chenxiang66@hisilicon.com> Reviewed-by:
John Garry <john.garry@huawei.com> Signed-off-by:
Jason Yan <yanaijie@huawei.com> Reviewed-by:
Christoph Hellwig <hch@lst.de> Reviewed-by:
Hannes Reinecke <hare@suse.com> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Jason Yan authored
The intend purpose here was to goto out if smp_execute_task() returned error. Obviously something got screwed up. We will never get these link error statistics below: ~:/sys/class/sas_phy/phy-1:0:12 # cat invalid_dword_count 0 ~:/sys/class/sas_phy/phy-1:0:12 # cat running_disparity_error_count 0 ~:/sys/class/sas_phy/phy-1:0:12 # cat loss_of_dword_sync_count 0 ~:/sys/class/sas_phy/phy-1:0:12 # cat phy_reset_problem_count 0 Obviously we should goto error handler if smp_execute_task() returns non-zero. Fixes: 2908d778 ("[SCSI] aic94xx: new driver") Signed-off-by:
-
Jason Yan authored
We've got a memory leak with the following producer: while true; do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null; done The buffer req is allocated and not freed after we return. Fix it. Fixes: 2908d778 ("[SCSI] aic94xx: new driver") Signed-off-by:
-
- 08 Jan, 2018 1 commit
-
-
Andy Shevchenko authored
Using this extension reduces the object size. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by:
Don Brace <don.brace@microsemi.com> Signed-off-by:
-
- 04 Jan, 2018 36 commits
-
-
Himanshu Jha authored
Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset 0. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Suggested-by:
Luis R. Rodriguez <mcgrof@kernel.org> Signed-off-by:
Himanshu Jha <himanshujha199640@gmail.com> Acked-by:
Manish Rangankar <Manish.Rangankar@cavium.com> Signed-off-by:
-
Himanshu Jha authored
Use vzalloc instead of vmalloc followed by memset 0. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Suggested-by:
Anil Gurumurthy <anil.gurumurthy@cavium.com> Signed-off-by:
-
Himanshu Jha authored
Use dma_zalloc_coherent and vzalloc instead of dma_alloc_coherent and vmalloc respectively, followed by memset 0. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Suggested-by:
Himanshu Madhani <himanshu.madhani@cavium.com> Signed-off-by:
-
Himanshu Jha authored
Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset 0. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Suggested-by:
-
Meelis Roos authored
The battery in my HP NetRAID-4M died of old age, and the aacraid driver started oopsing with NULL pointer dereference on startup after that. Fix it by reordering the init sequence to fill in function pointers before ioremapping memory, or dev->a_ops.adapter_ioremap pointer will be NULL. Other subtypes of aacraid seem to have the order already correct. This was the call trace: ? aac_probe_one+0x7a5/0xb30 [aacraid] pci_device_probe+0xc0/0x1a0 driver_probe_device+0x1df/0x3b0 __driver_attach+0xa9/0xe0 ? driver_probe_device+0x3b0/0x3b0 bus_for_each_dev+0x4c/0x90 driver_attach+0x1d/0x40 ? driver_probe_device+0x3b0/0x3b0 bus_add_driver+0x1a7/0x2a0 driver_register+0x6e/0x130 __pci_register_driver+0x54/0x90 ? 0xf81f4000 aac_init+0x2b/0x1000 [aacraid] do_one_initcall+0x45/0x1e0 ? kfree_skbmem+0x74/0xa0 ? kfree+0x16d/0x240 ? kvfree+0x45/0x50 ? kvfree+0x45/0x50 ? __vunmap+0x99/0x120 ? do_init_module+0x1a/0x245 do_init_module+0x83/0x245 load_module+0x2764/0x34a0 ? kernel_read_file+0x150/0x320 SyS_finit_module+0x82/0xa0 do_fast_syscall_32+0xba/0x340 Signed-off-by:
Meelis Roos <mroos@linux.ee> Reviewed-by:
Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com> Signed-off-by:
-
himanshu.madhani@cavium.com authored
Signed-off-by:
-
Quinn Tran authored
Add free_pending flag to serialize queueing of free_work element onto the work queue Signed-off-by:
Quinn Tran <quinn.tran@cavium.com> Signed-off-by:
-
Quinn Tran authored
for session deletion, replace sess_lock with work_lock. Under certain case sess_lock is not feasiable to acquire. The lock is needed temporarily to make sure a single call to schedule of the work element. Signed-off-by:
-
Quinn Tran authored
Immeadiate flag is not used for scheduling session deletion. Remove it to simplfy session deletion code path. Signed-off-by:
-
Quinn Tran authored
This patch adds check for pending work event before queueing relogin work to prevent redundant work to be active at the same time. Signed-off-by:
-
Quinn Tran authored
Add check to allow single discovery command per session to be sent Signed-off-by:
-
Quinn Tran authored
Switch scan is assumed to succeed most of the time. If the scan failed, then scan is limit 5 retries. Signed-off-by:
-
Quinn Tran authored
Delay loop id allocation to login time Signed-off-by:
-
Quinn Tran authored
Add verbose bit for debug messages to reduce excessive log messages Signed-off-by:
-
himanshu.madhani@cavium.com authored
When any kind of reset is issued, current code was setting state of LOGIN pending too early. This resulted into driver not retrying relogin until pervious reloin completes. Signed-off-by:
-
Quinn Tran authored
add ability to use gpnft/gnnft to handle RSCN. Signed-off-by:
-
Quinn Tran authored
This patch fixes issue with extraction of ADISC error codes for decoding the error returned Signed-off-by:
-
Quinn Tran authored
retry gpnft/gnnft if error is encountered. Signed-off-by:
-
Quinn Tran authored
Current code creates a session when a new port is discovered, and a PLOGI/PRLI is received. There is no need to create session when command has arrived. Signed-off-by:
-
Quinn Tran authored
Migrate switch registration commands: RFTID, RFFID, RNNID and RSNN_NN out of mailbox interface to reduce fabric scan bottle neck. Signed-off-by:
-
Quinn Tran authored
Relogin stop moving forward due to improper check of scan_state flag. Signed-off-by:
-
Quinn Tran authored
Add NPIV id check to reduce multiple debug messages of the same RSCN event. Signed-off-by:
-
Quinn Tran authored
reduce usage of terminate exchange when command encounter resource bottle neck. Remote initiator view it as command drop. Signed-off-by:
-
Quinn Tran authored
Host lookup via btree is currently protected by the hardware_lock. Add hardware_lock when modifying btree to store host pointer. Signed-off-by:
-
Quinn Tran authored
- add "async" gpn_ft, gnn_ft, gfpn_id, gnn_id switch commands. - For 8G and newer adapters, use async commands when it comes to fabric scan to reduce bottle neck. Signed-off-by:
-
himanshu.madhani@cavium.com authored
Signed-off-by:
-
Quinn Tran authored
When connection type is N_Port to N_Port (point-to-point), there is a possibilty where initiator will not send PLOGI request and will directly send PRLI. In N2N connection the port has higher port name sends the PLOGI but not allow to send PRLI if is a target mode. Only initiator is allowed to send PRLI. Current driver code deletes old session when it receives PLOGI request. If we will not receive PLOGI request then we will not delete old session and create new session. Add check for N2N with PRLI receive only and trigger cleanup. For this case, the cleanup requires individual cmd abort instead of using implicit logout as a broad stroke flush. Signed-off-by:
Krishna Kant <krishna.kant@purestorage.com> Signed-off-by:
Alexei Potashnik <alexei@purestorage.com> Signed-off-by:
-
Quinn Tran authored
Fetch actual data from firmware instead of static data at chip reset time. Signed-off-by:
Quinn Tran <quinn.tran@qlogic.com> Signed-off-by:
-
Quinn Tran authored
For Dual Mode, Initiator side of the driver finish login, target side receive PRLI, but driver terminates PRLI. This patch allows target side to go ahead and accept PRLI. Signed-off-by:
-
Giridhar Malavali authored
The logo ELS command allocates dma coherent memory for the data payload and serialize the completions. When this command times out, the timeout routine completes the thread waiting for completion which in turn cleanup resources allocated for this ELS command processing. Don't call generic sp->free routine when this ELS command times out to avoid to double freeing of the same resources. Signed-off-by:
Giridhar Malavali <giridhar.malavali@cavium.com> Signed-off-by:
-
Quinn Tran authored
Add ability to send Implicit PRLO to flush IOs from FW back to driver. Signed-off-by:
-
Quinn Tran authored
Add option to tell FW to reserve 1/2 of emergency exchanges for ELS. Signed-off-by:
-
Quinn Tran authored
For ISP27XX, use shadow register to read FW provided REQQ's consumer index. The shadow register is dma'ed by firmware. Signed-off-by:
-
Quinn Tran authored
Enable ATIO Q interrupt handshake for ISP27XX. This patch coalesce ATIO's interrupts for Quad port ISP27XX adapter. Interrupt coalesce allows performance to scale for this specific case. Signed-off-by:
-
Quinn Tran authored
DPC thread can stall during switch scan due to slow switch response. This will stall other work element that needs attention. Moving work element processing and relogin logic out of DPC thread and into its own work queue. Signed-off-by:
-
Quinn Tran authored
Replace call to Get Port DataBase MB with PDO_FORCE_ADISC flag with async ADISC command so driver can see ADISC command has error or not. Signed-off-by:
-
