1. 16 Sep, 2020 6 commits
  2. 12 Sep, 2020 26 commits
  3. 11 Sep, 2020 8 commits
    • David S. Miller's avatar
      Merge branch 'sfc-misc-cleanups' · cac7663c
      David S. Miller authored
      Edward Cree says:
      
      ====================
      sfc: misc cleanups
      
      Clean up a few nits I noticed while working on TXQ stuff.
      ====================
      Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      cac7663c
    • Edward Cree's avatar
      sfc: cleanups around efx_alloc_channel · 4da24fa6
      Edward Cree authored
      The old_channel argument is never used, so remove it.
      The function is only called from elsewhere in efx_channels.c, so make
       it static and remove the declaration from the header file.
      Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4da24fa6
    • Edward Cree's avatar
      sfc: remove spurious unreachable return statement · 3d6aef65
      Edward Cree authored
      The statement above it already returns, so there is no way to get here.
      Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3d6aef65
    • Edward Cree's avatar
      sfc: remove duplicate call to efx_init_channels from EF100 probe · c0941025
      Edward Cree authored
      efx_init_struct already calls this, we don't need to do it again.
      Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c0941025
    • Ido Schimmel's avatar
      bridge: mcast: Fix incomplete MDB dump · 12913f74
      Ido Schimmel authored
      Each MDB entry is encoded in a nested netlink attribute called
      'MDBA_MDB_ENTRY'. In turn, this attribute contains another nested
      attributed called 'MDBA_MDB_ENTRY_INFO', which encodes a single port
      group entry within the MDB entry.
      
      The cited commit added the ability to restart a dump from a specific
      port group entry. However, on failure to add a port group entry to the
      dump the entire MDB entry (stored in 'nest2') is removed, resulting in
      missing port group entries.
      
      Fix this by finalizing the MDB entry with the partial list of already
      encoded port group entries.
      
      Fixes: 5205e919 ("net: bridge: mcast: add support for src list and filter mode dumping")
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Acked-by: default avatarNikolay Aleksandrov <nikolay@nvidia.com>
      Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      12913f74
    • Colin Ian King's avatar
      ipv6: remove redundant assignment to variable err · 2291267e
      Colin Ian King authored
      The variable err is being initialized with a value that is never read and
      it is being updated later with a new value. The initialization is redundant
      and can be removed.  Also re-order variable declarations in reverse
      Christmas tree ordering.
      
      Addresses-Coverity: ("Unused value")
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2291267e
    • David S. Miller's avatar
      Merge branch 'ag71xx-add-ethtool-and-flow-control-support' · 4ba38190
      David S. Miller authored
      Oleksij Rempel says:
      
      ====================
      ag71xx: add ethtool and flow control support
      
      The main target of this patches is to provide flow control support
      for ag71xx driver. To be able to validate this functionality, I also
      added ethtool support with HW counters. So, this patches was validated
      with iperf3 and counters showing Pause frames send or received by this
      NIC.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4ba38190
    • Oleksij Rempel's avatar
      net: ag71xx: add flow control support · 2fb7357d
      Oleksij Rempel authored
      Add flow control support. The functionality was tested on AR9331 SoC and
      confirmed by iperf3 results and HW counters exported over ethtool.
      Following test configurations was used:
      
      iMX6S receiver <--- TL-SG1005D switch <---- AR9331 sender
      
      The switch is supporting symmytric flow control:
      Settings for eth0:
              Supported ports: [ MII ]
              Supported link modes:   10baseT/Half 10baseT/Full
                                      100baseT/Half 100baseT/Full
              Supported pause frame use: Symmetric Receive-only
              Supports auto-negotiation: Yes
              Supported FEC modes: Not reported
              Advertised link modes:  10baseT/Half 10baseT/Full
                                      100baseT/Half 100baseT/Full
              Advertised pause frame use: Symmetric
              Advertised auto-negotiation: Yes
              Advertised FEC modes: Not reported
              Link partner advertised link modes:  10baseT/Half 10baseT/Full
                                                   100baseT/Half 100baseT/Full
      --->>   Link partner advertised pause frame use: Symmetric
              Link partner advertised auto-negotiation: Yes
              Link partner advertised FEC modes: Not reported
              Speed: 100Mb/s
              Duplex: Full
              Auto-negotiation: on
              Port: MII
              PHYAD: 4
              Transceiver: external
              Link detected: yes
      
      The iMX6S system was configured to 10Mbit, to let the switch use flow
      control:
        - ethtool -s eth0 speed 10
      
      With flow control disabled on AR9331:
        - ethtool -A eth0  rx off tx off
        - iperf3 -u -c 172.17.0.1 -b100M -l1472 -t10
      
      [ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
      [  5]   0.00-10.00  sec  66.2 MBytes  55.5 Mbits/sec  0.000 ms  0/47155 (0%)  sender
      [  5]   0.00-10.04  sec  11.5 MBytes  9.57 Mbits/sec  1.309 ms  38986/47146 (83%)  receiver
      
      With flow control enabled on AR9331:
        - ethtool -A eth0  rx on tx on
        - iperf3 -u -c 172.17.0.1 -b100M -l1472 -t10
      
      [ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
      [  5]   0.00-10.00  sec  15.1 MBytes  12.6 Mbits/sec  0.000 ms  0/10727 (0%)  sender
      [  5]   0.00-10.05  sec  11.5 MBytes  9.57 Mbits/sec  1.371 ms  2525/10689 (24%)  receiver
      
      Similar results are get in opposite direction by introducing extra CPU
      load on AR9331:
        - chrt 40 dd if=/dev/zero of=/dev/null &
      Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2fb7357d