Skip to content

L
linux
Switch branch/tag
  1. 24 Aug, 2007 21 commits
  3. 23 Aug, 2007 19 commits
    • Mauro Carvalho Chehab's avatar
      V4L/DVB (6070): Fix a warning at dvb_net · 04b35abe
      Mauro Carvalho Chehab authored 
      static function dvb_net_sec declares input arg "pkt" as u8. However, the
same argument at dvb_net_sec_callback is defined as "const u8". When
calling dvb_net_sec, this is casted as just "u8".

gcc 4.2.1 generates a warning about that:

  CC [M]  drivers/media/dvb/dvb-core/dvb_net.o
drivers/media/dvb/dvb-core/dvb_net.c: In function "dvb_net_sec_callback":
drivers/media/dvb/dvb-core/dvb_net.c:905: warning: passing argument 2 of
		"dvb_net_sec" discards qualifiers from pointer target type
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
      04b35abe
    • Trent Piepho's avatar
      V4L/DVB (6042): b2c2-flexcop: fix Airstar HD5000 tuning regression · 6175e487
      Trent Piepho authored 
      Git changeset 6bdcc6e6 dropped the
stand-alone lgh06xf module, whose functionality was absorbed into the
dvb-pll module. However, there was a minor difference between the code
in lgh06xf and dvb-pll, which caused a regression in b2c2-flexcop
devices using the LG-H06xF NIM.

dvb-pll will probe for the presence of an i2c pll chip by performing a
single byte read, the lgh06xf driver did not do this. Unfortunately, the
code in flexcop-i2c.c does not currently support 1 byte or 0 byte reads
as a probe.  Such probes with the current code will always fail.

In order to work around this problem, and restore proper functionality
of the Airstar HD5000 device, this hack was created to make the probe
appear to succeed.  The single byte read in dvb_pll_attach is the only
place where such a probe would ever occur, so this change is safe, and
will not affect any other devices.

Of course, if one knew how to actually perform the read operation, it
would be better to go that route.  In the meantime, however, we must
apply this workaround, in order to prevent the regression that causes
tuning to fail on the Airstar HD5000 ATSC device.

Thanks to Jarod Wilson, who had originally reported this regression, and
to Geoffrey Hausheer, whose original workaround patch led us to find the
actual cause of the problem.
Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
Cc: Geoffrey Hausheer <inli3epy93n@phracturedblue.com>
Acked-by: default avatarJarod Wilson <jwilson@redhat.com>
Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
      6175e487
    • Mariusz Kozlowski's avatar
      9p: fix bad error path in conversion routines · 02881d94
      Mariusz Kozlowski authored 
      When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err))
and it will not be happy about it.
Signed-off-by: default avatarMariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
      02881d94
    • Eric Van Hensbergen's avatar
      9p: remove deprecated v9fs_fid_lookup_remove() · fbcb7599
      Eric Van Hensbergen authored 
      This patch removes the v9fs_fid_lookup_remove which is no longer used.

Based on original patch from Adrian Bunk <bunk@stusta.de> which
used #if 0 to isolate the code.
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
      fbcb7599
    • Eric Van Hensbergen's avatar
      9p: update maintainers and documentation · 27a2a5ff
      Eric Van Hensbergen authored 
      Updates to the MAINTAINERS file and documentation for 9p to point to the
swik wiki versus the outdated sf.net page.  Also updated some email addresses
and added pointers to papers which better describe the implementation and
application of the Linux 9p client.
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
      27a2a5ff
    • Eric Van Hensbergen's avatar
      9p: fix use after free · 1a3cac6c
      Eric Van Hensbergen authored 
      On 7/22/07, Adrian Bunk <bunk@stusta.de> wrote:
     The Coverity checker spotted the following use-after-free
     in net/9p/mux.c:

     <--  snip  -->

     ...
     struct p9_conn *p9_conn_create(struct p9_transport *trans, int msize,
                                         unsigned char *extended)
     {
     ...
             if (!m->tagpool) {
                     kfree(m);
                     return ERR_PTR(PTR_ERR(m->tagpool));
             }
     ...

     <--  snip  -->

Also spotted was a leak of the same structure further down in the function.
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
      1a3cac6c
    • Ingo Molnar's avatar
      sched: tweak the sched_runtime_limit tunable · 505c0efd
      Ingo Molnar authored 
      Michael Gerdau reported reniced task CPU usage weirdnesses.
Such symptoms can be caused by limit underruns so double the
sched_runtime_limit.
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      505c0efd
    • Suresh Siddha's avatar
      sched: skip updating rq's next_balance under null SD · f549da84
      Suresh Siddha authored 
      Was playing with sched_smt_power_savings/sched_mc_power_savings and
found out that while the scheduler domains are reconstructed when sysfs
settings change, rebalance_domains() can get triggered with null domain
on other cpus, which is setting next_balance to jiffies + 60*HZ.
Resulting in no idle/busy balancing for 60 seconds.

Fix this.
Signed-off-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      f549da84
    • Suresh Siddha's avatar
      sched: fix broken SMT/MC optimizations · f8700df7
      Suresh Siddha authored 
      On a four package system with HT - HT load balancing optimizations were
broken.  For example, if two tasks end up running on two logical threads
of one of the packages, scheduler is not able to pull one of the tasks
to a completely idle package.

In this scenario, for nice-0 tasks, imbalance calculated by scheduler
will be 512 and find_busiest_queue() will return 0 (as each cpu's load
is 1024 > imbalance and has only one task running).

Similarly MC scheduler optimizations also get fixed with this patch.

[ mingo@elte.hu: restored fair balancing by increasing the fuzz and
                 adding it back to the power decision, without the /2
                 factor. ]
Signed-off-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      f8700df7
    • Christian Borntraeger's avatar
      sched: accounting regression since rc1 · efe567fc
      Christian Borntraeger authored 
      Fix the accounting regression for CONFIG_VIRT_CPU_ACCOUNTING.  It
reverts parts of commit b27f03d4 by
converting fs/proc/array.c back to cputime_t.  The new functions
task_utime and task_stime now return cputime_t instead of clock_t.  If
CONFIG_VIRT_CPU_ACCOUTING is set, task->utime and task->stime are
returned directly instead of using sum_exec_runtime.

Patch is tested on s390x with and without VIRT_CPU_ACCOUTING as well as
on i386.

[ mingo@elte.hu: cleanups, comments. ]
Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      efe567fc
    • Eric W. Biederman's avatar
      sched: fix sysctl directory permissions · c57baf1e
      Eric W. Biederman authored 
      There are two remaining gotchas:

- The directories have impossible permissions (writeable).

- The ctl_name for the kernel directory is inconsistent with
  everything else.  It should be CTL_KERN.
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      c57baf1e
    • Ingo Molnar's avatar
      sched: sched_clock_idle_[sleep|wakeup]_event() · 2aa44d05
      Ingo Molnar authored 
      construct a more or less wall-clock time out of sched_clock(), by
using ACPI-idle's existing knowledge about how much time we spent
idling. This allows the rq clock to work around TSC-stops-in-C2,
TSC-gets-corrupted-in-C3 type of problems.

( Besides the scheduler's statistics this also benefits blktrace and
  printk-timestamps as well. )

Furthermore, the precise before-C2/C3-sleep and after-C2/C3-wakeup
callbacks allow the scheduler to get out the most of the period where
the CPU has a reliable TSC. This results in slightly more precise
task statistics.

the ACPI bits were acked by Len.
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
Acked-by: default avatarLen Brown <len.brown@intel.com>
      2aa44d05
    • Tejun Heo's avatar
      libata: don't check n_sectors during revalidation if zero · b54eebd6
      Tejun Heo authored 
      If the initial configuration fails early, n_sectors is left at zero.
Checking against it during revalidation makes retried configuration
fail due to n_sectors mismatch.  Ignore zero n_sectors during
revalidation.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      b54eebd6
    • Alan Cox's avatar
      pata_via: Add Arima W730-K8 and other rebadgings · 9edbdbea
      Alan Cox authored 
      More cable funnies
Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Tested-by: default avatarMikael Pettersson <mikpe@it.uu.se>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      9edbdbea
    • Alan Cox's avatar
      pata_sis: Add the FSC Amilo and friends · 4f2d47cf
      Alan Cox authored 
      More short cables
Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      4f2d47cf
    • Mikael Pettersson's avatar
      pata_pdc2027x: PLL detection fixes · 78c4af0b
      Mikael Pettersson authored 
      Previously I reported that the pata_pdc2027x PLL detection changes
in kernel 2.6.22 broke the driver on my PowerMac:

>pata_pdc2027x: Invalid PLL input clock 1691742kHz, give up!

This is followed by a number of errors and speed reduction
steps on the affected ports.

There are two bugs in pata_pdc2027x's PLL detection code:

1. The PLL counter's start value is read before the chip is
   put in "test mode". Outside of test mode the counter is
   halted, and on the PowerMac the counter is zero because
   the chip hasn't been initialised by its BIOS.

   The fix is to move the read of the start value to after
   test mode is started, but before the mdelay() in test mode.
   This also improves the precision of the PLL detection.

2. The code to compute the number of PLL decrements during the
   mdelay() in test mode fails to consider that the PLL counter
   only is 30 bits wide. If there is a wraparound, it will compute
   an incorrect and much too large value. On the PowerMac, the
   start count is zero, the end count is a large 30-bit value, so
   wraparound occurs and an out of bounds PLL clock is detected.

   The fix is to mask the (start - end) computation to 30 bits.

While debugging this I also noticed that pdc_read_counter()
reads the two halves of the 30-bit PLL counter as 16-bit values,
and then combines them as if the halves only are 15 bits wide.
To avoid confusion, the halves should be read as 15-bit values.

This patch implements all three changes. It fixes the PLL detection
failure on my PowerMac, and doesn't cause any regressions on an x86
with an identical card.
Signed-off-by: default avatarMikael Pettersson <mikpe@it.uu.se>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      78c4af0b
    • Tejun Heo's avatar
      libata: fix n_sectors failure handling during revalidation · 8270bec4
      Tejun Heo authored 
      If revalidation fails because device has different n_sectors after
configuration the original n_sectors should be restored before failing
revalidation.  Without this fix, n_sectors difference will incorrectly
and silently pass revalidation when revalidation is retried.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      8270bec4
    • Pierre Ossman's avatar
      sdhci: tell which spurious interrupt we got · b67ac3f3
      Pierre Ossman authored 
      When we get unexpected interrupts, also print which interrupt it was.
Signed-off-by: default avatarPierre Ossman <drzeus@drzeus.cx>
      b67ac3f3
    • Pierre Ossman's avatar
      sdhci: handle data interrupts during command · e538fbe8
      Pierre Ossman authored 
      It is fully legal for a controller to start issuing data related
interrupts before it has signalled that the command has completed.
Make sure the driver actually can handle this.
Signed-off-by: default avatarPierre Ossman <drzeus@drzeus.cx>
      e538fbe8
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7