1. 28 Jul, 2011 8 commits
    • Andy Gospodarek's avatar
      bonding: reduce noise during init · b2730f4f
      Andy Gospodarek authored
      On Tue, Jul 26, 2011 at 05:40:27PM -0700, Joe Perches wrote:
      > On Tue, 2011-07-26 at 17:37 -0700, Jay Vosburgh wrote:
      > > Joe Perches <joe@perches.com> wrote:
      > > >I'd prefer you don't separate the format string
      > > >into multiple pieces.
      > > Why not?  To me, it looks easier to read split into sections
      > > that don't wrap lines.
      >
      > Harder to grep for a dmesg and the
      > defect rate of these split formats is
      > typically higher than single strings
      > because of bad spacing between string
      > segments.
      >
      
      I noticed that you took some time back in late 2009 to 'consolidate' the
      split format-strings present in the bonding driver at the time and I've
      decided I'm fine to leave them the way they are.  The main point of my
      patch was to change the output and I would like to get that included.
      Here is my updated patch...
      
      Subject: [PATCH net-next-2.6 v2] bonding: reduce noise during init
      
      Many are using sysfs to configure bonding rather than module options, so
      there is no need for bonding to throw this warning in normal cases.
      
      Keep the message around when debugging is enabled as it might be useful
      for someone desperate enough to enable debugging, but eliminate it
      otherwise.
      Signed-off-by: default avatarAndy Gospodarek <andy@greyhouse.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b2730f4f
    • Andy Gospodarek's avatar
      bonding: fix string comparison errors · f4bb2e9c
      Andy Gospodarek authored
      When a bond contains a device where one name is the subset of another
      (eth1 and eth10, for example), one cannot properly set the primary
      device or the currently active device.
      
      This was reported and based on work by Takuma Umeya.  I also verified
      the problem and tested that this fix resolves it.
      
      V2: A few did not like the the current code or my changes, so I
      refactored bonding_store_primary and bonding_store_active_slave to be a
      bit cleaner, dropped the use of strnicmp since we did not really need
      the comparison to be case insensitive, and formatted the input string
      from sysfs so a comparison to IFNAMSIZ could be used.
      
      I also discovered an error in bonding_store_active_slave that would
      modify bond->primary_slave rather than bond->curr_active_slave before
      forcing the bonding driver to choose a new active slave.
      
      V3: Actually sending the proper patch....
      Signed-off-by: default avatarAndy Gospodarek <andy@greyhouse.net>
      Reported-by: default avatarTakuma Umeya <tumeya@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f4bb2e9c
    • Neil Horman's avatar
      net: Audit drivers to identify those needing IFF_TX_SKB_SHARING cleared · 550fd08c
      Neil Horman authored
      After the last patch, We are left in a state in which only drivers calling
      ether_setup have IFF_TX_SKB_SHARING set (we assume that drivers touching real
      hardware call ether_setup for their net_devices and don't hold any state in
      their skbs.  There are a handful of drivers that violate this assumption of
      course, and need to be fixed up.  This patch identifies those drivers, and marks
      them as not being able to support the safe transmission of skbs by clearning the
      IFF_TX_SKB_SHARING flag in priv_flags
      Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
      CC: Karsten Keil <isdn@linux-pingi.de>
      CC: "David S. Miller" <davem@davemloft.net>
      CC: Jay Vosburgh <fubar@us.ibm.com>
      CC: Andy Gospodarek <andy@greyhouse.net>
      CC: Patrick McHardy <kaber@trash.net>
      CC: Krzysztof Halasa <khc@pm.waw.pl>
      CC: "John W. Linville" <linville@tuxdriver.com>
      CC: Greg Kroah-Hartman <gregkh@suse.de>
      CC: Marcel Holtmann <marcel@holtmann.org>
      CC: Johannes Berg <johannes@sipsolutions.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      550fd08c
    • Neil Horman's avatar
      net: add IFF_SKB_TX_SHARED flag to priv_flags · d8873315
      Neil Horman authored
      Pktgen attempts to transmit shared skbs to net devices, which can't be used by
      some drivers as they keep state information in skbs.  This patch adds a flag
      marking drivers as being able to handle shared skbs in their tx path.  Drivers
      are defaulted to being unable to do so, but calling ether_setup enables this
      flag, as 90% of the drivers calling ether_setup touch real hardware and can
      handle shared skbs.  A subsequent patch will audit drivers to ensure that the
      flag is set properly
      Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
      Reported-by: default avatarJiri Pirko <jpirko@redhat.com>
      CC: Robert Olsson <robert.olsson@its.uu.se>
      CC: Eric Dumazet <eric.dumazet@gmail.com>
      CC: Alexey Dobriyan <adobriyan@gmail.com>
      CC: David S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d8873315
    • Eric Dumazet's avatar
      net: sock_sendmsg_nosec() is static · 894dc24c
      Eric Dumazet authored
      Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
      CC: Anton Blanchard <anton@samba.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      894dc24c
    • Jiri Pirko's avatar
      forcedeth: fix vlans · 0891b0e0
      Jiri Pirko authored
      For some reason, when rxaccel is disabled, NV_RX3_VLAN_TAG_PRESENT is
      still set and some pseudorandom vids appear. So check for
      NETIF_F_HW_VLAN_RX as well. Also set correctly hw_features and set vlan
      mode on probe.
      Signed-off-by: default avatarJiri Pirko <jpirko@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0891b0e0
    • Sebastian Pöhn's avatar
      gianfar: fix bug caused by 87c288c6 · b852b720
      Sebastian Pöhn authored
      commit 87c288c6 "gianfar: do vlan cleanup" has two issues:
      # permutation of rx and tx flags
      # enabling vlan tag insertion by default (this leads to unusable connections on some configurations)
      
      If VLAN insertion is requested (via ethtool) it will be set at an other point ...
      Signed-off-by: default avatarSebastian Poehn <sebastian.poehn@belden.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b852b720
    • David S. Miller's avatar
  2. 27 Jul, 2011 1 commit
  3. 26 Jul, 2011 7 commits
  4. 25 Jul, 2011 24 commits