1. 02 Feb, 2008 2 commits
    • Henrique de Moraes Holschuh's avatar
      ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set (v2) · b2c985e7
      Henrique de Moraes Holschuh authored
      Refactor and organize the code a bit for the NVRAM polling support:
      
      1. Split hotkey_get/set into hotkey_status_get/set and hotkey_mask_get/set;
      2. Cache the status of hot key mask for later driver use;
      3. Make sure the cache of hot key mask is refreshed when needed;
      4. log a printk notice when the firmware doesn't set the hot key
         mask to exactly what we asked it to;
      5. Add proper locking to the data structures.
      
      Only (4) should be user-noticeable, but there is a chance (5) fixes
      some unknown/unreported race conditions.
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      b2c985e7
    • Henrique de Moraes Holschuh's avatar
      ACPI: thinkpad-acpi: document keymap gotcha's (v2) · 0f089147
      Henrique de Moraes Holschuh authored
      Publish the requirements for keymap changes.  This is a documentation
      change, only.
      
      Currently, people look at the thinkpad-acpi default keymaps, and think:
      "modifying this is a trivial thing, it can't break systems, and there are
      keys defined for foo and bar, but the driver has them as KEY_RESERVED.
      Must have been an oversight, let me change it."
      
      And since they never get to see the bug reports, because they are not
      really a part of the Linux ThinkPad users community (linux-thinkpad
      mailinglist, thinkwiki wiki, thinkpad forums) and laptop users are slow
      to complain to distros about any breakages...
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      0f089147
  2. 01 Feb, 2008 38 commits