- 10 Mar, 2005 40 commits
-
-
Hirofumi Ogawa authored
With Christoph Hellwig <hch@lst.de> These patches adds the `-o sync' and `-o dirsync' supports to fatfs. If user specified that option, the fatfs does traditional ordered updates by using synchronous writes. If compared to before, these patches will show a improvement of robustness I think. `-o sync' - writes all buffers out before returning from syscall. `-o dirsync' - writes the directory's metadata, and unreferencing operations of data block. remaining to be done fat_generic_ioctl(), fat_notify_change(), ATTR_ARCH of fat_xxx_write[v], and probably, filling hole in cont_prepare_write(), NOTE: Since fatfs doesn't have link-count, unfortunately ->rename() is not safe order at all. It may make the shared blocks, but user shouldn't lose the data by ->rename(). If you test this, please use the dosfstools at http://www.zip.com.au/~akpm/linux/patches/stuff/fatfsprogs.tar.bz2 This is fixing several bugs of dosfstools. And "2/29" patch from hpa adds new ioctl, the attached archive is also including the commands for testing it. This patch fixes vectored write support on fat to do the nessecary non-standard action done in write() aswell. Also adds aio support and makes read/write wrappers around the aio version. Signed-off-by:OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
J. Bruce Fields authored
Removing the spurious (!clnt) check, as in the following, will also simplify that conflict resolution a bit. Signed-off-by:
J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by:
-
gam3@gam3.net authored
ETXTBSY doesn't have a direct anaolog in NFS, so just map it to nfserr_io. As this is the default error code this does not change the operation of nfsd. It only reduces logging. Signed-off-by:
Neil Brown <neilb@cse.unsw.edu.au> Signed-off-by:
-
Neil Brown authored
Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by:
Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by:
Domen Puncer <domen@coderock.org> Signed-off-by:
-
Neil Brown authored
Get rid of remove_lease, use setlease() with F_UNLCK Signed-off-by:
Andy Adamson <andros@citi.umich.edu> Signed-off-by:
-
Neil Brown authored
Remove nfs4_check_deleg_recall(). Move its checks into __setlease() via two new lock_manager callbacks, fl_mylease and fl_change, so that all leases (not just NFSv4 lease as with nfs4_check_deleg_recall) are checked. Default implementations of fl_mylease and fl_change are provided for the sake of the fcntl_setlease interface. Both callbacks must always be defined. fl_mylease: for the NFSv4 server, this check is used to see if an existing lease comes from the same client. For the fcntl_setlease interface, the existing logic is preserved. the fl_mylease check sees if the existing lease is from the input filp. fl_change: called if the fl_mylease returns true the NFSv4 server does not hand out a delegation to a client that already has one. -EAGAIN is returned. Otherwise lease_modify is used. For the fcntl_setlease interface, the exisiting logic is preserved: The callback used in lease_modify(). Signed-off-by:
-
Neil Brown authored
We get a NULL dereference here anyway, no need to BUG() explicitly. Signed-off-by:
-
Neil Brown authored
Note that the second parameter is unused. Signed-off-by:
-
Neil Brown authored
It is the responsibility of the code that runs in the do_recall thread to drop the reference to the delegation. So if we fail to run that thread, then we need to do it ourselves here. Signed-off-by:
-
Neil Brown authored
The dl_state flag isn't actually useful. Signed-off-by:
-
Neil Brown authored
Allow io using a delegation stateid to proceed without the need to reopen the file, as is done already with open stateid's. Signed-off-by:
-
Neil Brown authored
We shouldn't be calling release_deleg under a spinlock. Signed-off-by:
-
Neil Brown authored
The st_vfs_file pointer is set when the open that originally got the delegation is closed, and then in release_deleg we attempt to distinguish between the case when the original open has been closed and when it hasn't. The resulting logic is complicated and buggy. It's much simpler just to keep a reference count on the struct file. Signed-off-by:
-
Neil Brown authored
The only reason we're keeping a pointer to the stateid in the delegation is so we can get at st_vfs_file. So we should just keep a pointer to the struct file instead. Signed-off-by:
-
Neil Brown authored
Just separate part of release_deleg into a separate function. Signed-off-by:
-
Neil Brown authored
The delegation recall callback is setting the REAP_DELEGATION state when it drops the reference count to zero instead of just freeing the thing itself, which is needlessly complicated and bug-prone. It's simpler just to define a nfs4_put_delegation() which works in the usual way and have the delegation recall code do call that itself. Eventually I'll convert all the nfsd4 state reference counts to struct krefs which will be harder to abuse in this way.... Signed-off-by:
-
Neil Brown authored
We weren't taking the reference count in the delegation recall thread until we'd already started the new delegation thread (and possibly returned from the break_lease callback). That's too late. Also document some assumptions. Signed-off-by:
-
Neil Brown authored
The st_vfs_file field *must* be non-NULL as long as the stateid is in use, so there's no point testing for it, unless we want to just BUG(). But since we'd immediately hit a NULL dereference in every case, there's no need even for that. Signed-off-by:
-
Neil Brown authored
Note st_vfs_set is redundant; we can always just check whether st_vfs_file is set. Fix one inconsistency along the way: we were setting st_vfs_file to 0 in one case without fput()'ing st_vfs_file. It doesn't appear there was a need to do either one in that case. Signed-off-by:
-
Neil Brown authored
The laundromat is freeing any delegation it finds in the RECALL_COMPLETE state. But note that RECALL_COMPLETE is the state that the delegation recall callback leaves the state in. We shouldn't actually be giving up on the delegation till either the client has had a chance to call delegreturn, or the lease time has run out. Signed-off-by:
-
Neil Brown authored
There's no reason to have the lockowners hang off the same list on the client struct as the openowners do; you can always get to the lockowners from their original openowners instead. Signed-off-by:
-
Neil Brown authored
The name makes it sounds like the job of this function is to release a single lockowner; the plural seems clearer. Signed-off-by:
-
Neil Brown authored
We don't need dl_recall_cnt any more, we're just using a local variable in nfsd4_cb_recall. Signed-off-by:
-
Neil Brown authored
Miscellaneous cleanup including: remove recursion use a local variable instead of dl_recall_cnt Signed-off-by:
-
Neil Brown authored
Whitespace, etc. Signed-off-by:
-
Neil Brown authored
Use a synchronous rpc for the delegation recall. This is simpler and avoids putting rpciod to sleep for 2 seconds on retries. Signed-off-by:
-
Neil Brown authored
The rpc creds we look up in the callback code need puts. Signed-off-by:
-
Neil Brown authored
The return value of nfsd4_cb_recall isn't really used (and the errors we were returning were incorrect anyway). Signed-off-by:
-
Neil Brown authored
Remove incorrect kfree. Signed-off-by:
-
Neil Brown authored
Pass the callback_ident received in SETCLIENTID to the CB_RECALL rpc. Signed-off-by:
-
Neil Brown authored
Fix "find" functions that use return value redundantly. Calculate hashes on demand. Miscellaneous kernel style. Signed-off-by:
-
Neil Brown authored
There's no need to return duplicate information through the return value and an argument. Other minor cleanup. Signed-off-by:
-
Neil Brown authored
If the client was given a delegation, but our callback path to the client has since failed for some reason, then our only chance to inform the client of this is to return the cb_path_down error next time the client attempts to renew its state. Signed-off-by:
-
Neil Brown authored
Don't bother searching for unconfirmed clients when handling RENEW; a client is pretty sick if it's trying to renew state it hasn't even finished acquiring yet. Signed-off-by:
-
Neil Brown authored
Simplify verify_clientid out of existance. Signed-off-by:
-
Neil Brown authored
We repeat the same hash table searches in a bunch of places, and keep making the mistake of assuming the variable iterating over the list will be NULL when the search fails. Some helper functions here simplify things a bit. While we're at it, make move_to_confirmed take just a clp instead of making the caller compute the hash. This means we sometimes have to compute the hash multiple times, but it's only an &, so no big deal. Signed-off-by:
-
Neil Brown authored
Inline nfs4_check_delegmode, replace & by &&, remove incorrect check. (Note that it's fine to read using the stateid for a write delegation.) While we're at it, the status return logic seems like overkill for one simple check. Signed-off-by:
-
Neil Brown authored
We would have oopsed some time ago if either of these parameters were NULL. Signed-off-by:
-
Neil Brown authored
Don't hand out a delegation to a client that already has one. Minor simplification and reformatting. Signed-off-by:
-
Neil Brown authored
Simplify logic in nfs4_open_delegation, fix a small bug on allocation failure. Signed-off-by:
-
