- 02 May, 2019 36 commits
-
-
Vinod Koul authored
Multi-blank lines do not help readability so remove them Checkpatch complains: CHECK: Please don't use multiple blank lines Signed-off-by:
Vinod Koul <vkoul@kernel.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Vinod Koul authored
For improving code readability it helps to have a blank line between function so add when missing. Checkpatch complains: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by:
-
Vinod Koul authored
macro argument should be inside a parenthesis to avoid precedence issues checkpatch complains: CHECK: Macro argument 'n' may be better as '(n)' to avoid precedence issues Signed-off-by:
-
Vinod Koul authored
Found few more typos in the code, fix them CHECK: 'and and' may be misspelled - perhaps 'and'? CHECK: 'smaple' may be misspelled - perhaps 'sample'? Signed-off-by:
-
Vinod Koul authored
Modify the code to avoid multiple assignments by assigning to variable after error checks in soundwire bus. CHECK: multiple assignments should be avoided Signed-off-by:
-
Vinod Koul authored
Found few more issues reported checkpatch on code alignment so fix those as well in the intel module. Signed-off-by:
-
Vinod Koul authored
Found few more issues reported checkpatch on code alignment so fix those as well in the soundwire core. Signed-off-by:
-
Vinod Koul authored
Checkpatch warns that function definition of __sdw_register_driver misses argument, so add it WARNING: function definition argument 'struct module *' should also have an identifier name Signed-off-by:
-
Vinod Koul authored
Linux code style doesn't expect empty lines after braces and gives warning: CHECK: Blank lines aren't necessary after an open brace '{' Remove the empty line in intel module Signed-off-by: -
Vinod Koul authored
Linux code style doesn't expect empty lines after braces and gives warning: CHECK: Blank lines aren't necessary after an open brace '{' Remove the empty line in cadence lib Signed-off-by: -
Vinod Koul authored
Linux code style doesn't expect empty lines before or after braces and gives warning: CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Blank lines aren't necessary before a close brace '}' Fix these instances in soundwire core Signed-off-by: -
Vinod Koul authored
Some more headers had C++ style SDPX line, fix that and change copyright so that it is consistent with rest of the code in subsystem Signed-off-by:
-
Vinod Koul authored
Move to help format instead of --help-- as that is not recommended and this makes file consistent with other instance Signed-off-by:
-
Pierre-Louis Bossart authored
For some reason the newlines are not used everywhere. Fix as needed. Reported-by:
Joe Perches <joe@perches.com> Reviewed-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
-
Pierre-Louis Bossart authored
Extra newline does not improve readability. Reviewed-by:
-
Pierre-Louis Bossart authored
No need for explicit test against true Reviewed-by:
-
Pierre-Louis Bossart authored
While not strictly necessary, balanced parentheses help with code readability. Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
No need for explicit test against true Reviewed-by:
-
Pierre-Louis Bossart authored
Extra parentheses required here Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
No need for explicit test against true Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style. In some cases parenthesis alignment is modified to keep the code readable. Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
tools complain here and the location of the newline does not improve readability. Reviewed-by:
-
Pierre-Louis Bossart authored
no need for an explicit test against false reported by Coccinelle Reviewed-by:
-
Pierre-Louis Bossart authored
and make the code more readable Reviewed-by:
-
Pierre-Louis Bossart authored
spelling mistakes Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
use Linux style Reviewed-by:
-
Vinod Koul authored
Some more headers had C++ style SDPX line, fix that and change copyright so that it is consistent with rest of the code in subsystem Signed-off-by:
-
Pierre-Louis Bossart authored
No C++ comments in .h files Reviewed-by:
-
Pierre-Louis Bossart authored
Move to the regular help format, --help-- is no longer recommended. Reviewed-by:
-
- 29 Apr, 2019 1 commit
-
-
Greg Kroah-Hartman authored
Merge tag 'soundwire-5.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire into char-misc-next Vinod writes: soundwire updates for v5.2-rc1 This round saw interest from Intel, Linaro and Cadence in Soundwire. More patches are in pipeline (maybe next cycle) - removal of useless initialzation in core - couple of header and kcalloc inversion fixes on Intel driver * tag 'soundwire-5.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire: soundwire: intel: fix implicit header use of module.h/export.h soundwire: stream: remove useless initialization of local variable soundwire: remove useless initializations soundwire: intel: fix inversion in devm_kcalloc parameters
-
- 27 Apr, 2019 3 commits
-
-
Greg Kroah-Hartman authored
Merge tag 'thunderbolt-for-v5.2' of git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt into char-misc-next Mika writes: thunderbolt: Changes for v5.2 merge window This improves software connection manager on older Apple systems with Thunderbolt 1 and 2 controller to support full PCIe daisy chains, Display Port tunneling and P2P networking. There are also fixes for potential NULL pointer dereferences at various places in the driver. * tag 'thunderbolt-for-v5.2' of git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt: (44 commits) thunderbolt: Make priority unsigned in struct tb_path thunderbolt: Start firmware on Titan Ridge Apple systems thunderbolt: Reword output of tb_dump_hop() thunderbolt: Make rest of the logging to happen at debug level thunderbolt: Make __TB_[SW|PORT]_PRINT take const parameters thunderbolt: Add support for XDomain connections thunderbolt: Make tb_switch_alloc() return ERR_PTR() thunderbolt: Add support for DMA tunnels thunderbolt: Add XDomain UUID exchange support thunderbolt: Run tb_xdp_handle_request() in system workqueue thunderbolt: Do not tear down tunnels when driver is unloaded thunderbolt: Add support for Display Port tunnels thunderbolt: Rework NFC credits handling thunderbolt: Generalize port finding routines to support all port types thunderbolt: Scan only valid NULL adapter ports in hotplug thunderbolt: Add support for full PCIe daisy chains thunderbolt: Discover preboot PCIe paths the boot firmware established thunderbolt: Deactivate all paths before restarting them thunderbolt: Extend tunnel creation to more than 2 adjacent switches thunderbolt: Add helper function to iterate from one port to another ...
-
Mariusz Bialonczyk authored
>From the DS2408 datasheet [1]: "Resume Command function checks the status of the RC flag and, if it is set, directly transfers control to the control functions, similar to a Skip ROM command. The only way to set the RC flag is through successfully executing the Match ROM, Search ROM, Conditional Search ROM, or Overdrive-Match ROM command" The function currently works perfectly fine in a multidrop bus, but when we have only a single slave connected, then only a Skip ROM is used and Match ROM is not called at all. This is leading to problems e.g. with single one DS2408 connected, as the Resume Command is not working properly and the device is responding with failing results after the Resume Command. This commit is fixing this by using a Skip ROM instead in those cases. The bandwidth / performance advantage is exactly the same. Refs: [1] https://datasheets.maximintegrated.com/en/ds/DS2408.pdfSigned-off-by:
Mariusz Bialonczyk <manio@skyboo.net> Reviewed-by:
Jean-Francois Dagenais <jeff.dagenais@gmail.com> Signed-off-by:
-
Patrick Venture authored
Fix up mixed declarations and code in aspeed_p2a_mmap. Tested: Verified the build had the error and that this patch resolved it and there were no other warnings or build errors associated with compilation of this driver. Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
Patrick Venture <venture@google.com> Signed-off-by:
-
