1. 01 Jun, 2018 15 commits
    • John Whitmore's avatar
      staging: rtl8192e: Correct indentation of switch statements - coding style · b63881e2
      John Whitmore authored
      Two switch statements had wrong indentation of 'case' options
      Signed-off-by: default avatarJohn Whitmore <johnfwhitmore@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b63881e2
    • John Whitmore's avatar
      staging: rtl8192e: correct position of '{', '}', '(' and ')' - coding style · 4112d099
      John Whitmore authored
      Correct the coding style of parenthesis and braces in various code blocks
      Signed-off-by: default avatarJohn Whitmore <johnfwhitmore@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4112d099
    • John Whitmore's avatar
      staging: rtl8192e: Add spaces where required by coding standard · 59bd7f62
      John Whitmore authored
      There were numerous coding syle errors in this file where spaces were required
      around operators.
      Signed-off-by: default avatarJohn Whitmore <johnfwhitmore@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      59bd7f62
    • Greg Kroah-Hartman's avatar
      staging: lustre: get rid of ldebugfs_remove() · b145d786
      Greg Kroah-Hartman authored
      It was just a dumb wrapper around debugfs_remove_recursive() so just
      call the function properly.  Also, there is no need to set the dentry to
      NULL, it's gone, who cares about it anymore...
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Roman Storozhenko <romeusmeister@gmail.com>
      Cc: Aastha Gupta <aastha.gupta4104@gmail.com>
      Cc: Ben Evans <bevans@cray.com>
      Cc: Quentin Bouget <quentin.bouget@cea.fr>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Arushi Singhal <arushisinghal19971997@gmail.com>
      Cc: Patrick Farrell <paf@cray.com>
      Cc: Aliaksei Karaliou <akaraliou.dev@gmail.com>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: Andriy Skulysh <andriy.skulysh@seagate.com>
      Cc: Dafna Hirschfeld <dafna3@gmail.com>
      Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
      Cc: Bob Glosman <bob.glossman@intel.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b145d786
    • Greg Kroah-Hartman's avatar
      staging: lustre: make ldebugfs_add_vars a void function · d5bf5cf9
      Greg Kroah-Hartman authored
      The call to ldebugfs_add_vars() can not really fail, so have it just
      return nothing, which allows us to clean up a lot of unused error
      handling code.
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Roman Storozhenko <romeusmeister@gmail.com>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: Quentin Bouget <quentin.bouget@cea.fr>
      Cc: Aastha Gupta <aastha.gupta4104@gmail.com>
      Cc: Ben Evans <bevans@cray.com>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Arushi Singhal <arushisinghal19971997@gmail.com>
      Cc: Frank Zago <fzago@cray.com>
      Cc: Patrick Farrell <paf@cray.com>
      Cc: Simo Koskinen <koskisoft@gmail.com>
      Cc: Andriy Skulysh <andriy.skulysh@seagate.com>
      Cc: "John L. Hammond" <john.hammond@intel.com>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: Dafna Hirschfeld <dafna3@gmail.com>
      Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d5bf5cf9
    • Greg Kroah-Hartman's avatar
      staging: lustre: remove last two users of ldebugfs_register() · 00905f00
      Greg Kroah-Hartman authored
      ldebugfs_register() is just a call to debugfs_create_dir() and
      ldebugfs_add_vars() if the list option is set.  Fix up the last two
      users of this function to just call these two functions instead, and
      delete the now unused ldebugfs_register() call.
      
      This ends up cleaning up more code and making things smaller, always a
      good thing.
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Ben Evans <bevans@cray.com>
      Cc: Quentin Bouget <quentin.bouget@cea.fr>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Arushi Singhal <arushisinghal19971997@gmail.com>
      Cc: Julia Lawall <julia.lawall@lip6.fr>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: Dafna Hirschfeld <dafna3@gmail.com>
      Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
      Cc: Patrick Farrell <paf@cray.com>
      Cc: Nadav Amit <namit@vmware.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      00905f00
    • Greg Kroah-Hartman's avatar
      staging: lustre: unwrap some ldebugfs_register() calls · b145f49f
      Greg Kroah-Hartman authored
      When the third option (list) to ldebugfs_register() is NULL, it's the
      same as just calling debugfs_create_dir().  So unwind this and call
      debugfs_create_dir() directly.
      
      This ends up saving lots of code as we do not need to do any error
      checking of the return value (because it does not matter).
      
      The ldebugfs_register() call will be removed in a later patch when it is
      fully removed, right now there are 2 outstanding users of it in the
      tree.
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Aastha Gupta <aastha.gupta4104@gmail.com>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Quentin Bouget <quentin.bouget@cea.fr>
      Cc: Patrick Farrell <paf@cray.com>
      Cc: Aliaksei Karaliou <akaraliou.dev@gmail.com>
      Cc: "John L. Hammond" <john.hammond@intel.com>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: Andriy Skulysh <andriy.skulysh@seagate.com>
      Cc: Ben Evans <bevans@cray.com>
      Cc: Bob Glosman <bob.glossman@intel.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b145f49f
    • Greg Kroah-Hartman's avatar
      staging: lustre: remove ldebugfs_obd_seq_create() wrapper function · 08bd45fd
      Greg Kroah-Hartman authored
      It was just calling debugfs_create_file() so unwind things and just call
      the real function instead.  This ends up saving a number of lines as
      there was never any error handling happening anyway, so that all can be
      removed as well.
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: Quentin Bouget <quentin.bouget@cea.fr>
      Cc: Ben Evans <bevans@cray.com>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Arushi Singhal <arushisinghal19971997@gmail.com>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Julia Lawall <julia.lawall@lip6.fr>
      Cc: Dafna Hirschfeld <dafna3@gmail.com>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
      Cc: Roman Storozhenko <romeusmeister@gmail.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      08bd45fd
    • Greg Kroah-Hartman's avatar
      staging: lustre: remove ldebugfs_seq_create() wrapper function · 6f7ed760
      Greg Kroah-Hartman authored
      It was just calling debugfs_create_file() so unwind things and just call
      the real function instead.  This ends up saving a number of lines as
      there was never any error handling happening anyway, so that all can be
      removed as well.
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: Quentin Bouget <quentin.bouget@cea.fr>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Ben Evans <bevans@cray.com>
      Cc: Arushi Singhal <arushisinghal19971997@gmail.com>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: "John L. Hammond" <john.hammond@intel.com>
      Cc: Vitaly Fertman <vitaly.fertman@seagate.com>
      Cc: Julia Lawall <julia.lawall@lip6.fr>
      Cc: Dafna Hirschfeld <dafna3@gmail.com>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
      Cc: Bob Glosman <bob.glossman@intel.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6f7ed760
    • Greg Kroah-Hartman's avatar
      staging: lustre: remove ldebugfs_register_stats() wrapper function · cd514eac
      Greg Kroah-Hartman authored
      It was just calling debugfs_create_file() so unwind things and just call
      the real function instead.  This ends up saving a number of lines as
      there was never any error handling happening anyway, so that all can be
      removed as well.
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: Ben Evans <bevans@cray.com>
      Cc: Quentin Bouget <quentin.bouget@cea.fr>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Arushi Singhal <arushisinghal19971997@gmail.com>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Patrick Farrell <paf@cray.com>
      Cc: Aliaksei Karaliou <akaraliou.dev@gmail.com>
      Cc: Aastha Gupta <aastha.gupta4104@gmail.com>
      Cc: Dafna Hirschfeld <dafna3@gmail.com>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
      Cc: Bob Glosman <bob.glossman@intel.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      cd514eac
    • Greg Kroah-Hartman's avatar
      staging: lustre: remove ldebugfs_add_simple() wrapper · 460c9a86
      Greg Kroah-Hartman authored
      It was only being called in one place, and is an unneeded wrapper
      function around debugfs_create_file() so just call the real debugfs
      function instead.  This ends up cleaning up some unneeded error handling
      logic that was never needed as well.
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: Quentin Bouget <quentin.bouget@cea.fr>
      Cc: Ben Evans <bevans@cray.com>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Arushi Singhal <arushisinghal19971997@gmail.com>
      Cc: Dafna Hirschfeld <dafna3@gmail.com>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      460c9a86
    • Greg Kroah-Hartman's avatar
      staging: lustre: no need to check debugfs return values · d0202661
      Greg Kroah-Hartman authored
      When calling debugfs functions, there is no need to ever check the
      return value.  The function can work or not, but the code logic should
      never do something different based on this.
      
      Clean up the lustre core code by not caring about the value of debugfs
      calls.  This ends up removing a number of lines of code that are not
      needed.
      
      Note, more work is needed to remove the unneeded debugfs wrapper
      functions in the future.
      
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Cc: NeilBrown <neilb@suse.com>
      Cc: Ben Evans <bevans@cray.com>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: "John L. Hammond" <john.hammond@intel.com>
      Cc: Dafna Hirschfeld <dafna3@gmail.com>
      Cc: Mathias Rav <mathiasrav@gmail.com>
      Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
      Cc: lustre-devel@lists.lustre.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d0202661
    • Greg Kroah-Hartman's avatar
      staging: unisys: visornic: no need to check debugfs return values · 4d883eea
      Greg Kroah-Hartman authored
      When calling debugfs functions, there is no need to ever check the
      return value.  The function can work or not, but the code logic should
      never do something different based on this.
      
      Clean up the visornic driver code by not caring about the value of
      debugfs calls.  This ends up removing a number of lines of code that are
      not needed.
      
      Cc: David Kershner <david.kershner@unisys.com>
      Cc: Tim Sell <timothy.sell@unisys.com>
      Cc: David Binder <david.binder@unisys.com>
      Cc: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
      Cc: Charles Daniels <cdaniels@fastmail.com>
      Cc: sparmaintainer@unisys.com
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4d883eea
    • Greg Kroah-Hartman's avatar
      staging: rtlwifi: don't check the return value of debugfs_create_file · e206a0d4
      Greg Kroah-Hartman authored
      We never did anything with the return value, and it does not matter if
      the call succeeds or not (it's just debugging code), so don't even check
      it.
      
      Cc: Larry Finger <Larry.Finger@lwfinger.net>
      Cc: Ping-Ke Shih <pkshih@realtek.com>
      Cc: Colin Ian King <colin.king@canonical.com>
      Cc: "Frank A. Cancio Bello" <frank@generalsoftwareinc.com>
      Cc: Nathan Chancellor <natechancellor@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      e206a0d4
    • Greg Kroah-Hartman's avatar
      staging: greybus: camera: no need to check debugfs return values · 00aaa6b1
      Greg Kroah-Hartman authored
      When calling debugfs functions, there is no need to ever check the
      return value.  The function can work or not, but the code logic should
      never do something different based on this.
      
      Clean up the greybus camera driver by not caring about the value of
      debugfs calls.  This ends up removing a number of lines of code that
      are not needed.
      
      Cc: Alex Elder <elder@kernel.org>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: greybus-dev@lists.linaro.org
      Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
      Acked-by: default avatarJohan Hovold <johan@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      00aaa6b1
  2. 31 May, 2018 11 commits
  3. 26 May, 2018 3 commits
  4. 25 May, 2018 11 commits