- 02 Apr, 2019 9 commits
-
-
Wen Yang authored
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./sound/soc/fsl/eukrea-tlv320.c:121:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 102, but without a correspo nding object release within this function. ./sound/soc/fsl/eukrea-tlv320.c:127:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 102, but without a correspo nding object release within this function. Signed-off-by:
Wen Yang <wen.yang99@zte.com.cn> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Wen Yang authored
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./sound/soc/fsl/fsl_utils.c:74:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 38, but without a corresponding object release within this function. Signed-off-by:
Wen Yang <wen.yang99@zte.com.cn> Cc: Timur Tabi <timur@kernel.org> Cc: Nicolin Chen <nicoleotsuka@gmail.com> Cc: Xiubo Li <Xiubo.Lee@gmail.com> Cc: Fabio Estevam <festevam@gmail.com> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Wen Yang authored
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./sound/soc/codecs/wcd9335.c:5193:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 5183, but without a correspon ding object release within this function. Signed-off-by:
Wen Yang <wen.yang99@zte.com.cn> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Vinod Koul <vkoul@kernel.org> Cc: Dan Carpenter <dan.carpenter@oracle.com> (commit_signer:1/11=9%,authored:1/11=9%) Cc: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Liam Girdwood authored
This aligns all kcontrol tplg pointer increments to be consistent in the respective create methods and ensures that the position is pointing to the next widget rather the current invalid widget. Signed-off-by:
Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by:
Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Pierre-Louis Bossart authored
When the same machine driver is reused between platforms but with a different alias, using the driver name is not enough. Add additional fallback case to use the card device name. Tested on GeminiLake with bxt_da7219_max98357a machine driver Suggested-by:
Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Baolin Wang authored
We use 2-stage DMA mode to support Spreadtrum audio compress offload, which means we use one DMA source channel to transfer data from IRAM buffer to the DSP fifo to do decoding/encoding, once IRAM buffer is empty by transferring done, another DMA destination channel will be triggered automatically to start to transfer data from DDR buffer to the IRAM buffer. This can reduce the AP subsystem wakeup times to save power. Co-developed-by:
Yintang Ren <yintang.ren@unisoc.com> Signed-off-by:
Baolin Wang <baolin.wang@linaro.org> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Randy Dunlap authored
Fix kconfig warning for SND_SOC_LOCHNAGAR_SC: WARNING: unmet direct dependencies detected for SND_SOC_LOCHNAGAR_SC Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=m] && MFD_LOCHNAGAR [=n] Selected by [m]: - SND_SOC_ALL_CODECS [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=m] && COMPILE_TEST [=y] Signed-off-by:
Randy Dunlap <rdunlap@infradead.org> Cc: Piotr Stankiewicz <piotrs@opensource.cirrus.com> Cc: Charles Keepax <ckeepax@opensource.cirrus.com> Cc: Richard Fitzgerald <rf@opensource.cirrus.com> Cc: patches@opensource.cirrus.com Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: alsa-devel@alsa-project.org Acked-by:
Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Andrew F. Davis authored
This device can optionally detect headset or microphone button presses. Add support for this by passing this event to the jack layer. Signed-off-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Andrew F. Davis authored
This device can detect the insertion/removal of headphones and headsets. Enable reporting this status by enabling this interrupt and forwarding this to upper-layers if a jack has been defined. This jack definition and the resulting operation from a jack detection event must currently be defined by sound card platform code until CODEC outputs to jack mappings can be defined generically. Signed-off-by:
Andrew F. Davis <afd@ti.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- 01 Apr, 2019 10 commits
-
-
YueHaibing authored
Fixes gcc '-Wunused-but-set-variable' warning: sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk': sound/soc/generic/simple-card-utils.c:164:18: warning: parameter 'dai_name' set but not used [-Wunused-but-set-parameter] It's not used since commit 0580dde5 ("ASoC: simple-card-utils: add asoc_simple_debug_info()"), so can be removed. Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Acked-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by:
Mukesh Ojha <mojha@codeaurora.org> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Paul Cercueil authored
On some devices (Teclast X98+ II tablet, maybe others), the jack detection has been wired backwards, so when the ES8316 reports headphones being present it means they are actually not plugged. Use a quirk around this incorrect behaviour, which can be enabled through the 'everest,jack-detect-inverted' boolean device property. Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Shunli Wang authored
This patch adds document for the machine board with mt6358, da7219 and max98357 codecs. Signed-off-by:
Shunli Wang <shunli.wang@mediatek.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Charles Keepax authored
Signed-off-by:
Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Colin Ian King authored
There is a spelling mistake in a dev_err message. Fix this. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Reviewed-by:
Mukesh Ojha <mojha@codeaurora.org> Acked-by:
Viorel Suman <viorel.suman@nxp.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Shunli Wang authored
This patch adds support for the machine board with mt6358, da7219 and max98357 codecs. Signed-off-by:
Shunli Wang <shunli.wang@mediatek.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Shunli Wang authored
This patch adds document for the machine board with mt6358, ts3a227 and max98357 codecs. Signed-off-by:
Shunli Wang <shunli.wang@mediatek.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Shunli Wang authored
This patch adds support for the machine board with TS3A227. Signed-off-by:
Shunli Wang <shunli.wang@mediatek.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Oder Chiou authored
Add the ACPI ID for the product "chromebook pixel 2015" to match the coreboot settings. Signed-off-by:
Oder Chiou <oder_chiou@realtek.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Olivier Moysan authored
Support multiple endpoints on cs42L51 codec port when used in of_graph context. This patch allows to share the codec port between two CPU DAIs. Example: STM32MP157C-DK2 board uses CS42L51 audio codec. This codec is connected to two serial audio interfaces, which are configured either as rx or tx. From AsoC point of view the topolgy is the following: // 2 CPU DAIs (SAI2A/B), 1 Codec (CS42L51) Playback: CPU-A-DAI(slave) -> (master)CODEC-DAI/port0 Record: CPU-B-DAI(slave) <- (master)CODEC-DAI/port0 In the DT two endpoints have to be associated to the codec port: cs42l51_port: port { cs42l51_tx_endpoint: endpoint@0 { remote-endpoint = <&sai2a_endpoint>; }; cs42l51_rx_endpoint: endpoint@1 { remote-endpoint = <&sai2b_endpoint>; }; }; However, when the audio graph card parses the codec nodes, it expects to find DAI interface indexes matching the endpoints indexes. The current patch forces the use of DAI id 0 for both endpoints, which allows to share the codec DAI between the two CPU DAIs for playback and capture streams respectively. Signed-off-by:
Olivier Moysan <olivier.moysan@st.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- 27 Mar, 2019 1 commit
-
-
Viorel Suman authored
The format in dev_dbg function must be a constant. Signed-off-by:
Viorel Suman <viorel.suman@nxp.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- 26 Mar, 2019 4 commits
-
-
Viorel Suman authored
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs. It connects together Audio Mixer and related SAI instances. Signed-off-by:
Viorel Suman <viorel.suman@nxp.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Viorel Suman authored
Add the DT binding documentation for NXP Audio Mixer CPU DAI driver. Signed-off-by:
Viorel Suman <viorel.suman@nxp.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Viorel Suman authored
This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs. The Audio Mixer is a on-chip functional module that allows mixing of two audio streams into a single audio stream. Audio Mixer datasheet is available here: https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdfSigned-off-by:
Viorel Suman <viorel.suman@nxp.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Mark Brown authored
Some architectures do not yet support the common clock API at all but the tlv320aic32x4 driver now requires it. Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- 25 Mar, 2019 15 commits
-
-
Annaliese McDermond authored
The clocking and processing blocks are now properly set up to support 192000 sample rates. Allow drivers to ask for that. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
mclk is not used by anything anymore. Remove support for it. All that information now comes from the clock tree. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
The sysclk is now managed by the CCF. Change this function to merely find the system clock and set it using clk_set_rate. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
The existing code uses a static lookup table to determine the settings of the various clock devices on board the chip. This is limiting in a couple of ways. First, this doesn't allow for any master clock rates other than the three that have been precalculated. Additionally, new sample rates are difficult to add to the table. Witness that the chip is capable of 192000 Hz sampling, but it is not provided by this driver. Last, if the driver is clocked by something that isn't a crystal, the upstream clock may not be able to achieve exactly the rate requested in the driver. This will mean that clocking will be slightly off for the sampling clock or that it won't work at all. This patch determines the settings for all of the clocks at runtime considering the real conditions of the clocks in the system. The rules for the clocks are in TI's SLAA557 application guide on pages 37, 51 and 77. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
Move these to separate helper functions. This looks cleaner and fits better with the new clock setting in CCF. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
Control the clock gating to the various clock components to use the CCF. This allows us to prepare_enalbe only 3 clocks and the relationships assigned to them will cause upstream clockss to enable automatically. Additionally we can do this in a single call to the CCF. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
Model and manage BDIV divider as components in the Core Clock Framework. This should allow us to do some more complex clock management and power control. Also, some of the on-board chip clocks can be exposed to the outside, and this change will make those clocks easier to consume by other parts of the kernel. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
Model and manage DAC/ADC dividers as components in the Core Clock Framework. This should allow us to do some more complex clock management and power control. Also, some of the on-board chip clocks can be exposed to the outside, and this change will make those clocks easier to consume by other parts of the kernel. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
Model and manage codec clock input as a component in the Core Clock Framework. This should allow us to do some more complex clock management and power control. Also, some of the on-board chip clocks can be exposed to the outside, and this change will make those clocks easier to consume by other parts of the kernel. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Annaliese McDermond authored
Model and manage the on-board PLL as a component in the Core Clock Framework. This should allow us to do some more complex clock management and power control. Also, some of the on-board chip clocks can be exposed to the outside, and this change will make those clocks easier to consume by other parts of the kernel. Signed-off-by:
Annaliese McDermond <nh6z@nh6z.net> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Pankaj Bharadiya authored
In case of single config, private_value is left uninitialized. The private_value does need to be initialized or in snd_soc_dapm_new_control_unlocked() call failure case, it leads to a bogus free in snd_soc_dapm_free_kcontrol() Signed-off-by:
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Aditya Pakki authored
Unlike other drivers probe method, of_match_node return value is not used or checked. This patch removes the redundant code. Signed-off-by:
Aditya Pakki <pakki001@umn.edu> Reviewed-by:
Steven Price <steven.price@arm.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Olivier Moysan authored
Add support of low power modes to STM32 SAI driver. Signed-off-by:
Olivier Moysan <olivier.moysan@st.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Andi Kleen authored
When using bare externs outside include files that types should at least match. This fixes a type confusion between bool and int. Cc: broonie@kernel.org Signed-off-by:
Andi Kleen <ak@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
John Hsu authored
Do division with div_u64 for the PLL calculation. These errors are fixed and list as follows: 1."__udivdi3" [sound/soc/codecs/snd-soc-nau8810.ko] undefined! 2."__aeabi_uldivmod" [sound/soc/codecs/snd-soc-nau8810.ko] undefined! 3. nau8810.c:(.text.nau8810_calc_pll+0xd8): undefined reference to `__udivdi3' Signed-off-by:
John Hsu <KCHSU0@nuvoton.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- 21 Mar, 2019 1 commit
-
-
Kuninori Morimoto authored
li->conf will be 0 if it was not DPCM case. Then, 1) we shouldn't call devm_kcalloc() with size 0, 2) we need NULL pointer check if li->conf was not 0. This patch fixed above issues. Special thanks to Pierre-Louis Bossart Reported-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-