- 12 Jul, 2017 6 commits
-
-
Colin Ian King authored
The functions cvm_encrypt, cvm_decrypt, cvm_xts_setkey and cvm_enc_dec_init does not need to be in global scope, so make them static. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Acked-by:
David S. Miller <davem@davemloft.net> Signed-off-by:
Herbert Xu <herbert@gondor.apana.org.au>
-
Harsh Jain authored
Thsi patch fixes calling "crypto_alloc_cipher" call in bottom halves. Pre allocate aes cipher required to update Tweak value for XTS. Signed-off-by:
Harsh Jain <harsh@chelsio.com> Signed-off-by:
-
David Gstir authored
Certain cipher modes like CTS expect the IV (req->info) of ablkcipher_request (or equivalently req->iv of skcipher_request) to contain the last ciphertext block when the {en,de}crypt operation is done. This is currently not the case for the CAAM driver which in turn breaks e.g. cts(cbc(aes)) when the CAAM driver is enabled. This patch fixes the CAAM driver to properly set the IV after the {en,de}crypt operation of ablkcipher finishes. This issue was revealed by the changes in the SW CTS mode in commit 0605c41c ("crypto: cts - Convert to skcipher") Cc: <stable@vger.kernel.org> # 4.8+ Signed-off-by:David Gstir <david@sigma-star.at> Reviewed-by:
Horia Geantă <horia.geanta@nxp.com> Signed-off-by:
-
Gilad Ben-Yossef authored
The Atmel SHA driver was treating -EBUSY as indication of queueing to backlog without checking that backlog is enabled for the request. Fix it by checking request flags. Cc: <stable@vger.kernel.org> Signed-off-by:
Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by:
-
Herbert Xu authored
crypto: af_alg - Avoid sock_graft call warning The newly added sock_graft warning triggers in af_alg_accept. It's harmless as we're essentially doing sock->sk = sock->sk. The sock_graft call is actually redundant because all the work it does is subsumed by sock_init_data. However, it was added to placate SELinux as it uses it to initialise its internal state. This patch avoisd the warning by making the SELinux call directly. Reported-by:
Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by:
-
Horia Geantă authored
Driver does not properly handle the case when signals interrupt wait_for_completion_interruptible(): -it does not check for return value -completion structure is allocated on stack; in case a signal interrupts the sleep, it will go out of scope, causing the worker thread (caam_jr_dequeue) to fail when it accesses it wait_for_completion_interruptible() is replaced with uninterruptable wait_for_completion(). We choose to block all signals while waiting for I/O (device executing the split key generation job descriptor) since the alternative - in order to have a deterministic device state - would be to flush the job ring (aborting *all* in-progress jobs). Cc: <stable@vger.kernel.org> Fixes: 045e3678 ("crypto: caam - ahash hmac support") Fixes: 4c1ec1f9 ("crypto: caam - refactor key_gen, sg") Signed-off-by:
-
- 05 Jul, 2017 2 commits
-
-
Herbert Xu authored
It has been reported that sha1-avx2 can cause page faults by reading beyond the end of the input. This patch disables it until it can be fixed. Cc: <stable@vger.kernel.org> Fixes: 7c1da8d0 ("crypto: sha - SHA1 transform x86_64 AVX2") Reported-by:
Jan Stancek <jstancek@redhat.com> Signed-off-by:
-
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6Herbert Xu authored
Merge the crypto tree to pull in fixes for the next merge window.
-
- 28 Jun, 2017 1 commit
-
-
Herbert Xu authored
The combination of sha1 and aes was disabled in FIPS Mode accidentally. This patch reenables it. Fixes: 284a0f6e ("crypto: testmgr - Disable fips-allowed for...") Signed-off-by:
Stephan Müller <smueller@chronox.de>
-
- 22 Jun, 2017 7 commits
-
-
Gary R Hook authored
krobot warning: make sure that all error return paths release locks. Signed-off-by:
Gary R Hook <gary.hook@amd.com> Signed-off-by:
-
Dan Carpenter authored
We want to return negative error codes here, but we're accidentally propogating the "true" return from dma_mapping_error(). Fixes: 14fa93cd ("crypto: cavium - Add support for CNN55XX adapters.") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Benjamin Peterson authored
Signed-off-by:
Benjamin Peterson <bp@benjamin.pe> Signed-off-by:
-
Antoine Ténart authored
The Inside Secure Safexcel cryptographic engine is found on some Marvell SoCs (7k/8k). Document the bindings used by its driver. Signed-off-by:
Antoine Tenart <antoine.tenart@free-electrons.com> Signed-off-by:
-
Horia Geantă authored
This is the 2nd part of fixing the usage of GFP_KERNEL for memory allocations, taking care off all the places that haven't caused a real problem / failure. Again, the issue being fixed is that GFP_KERNEL should be used only when MAY_SLEEP flag is set, i.e. MAY_BACKLOG flag usage is orthogonal. Signed-off-by:
-
Horia Geantă authored
Changes in the SW cts (ciphertext stealing) code in commit 0605c41c ("crypto: cts - Convert to skcipher") revealed a problem in the CAAM driver: when cts(cbc(aes)) is executed and cts runs in SW, cbc(aes) is offloaded in CAAM; cts encrypts the last block in atomic context and CAAM incorrectly decides to use GFP_KERNEL for memory allocation. Fix this by allowing GFP_KERNEL (sleeping) only when MAY_SLEEP flag is set, i.e. remove MAY_BACKLOG flag. We split the fix in two parts - first is sent to -stable, while the second is not (since there is no known failure case). Link: http://lkml.kernel.org/g/20170602122446.2427-1-david@sigma-star.at Cc: <stable@vger.kernel.org> # 4.8+ Reported-by:
-
Stephan Mueller authored
Initialise ctr_completion variable before use. Cc: <stable@vger.kernel.org> Signed-off-by:
Harsh Jain <harshjain.prof@gmail.com> Signed-off-by:
-
- 20 Jun, 2017 24 commits
-
-
Arvind Yadav authored
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by <linux/of.h> work with const of_device_ids. So mark the non-const structs as const. File size before: text data bss dec hex filename 2376 808 128 3312 cf0 drivers/crypto/caam/jr.o File size after constify caam_jr_match: text data bss dec hex filename 2976 192 128 3296 ce0 drivers/crypto/caam/jr.o Signed-off-by:
Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by:
-
Tudor-Dan Ambarus authored
You can't reach init() if parent alg_name is invalid. Moreover, cypto_alloc_base() will return ENOENT if alg_name is NULL. Found while grasping the fallback mechanism. Signed-off-by:
Tudor Ambarus <tudor.ambarus@microchip.com> Signed-off-by:
-
Arvind Yadav authored
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by <linux/of.h> work with const of_device_ids. So mark the non-const structs as const. File size before: text data bss dec hex filename 2001 2168 48 4217 1079 drivers/crypto/n2_core.o File size after constify dummy_tlb_ops.: text data bss dec hex filename 3601 536 48 4185 1059 drivers/crypto/n2_core.o Signed-off-by:
-
Antoine Ténart authored
A base_end pointer is set and provided. Use it in the ring rollback function to avoid using build-in defines. Signed-off-by:
-
Antoine Ténart authored
Increase the batch size to the maximum number of requests a ring can handle at a time (its size). This is possible now that the request queues are per hw ring. This improves performances. Signed-off-by:
-
Antoine Ténart authored
This force the need_dequeue flag to be unset whenever the dequeue function is called, to avoid calling it when it is not necessary. Signed-off-by:
-
Antoine Ténart authored
Get the backlog before dequeuing the request otherwise we'll miss the first request in line. Signed-off-by:
-
Antoine Ténart authored
This update the dequeue function of the inside-secure safexcel driver so that failed requests aren't requeued when they fail (for whatever reason, which can be because the hw ring is full). Signed-off-by:
-
Antoine Ténart authored
Update the inside-secure safexcel driver from using one global queue to one queue per hw ring. This ease the request management and keep the hw in sync with what's done in sw. Signed-off-by:
-
Antoine Ténart authored
This move the context and request updates at the end of the cipher and hash send() functions. This way the context and request fields are set only when everything else was successful in the send() functions. Signed-off-by:
-
Ofer Heifetz authored
The cipher and hash send functions both set the results variable, to be used later by the caller. Align the way they're setting this variable. Signed-off-by:
Ofer Heifetz <oferh@marvell.com> Signed-off-by:
-
Igal Liberman authored
Configure the data write bufferability to always buffer packets in the DSE. This change slightly improves performance. Signed-off-by:
Igal Liberman <igall@marvell.com> Signed-off-by:
-
Igal Liberman authored
When enable_single_wr is not enabled, the DSE will only write those parts of a result descriptor that need updating, which means a final result descriptor will be written in 2 or 3 smaller transfers. When enable_single_wr is enabled the DSE will combine these 2-3 updates into one large write transfer, generally improving performance. Signed-off-by:
-
Antoine Ténart authored
Set the correct value to the DSE data cache, using WR_CACHE_3BITS instead of RD_CACHE_3BITS. This fixes an incorrect setting and helps improving performances. Reported-by:
-
Antoine Ténart authored
The EIP197_HIA_xDR_CFG_WR_CACHE macro was defined to use an offset of 23, which is wrong as it's actually 25. Fix this. Reported-by:
-
Antoine Ténart authored
Replace the hmac ipad/opad values by their defined constants. Signed-off-by:
-
Harsh Jain authored
When multiple devices are present in system select device in round-robin fashion for crypto operations Signed-off-by:
Atul Gupta <atul.gupta@chelsio.com> Reviewed-by:
Ganesh Goudar <ganeshgr@chelsio.com> Signed-off-by:
-
Harsh Jain authored
Allocate new sg list in case received destination sg list has entry greater that 2k. Signed-off-by:
-
Harsh Jain authored
Add myself as maintainer for chcr. Signed-off-by:
-
Harsh Jain authored
Count types of operation done by HW. Signed-off-by:
-
Harsh Jain authored
It send multiple WRs to H/W to handle large sg lists. Adds ctr(aes) and rfc(ctr(aes)) modes. Signed-off-by:
-
Harsh Jain authored
Do not update assoclen received in aead_request. Signed-off-by:
-
Harsh Jain authored
Return correct error instead of EINVAL. Signed-off-by:
-
Harsh Jain authored
Set key of fallback tfm for rfc4309. Signed-off-by:
-
