1. 08 Dec, 2016 2 commits
  2. 07 Dec, 2016 2 commits
  3. 06 Dec, 2016 3 commits
    • Shuah Khan's avatar
      usbip: fix warning in vhci_hcd_probe/lockdep_init_map · 918b8ac5
      Shuah Khan authored
      vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs
      attributes triggering the lock-class key not persistent warning. Call
      sysfs_attr_init() for dynamically allocated sysfs attributes to fix it.
      
      vhci_hcd vhci_hcd: USB/IP Virtual Host Controller
      vhci_hcd vhci_hcd: new USB bus registered, assigned bus number 2
      BUG: key ffff88006a7e8d18 not in .data!
      ------------[ cut here ]------------
      WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:3131
      lockdep_init_map+0x60c/0x770
      DEBUG_LOCKS_WARN_ON(1)[    1.567044] Modules linked in:
      CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-rc7+ #58
      Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
       ffff88006bce6eb8 ffffffff81f96c8a ffffffff00000a02 1ffff1000d79cd6a
       ffffed000d79cd62 000000046bce6ed8 0000000041b58ab3 ffffffff8598af40
       ffffffff81f969f8 0000000000000000 0000000041b58ab3 0000000000000200
      Call Trace:
       [<     inline     >] __dump_stack lib/dump_stack.c:15
       [<ffffffff81f96c8a>] dump_stack+0x292/0x398 lib/dump_stack.c:51
       [<ffffffff812b808f>] __warn+0x19f/0x1e0 kernel/panic.c:550
       [<ffffffff812b8195>] warn_slowpath_fmt+0xc5/0x110 kernel/panic.c:565
       [<ffffffff813f3efc>] lockdep_init_map+0x60c/0x770 kernel/locking/lockdep.c:3131
       [<ffffffff819e43d4>] __kernfs_create_file+0x114/0x2a0 fs/kernfs/file.c:954
       [<ffffffff819e68f5>] sysfs_add_file_mode_ns+0x225/0x520 fs/sysfs/file.c:305
       [<     inline     >] create_files fs/sysfs/group.c:64
       [<ffffffff819e8a89>] internal_create_group+0x239/0x8f0 fs/sysfs/group.c:134
       [<ffffffff819e915f>] sysfs_create_group+0x1f/0x30 fs/sysfs/group.c:156
       [<ffffffff8323de24>] vhci_start+0x5b4/0x7a0 drivers/usb/usbip/vhci_hcd.c:978
       [<ffffffff82c907ca>] usb_add_hcd+0x8da/0x1c60 drivers/usb/core/hcd.c:2867
       [<ffffffff8323bc57>] vhci_hcd_probe+0x97/0x130
      drivers/usb/usbip/vhci_hcd.c:1103
       ---
       ---
      ---[ end trace c33c7b202cf3aac8 ]---
      Signed-off-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
      Reported-by: default avatarAndrey Konovalov <andreyknvl@google.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      918b8ac5
    • Rafał Miłecki's avatar
      usb: core: usbport: Use proper LED API to fix potential crash · 89778ba3
      Rafał Miłecki authored
      Calling brightness_set manually isn't safe as some LED drivers don't
      implement this callback. The best idea is to just use a proper helper
      which will fallback to the brightness_set_blocking callback if needed.
      
      This fixes:
      [ 1461.761528] Unable to handle kernel NULL pointer dereference at virtual address 00000000
      (...)
      [ 1462.117049] Backtrace:
      [ 1462.119521] [<bf228164>] (usbport_trig_port_store [ledtrig_usbport]) from [<c023f758>] (dev_attr_store+0x20/0x2c)
      [ 1462.129826]  r7:dcabc7c0 r6:dee0ff80 r5:00000002 r4:bf228164
      [ 1462.135511] [<c023f738>] (dev_attr_store) from [<c0169310>] (sysfs_kf_write+0x48/0x4c)
      [ 1462.143459]  r5:00000002 r4:c023f738
      [ 1462.147049] [<c01692c8>] (sysfs_kf_write) from [<c0168ab8>] (kernfs_fop_write+0xf8/0x1f8)
      [ 1462.155258]  r5:00000002 r4:df4a1000
      [ 1462.158850] [<c01689c0>] (kernfs_fop_write) from [<c0100c78>] (__vfs_write+0x34/0x120)
      [ 1462.166800]  r10:00000000 r9:dee0e000 r8:c000fc24 r7:00000002 r6:dee0ff80 r5:c01689c0
      [ 1462.174660]  r4:df727a80
      [ 1462.177204] [<c0100c44>] (__vfs_write) from [<c0101ae4>] (vfs_write+0xac/0x170)
      [ 1462.184543]  r9:dee0e000 r8:c000fc24 r7:dee0ff80 r6:b6f092d0 r5:df727a80 r4:00000002
      [ 1462.192319] [<c0101a38>] (vfs_write) from [<c01028dc>] (SyS_write+0x4c/0xa8)
      [ 1462.199396]  r9:dee0e000 r8:c000fc24 r7:00000002 r6:b6f092d0 r5:df727a80 r4:df727a80
      [ 1462.207174] [<c0102890>] (SyS_write) from [<c000fa60>] (ret_fast_syscall+0x0/0x3c)
      [ 1462.214774]  r7:00000004 r6:ffffffff r5:00000000 r4:00000000
      [ 1462.220456] Code: bad PC value
      [ 1462.223560] ---[ end trace 676638a3a12c7a56 ]---
      Reported-by: default avatarRalph Sennhauser <ralph.sennhauser@gmail.com>
      Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
      Fixes: 0f247626 ("usb: core: Introduce a USB port LED trigger")
      Cc: stable@vger.kernel.org # 4.9+
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      89778ba3
    • Shuah Khan's avatar
      usbip: add missing compile time generated files to .gitignore · 71158c28
      Shuah Khan authored
      Add the following files to .gitignore
      
      compile
      libsrc/libusbip_la-sysfs_utils.lo
      libsrc/libusbip_la-usbip_device_driver.lo
      libsrc/libusbip_la-usbip_host_common.lo
      Signed-off-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      71158c28
  4. 05 Dec, 2016 10 commits
  5. 01 Dec, 2016 1 commit
  6. 30 Nov, 2016 2 commits
  7. 29 Nov, 2016 13 commits
  8. 28 Nov, 2016 4 commits
  9. 27 Nov, 2016 3 commits