- 31 May, 2018 6 commits
-
-
Tim Collier authored
A number of extern struct declarations in p80211types.h were causing checkpatch warnings: "extern prototypes should be avoided in .h files" and "function definition argument 'xxxxxx' should also have an identifier name". This appears to be a result of using a macro to form the declarations and checkpatch consequently misinterpreting the declarations as function prototypes. On checking, the declarations have no corresponding definition in the driver and are not used, so they are removed along with the macro used to construct them, which is not needed elsewhere. After this change, checkpatch reports that p80211types.h has no obvious issues. Signed-off-by:
Tim Collier <osdevtc@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Andrew Perepechko authored
The refill operation of the xattr cache does not know the reply size in advance, so it makes a guess based on the maxeasize value returned by the MDS. In practice, it allocates 16 KiB for the common case and 4 MiB for the large xattr case. However, a typical reply is just a few hundred bytes. If we follow the conservative approach, we can prepare a single memory page for the reply. It is large enough for any reasonable xattr set and, at the same time, it does not require multiple page memory reclaim, which can be costly. If, for a specific file, the reply is larger than a single page, the client is prepared to handle that and will fall back to non-cached xattr code. Indeed, if this happens often and xattrs are often used to store large values, it makes sense to disable the xattr cache at all since it wasn't designed for such [mis]use. Signed-off-by:
Andrew Perepechko <c17827@cray.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9417 Reviewed-on: https://review.whamcloud.com/26887Reviewed-by:
Fan Yong <fan.yong@intel.com> Reviewed-by:
Ben Evans <bevans@cray.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
Fan Yong authored
Originally, the limitation of ACL entries is 32, that is not enough for some use cases. In fact, restricting ACL entries count is mainly for preparing the RPC reply buffer to receive the ACL data. So we cannot make the ACL entries count to be unlimited. But we can enlarge the RPC reply buffer to hold more ACL entries. On the other hand, MDT backend filesystem has its own EA size limitation. For example, for ldiskfs case, if large EA enable, then the max ACL size is 1048492 bytes; otherwise, it is 4012 bytes. For ZFS backend, such value is 32768 bytes. With such hard limitation, we can calculate how many ACL entries we can have at most. This patch increases the RPC reply buffer to match such hard limitation. For old client, to avoid buffer overflow because of large ACL data (more than 32 ACL entries), the MDT will forbid the old client to access the file with large ACL data. As for how to know whether it is old client or new, a new connection flag OBD_CONNECT_LARGE_ACL is used for that. Signed-off-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
Li Xi <lixi@ddn.com> Reviewed-by:
Lai Siyao <lai.siyao@intel.com> Reviewed-by:
-
John L. Hammond authored
md_getxattr() and md_setxattr() each have several unused parameters. Remove them and improve the naming or remaining parameters. Signed-off-by:
John L. Hammond <john.hammond@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10792 Reviewed-on: https://review.whamcloud.com/Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
James Simmons <uja.ornl@yahoo.com> Signed-off-by:
-
Dmitry Eremin authored
Linux kernel v3.14 adds set_acl method to inode operations. This patch adds support to Lustre for proper acl management. Signed-off-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
-
James Simmons authored
Move ll_get_acl() to its own file acl.c just like all the other linux file systems do. Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142Signed-off-by:
-
- 26 May, 2018 3 commits
-
-
Greg Kroah-Hartman authored
And we need even more .h files to be included to build this file. So add kernel.h and module.h, and hopefully that's enough... Reported-by:
kbuild test robot <lkp@intel.com> Fixes: 0922c008 ("staging: lustre: remove libcfs_all from ptlrpc") Cc: NeilBrown <neilb@suse.com> Signed-off-by:
-
Greg Kroah-Hartman authored
Turns out we need some more .h files to build properly on all arches. Specifically errno.h for this file. Reported-by:
-
Greg Kroah-Hartman authored
Turns out we need some more .h files to build properly on all arches. Specifically prefetch.h for this file. Reported-by:
-
- 25 May, 2018 31 commits
-
-
Sergio Paracuellos authored
update TODO file accordly to last changes. Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Reviewed-by:
NeilBrown <neil@brown.name> Signed-off-by:
-
Sergio Paracuellos authored
There are some places where magic number '32' is being used to get the gpio bank. There already exist a definition MTK_BANK_WIDTH with this value, so just use it instead. Signed-off-by:
-
Sergio Paracuellos authored
This commits replaces if statement and two returns in favour of a only one return using a ternary operator. Signed-off-by:
-
Sergio Paracuellos authored
Driver probe function includes an allocation using devm_kzalloc which is "hidden" a bit inside the declarations. Extract this to a better place to increase readability. Also because we are allocating zeroed memory 'memset' statement is not needed at all. Condition for checking for a valid gpio id is wrong and it should be greater or equal instead of only greater so update to be the good one. Signed-off-by:
-
Sergio Paracuellos authored
Interrupt related stuff for gpio controller in mt7621 was missing in device tree documentation. Add it to complete documentation for this driver. Signed-off-by:
-
Sergio Paracuellos authored
The GPIO controller of mt7621 can receive interrupts on any of the GPIOs, either edge or level. It then interrupts the CPU using GIC INT12. Update device tree accordly. Signed-off-by:
-
Sergio Paracuellos authored
Gpio driver have a some globals which can be avoided just using platform_data in a proper form. This commit adds a new struct mtk_data which includes all of those globals setting them using platform_set_drvdata and devm_gpiochip_add_data functions. With this properly set we are able to retrieve driver data along the code using kernel api's so globals are not needed anymore. Signed-off-by:
-
Sergio Paracuellos authored
Gpio driver is using mtk and there is already 'mediatek' binding defined for this maker. Update driver to use it instead the custom one 'mtk'. Signed-off-by:
-
Sergio Paracuellos authored
Gpio driver for mt7621 is using 'mtk' as binding but in the kernel is already defined one for this maker which is 'mediatek'. Update device tree to use the correct one. Signed-off-by:
-
Sergio Paracuellos authored
This commit add missing dt bindings documentation for mt7621-gpio driver. There is some missing stuff here about interrupts with is not also being used in the mt7621.dtsi file. So just include in staging a incomplete version before moving this to kernel's dt-bindings place. Signed-off-by:
-
Quytelda Kahja authored
Fix a grammatical error in the comment describing 'struct rt_firmware_hdr'. Signed-off-by:
Quytelda Kahja <quytelda@tamalin.org> Signed-off-by:
-
Quytelda Kahja authored
Replace camel-case member names with snake-case names per the linux kernel coding style guidelines. Signed-off-by:
-
Quytelda Kahja authored
Fix the spelling/grammar errors in the comment block describing the 'Function' member of 'struct rt_firmware_hdr'. Signed-off-by:
-
Quytelda Kahja authored
Change the members of 'struct rt_firmware' to be snake case instead of camel-case, per the kernel coding style guide. Signed-off-by:
-
Quytelda Kahja authored
Change the parameter of the macro to the snake case 'fw_hdr' instead of '_pFwHdr'. Signed-off-by:
-
Quytelda Kahja authored
Make alignment and whitespace more consistent within the file 'rtl8723_hal.h' and with the kernel coding style guidelines. Signed-off-by:
-
Quytelda Kahja authored
Camel-case is discouraged in the linux kernel coding style. Rename this header file using snake case instead. Signed-off-by:
-
Quytelda Kahja authored
Camel-case is discouraged in the linux kernel coding style. Rename this header using snake case instead. Signed-off-by:
-
Quytelda Kahja authored
Camel-case naming is discouraged int the linux kernel coding style. Rename these files using snake case, and update the makefile to use the new names. Signed-off-by:
-
Arnd Bergmann authored
We can't select PTP_1588_CLOCK when posix timers are completely disabled: WARNING: unmet direct dependencies detected for PTP_1588_CLOCK Depends on [n]: NET [=y] && POSIX_TIMERS [=n] Selected by [y]: - FSL_DPAA2_PTP_CLOCK [=y] && STAGING [=y] && FSL_DPAA2_ETH [=y] This adds the necessary dependency. Fixes: 9bdf43b3 ("staging: fsl-dpaa2/rtc: add rtc driver") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Adham Abozaeid authored
Commit d4b4aaba ("staging: wilc1000: fix line over 80 characters in host_int_parse_join_bss_param()") introduced a bug by not keeping the rates_no value while parsing ies elements. It also increments auth_total_cnt as a pointer instead of its reference. This commit fixes the bug by passing reference to rates_no to host_int_parse_join_bss_param() and by incrementing reference of auth_total_cnt Fixes: d4b4aaba (staging: wilc1000: fix line over 80 characters in host_int_parse_join_bss_param()) Signed-off-by:
Adham Abozaeid <adham.abozaeid@microchip.com> Signed-off-by:
-
Tim Collier authored
To avoid possible issues with repeated reference to the macro argument as reported by checkpatch, macro P80211SKB_RXMETA is replaced with an equivalent inline function. The function is named p80211skb_rxmeta to follow the coding style guidelines; references to the macro are updated to reference the new function. This change depends on the similar change for P80211SKB_FRMMETA having been applied. Signed-off-by:
-
Tim Collier authored
To avoid possible issues with repeated reference to the macro argument as reported by checkpatch, macro P80211SKB_FRMMETA is replaced with an equivalent inline function. The function is named p80211skb_frmmeta to follow the coding style guidelines; references to the macro are updated to reference the new function. Signed-off-by:
-
Davide Spataro authored
Fix a spelling problem. Issue found by checkpatch.pl. Signed-off-by:
Davide Spataro <davide90.spataro@gmail.com> Signed-off-by:
-
Colin Ian King authored
Trivial fix to another spelling mistake in N_MSG message text Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistake in dev_err error message Signed-off-by:
Vaibhav Agarwal <vaibhav.sr@gmail.com> Acked-by:
Mark Greer <mgreer@animalcreek.com> Acked-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistake in ODM_RT_TRACE message text Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistake in netdev_err error message Signed-off-by:
Claudiu Beznea <claudiu.beznea@microchip.com> Signed-off-by:
-
Ivan Bornyakov authored
One may call 'CFS_FAIL_TIMEOUT(id, secs + 5);' and get unexpected result after macro substitution, viz., 'secs + 5' will turn into 'secs + 5 * 1000' Signed-off-by:
Ivan Bornyakov <brnkv.i1@gmail.com> Signed-off-by:
-
Sabin Mihai Rapan authored
This patch fixes the checkpatch.pl warning: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line Signed-off-by:
Sabin Mihai Rapan <sabin.rapan@gmail.com> Signed-off-by:
-
Sabin Mihai Rapan authored
This patch fixes the checkpatch.pl warning: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by:
-
