1. 11 Sep, 2012 2 commits
  2. 10 Sep, 2012 1 commit
    • Takashi Iwai's avatar
      ALSA: hda - Fix Oops at codec reset/reconfig · 07dc59f0
      Takashi Iwai authored
      snd_hda_codec_reset() calls restore_pincfgs() where the codec is
      powered up again, which eventually tries to resume and initialize via
      the callbacks of the codec.  However, it's the place just after codec
      free callback, thus no codec callbacks should be called after that.
      On a codec like CS4206, it results in Oops due to the access in init
      callback.
      
      This patch fixes the issue by clearing the codec callbacks properly
      after freeing codec.
      Reported-by: default avatarDaniel J Blueman <daniel@quora.org>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      07dc59f0
  3. 06 Sep, 2012 2 commits
    • Takashi Iwai's avatar
      ALSA: usb-audio: Fix bogus error messages for delay accounting · 1213a205
      Takashi Iwai authored
      The recent fix for the missing fine delayed time adjustment gives
      strange error messages at each start of the playback stream, such as
        delay: estimated 0, actual 352
        delay: estimated 353, actual 705
      
      These come from the sanity check in retire_playback_urb().  Before the
      stream is activated via start_endpoints(), a few silent packets have
      been already sent.  And at this point the delay account is still in
      the state as if the new packets are just queued, so the driver gets
      confused and spews the bogus error messages.
      
      For fixing the issue, we just need to check whether the received
      packet is valid, whether it's zero sized or not.
      Reported-by: default avatarMarkus Trippelsdorf <markus@trippelsdorf.de>
      Cc: <stable@vger.kernel.org> [v3.5+]
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      1213a205
    • Takashi Iwai's avatar
      ALSA: hda - Fix missing Master volume for STAC9200/925x · ab548d2d
      Takashi Iwai authored
      With the commit [2faa3bf1: ALSA: hda - Rewrite the mute-LED hook with
      vmaster hook in patch_sigmatel.c], the former Master volume control
      was converted to PCM.  This was supposed to be covered by the vmaster
      control.  But due to the lack of "PCM" slave definition, this didn't
      happen properly.  The patch fixes the missing entry.
      Reported-by: default avatarAndrew Shadura <bugzilla@tut.by>
      Cc: <stable@vger.kernel.org> [v3.4+]
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      ab548d2d
  4. 31 Aug, 2012 4 commits
    • Daniel Mack's avatar
      ALSA: snd-usb: fix cross-interface streaming devices · 2e4a263c
      Daniel Mack authored
      Commit 68e67f40 ("ALSA: snd-usb: move calls to usb_set_interface")
      saved us some unnecessary calls to snd_usb_set_interface() but ignored
      the fact that there is at least one device out there which operates on
      two endpoint in different interfaces simultaniously.
      
      Take care for this by catching the case where data and sync endpoints
      are located on different interfaces and calling snd_usb_set_interface()
      between the start of the two endpoints.
      Signed-off-by: default avatarDaniel Mack <zonque@gmail.com>
      Reported-by: default avatarRobert M. Albrecht <linux@romal.de>
      Cc: stable@kernel.org [v3.5+]
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      2e4a263c
    • Daniel Mack's avatar
      ALSA: snd-usb: fix calls to next_packet_size · 245baf98
      Daniel Mack authored
      In order to support devices with implicit feedback streaming models,
      packet sizes are now stored with each individual urb, and the PCM
      handling code which fills the buffers purely relies on the size fields
      now.
      
      However, calling snd_usb_audio_next_packet_size() for all possible
      packets in an URB at once, prior to letting the PCM code do its job
      does in fact not lead to the same behaviour than what the old code did:
      The PCM code will break its loop once a period boundary is reached,
      consequently using up less packets that it really could.
      
      As snd_usb_audio_next_packet_size() implements a feedback mechanism to
      the endpoints phase accumulator, the number of calls to that function
      matters, and when called too often, the data rate runs out of bounds.
      
      Fix this by making the next_packet function public, and call it from the
      PCM code as before if the packet data sizes are not defined.
      Signed-off-by: default avatarDaniel Mack <zonque@gmail.com>
      Cc: stable@kernel.org [v3.5+]
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      245baf98
    • Daniel Mack's avatar
      ALSA: snd-usb: restore delay information · fbcfbf5f
      Daniel Mack authored
      Parts of commit 294c4fb8 ("ALSA: usb: refine delay information with USB
      frame counter") were unfortunately lost during the refactoring of the
      snd-usb driver in 3.5.
      
      This patch adds them back, restoring the correct delay information
      behaviour.
      Signed-off-by: default avatarDaniel Mack <zonque@gmail.com>
      Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Cc: stable@kernel.org [3.5+]
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      fbcfbf5f
    • Pavel Roskin's avatar
      ALSA: snd-usb: use list_for_each_safe for endpoint resources · 03d2f44e
      Pavel Roskin authored
      snd_usb_endpoint_free() frees the structure that contains its argument.
      Signed-off-by: default avatarPavel Roskin <proski@gnu.org>
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      03d2f44e
  5. 30 Aug, 2012 1 commit
    • Daniel Mack's avatar
      ALSA: snd-usb: Fix URB cancellation at stream start · 015618b9
      Daniel Mack authored
      Commit e9ba389c ("ALSA: usb-audio: Fix scheduling-while-atomic bug in
      PCM capture stream") fixed a scheduling-while-atomic bug that happened
      when snd_usb_endpoint_start was called from the trigger callback, which
      is an atmic context. However, the patch breaks the idea of the endpoints
      reference counting, which is the reason why the driver has been
      refactored lately.
      
      Revert that commit and let snd_usb_endpoint_start() take care of the URB
      cancellation again. As this function is called from both atomic and
      non-atomic context, add a flag to denote whether the function may sleep.
      Signed-off-by: default avatarDaniel Mack <zonque@gmail.com>
      Cc: stable@kernel.org [3.5+]
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      015618b9
  6. 28 Aug, 2012 2 commits
  7. 22 Aug, 2012 1 commit
  8. 21 Aug, 2012 1 commit
  9. 20 Aug, 2012 12 commits
  10. 17 Aug, 2012 3 commits
  11. 16 Aug, 2012 2 commits
  12. 14 Aug, 2012 2 commits
  13. 13 Aug, 2012 4 commits
  14. 10 Aug, 2012 3 commits