- 01 Aug, 2007 3 commits
-
-
sebastian@breakpoint.cc authored
Fixes the following sparse warnings: net/sctp/sm_make_chunk.c:1457:9: warning: symbol 'len' shadows an earlier one net/sctp/sm_make_chunk.c:1356:23: originally declared here net/sctp/socket.c:1534:22: warning: symbol 'chunk' shadows an earlier one net/sctp/socket.c:1387:20: originally declared here Signed-off-by:
Sebastian Siewior <sebastian@breakpoint.cc> Signed-off-by:
Vlad Yasevich <vladislav.yasevich@hp.com>
-
sebastian@breakpoint.cc authored
sctp_chunk_cachep & sctp_bucket_cachep is used module global, so move it to a header file. Signed-off-by:
-
sebastian@breakpoint.cc authored
Forward declarion is static, the function itself is not. Make it consistent. Signed-off-by:
-
- 19 Jul, 2007 1 commit
-
-
YOSHIFUJI Hideaki authored
Signed-off-by:YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
-
- 06 Jul, 2007 2 commits
-
-
Vlad Yasevich authored
In-kernel sockets created with sock_create_kern don't usually have a file and file descriptor allocated to them. As a result, when SCTP tries to check the non-blocking flag, we Oops when dereferencing a NULL file pointer. Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vlad Yasevich authored
Correctly dereference bytes_copied in sctp_copy_laddrs(). I totally must have spaced when doing this. Signed-off-by:
-
- 26 Jun, 2007 1 commit
-
-
Zach Brown authored
sctp_sock_migrate() grabs the socket lock on a newly allocated socket while holding the socket lock on an old socket. lockdep worries that this might be a recursive lock attempt. task/3026 is trying to acquire lock: (sk_lock-AF_INET){--..}, at: [<ffffffff88105b8c>] sctp_sock_migrate+0x2e3/0x327 [sctp] but task is already holding lock: (sk_lock-AF_INET){--..}, at: [<ffffffff8810891f>] sctp_accept+0xdf/0x1e3 [sctp] This patch tells lockdep that this locking is safe by using lock_sock_nested(). Signed-off-by:Zach Brown <zach.brown@oracle.com> Signed-off-by:
-
- 19 Jun, 2007 2 commits
-
-
Neil Horman authored
This is the split out of the patch that we agreed I should split out from my last patch. It changes space_left to be computed in the same way the to variable is. I know we talked about changing space_left to an int, but I think size_t is more appropriate, since we should never have negative space in our buffer, and computing using offsetof means space_left should now never drop below zero. Signed-off-by:
Neil Horman <nhorman@tuxdriver.com> Acked-by:
Sridhar Samudrala <sri@us.ibm.com> Signed-off-by:
-
Neil Horman authored
I noted the other day while looking at a bug that was ostensibly in some perl networking library, that we strictly avoid allowing getsockopt operations to complete if we pass in oversized buffers. This seems to make libraries like Perl::NET malfunction since it seems to allocate oversized buffers for use in several operations. It also seems to be out of line with the way udp, tcp and ip getsockopt routines handle buffer input (since the *optlen pointer in both an input and an output and gets set to the length of the data that we copy into the buffer). This patch brings our getsockopt helpers into line with other protocols, and allows us to accept oversized buffers for our getsockopt operations. Tested by me with good results. Signed-off-by:
-
- 13 Jun, 2007 4 commits
-
-
Vlad Yasevich authored
Currently, if the socket is owned by the user, we drop the ICMP message. As a result SCTP forgets that path MTU changed and never adjusting it's estimate. This causes all subsequent packets to be fragmented. With this patch, we'll flag the association that it needs to udpate it's estimate based on the already updated routing information. Signed-off-by:
-
Vlad Yasevich authored
If the copy_to_user or copy_user calls fail in sctp_getsockopt_local_addrs(), the function should free locally allocated storage before returning error. Spotted by Coverity. Signed-off-by:
-
Vlad Yasevich authored
Allow sctp_bindx() to accept multiple address with unspecified port. In this case, all addresses inherit the first bound port. We still catch full mis-matches. Signed-off-by:
-
Vlad Yasevich authored
During peeloff of AF_INET6 socket, the inet6_sk(sk)->daddr wasn't set correctly since the code was assuming IPv4 only. Now we use a correct call to set the destination address. Signed-off-by:
-
- 11 May, 2007 2 commits
-
-
Vlad Yasevich authored
I broke the non-wildcard case recently. This is to fixes it. Now, explictitly bound addresses can ge retrieved using the API. Signed-off-by:
-
Vlad Yasevich authored
SCTP was checking for NULL when trying to detect hmac allocation failure where it should have been using IS_ERR. Also, print a rate limited warning to the log telling the user what happend. Signed-off-by:
-
- 09 May, 2007 1 commit
-
-
Michael Opdenacker authored
Signed-off-by:
Michael Opdenacker <michael@free-electrons.com> Signed-off-by:
Adrian Bunk <bunk@stusta.de>
-
- 04 May, 2007 2 commits
-
-
Vlad Yasevich authored
Update the SO_REUSEADDR handling to also check for listen state. This was muliple listening server sockets can't be created and they will not steal packets from each other. Reported by Paolo Galtieri <pgaltieri@mvista.com> Signed-off-by:
-
Vlad Yasevich authored
We need to make sure that all destination ports are the same, since the association really must not connect to multiple different ports at once. This was reported on the sctp-impl list. Signed-off-by:
-
- 29 Apr, 2007 1 commit
-
-
Vlad Yasevich authored
sctp_getsockopt_local_addrs_old() in net/sctp/socket.c calls copy_to_user() while the spinlock addr_lock is held. this should not be done as copy_to_user() might sleep. the call to sctp_copy_laddrs_to_user() while holding the lock is also problematic as it calls copy_to_user() Signed-off-by:
-
- 26 Apr, 2007 5 commits
-
-
Stephen Hemminger authored
Spring cleaning time... There seems to be a lot of places in the network code that have extra bogus semicolons after conditionals. Most commonly is a bogus semicolon after: switch() { } Signed-off-by:Stephen Hemminger <shemminger@linux-foundation.org> Signed-off-by:
-
Vlad Yasevich authored
Signed-off-by:
-
Vlad Yasevich authored
Parameters only take effect when a corresponding flag bit is set and a value is specified. This means we need to check the flags in addition to checking for non-zero value. Signed-off-by:
-
Vlad Yasevich authored
This option induces partial delivery to run as soon as the specified amount of data has been accumulated on the association. However, we give preference to fully reassembled messages over PD messages. In any case, window and buffer is freed up. Signed-off-by:
Vlad Yasevich <vladislav.yasevich@.hp.com> Signed-off-by:
-
Vlad Yasevich authored
This option was introduced in draft-ietf-tsvwg-sctpsocket-13. It prevents head-of-line blocking in the case of one-to-many endpoint. Applications enabling this option really must enable SCTP_SNDRCV event so that they would know where the data belongs. Based on an earlier patch by Ivan Skytte Jørgensen. Additionally, this functionality now permits multiple associations on the same endpoint to enter Partial Delivery. Applications should be extra careful, when using this functionality, to track EOR indicators. Signed-off-by:
-
- 17 Apr, 2007 2 commits
-
-
Paolo Galtieri authored
During the sctp_bindx() call to add additional addresses to the endpoint, any v4mapped addresses are converted and stored as regular v4 addresses. However, when trying to remove these addresses, the v4mapped addresses are not converted and the operation fails. This patch unmaps the addresses on during the remove operation as well. Signed-off-by:
Paolo Galtieri <pgaltieri@mvista.com> Signed-off-by:
-
Tsutomu Fujii authored
In current implementation, LKSCTP does receive buffer accounting for data in sctp_receive_queue and pd_lobby. However, LKSCTP don't do accounting for data in frag_list when data is fragmented. In addition, LKSCTP doesn't do accounting for data in reasm and lobby queue in structure sctp_ulpq. When there are date in these queue, assertion failed message is printed in inet_sock_destruct because sk_rmem_alloc of oldsk does not become 0 when socket is destroyed. Signed-off-by:
Tsutomu Fujii <t-fujii@nb.jp.nec.com> Signed-off-by:
-
- 11 Feb, 2007 1 commit
-
-
YOSHIFUJI Hideaki authored
Signed-off-by:
-
- 22 Dec, 2006 1 commit
-
-
Ivan Skytte Jorgensen authored
Signed-off-by:
Ivan Skytte Jorgensen <isj-sctp@i1.dk> Signed-off-by:
-
- 14 Dec, 2006 2 commits
-
-
Ivan Skytte Jorgensen authored
Signed-off-by:
-
Sridhar Samudrala authored
Currently in SCTP, we maintain a local address list by rebuilding the whole list from the device list whenever we get a address add/delete event. This patch fixes it by only adding/deleting the address for which we receive the event. Also removed the sctp_local_addr_lock() which is no longer needed as we now use list_for_each_safe() to traverse this list. This fixes the bugs in sctp_copy_laddrs_xxx() routines where we do copy_to_user() while holding this lock. Signed-off-by:
-
- 07 Dec, 2006 2 commits
-
-
Christoph Lameter authored
Replace all uses of kmem_cache_t with struct kmem_cache. The patch was generated using the following script: #!/bin/sh # # Replace one string by another in all the kernel sources. # set -e for file in `find * -name "*.c" -o -name "*.h"|xargs grep -l $1`; do quilt add $file sed -e "1,\$s/$1/$2/g" $file >/tmp/$$ mv /tmp/$$ $file quilt refresh done The script was run like this sh replace kmem_cache_t "struct kmem_cache" Signed-off-by:
Christoph Lameter <clameter@sgi.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Christoph Lameter authored
SLAB_ATOMIC is an alias of GFP_ATOMIC Signed-off-by:
-
- 03 Dec, 2006 8 commits
-
-
Al Viro authored
Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk> Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
... switched to taking and returning pointers to net-endian sctp_addr resp. Together, since the only user of sctp_find_unmatch_addr() just passes its value to sctp_make_asconf_update_ip(). sctp_make_asconf_update_ip() is actually endian-agnostic. Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Ditto for its only caller (sctp_endpoint_is_peeled_off) Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
