- 28 Jan, 2024 1 commit
-
-
Huacai Chen authored
When a Loongson laptop is equipped with a Radeon GPU, it can be true that there is no dedicated VRAM soldered on the motherboard. This is probably for cost reason, but drm/loongson driver is probed because the platform BIOS (either UEFI or PMON) forget to disable the integrated GPU. So in the lsdc_get_dedicated_vram() function, we error out if no dedicated VRAM detected. This fix nothing, but serve as a sanity check only. Tested-by:
Xiaotian Wu <wuxiaotian@loongson.cn> Signed-off-by:
Huacai Chen <chenhuacai@loongson.cn> Reviewed-by:
Sui Jingfeng <sui.jingfeng@linux.dev> Signed-off-by:
-
- 26 Jan, 2024 3 commits
-
-
Zack Rusin authored
Some drivers require the mapped tt pages to be decrypted. In an ideal world this would have been handled by the dma layer, but the TTM page fault handling would have to be rewritten to able to do that. A side-effect of the TTM page fault handling is using a dma allocation per order (via ttm_pool_alloc_page) which makes it impossible to just trivially use dma_mmap_attrs. As a result ttm has to be very careful about trying to make its pgprot for the mapped tt pages match what the dma layer thinks it is. At the ttm layer it's possible to deduce the requirement to have tt pages decrypted by checking whether coherent dma allocations have been requested and the system is running with confidential computing technologies. This approach isn't ideal but keeping TTM matching DMAs expectations for the page properties is in general fragile, unfortunately proper fix would require a rewrite of TTM's page fault handling. Fixes vmwgfx with SEV enabled. v2: Explicitly include cc_platform.h v3: Use CC_ATTR_GUEST_MEM_ENCRYPT instead of CC_ATTR_MEM_ENCRYPT to limit the scope to guests and log when memory decryption is enabled. Signed-off-by:
Zack Rusin <zack.rusin@broadcom.com> Fixes: 3bf3710e ("drm/ttm: Add a generic TTM memcpy move for page-based iomem") Reviewed-by:
Thomas Hellström <thomas.hellstrom@linux.intel.com> Acked-by:
Christian König <christian.koenig@amd.com> Cc: Huang Rui <ray.huang@amd.com> Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Cc: <stable@vger.kernel.org> # v5.14+ Link: https://patchwork.freedesktop.org/patch/msgid/20230926040359.3040017-1-zack@kde.org
-
Zack Rusin authored
vmw_context_cotable can return either an error or a null pointer and its usage sometimes went unchecked. Subsequent code would then try to access either a null pointer or an error value. The invalid dereferences were only possible with malformed userspace apps which never properly initialized the rendering contexts. Check the results of vmw_context_cotable to fix the invalid derefs. Thanks: ziming zhang(@ezrak1e) from Ant Group Light-Year Security Lab who was the first person to discover it. Niels De Graef who reported it and helped to track down the poc. Fixes: 9c079b8c ("drm/vmwgfx: Adapt execbuf to the new validation api") Cc: <stable@vger.kernel.org> # v4.20+ Reported-by:
Niels De Graef <ndegraef@redhat.com> Signed-off-by:
Maaz Mombasawala <maaz.mombasawala@broadcom.com> Reviewed-by:
Martin Krastev <martin.krastev@broadcom.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240110200305.94086-1-zack.rusin@broadcom.com
-
Ian Forbes authored
Without this definition device errors will display the command name as (null) when debug logging is enabled. Signed-off-by:
Ian Forbes <ian.forbes@broadcom.com> Signed-off-by:
-
- 25 Jan, 2024 1 commit
-
-
Somalapuram Amaranath authored
Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ERROR on drm-tip/drm-tip v4: fix some typos pointed out by checkpatch v5: cleanup some rebase problems with VMWGFX v6: implement some missing VMWGFX functionality pointed out by Zack, rename the flags as suggested by Michel, rebase on drm-tip and adjust XE as well Signed-off-by:Somalapuram Amaranath <Amaranath.Somalapuram@amd.com> Reviewed-by:
Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by:
-
- 24 Jan, 2024 1 commit
-
-
Christian König authored
Only convert it to ENOMEM in ttm_bo_validate. This allows ttm_bo_validate to distinguish between an out of memory situation and just out of space in a placement domain. v2: improve commit message v3: fix kerneldoc typos Signed-off-by:
-
- 23 Jan, 2024 6 commits
-
-
Tomi Valkeinen authored
The driver never unregisters the audio codec platform device, which can lead to a crash on module reloading, nor does it handle the return value from sii902x_audio_codec_init(). Signed-off-by:
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Fixes: ff578163 ("drm/bridge: sii902x: Implement HDMI audio support") Cc: Jyri Sarha <jsarha@ti.com> Reviewed-by:
Aradhya Bhatia <a-bhatia1@ti.com> Acked-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240103-si902x-fixes-v1-2-b9fd3e448411@ideasonboard.com
-
Tomi Valkeinen authored
A null pointer dereference crash has been observed rarely on TI platforms using sii9022 bridge: [ 53.271356] sii902x_get_edid+0x34/0x70 [sii902x] [ 53.276066] sii902x_bridge_get_edid+0x14/0x20 [sii902x] [ 53.281381] drm_bridge_get_edid+0x20/0x34 [drm] [ 53.286305] drm_bridge_connector_get_modes+0x8c/0xcc [drm_kms_helper] [ 53.292955] drm_helper_probe_single_connector_modes+0x190/0x538 [drm_kms_helper] [ 53.300510] drm_client_modeset_probe+0x1f0/0xbd4 [drm] [ 53.305958] __drm_fb_helper_initial_config_and_unlock+0x50/0x510 [drm_kms_helper] [ 53.313611] drm_fb_helper_initial_config+0x48/0x58 [drm_kms_helper] [ 53.320039] drm_fbdev_dma_client_hotplug+0x84/0xd4 [drm_dma_helper] [ 53.326401] drm_client_register+0x5c/0xa0 [drm] [ 53.331216] drm_fbdev_dma_setup+0xc8/0x13c [drm_dma_helper] [ 53.336881] tidss_probe+0x128/0x264 [tidss] [ 53.341174] platform_probe+0x68/0xc4 [ 53.344841] really_probe+0x188/0x3c4 [ 53.348501] __driver_probe_device+0x7c/0x16c [ 53.352854] driver_probe_device+0x3c/0x10c [ 53.357033] __device_attach_driver+0xbc/0x158 [ 53.361472] bus_for_each_drv+0x88/0xe8 [ 53.365303] __device_attach+0xa0/0x1b4 [ 53.369135] device_initial_probe+0x14/0x20 [ 53.373314] bus_probe_device+0xb0/0xb4 [ 53.377145] deferred_probe_work_func+0xcc/0x124 [ 53.381757] process_one_work+0x1f0/0x518 [ 53.385770] worker_thread+0x1e8/0x3dc [ 53.389519] kthread+0x11c/0x120 [ 53.392750] ret_from_fork+0x10/0x20 The issue here is as follows: - tidss probes, but is deferred as sii902x is still missing. - sii902x starts probing and enters sii902x_init(). - sii902x calls drm_bridge_add(). Now the sii902x bridge is ready from DRM's perspective. - sii902x calls sii902x_audio_codec_init() and platform_device_register_data() - The registration of the audio platform device causes probing of the deferred devices. - tidss probes, which eventually causes sii902x_bridge_get_edid() to be called. - sii902x_bridge_get_edid() tries to use the i2c to read the edid. However, the sii902x driver has not set up the i2c part yet, leading to the crash. Fix this by moving the drm_bridge_add() to the end of the sii902x_init(), which is also at the very end of sii902x_probe(). Signed-off-by:
-
Marek Vasut authored
According to new configuration spreadsheet from Toshiba for TC9595, the Pixel PLL input clock have to be in range 6..40 MHz. The sheet calculates those PLL input clock as reference clock divided by both pre-dividers. Add the extra limit. Signed-off-by:
Marek Vasut <marex@denx.de> Reviewed-by:
Lucas Stach <l.stach@pengutronix.de> Signed-off-by:
-
Thomas Zimmermann authored
Enable support for nomodeset= parameter via CONFIG_VIDEO. Both, DRM and fbdev, already select this option. Remove the existing option CONFIG_VIDEO_NOMODESET. Simplifies the Kconfig rules. Signed-off-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20240118090721.7995-4-tzimmermann@suse.de
-
Thomas Zimmermann authored
The function __video_get_options() only exists for compatibility with old fbdev drivers that cannot be refactored easily. Hide it behind CONFIG_FB_CORE. v2: * support CONFIG_FB_CORE=m via IS_ENABLED() (kernel test robot) Signed-off-by:
-
Thomas Zimmermann authored
Add CONFIG_VIDEO for common code in drivers/video/. Use the option to select helpers for the video= parameter. Replaces CONFIG_VIDEO_CMDLINE. Other common code in drivers/video/ can be moved behind CONFIG_VIDEO, which will simplify the Kconfig rules. Signed-off-by:
-
- 22 Jan, 2024 5 commits
-
-
Thomas Hellström authored
The relatively recently introduced drm/exec utility was using uint32_t in its interface, which was then also carried over to drm/gpuvm. Prefer u32 in new code and update drm/exec and drm/gpuvm accordingly. Cc: Christian König <christian.koenig@amd.com> Cc: Danilo Krummrich <dakr@redhat.com> Signed-off-by:
Danilo Krummrich <dakr@redhat.com> Reviewed-by:
Lucas De Marchi <lucas.demarchi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240119090557.6360-1-thomas.hellstrom@linux.intel.com
-
Alexander Stein authored
Ensure the device has been setup correctly before registering the v4l2 async device, thus allowing userspace to access. Signed-off-by:
Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by:
-
Dario Binacchi authored
The patch completes the setting of CLKLANE_STOP for the imx8m{m,n,p} platforms (i. e. not exynos). Co-developed-by:Michael Trimarchi <michael@amarulasolutions.com> Signed-off-by:
Dario Binacchi <dario.binacchi@amarulasolutions.com> Reviewed-by:
-
Dario Binacchi authored
The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the pre_enabled() and enabled() of the bridge. So, the bridge can enter display mode only in the enabled(). The unprepare() of the panel-bridge is instead called between the disable() and post_disable() of the bridge. So, the disable() must exit the display mode (i .e. enter command mode) to allow the panel-bridge to receive DSI commands. samsung_dsim_atomic_pre_enable -> command mode r63353_panel_prepare -> send DSI commands samsung_dsim_atomic_enable -> enter display mode samsung_dsim_atomic_disable -> exit display mode (command mode) r63353_panel_unprepare -> send DSI commands samsung_dsim_atomic_post_disable Co-developed-by:
-
Christian König authored
Seems to be unused. Signed-off-by:
-
- 19 Jan, 2024 5 commits
-
-
Rodrigo Vivi authored
The file has already been deleted as the tasks were completed. However the index reference was missed behind. fixes a doc build warning: Documentation/gpu/rfc/index.rst:35: WARNING: toctree contains reference to nonexisting document 'gpu/rfc/xe' Fixes: d11dc7aa ("drm/doc/rfc: Remove Xe's pre-merge plan") Cc: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by:
Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by:
Matthew Auld <matthew.auld@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240116220331.145607-1-rodrigo.vivi@intel.com
-
Thomas Zimmermann authored
Add two articles on LWN about the Linux graphics stack to DRM's list of external references. The articles document the graphics output as a whole, including the kernel side. Signed-off-by:
Simon Ser <contact@emersion.fr> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240115113908.25897-1-tzimmermann@suse.de
-
Ritesh Kumar authored
Include <linux/of.h> instead of <linux/of_device.h> to fix below compilation errors: drivers/gpu/drm/panel/panel-novatek-nt36672e.c:564:14: error: implicit declaration of function 'of_device_get_match_data' ctx->desc = of_device_get_match_data(dev); ^ drivers/gpu/drm/panel/panel-novatek-nt36672e.c:622:34: error: array type has incomplete element type 'struct of_device_id' static const struct of_device_id nt36672e_of_match[] = { ^ Signed-off-by:Ritesh Kumar <quic_riteshk@quicinc.com> Fixes: ea4f9975 ("drm/panel: Add support for Novatek NT36672E panel driver") Reviewed-by:
Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by:
-
Samuel Dionne-Riel authored
This adds a DMI orientation quirk for the GPD Win Mini panel. Signed-off-by:
Samuel Dionne-Riel <samuel@dionne-riel.com> Signed-off-by:
-
Zhipeng Lu authored
When lima_vm_map_bo fails, the resources need to be deallocated, or there will be memleaks. Fixes: 6aebc51d ("drm/lima: support heap buffer creation") Signed-off-by:
Zhipeng Lu <alexious@zju.edu.cn> Signed-off-by:
Qiang Yu <yuq825@gmail.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240117071328.3811480-1-alexious@zju.edu.cn
-
- 17 Jan, 2024 6 commits
-
-
Michał Winiarski authored
Add a simple test that checks whether the action is called when drmm_managed_release is called. Signed-off-by:
Michał Winiarski <michal.winiarski@intel.com> Signed-off-by:
Maxime Ripard <mripard@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240115171351.504264-6-michal.winiarski@intel.com
-
Michał Winiarski authored
It simplifies the process of extending the test suite with additional test cases without unnecessary duplication. Signed-off-by:
-
Michał Winiarski authored
Add comments explaining the intention behind the test and certain implementation details related to device lifetime. Signed-off-by:
-
Michał Winiarski authored
DRM tests use "_" rather than "-" as word separator. Rename the test suite to match other tests. Signed-off-by:
-
Michał Winiarski authored
Similar to devres equivalent, it allows to call the "release" action directly and remove the resource from the managed resources list. Signed-off-by:
-
Alex Bee authored
Commit d3e040f4 ("drm/rockchip: inno_hdmi: Get rid of mode_set") started using drm_atomic_get_new_connector_state and drm_atomic_get_new_crtc_state which are defined in drm_atomic.h Building does currently only work if CONFIG_OF and CONFIG_DRM_PANEL_BRIDGE are enabled since this will include drm_atomic.h via drm_bridge.h (see drm_of.h). Explicitly include drm_atomic.h in inno_hdmi.c to fix this. Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401100949.ZVRr0pIa-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202401081720.UtgAZgba-lkp@intel.com/ Fixes: d3e040f4 ("drm/rockchip: inno_hdmi: Get rid of mode_set") Signed-off-by:
Alex Bee <knaerzche@gmail.com> Signed-off-by:
-
- 16 Jan, 2024 1 commit
-
-
Jani Nikula authored
hdmi-codec.h does not appear to directly need drm/drm_edid.h for anything. Remove it. There are some files that get drm/drm_edid.h by proxy; include it where needed. v2-v4: Fix build (kernel test robot <lkp@intel.com>) Cc: Rob Clark <robdclark@gmail.com> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Sean Paul <sean@poorly.run> Cc: Marijn Suijten <marijn.suijten@somainline.org> Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: Andrzej Hajda <andrzej.hajda@intel.com> Cc: Neil Armstrong <neil.armstrong@linaro.org> Cc: Robert Foss <rfoss@kernel.org> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Jonas Karlman <jonas@kwiboo.se> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: linux-sound@vger.kernel.org Acked-by:
Andi Shyti <andi.shyti@linux.intel.com> Acked-by:
Alex Deucher <alexander.deucher@amd.com> Reviewed-by: <jyri.sarha@linux.intel.com> Signed-off-by:
Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240104201632.1100753-3-jani.nikula@intel.com
-
- 15 Jan, 2024 5 commits
-
-
Vignesh Raman authored
Add job that executes the IGT test suite for sc7180-trogdor-kingoftown. This commit also updates xfails for sc7180-trogdor-lazor-limozeen. Signed-off-by:
Vignesh Raman <vignesh.raman@collabora.com> Acked-by:
Helen Koike <helen.koike@collabora.com> Signed-off-by:
-
Vignesh Raman authored
build-kdl.sh was doing a `clone --depth 1` of the default branch, then checking out a commit that might not be the latest of that branch, resulting in container build error. https://gitlab.freedesktop.org/mesa/mesa/-/commit/5efa4d56 fixes kdl commit fetch issue. Uprev mesa in drm-ci to fix this. This commit updates the kernel tag and adds .never-post-merge-rules due to the mesa uprev. It also fixes an issue where the virtio-gpu pipeline was not getting created with the mesa uprev. Reviewed-by:
David Heidelberg <david.heidelberg@collabora.com> Acked-by:
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Tested-by:
Abhinav Kumar <quic_abhinavk@quicinc.com> Signed-off-by:
-
Vignesh Raman authored
msm tests are added to testlist.txt, so update the xfails for jobs in msm stage. Signed-off-by:
-
Rob Clark authored
The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere. Signed-off-by:
Rob Clark <robdclark@chromium.org> Reviewed-by:
-
Jianhua Lu authored
After commit e6c0de5f ("drm/msm/dpu: try multirect based on mdp clock limits") merged, 120Hz is working on xiaomi,elish panels, so feature it. Signed-off-by:
Jianhua Lu <lujianhua000@gmail.com> Reviewed-by:
Jessica Zhang <quic_jesszhan@quicinc.com> Link: https://lore.kernel.org/r/20240112140047.18123-1-lujianhua000@gmail.comSigned-off-by:
-
- 12 Jan, 2024 6 commits
-
-
Randy Dunlap authored
Fix spelling mistakes as reported by codespell. Signed-off-by:
Randy Dunlap <rdunlap@infradead.org> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Gustavo Padovan <gustavo@padovan.org> Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Christian König <christian.koenig@amd.com> Cc: linaro-mm-sig@lists.linaro.org Signed-off-by:
-
Randy Dunlap authored
Fix spelling mistakes as reported by codespell. Signed-off-by:
-
Randy Dunlap authored
The functions that were described in this section of drm-internals.rst were removed in NOV-2023, along with all of the kernel-doc comments in the source file. This now causes a docs build warning, so remove that section of the documentation also. drivers/gpu/drm/drm_pci.c:1: warning: no structured comments found Fixes: 2504c7ec ("drm: Remove source code for non-KMS drivers") Signed-off-by:
-
Lukas Bulwahn authored
As config FRAMEBUFFER_CONSOLE already selects VT_HW_CONSOLE_BINDING, there is no need for any drm driver to repeat that rule for selecting. Remove those duplications of selecting VT_HW_CONSOLE_BINDING. Signed-off-by:
Lukas Bulwahn <lukas.bulwahn@gmail.com> [sima: Note that this is only correct since a5ae331e ("drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION") because select in Kconfig isn't recursive and so needs to be replicated.] Signed-off-by:
-
Chen Haonan authored
dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by:
Chen Haonan <chen.haonan2@zte.com.cn> Reviewed-by:
-
Ritesh Kumar authored
Add support for the 1080x2408 Novatek NT36672E video mode DSI panel driver. Signed-off-by:
-
