- 20 Mar, 2014 33 commits
-
-
Emil Tantilov authored
This patch moves the call to enable Tx queues after the link is established. Previously there was a chance for aggressive start_ndo_xmit() callers to sneak packets between enabling the Tx queues and the link coming up. In addition it replaces netif_tx_start_all_queues() with netif_tx_wake_all_queues() to allow for flushing of the qdisc. CC: Arun Sharma <asharma@fb.com> Signed-off-by:
Emil Tantilov <emil.s.tantilov@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-
Don Skidmore authored
We use to cache whether the MNG FW was enabled, how since this isn't static we really need to verify with each check. This patch makes that change. CC: Arun Sharma <asharma@fb.com> Signed-off-by:
Don Skidmore <donald.c.skidmore@intel.com> Tested-by:
Phil Schmitt <phillip.j.schmitt@intel.com> Signed-off-by:
-
Jacob Keller authored
Rather than assign several parameters in a row, we should use a for loop, which reduces code size. CC: Arun Sharma <asharma@fb.com> Signed-off-by:
Jacob Keller <jacob.e.keller@intel.com> Tested-by:
-
Jacob Keller authored
This patch replaces some direct uses of pci_read_config_word with the protected ixgbe_read_pci_cfg_word function, which checks for whether the adapter is removed when LER is enabled. We shouldn't use the pci_read_config_word calls directly because of these checks. This patch also cleans up an unnecessary save of a pointer to the mac object, as our standard style is to just use the hw pointer. CC: Arun Sharma <asharma@fb.com> Signed-off-by:
-
Jacob Keller authored
This patch reverts the addition of the fiber_fixed type, which ended up never being used. We don't have plans to support this type going forward, and there is no reason to keep an unused type around polluting the code. Reverts: 4e8e1bca ("ixgbe: add new media type") CC: Arun Sharma <asharma@fb.com> Signed-off-by:
-
Jacob Keller authored
This patch fixes flow control autonegotiation for KR/KX/K4 interfaces. When setting up MAC link, the cached autoc value and current autoc value were being incorrectly used to determine whether link reset is required. This resulted in the driver ignoring and discarding flow control negotiation changes that occur since the caching happened, as well as when the mac was being setup. This patch also splits the assignments for the 3 autoc variables into their own block, and adds a comment explaining what each one means, in order to help keep logic more straightforward while reading the code. CC: Arun Sharma <asharma@fb.com> Reported-by:
Sourav Chatterjee <sourav.chatterjee@intel.com> Signed-off-by:
-
Jacob Keller authored
Previously, we did a full check to see if MNG FW was running. Instead, we should only check to see whether it could be enabled. Since it may become active while down, we don't want to bring the link down. CC: Arun Sharma <asharma@fb.com> Signed-off-by:
-
Jacob Keller authored
This patch corrects the stop_mac_link_on_d3 function in ixgbe_82599 by checking the Core Clock Disable bit before stopping link. CC: Arun Sharma <asharma@fb.com> Reported-by:
Chris Pavlas <chris.pavlas@intel.com> Signed-off-by:
-
Don Skidmore authored
Found several incorrect conditionals after calling the prot_autoc_* functions. Likewise we weren't always freeing the FWSW semaphore after grabbing it. This would lead to DA cables being unable to link along with possible other errors. CC: Arun Sharma <asharma@fb.com> CC: Emil Tantilov <emil.s.tantilov@intel.com> Signed-off-by:
-
Joe Perches authored
The use of __constant_<foo> has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by:
Joe Perches <joe@perches.com> Tested-by:
-
Joe Perches authored
The use of __constant_<foo> has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by:
-
Joe Perches authored
The use of __constant_<foo> has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by:
Aaron Brown <aaron.f.brown@intel.com> Signed-off-by:
-
Joe Perches authored
The use of __constant_<foo> has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by:
-
Joe Perches authored
The use of __constant_<foo> has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by:
-
Stefan Assmann authored
For i350 VLAN stripping for VMs is not enabled in the VMOLR register but in the DVMOLR register. Making the changes accordingly. It's not necessary to unset the E1000_VMOLR_STRVLAN bit on i350 as the hardware will simply ignore it. Without this change if a VLAN is configured for a VF assigned to a guest via (i.e.) ip link set p1p1 vf 0 vlan 10 the VLAN tag will not be stripped from packets going into the VM. Which they should be because the VM itself is not aware of the VLAN at all. Signed-off-by:
Stefan Assmann <sassmann@kpanic.de> Tested-by:
Sibai Li <sibai.li@intel.com> Signed-off-by:
-
Stefan Raspl authored
The current code would always return 0 for VLAN-encapsulated IP traffic. One notable side effect was that VLAN traffic would never get prioritized on OSD and OSX devices when priority queueing modes prio_queueing_tos or prio_queueing_prec were enabled. Signed-off-by:
Stefan Raspl <raspl@linux.vnet.ibm.com> Signed-off-by:
Frank Blaschka <frank.blaschka@de.ibm.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Stefan Raspl authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by:
-
Ursula Braun authored
Commit f9c41a62 introduced a problem for SOCK_STREAM sockets, when only part of the incoming iucv message is received by user space. In this case the remaining data of the iucv message is lost. This patch makes sure an incompletely received iucv message is queued back to the receive queue. Signed-off-by:
Ursula Braun <ursula.braun@de.ibm.com> Signed-off-by:
Hendrik Brueckner <brueckner@linux.vnet.ibm.com> Signed-off-by:
-
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-nextDavid S. Miller authored
Jeff Kirsher says: ==================== Intel Wired LAN Driver Updates This series contains updates to i40e, i40evf, e1000e, ixgbe and ixgbevf. Mitch adds support for the VF link state ndo which allows the PF driver to control the virtual link state of the VF devices. Added support for viewing and modifying RSS hash options and RSS hash look-up table programming through ethtool for i40evf. Fixed complaint about the use of min() where min_t() should be used in i40evf. Anjali adds support for ethtool -k option for NTUPLE control for i40e. Elizabeth cleans up and refactors i40e_open() to separate out the VSI code into its own i40e_vsi_open(). Jesse enables the hardware feature head write back to avoid updating the descriptor ring by marking each descriptor with a DD bit and instead writes a memory location with an update to where the driver should clean up to in i40e and i40evf. Reduces context descriptors for i40e/i40evf since we do not need context descriptors for every packet, only for TSO or timesync. Dan Carpenter fixes a potential array underflow in i40e_vc_process_vf_msg(). Dave fixes an e1000e hardware unit hang where the check for pending Tx work when link is lost was mistakenly moved to be done only when link is first detected to be lost. Fixed a problem with poor network performance on certain silicon in e1000e when configured for 100M HDX performance. Carolyn adds register defines needed for time sync functions and the code to call the updated defines. Jacob adds the ixgbe function for writing PCI config word and checks whether the adapter has been removed first. Mark adds the bit __IXGBEVF_REMOVING to indicate that the module is being removed because the __IXGBEVF_DOWN bit had been overloaded for this purpose, but leads to trouble. ixgbevf_down function can now prevent multiple executions by doing test_and_set_bit on __IXGBEVF_DOWN. v2: - dropped patch Mitch's patch "i40evf: Support RSS option in ethtool" based on feedback from Ben Hutchings so that Mitch can re-work the patch solution v3: - removed unnecessary parenthesis in patch 1 based on feedback from David Miller - changed a macro to get the next queue to a function in patch 2 based on feedback from David Miller - added blank lines after variable declaration and code in two functions in patch 6 based on feedback from David Miller ==================== Signed-off-by: -
Mark Rustad authored
The ixgbevf_down function can now prevent multiple executions by doing test_and_set_bit on __IXGBEVF_DOWN. This did not work before introduction of the __IXGBEVF_REMOVING bit, because of overloading of __IXGBEVF_DOWN. Also add smp_mb__before_clear_bit call before clearing the __IXGBEVF_DOWN bit. Signed-off-by:
Mark Rustad <mark.d.rustad@intel.com> Tested-by:
-
Mark Rustad authored
Add a bit, __IXGBEVF_REMOVING, to indicate that the module is being removed. The __IXGBEVF_DOWN bit had been overloaded for this purpose, but that leads to trouble. A few places now check both __IXGBEVF_DOWN and __IXGBEVF_REMOVING. Signed-off-by:
-
Jacob Keller authored
Inline with the current use for ixgbe_read_pci_cfg_word, create a similar function for writing PCI config, which checks whether the adapter has been removed first, if Live Error Recovery has been enabled. Signed-off-by:
-
Carolyn Wyborny authored
This patch adds defines needed for implementing the auxiliary time sync functions and also changes code to call the updated defines instead of the old. Reported-by:
Richard Cochran <ricahrdcochran@gmail.com> Signed-off-by:
Carolyn Wyborny <carolyn.wyborny@intel.com> Tested-by:
-
David Ertman authored
This patch causes the TCTL to be explicitly set to fix a problem with poor network performance (throughput) on certain silicon when configured for 100M HDX performance. Cc: Todd Fujinaka <todd.fujinaka@intel.com> Signed-off-by:
Dave Ertman <davidx.m.ertman@intel.com> Acked-by:
Bruce W. Allan <bruce.w.allan@intel.com> Tested-by:
Jeff Pieper <jeffrey.e.pieper@intel.com> Signed-off-by:
-
David Ertman authored
The check for pending Tx work when link is lost was mistakenly moved to be done only when link is first detected to be lost. It turns out there is a small window of opportunity for additional Tx work to get queued up shortly after link is dropped. Move the check back to the place it was before in the watchdog task. Put in additional debug information for other reset paths and a final catch-all for false hangs in the scheduled function that prints out the hardware hang message. Signed-off-by:
-
Catherine Sullivan authored
Bump to version 0.3.36 for i40e and 0.9.16 for i40evf. Change-ID: I7b4ff97b32d2825181803c03c316381a7608a618 Signed-off-by:
Catherine Sullivan <catherine.sullivan@intel.com> Tested-by:
Kavindya Deegala <kavindya.s.deegala@intel.com> Signed-off-by:
-
Dan Carpenter authored
If "vf_id" is smaller than hw->func_caps.vf_base_id then it leads to an array underflow of the pf->vf[] array. This is unlikely to happen unless the hardware is bad, but it's a small change and it silences a static checker warning. Fixes: 7efa84b7 ('i40e: support VFs on PFs other than 0') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Tested-by:
-
Jesse Brandeburg authored
We don't need context descriptors for every packet, only tso or timesync. This fixes a bug in the driver where it would always add a context even if all the passed in values to the context descriptor function were 0/default values. Change-ID: I0101d2b893380707b5c2de61aab3e16d4310e9a1 Signed-off-by:
Jesse Brandeburg <jesse.brandeburg@intel.com> Signed-off-by:
-
Jesse Brandeburg authored
The hardware supports a feature to avoid updating the descriptor ring by marking each descriptor with a DD bit, and instead writes a memory location with an update to where the driver should clean up to. Enable this feature. Change-ID: I5da4e0681f0b581a6401c950a81808792267fe57 Signed-off-by:
Mitch Williams <mitch.a.williams@intel.com> Signed-off-by:
-
Elizabeth Kappler authored
This patch cleans up and moves a portion of i40e_open to i40e_vsi_open, in order to have a shorter vsi_open function that does only that. Change-ID: I1c418dda94dcfc0eb7d4386a70c330692ef5ecc9 Signed-off-by:
Elizabeth Kappler <elizabeth.m.kappler@intel.com> Signed-off-by:
Akeem G Abodunrin <akeem.g.abodunrin@intel.com> Signed-off-by:
-
Anjali Singhai Jain authored
This enables option '-k/-K' in ethtool for NTUPLE control. NTUPLE control requires a reset, to take effect. When the feature is turned off, the SW list of stored FD SB filters gets cleaned up. Change-ID: I9d564b67a10d4afa11de3b320d601c3d2e6edc1f Signed-off-by:
Anjali Singhai Jain <anjali.singhai@intel.com> Signed-off-by:
-
Mitch Williams authored
Checkpatch complained in an earlier patch about using min(), but that change would have been completely unrelated to the point of that patch. So fix it here. Change-ID: I2cd87b39cfd406850d283b88f259757a6bcd14cd Signed-off-by:
-
- 19 Mar, 2014 4 commits
-
-
Mitch Williams authored
The HLUT programming loop in in i40evf_configure_rss was a) overly- complicated, and b) just plain broken. Most of the entries ended up being not written at all, so most of the flows ended up at queue zero. Refactor the HLUT programming loop to simply walk through the registers and write four values to each one, incrementing through the number of available queues. Change-ID: I75766179bc67e4e997187794f3144e28c83fd00d Signed-off-by:
-
Sergei Shtylyov authored
Commit 20d8435a (phy: micrel: add of configuration for LED mode) made the obvious mistake when masking off the LED mode bits: forgot to do a logical NOT to the mask with which it ANDs the register value, so that unrelated bits are cleared instead. Signed-off-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Acked-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by:
Ben Dooks <ben.dooks@codethink.co.uk> Reviewed-by:
Florian Fainelli <f.fainelli@gmail.com> Signed-off-by:
-
Mitch Williams authored
This netdev op allows the PF driver to control the virtual link state of the VF devices. This can be used to deny naughty VF drivers access to the wire, or to allow VFs (regardless of temperament) to communicate with each other over the device's internal switch even though external link is down. Add the actual ndo function, and modify vc_notify_link_state to check the link status of each VF before sending a message in the case when physical link changes state. Change-ID: Ib5a6924da78c540789f21d26b5e8086d71c29384 Signed-off-by:
-
David S. Miller authored
Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
- 18 Mar, 2014 3 commits
-
-
Phoebe Buckheister authored
ieee802154 sockets do not properly unshare received skbs, which leads to panics (at least) when they are used in conjunction with 6lowpan, so run skb_share_check on received skbs. 6lowpan also contains a use-after-free, which is trivially fixed by replacing the inlined skb_share_check with the explicit call. Signed-off-by:
Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de> Tested-by:
Alexander Aring <alex.aring@gmail.com> Signed-off-by:
-
git://gitorious.org/linux-can/linux-can-nextDavid S. Miller authored
linux-can-next-for-3.15-20140317 Marc Kleine-Budde says: ==================== this is a pull request of three patches for net-next/master. It consists of a patch by Oliver Hartkopp, which unifies the MTU settings for CAN interfaces. A patch by Christopher R. Baker populates netdev::dev_id for udev discrimination for multi interface CAN devices. Alexander Shiyan contributes a patch for the mcp251x driver which fixes the regulators operation if CONFIG_REGULATOR is not enabled. ==================== Signed-off-by: -
wangweidong authored
In generic, after an assignment, we use ';' instead of ','. Although, it won't hurt. Signed-off-by:
Wang Weidong <wangweidong1@huawei.com> Signed-off-by:
-
