- 26 Nov, 2018 12 commits
-
-
Sergio Paracuellos authored
The sysctl register are already claimed by palmbus, so pci fails to claim it. The best way to access the sysc registers is to use rt_sysc_[rwm]32(). Fixes: 89e9f6e6: staging: mt7621-pci: remap and use sysctl from device tree Reported-by:
NeilBrown <neil@brown.name> Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Tested-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Michael Straube authored
Add a test for successful call to cdev_alloc() to avoid potential null dereference. Issue reported by smatch. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Fixes: 874bcba6 ("staging: pi433: New driver") Signed-off-by:
-
Wen Yang authored
The null check on &padapter->registrypriv is redundant since registrypriv is a struct inside padapter and can never be null, so the check is always true. we may remove it. Signed-off-by:
Wen Yang <wen.yang99@zte.com.cn> CC: devel@driverdev.osuosl.org CC: linux-kernel@vger.kernel.org Signed-off-by:
-
Michael Straube authored
Cleanup lines over 80 characters by replacing tabs with spaces or adding appropriate line breaks. Signed-off-by:
-
Michael Straube authored
Correct indentation to clear a checkpatch warning. WARNING: suspect code indent for conditional statements (8, 24) Signed-off-by:
-
Michael Straube authored
Remove return from a void function to clear a checkpatch warning. WARNING: void function return statements are not generally useful Signed-off-by:
-
Michael Straube authored
Refactor if else statement to clear checkpatch warnings. WARNING: else is not generally useful after a break or return WARNING: line over 80 characters Signed-off-by:
-
Michael Straube authored
Replace tabs with spaces, remove spaces, remove blank lines and break lines appropriatly in declarations. Signed-off-by:
-
Michael Straube authored
The function rtw_android_set_block() just returns zero. The only user is the function rtw_android_priv_cmd(). The variable bytes_written is initialized to zero and not changed before the use of rtw_android_set_block(). Remove rtw_android_set_block() and it's only use. Signed-off-by:
-
Michael Straube authored
Use __func__ instead of hardcoded function names. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Cleanup remaining comparsions to true. if (x == true) -> if (x) if (x != true) -> if (!x) if (!x == true) -> if (!x) Signed-off-by:
-
- 23 Nov, 2018 19 commits
-
-
Ricardo Reis Marques Silva authored
Issue found by checkpatch. CHECK: Prefer kernel type 'u32' over 'uint32_t' +static const uint32_t vbox_cursor_plane_formats[] = { CHECK: Prefer kernel type 'u32' over 'uint32_t' +static const uint32_t vbox_primary_plane_formats[] = { CHECK: Prefer kernel type 'u32' over 'uint32_t' + const uint32_t *formats; Signed-off-by:Ricardo Reis Marques Silva <ricardormsilva93@gmail.com> Signed-off-by:
-
Michael Straube authored
The local variable ret is only used to test the return value of the call to rtl8188eu_xmitframe_complete(). Use the function directly in the if test and remove the variable ret. Signed-off-by:
-
Michael Straube authored
Replace tabs with spaces and/or remove spaces in declarations to cleanup whitespace. Signed-off-by:
-
Michael Straube authored
Add spaces around '>>' and '&' to follow kernel coding style. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in usb_ops_linux.c. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Correct spelling mistake in a comment reported by checkpatch. checksumed -> checksummed Signed-off-by:
-
Michael Straube authored
Remove braces from single line if else statement. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Cleanup line ending with a '(' to follow kernel coding style. Reported by checkpatch. Signed-off-by: -
Michael Straube authored
Use __func__ instead of hardcoded function names. Reported by checkpatch. Signed-off-by:
-
Gao Xiang authored
Previously, 2 members called `initial' and `cachedzone_la' are used for applying caching policy (whether the workgroup is at either end), which are hard to understand, rename them to `backmost' and `headoffset'. Reviewed-by:
Chao Yu <yuchao0@huawei.com> Signed-off-by:
Gao Xiang <gaoxiang25@huawei.com> Signed-off-by:
-
Gao Xiang authored
For the case of nr_to_read == lookahead_size, it is better to decompress asynchronously as well since no page will be needed immediately. Reviewed-by:
-
Gao Xiang authored
Let's make sure that the one registering a workgroup will also take the primary work lock at first for two reasons: 1) There's no need to introduce such a race window (and consequently overhead) between registering and locking, other tasks could break in by chance, and the race seems unnecessary (no benefit at all); 2) It's better to take the primary work when a workgroup is registered to apply the cache managed policy, for example, if some other tasks break in, it could turn into the in-place decompression rather than use as the cached decompression. Reviewed-by: -
Gao Xiang authored
`z_erofs_vle_workgroup' is heavily generated in the decompression, for example, it resets 32 bytes redundantly for 64-bit platforms even through Z_EROFS_VLE_INLINE_PAGEVECS + Z_EROFS_CLUSTER_MAX_PAGES, default 4, pages are stored in `z_erofs_vle_workgroup'. As an another example, `struct mutex' takes 72 bytes for our kirin 64-bit platforms, it's unnecessary to be reseted at first and be initialized each time. Let's avoid filling all `z_erofs_vle_workgroup' with 0 at first since most fields are reinitialized to meaningful values later, and pagevec is no need to initialized at all. Reviewed-by:
-
Gao Xiang authored
Just like other generic locks, insert a full barrier in case of memory reorder. Reviewed-by:
-
Gao Xiang authored
There are two minor issues in the current freeze interface: 1) Freeze interfaces have not related with CONFIG_DEBUG_SPINLOCK, therefore fix the incorrect conditions; 2) For SMP platforms, it should also disable preemption before doing atomic_cmpxchg in case that some high priority tasks preempt between atomic_cmpxchg and disable_preempt, then spin on the locked refcount later. Reviewed-by: -
Gao Xiang authored
It's better to use atomic_cond_read_relaxed, which is implemented in hardware instructions to monitor a variable changes currently for ARM64, instead of open-coded busy waiting. Reviewed-by:
-
Gao Xiang authored
When the managed cache is enabled, the last reference count of a workgroup must be used for its workstation. Otherwise, it could lead to incorrect (un)freezes in the reclaim path, and it would be harmful. A typical race as follows: Thread 1 (In the reclaim path) Thread 2 workgroup_freeze(grp, 1) refcnt = 1 ... workgroup_unfreeze(grp, 1) refcnt = 1 workgroup_get(grp) refcnt = 2 (x) workgroup_put(grp) refcnt = 1 (x) ...unexpected behaviors * grp is detached but still used, which violates cache-managed freeze constraint. Reviewed-by: -
Gao Xiang authored
It's better not to positively BUG_ON the kernel, however developers need a way to locate issues as soon as possible. DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG (EROFS developping feature) is on. It is helpful for developers to find and solve bugs quickly by eng builds. Previously, DBG_BUGON is defined as ((void)0) if EROFS_FS_DEBUG is off, but some unused variable warnings as follows could occur: drivers/staging/erofs/unzip_vle.c: In function `init_alway:': drivers/staging/erofs/unzip_vle.c:61:33: warning: unused variable `work' [-Wunused-variable] struct z_erofs_vle_work *const work = ^~~~ Fix it to #define DBG_BUGON(x) ((void)(x)). Reviewed-by: -
Gao Xiang authored
`trace_erofs_readpage' was designed for .readpage() interface hook in order to trace the detailed synchronized read rather than the internal implementation `z_erofs_do_read_page' which both .readpage() and .readpages() use. It seems the tracepoint was placed to a wrong place by mistake and it should be moved to the right place. Fixes: 284db12c ("staging: erofs: add trace points for reading zipped data") Reviewed-by:
Chen Gong <gongchen4@huawei.com> Reviewed-by:
-
- 22 Nov, 2018 9 commits
-
-
Michael Straube authored
Rename struct field SwLed0 to avoid CamelCase. SwLed0 -> sw_led Signed-off-by:
-
Michael Straube authored
Rename the function LedControl8188eu to avoid CamelCase. LedControl8188eu -> led_control_8188eu Signed-off-by:
-
Michael Straube authored
The comment for blink_handler() adds no extra information in addition to the function name, so remove it. Signed-off-by:
-
Michael Straube authored
Rename the function BlinkHandler to avoid CamelCase. BlinkHandler -> blink_handler Signed-off-by:
-
Michael Straube authored
Rename the function SwLedOff to avoid CamelCase. SwLedOff -> sw_led_off Signed-off-by:
-
Michael Straube authored
Rename the function SwLedOn to avoid CamelCase. SwLedOn -> sw_led_on Signed-off-by:
-
Michael Straube authored
Rename the variable LedCfg to avoid CamleCase. LedCfg -> led_cfg Signed-off-by:
-
Michael Straube authored
Add spaces around '&' to follow kernel coding style. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove comments in rtl8188eu_led.c. The function names are well descriptive. Signed-off-by:
-
