1. 18 Oct, 2021 35 commits
  2. 17 Oct, 2021 3 commits
  3. 16 Oct, 2021 2 commits
    • Nicolas Frattaroli's avatar
      ASoC: dt-bindings: rockchip: i2s-tdm: Drop rockchip,cru property · 4e52cb9e
      Nicolas Frattaroli authored
      This property was only needed for a driver hack, which we can
      remove. Since the bindings were not in any kernel release yet, we
      are able to just drop the property instead of silently accepting
      and ignoring it.
      Signed-off-by: default avatarNicolas Frattaroli <frattaroli.nicolas@gmail.com>
      Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
      Message-Id: <20211016105354.116513-3-frattaroli.nicolas@gmail.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      4e52cb9e
    • Nicolas Frattaroli's avatar
      ASoC: rockchip: i2s-tdm: Strip out direct CRU use · d6365d0f
      Nicolas Frattaroli authored
      In cases where both rx and tx lrck are synced to the same source,
      the resets for rx and tx need to be triggered simultaneously,
      according to the downstream driver.
      
      As there is no reset API to atomically bulk (de)assert two resets
      at once, what the driver did was implement half a reset controller
      specific to Rockchip, which tried to write the registers for the
      resets within one write ideally or several writes within an irqsave
      section.
      
      This of course violates abstractions quite badly. The driver should
      not write to the CRU's registers directly.
      
      In practice, for the cases I tested the driver with, which is audio
      playback, replacing the synchronised asserts with just individual
      ones does not seem to make any difference.
      
      If it turns out that this breaks something in the future, it should
      be fixed through the specification and implementation of an atomic
      bulk reset API, not with a CRU hack.
      Signed-off-by: default avatarNicolas Frattaroli <frattaroli.nicolas@gmail.com>
      Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
      Message-Id: <20211016105354.116513-2-frattaroli.nicolas@gmail.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      d6365d0f