- 13 Mar, 2005 40 commits
-
-
Domen Puncer authored
Use wait_event_interruptible() instead of the deprecated interruptible_sleep_on(). The replacements were all straight-forward as every sleep was conditionally-looped. Patch is compile-tested (still warns about {save,restore}_flags(),cli()). Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Replace deprecated interruptible_sleep_on_timeout() function calls with direct wait-queue usage. There may be an existing problem with this driver, as I am not finding any wake_up_interruptible() callers for the waitq. Patch is compile-tested. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
convert from pci_module_init to pci_register_driver Signed-off-by: Christophe Lucas <c.lucas@ifrance.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
convert from pci_module_init to pci_register_driver Signed-off-by: Christophe Lucas <c.lucas@ifrance.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Use ssleep() instead of schedule_timeout() to guarantee the task delays as expected. The original code does use TASK_INTERRUPTIBLE, but does not check for signals or early return from schedule_timeout() so ssleep() seems more appropriate. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
convert from pci_module_init to pci_register_driver Signed-off-by: Christophe Lucas <c.lucas@ifrance.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Remove nowhere referenced file. (egrep "filename\." didn't find anything) Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Inserts a set_current_state(TASK_INTERRUPTIBLE) before the schedule_timeout() call. Without this change, after the first iteration of the loop, schedule_timeout() will not only return immediately, but the loop will break, as the conditional will no longer be satisfied. In fact, this conditional makes little sense given the workings of schedule_timeout. The timeout variable is ignored, as well, and I'm fairly certain that it should be included in the loop conditional. That way, if the timeout expires before a signal hits, -ETIME will be returned by fdc_interrupt_wait() instead of -EINTR. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. The current code uses TASK_INTERRUPTIBLE, but does not care about signals, so I believe msleep() should be ok. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Domen Puncer <domen@coderock.org> Acked-by: Mikael Starvik <starvik@axis.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Use msleep_interruptible() instead of schedule_timeout() to guarantee consistent timing regardless of HZ value. schedule_timeout(1) will vary between 10 and 1 milliseconds, depending on the value of HZ (100 or 1000 respectively). For consistent behavior, msleep_interruptible() should be used. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Nishanth Aravamudan authored
Use wait_event_timeout() in place of custom wait-queue code. The code is not changed in any way (I don't think), but is cleaned up quite a bit (will get expanded to almost identical code). Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Reorder add_wait_queue() and set_current_state() as a signal could be lost in between the two functions. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Replaces strtok() with strsep() Signed-off-by: Nicolas Kaiser <nikai@nikai.net> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Unify the spinlock initialization as far as possible. Signed-off-by: Amit Gud <gud@eth.net> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Remove the `sf16fm=' kernel boot parameter. Users must switch to `radio-sf16fmi.io=' Signed-off-by: Marcel Sebek <sebek64@post.cz> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Use ssleep() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
gus_wave.c vfree() checking cleanups. Signed-off by: James Lamanna <jlamanna@gmail.com> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Domen Puncer authored
Make code more readable with list_for_each_entry* Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
I haven't found any possible modular usage of pcibios_penalize_isa_irq in the kernel. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
I haven't found any possible modular usage of dmi_get_system_info in the kernel. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
Make hweight() macros return unsigned int for 8,16,32 bits, instead of requiring callers to do that. drivers/input/joystick/analog.c:414: warning: int format, different type arg (arg 3) drivers/input/joystick/analog.c:414: warning: int format, different type arg (arg 4) drivers/input/joystick/analog.c:418: warning: int format, different type arg (arg 4) Note: does not address parisc, s390, or sparc64... waiting for comments. Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
zoran: fix printk format types: drivers/media/video/zoran_driver.c:3763: warning: long long unsigned int format, long unsigned int arg (arg 3) drivers/media/video/zoran_driver.c:3775: warning: long long unsigned int format, long unsigned int arg (arg 3) drivers/media/video/zoran_driver.c:4109: warning: long long unsigned int format, long unsigned int arg (arg 3) Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
Use 'unsigned long long' for __u64 printk: drivers/w1/w1.c:415: warning: long long unsigned int format, __u64 arg (arg 6) Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
Fix gcc warning: drivers/isdn/i4l/isdn_ppp.c:1581: warning: large integer implicitly truncated to unsigned type <seq> is unsigned int. Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
On sparc32 build, there is a printk format arg-type warning: fs/proc/proc_misc.c:195: warning: long unsigned int format, unsigned int arg (arg 23) I tried to fix it with a change to asm-sparc/vaddrs.h: -#define VMALLOC_START 0xfe600000 +#define VMALLOC_START 0xfe600000UL -#define VMALLOC_END 0xffc00000 +#define VMALLOC_END 0xffc00000UL but that won't fly because the #defines are used in asm code and asm doesn't like the UL suffixes (reported by Bill Irwin). Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Telemaque Ndizihiwe authored
Remove an unused label (fixes compiler WARNING) and a function (inside a preprocessor directive) that is never called. Signed-off- by: Telemaque Ndizihiwe <telendiz@eircom.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
This patch contains the following cleanups: - make needlessly gloval code static - vt_ioctl.c: removed the global variable keyboard_type since noone did actually set it to any other value Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
sysrq_power_off was completely unused. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
This patch contains the following cleanups: - make some needlessly global code static - remove the unused global function specialix_setup Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
This patch contains the following cleanups: - make the needlessly global function smapi_request static - #if 0 the currently unused function SmapiQuerySystemID Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
This patch contains the following cleanups: - make two needlessly global structs static - remove the unused global function SDS_PORT8_DTR Alan already ACK'ed this patch. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
I haven't found any possible modular usage of mmu_cr4_features in the kernel. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
The patch below contains the following cleanups: - make some needlessly global code static - #if 0 the following unused global functions: - scx200_gpio_dump - remove the following unneeded EXPORT_SYMBOL's: - scx200_gpio_lock - scx200_gpio_dump Signed-off-by: Adrian Bunk <bunk@stusta.de> Acked-by: Henrik Brix Andersen <brix@gentoo.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Brian Gerst authored
- Make sprintf call vsnprintf directly - use INT_MAX for sprintf and vsprintf Signed-off-by: Brian Gerst <bgerst@didntduck.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
Andries Brouwer proposed this patch with the following comment: As observed earlier, ps2esdi was broken as a module, and the passing of geometry boot parameters is broken. But does it still work with kernels 2.3 or later? I think it does, but failed to verify that. I found an IBM PS/2 model 70-A21 with 8 MB and 120 MB ESDI disk. Tried a few distribution boot floppies to see whether they would boot. Slackware has special ibmmca bootdisks. SW 3.3 - Linux 2.1.43 - boots fine SW 4.0 - Linux 2.2.6 - hangs SW 7.0 - Linux 2.2.13 - boots fine SW 8.1 - Linux 2.4.18 - boots, but every single command is killed by OOM SW 10.0 - Linux 2.4.26 - kernel panic: no 386 supported Then Debian: Woody - Linux 2.2.10 - boots fine, but the rootdisk hangs Sarge - Linux 2.4.27 - does not recognize the ESDI disk, and the rootdisk crashes by OOM. So, good luck with 2.1 and 2.2 kernels, only failures with later kernels. What about other people? The two major Linux/MCA sites were http://glycerine.itsmm.uni.edu/mca (also referenced in Documentation/mca.txt) but it doesnt exist any longer, and http://www.dgmicro.com/mca/, which still exists ("last update: Jan 28 1999"), but the binaries it refers to live on ftp.dgmicro.com, which isn't there anymore. Concerning the speed: I measured this ESDI disk under Linux as transferring 50 kB/s, that is 4% of the speed the IBM specs claim. Also other Linux users complained that the disk is much faster under DOS. My proposal for this patch would be to get it into one 2.6 kernel (is it too late for 2.6.11?) and wait if anyone was still using it and screams, and remove it a few months later otherwise. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Olaf Hering authored
small nitpick, __KERNEL__ is the inner ifdef. Signed-off-by: Olaf Hering <olh@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Bjorn Helgaas authored
Remove unused get_resource_list() declaration. Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
This patch contains the following cleanups: - make some needlesly global code static - cciss_scsi.c: remove the unused global function cciss_scsi_info - cciss.c: - init_cciss_module -> cciss_init - cleanup_cciss_module -> cciss_cleanup Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
This patch contains the following cleanups: - make some needlessly global functions static - remove the following unused global functions: - compr.c: jffs2_set_compression_mode - compr.c: jffs2_get_compression_mode Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-