- 15 Dec, 2014 2 commits
-
-
Douglas Gilbert authored
Kernel build tools pointed out a memory leak so that has been fixed and its error paths strengthened with a goto. Testing showed compare and write was only working for lba=0; correcting the length of the LBA field fixed that. Signed-off-by:
Douglas Gilbert <dgilbert@interlog.com> Reviewed-by:
Ewan D. Milne <emilne@redhat.com> Signed-off-by:
Christoph Hellwig <hch@lst.de>
-
Laurence Oberman authored
When we have an rport disconnect we race during rport deletion and re-connection resulting in a panic. When we do this, we call fc_remote_port_del() just before we do the calls to re-establish the session with the FC transport with fc_remote_port_add() and then fc_remote_port_rolechg(). If we remove the call to fc_remote_port_del() before re-establishing the connection this prevents the race. This patch has resolved this for multiple customers via test kernels. Suggested by Chad Dupuis, implemented and tested by Laurence Oberman. Signed-off-by:
Laurence Oberman <loberman@redhat.com> Acked-by:
Chad Dupuis <chad.dupuis@qlogic.com> Signed-off-by:
-
- 04 Dec, 2014 10 commits
-
-
Sreekanth Reddy authored
This reverts commit 963ba22b ("mpt3sas: Remove phys on topology change") Reverting the previous mpt3sas drives patch changes, since we will observe below issue Issue: Drives connected Enclosure/Expander will unregister with SCSI Transport Layer, if any one remove and add expander cable with in DMD (Device Missing Delay) time period or even any one power-off and power-on the Enclosure with in the DMD period. Cc: <stable@vger.kernel.org> Signed-off-by:
Sreekanth Reddy <Sreekanth.Reddy@avagotech.com> Reviewed-by:
Tomas Henzl <thenzl@redhat.com> Signed-off-by:
-
Sreekanth Reddy authored
This reverts commit 3520f9c7 ("mpt2sas: Remove phys on topology change") Reverting the previous mpt2sas drives patch changes, since we will observe below issue Issue: Drives connected Enclosure/Expander will unregister with SCSI Transport Layer, if any one remove and add expander cable with in DMD (Device Missing Delay) time period or even any one power-off and power-on the Enclosure with in the DMD period. Cc: <stable@vger.kernel.org> Signed-off-by:
-
Boris Bodemann authored
Correct typos of "validate" in a comment Signed-off-by:
Boris Bodemann <bobo.barbarossa@gmail.com> Acked-by:
Bradley Grove <bgrove@attotech.com> Signed-off-by:
-
Christoph Hellwig authored
Not need to have an if/else to either assign FCP_PTA_SIMPLE or 0 to a variable. Btw, it seems we really should factor generating a fcp cmnd from a scsi_cmnd into a common helper. Signed-off-by:
Hannes Reinecke <hare@suse.de>
-
Christoph Hellwig authored
Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
Brian King <brking@linux.vnet.ibm.com>
-
Christoph Hellwig authored
For SPI drivers use the message definitions from scsi.h, and for target drivers introduce a new TCM_*_TAG namespace. Signed-off-by:
Bart Van Assche <bvanassche@acm.org> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com
-
Christoph Hellwig authored
There is no benefit over just setting sdev->simple_tags directly. Signed-off-by:
-
Christoph Hellwig authored
Both remaining users are better of just checking sdev->simple_tags directly. Signed-off-by:
-
Christoph Hellwig authored
Dropping to untagged mode when ramping down a queue due to QUEUE FULL events has two problems: - nothing in the midlayer or drivers ever moves back to tagged mode during queue ramp up. - cmd_per_lun isn't the untagged queue depth for many modern drivers that can handle multiple untagged commands, and this is the only place in the midlayer assuming that. Signed-off-by:
-
Christoph Hellwig authored
Since we got rid of ordered tag support in 2010 the prime use case of switching on and off ordered tags has been obsolete. The other function of enabling/disabling tagging entirely has only been correctly implemented by the 53c700 driver and isn't generally useful. Signed-off-by:
-
- 27 Nov, 2014 2 commits
-
-
Christoph Hellwig authored
The task_collector mode (or "latency_injector", (C) Dan Willians) is an optional I/O path in libsas that queues up scsi commands instead of directly sending it to the hardware. It generall increases latencies to in the optiomal case slightly reduce mmio traffic to the hardware. Only the obsolete aic94xx driver and the mvsas driver allowed to use it without recompiling the kernel, and most drivers didn't support it at all. Remove the giant blob of code to allow better optimizations for scsi-mq in the future. Signed-off-by:
Dan Williams <dan.j.williams@intel.com>
-
Ondrej Zary authored
Remove dma_cache_sync call to fix build on other architectures. Driver still works fine on x86 without that. Signed-off-by:
Ondrej Zary <linux@rainbow-software.org> Signed-off-by:
-
- 25 Nov, 2014 11 commits
-
-
Douglas Gilbert authored
The Report supported operation codes command is very closely integrated into the table driven parser and very useful for testing it. Its cdb masks form the basis of the 'strict' parameter's checks. The Report supported TMFs command is a simple extension. The Compare and write command may even be useful, as it should be atomic due to the read-write lock that the driver uses on its backing store (ram). Signed-off-by:
-
Douglas Gilbert authored
The existing 'big switch' parser in queuecommand() is changed to a table driven parser. The old and new queuecommand() were moved in the source so diff would not shuffle them. Apart from the new tables most other changes are refactoring existing response code to be more easily called out of the table parser. The 'strict' parameter is added so that cdb_s can be checked for non-zero values in parts of the cdb that are reserved. Some other changes include: tweak request sense response when D_SENSE differs; support NDOB in Write Same(16); and fix crash in Get LBA Status when LBP was inactive. Signed-off-by:
-
Douglas Gilbert authored
Via sysfs the virtual_gb scsi_debug parameter can be changed while LUs are in use. If that changes, the 'Capacity data has changed' Unit Attention is queued on all LUs. Signed-off-by:
-
Douglas Gilbert authored
The way the existing scsi_debug command parser associated various inject error flags to a command was difficult to replicate in the table driven parser. This patch adds infrastructure to append those flags to the end of a scsi_cmnd object with the cmd_size host template option. Signed-off-by:
-
Douglas Gilbert authored
Use Sense Key Specific field in the sense data of an ILLEGAL REQUEST to optionally pinpoint the location of the problem field. This may be either in the cdb or the associated parameter list. Signed-off-by:
-
Ondrej Zary authored
Add documentation and script to obtain required firmware. Signed-off-by:
-
Ondrej Zary authored
Introduce wd719x, a driver for Western Digital WD7193, WD7197 and WD7296 PCI SCSI controllers based on WD33C296A chip. Tested with WD7193 card. Signed-off-by:
-
Ondrej Zary authored
Add read-only support for EEPROMs configured in 8-bit mode (ORG pin connected to GND). This will be used by wd719x driver. Signed-off-by:
-
Tomas Henzl authored
The patch moves an error code assigment to a 'default' case in the previous switch statement. Signed-off-by:
-
Tomas Henzl authored
Is seems strange to manipulate nvram_semaphore when in this place, this patch fixes it. Signed-off-by:
-
Tomas Henzl authored
This patch fixes an error path and rearranges error handling. Signed-off-by:
-
- 24 Nov, 2014 15 commits
-
-
Hannes Reinecke authored
The am53c974 is a re-implementation of the tmscsim driver, and provides the same functionality. So remove the tmscsim driver and make am53c974 an alias to tmscsim. Acked-by:
Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by:
-
Hannes Reinecke authored
CONFIG2_FENAB ('feature enable') changed definition between chip revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display chip ID upon reset, and enable 24 bit addresses'. So only enable it for am53c974 where we know what it's doing. Acked-by:David S. Miller <davem@davemloft.net> Reviewed-by:
Paolo Bonzini <pbonzini@redhat.com> Signed-off-by:
-
Paolo Bonzini authored
On PCscsi, the FENAB configuration also enables 24-bit DMA transfer lengths (and provides the chip id in TCHI after reset). We want to be able to enable this parameter from the DMA driver. Check if the caller of scsi_esp_register provided a value for esp->config2. If this is the case, assume this is not an ESP100, skip the detection phase and leave esp->config2 untouched. It will be used in esp_reset_esp. Reviewed-by:
-
Hannes Reinecke authored
The am53c974 returns the same ID as the FAS236, but implements things slightly differently. So detect the am53c974 by checking for ESP_CONFIG4 register. Reviewed-by:
-
Hannes Reinecke authored
The am53c974 has an design issue where a single byte might be left in the SCSI FIFO after a DMA transfer. As the handling code is currently untested add a WARN_ON() statement here. Reviewed-by:
-
Hannes Reinecke authored
This patch adds a new implementation for the Tekram DC-390T / AMD AM53c974 SCSI controller, based on the generic esp_scsi infrastructure. Reviewed-by:
-
Hannes Reinecke authored
Using DMA for command submission has the drawback that it might generate additional DMA completion interrupts after the command has been submitted to the device. Additionally the am53c974 has a design flaw causing it to generate spurious interrupts even though DMA completion interrupts are not enabled. This can be avoided by using the FIFO for command submission. Reviewed-by:
-
Hannes Reinecke authored
A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read all status registers in one go to avoid losing information. Reviewed-by:
-
Hannes Reinecke authored
Add new debug definitions for event and command logging. Reviewed-by:
-
Hannes Reinecke authored
Use dev_printk functions for correct device annotations. Reviewed-by:
-
Hannes Reinecke authored
Add a field 'num_tags' to the esp structure to allow drivers to overwrite the number of avialable tags if required. Default is ESP_DEFAULT_TAGS. Reviewed-by:
-
Hannes Reinecke authored
Reviewed-by:
-
Christoph Hellwig authored
Remove overly verbose debugging output that pokes into mid-layer internal structures that looks like copy & paste from the mpt2/3 drivers. Signed-off-by:
Mike Christie <michaelc@cs.wisc.edu> Reviewed-by:
-
Christoph Hellwig authored
Merge two functions, and remove overly verbose debugging output that pokes into mid-layer internal structures. Signed-off-by:
-
Christoph Hellwig authored
Merge two functions, and remove overly verbose debugging output that pokes into mid-layer internal structures. Signed-off-by:
-
