- 26 Jun, 2005 15 commits
-
-
David S. Miller authored
1) netlink_release() should only decrement the hash entry count if the socket was actually hashed. This was causing hash->entries to underflow, which resulting in all kinds of troubles. On 64-bit systems, this would cause the following conditional to erroneously trigger: err = -ENOMEM; if (BITS_PER_LONG > 32 && unlikely(hash->entries >= UINT_MAX)) goto err; 2) netlink_autobind() needs to propagate the error return from netlink_insert(). Otherwise, callers will not see the error as they should and thus try to operate on a socket with a zero pid, which is very bad. However, it should not propagate -EBUSY. If two threads race to autobind the socket, that is fine. This is consistent with the autobind behavior in other protocols. So bug #1 above, combined with this one, resulted in hangs on netlink_sendmsg() calls to the rtnetlink socket. We'd try to do the user sendmsg() with the socket's pid set to zero, later we do a socket lookup using that pid (via the value we stashed away in NETLINK_CB(skb).pid), but that won't give us the user socket, it will give us the rtnetlink socket. So when we try to wake up the receive queue, we dive back into rtnetlink_rcv() which tries to recursively take the rtnetlink semaphore. Thanks to Jakub Jelink for providing backtraces. Also, thanks to Herbert Xu for supplying debugging patches to help track this down, and also finding a mistake in an earlier version of this fix. Signed-off-by:David S. Miller <davem@davemloft.net>
-
David S. Miller authored
We're using __be16 in userland visible types, so we have to include asm/byteorder.h so that works. Signed-off-by: -
Robert Olsson authored
Signed-off-by:
Robert Olsson <robert.olsson@its.uu.se> Signed-off-by:
-
Adrian Bunk authored
It doesn't seem to make much sense to let an "If unsure, say N." option default to y. Signed-off-by:
Adrian Bunk <bunk@stusta.de> Signed-off-by:
-
David S. Miller authored
Since it is tristate when we offer it as a choice, we should definte it also as tristate when forcing it as the default. Otherwise kconfig warns. Signed-off-by: -
-
-
Kumar Gala authored
The pending registers for IRQ1-IRQ7 were pointing to the interrupt pending register instead of the external one. Signed-off-by:
Tony Li <Tony.Li@freescale.com> Signed-off-by:
Kumar Gala <kumar.gala@freescale.com> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
Since the Trivial Patch Monkey is mentioned both in steps 4. and 5., I removed it from step4 (Select e-mail destination), since it should go under 'Select your CC list'. Signed-off-by:
Cosmin Nicolaescu <cos@camelot.homelinux.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
-
Andrew Morton authored
Another swsusp fixup. Cc: Russell King <rmk@arm.linux.org.uk> Signed-off-by:
-
Andrew Morton authored
Missed conversion in the swsusp cleanup. Cc: Russell King <rmk@arm.linux.org.uk> Signed-off-by:
-
Dave Airlie authored
After the previous fix in 2.6.12, this patch should properly fix the radeon IRQ handling code. From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by:Dave Airlie <airlied@linux.ie>
-
Linus Torvalds authored
The parentheses were missing. Noted by Pavel Machek.
-
Linus Torvalds authored
-
Christoph Lameter authored
1. Establish a simple API for process freezing defined in linux/include/sched.h: frozen(process) Check for frozen process freezing(process) Check if a process is being frozen freeze(process) Tell a process to freeze (go to refrigerator) thaw_process(process) Restart process frozen_process(process) Process is frozen now 2. Remove all references to PF_FREEZE and PF_FROZEN from all kernel sources except sched.h 3. Fix numerous locations where try_to_freeze is manually done by a driver 4. Remove the argument that is no longer necessary from two function calls. 5. Some whitespace cleanup 6. Clear potential race in refrigerator (provides an open window of PF_FREEZE cleared before setting PF_FROZEN, recalc_sigpending does not check PF_FROZEN). This patch does not address the problem of freeze_processes() violating the rule that a task may only modify its own flags by setting PF_FREEZE. This is not clean in an SMP environment. freeze(process) is therefore not SMP safe! Signed-off-by:
Christoph Lameter <christoph@lameter.com> Signed-off-by:
-
- 25 Jun, 2005 25 commits
-
-
Adrian Bunk authored
Since kernel 2.6.3 the Kconfig text explicitely stated this driver was obsolete. (trolling for IBMers) Signed-off-by:
-
Domen Puncer authored
Make code more readable with list_for_each_entry_safe. Signed-off-by:
Domen Puncer <domen@coderock.org> Signed-off-by:
Maximilian Attems <janitor@sternwelten.at> Signed-off-by:
Jan Kara <jack@suse.cz> Signed-off-by:
-
Adrian Bunk authored
There's no need for a function that only calls udelay. Signed-off-by:
-
Adrian Bunk authored
Signed-off-by:
-
Alexey Dobriyan authored
Signed-off-by:
Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by:
-
Nishanth Aravamudan authored
Use msleep_interruptible() instead of schedule_timeout() in send_break() to guarantee the task delays as expected. Change @duration's units to milliseconds, and modify arguments in callers appropriately. Signed-off-by:
Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by:
-
Nishanth Aravamudan authored
Use msleep_interruptible() instead of schedule_timeout() in send_break() to guarantee the task delays as expected. Change @duration's units to milliseconds, and modify arguments in callers appropriately. Signed-off-by:
-
Tobias Klauser authored
The files wanpipe.txt and wan-router.txt in Documentation/networking contain the exact same information (diff between the two shows no document is "Linux WAN Router Utilities Package" and therefor the name wan-router.txt is more appropriate. Signed-off-by:
Tobias Klauser <tklauser@nuerscht.ch> Signed-off-by:
-
Tobias Klauser authored
wanpipe.txt and wan-router.txt in Documentation/networking contain the exact same information (diff between the two shows no Documentation/networking/00-INDEX as pointed out by Randy Dunlap. Signed-off-by:
-
Tobias Klauser authored
wanpipe.txt and wan-router.txt in Documentation/networking contain the exact same information (diff between the two shows no drivers/net/wan/Kconfig. Signed-off-by:
-
Tobias Klauser authored
Use the DMA_32BIT_MASK constant from dma-mapping.h when calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details Signed-off-by:
-
Tobias Klauser authored
Use the DMA_32BIT_MASK constant from dma-mapping.h when calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details Signed-off-by:
-
Tobias Klauser authored
Use the DMA_32BIT_MASK constant from dma-mapping.h when calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details Signed-off-by:
-
Tobias Klauser authored
Use the DMA_32BIT_MASK constant from dma-mapping.h when calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details Signed-off-by:
-
Christophe Lucas authored
printk() calls should include appropriate KERN_* constant. Signed-off-by:
Christophe Lucas <clucas@rotomalug.org> Signed-off-by:
-
Christophe Lucas authored
printk() calls should include appropriate KERN_* constant. Signed-off-by:
-
J.A. Magallon authored
scripts/ is full of mismatches between char* params an signed char* arguments, and viceversa. gcc4 now complaints loud about this. Patch below deletes all those 'signed'. Signed-off-by:
-
Olaf Hering authored
fix a comment about the array size. Signed-off-by:
Olaf Hering <olh@suse.de> Signed-off-by:
-
Nikita Danilov authored
ll_merge_requests_fn() assigns total_{phys,hw}_segments twice. Fix this and a typo. Signed-off-by:Nikita Danilov <nikita@clusterfs.com> Signed-off-by:
-
Adrian Bunk authored
This patch contains the following possible cleanups: - make needlessly global code static - remove the compiled but unused st5481_hdlc.{c,h} - kill enternow.h - enternow_pci.c: kill InByte/OutByte/BYTE - isdnl2.c: kill FreeSkb - remove or #if 0 the following unused functions: - config.c: IsdnCardState - ipacx.c: ipacx_new_ph - ipacx.c: dch_bh - ipacx.c: setup_ipacx - isdnl2.c: IsRR Signed-off-by:Kai Germaschewski <kai@germaschewski.name> Signed-off-by:
-
Adrian Bunk authored
This patch contains the following cleanups: - make needlessly global functions static - remove the following unused global function: - cm206_delay Signed-off-by:
-
Adrian Bunk authored
This patch contains the following cleanups: - i2cmd.c: #if 0 the unused function i2cmdUnixFlags - i2cmd.c: make the needlessly global funciton i2cmdBaudDef static - ip2main.c: remove dead code that wasn't reachable due to an #ifdef Signed-off-by:
-
Jesper Juhl authored
Here's a patch with kfree() cleanups for drivers/firmware/efivars.c Patch removes redundant NULL checks before kfree and also makes a small whitespace cleanup - moves two statements on same line to separate lines. Signed-off-by:
Jesper Juhl <juhl-lkml@dif.dk> Acked-by:
Matt Domsch <Matt_Domsch@dell.com> Signed-off-by:
-
Jesper Juhl authored
This patch removes redundant checks for NULL pointer before kfree() in drivers/telephony/ Signed-off-by:
-
Jesper Juhl authored
There's no need to check for NULL, kfree() can cope. Signed-off-by:
-
