Skip to content

L
linux
Switch branch/tag
  1. 07 Feb, 2011 3 commits
    • Thomas Gleixner's avatar
      platform-drivers: x86: pmic: Use irq_chip buslock mechanism · d4b7de61
      Thomas Gleixner authored 
      The set_type function of the pmic irq chip is a horrible hack. It
schedules work because it cannot access the scu chip from the set_type
function. That breaks the assumption, that the type is set after
set_type has returned.

irq_chips provide buslock functions to avoid the above. Convert the
driver to use the proper model.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Feng Tang <feng.tang@intel.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Alek Du <alek.du@intel.com>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
      d4b7de61
    • Thomas Gleixner's avatar
      platform-drivers: x86: Convert pmic to new irq_chip functions · cb8e5e6a
      Thomas Gleixner authored 
      Old functions will go away soon. Remove the stray semicolons while at
it.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Feng Tang <feng.tang@intel.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Alek Du <alek.du@intel.com>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
      cb8e5e6a
    • Thomas Gleixner's avatar
      platform-drivers: x86: pmic: Fix up bogus irq hackery · 180e9d19
      Thomas Gleixner authored 
      commit 456dc301([PATCH] intel_pmic_gpio: modify EOI handling following
change of kernel irq subsystem) changes

-	desc->chip->eoi(irq);
+
+	if (desc->chip->irq_eoi)
+		desc->chip->irq_eoi(irq_get_irq_data(irq));
+	else
+		dev_warn(pg->chip.dev, "missing EOI handler for irq %d\n", irq);

With the following explanation:

 "Latest kernel has many changes in IRQ subsystem and its interfaces,
  like adding irq_eoi" for struct irq_chip, this patch will make it
  support both the new and old interface."

This is completely bogus.

#1) The changelog does not match the patch at all

#2) This driver relies on the assumption that it sits behind an eoi
    capable interrupt line. If the implementation of the underlying
    chip changes from eoi to irq_eoi then this driver has to follow
    that change and not add a total bogosity.

Remove the sillyness and retrieve the interrupt data from irq_desc
directly. No need to got through circles to look it up.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Feng Tang <feng.tang@intel.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Alek Du <alek.du@intel.com>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
      180e9d19
  3. 06 Feb, 2011 9 commits
  5. 05 Feb, 2011 3 commits
  7. 04 Feb, 2011 21 commits
  9. 03 Feb, 2011 4 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7