1. 02 Apr, 2013 12 commits
  2. 27 Mar, 2013 8 commits
    • Felipe Balbi's avatar
      usb: musb: ux500_dma: fix sparse warning · 6b0cfc65
      Felipe Balbi authored
      fix the following sparse warning:
      
      drivers/usb/musb/ux500_dma.c:60:6: warning: symbol 'ux500_dma_callback' was not declared. Should it be static?
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      6b0cfc65
    • Felipe Balbi's avatar
      usb: gadget: mv_u3d: fix sparse warnings · 6fbb2f7d
      Felipe Balbi authored
      fix the following sparse warnings:
      
      drivers/usb/gadget/mv_u3d_core.c:223:20: warning: context imbalance in 'mv_u3d_done' - unexpected unlock
      drivers/usb/gadget/mv_u3d_core.c:1562:25: warning: context imbalance in 'mv_u3d_handle_setup_packet' - unexpected unlock
      
      Note that the non-trivial sparse warnings
      are left out of this commit due to lack of
      HW to test:
      
      drivers/usb/gadget/mv_u3d_core.c:906:42: warning: incorrect type in argument 2 (different address spaces)
      drivers/usb/gadget/mv_u3d_core.c:906:42:    expected void [noderef] <asn:2>*<noident>
      drivers/usb/gadget/mv_u3d_core.c:906:42:    got unsigned int *<noident>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      6fbb2f7d
    • Felipe Balbi's avatar
      usb: gadget: mv_udc_core: fix sparse warnings · 94a06018
      Felipe Balbi authored
      fix the following sparse warnings:
      
      drivers/usb/gadget/mv_udc_core.c:1850:6: warning: symbol 'irq_process_reset' was not declared. Should it be static?
      drivers/usb/gadget/mv_udc_core.c:247:9: warning: context imbalance in 'done' - unexpected unlock
      drivers/usb/gadget/mv_udc_core.c:1692:25: warning: context imbalance in 'handle_setup_packet' - unexpected unlock
      
      Note that there are still other sparse warnings
      which aren't trivial to fix, so I left them out:
      
      drivers/usb/gadget/mv_udc_core.c:848:34: warning: incorrect type in argument 1 (different address spaces)
      drivers/usb/gadget/mv_udc_core.c:848:34:    expected void const volatile [noderef] <asn:2>*addr
      drivers/usb/gadget/mv_udc_core.c:848:34:    got unsigned int *<noident>
      drivers/usb/gadget/mv_udc_core.c:849:42: warning: incorrect type in argument 2 (different address spaces)
      drivers/usb/gadget/mv_udc_core.c:849:42:    expected void volatile [noderef] <asn:2>*addr
      drivers/usb/gadget/mv_udc_core.c:849:42:    got unsigned int *<noident>
      Acked-by: default avatarNeil Zhang <zhangwm@marvell.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      94a06018
    • Felipe Balbi's avatar
      usb: gadget: pch_udc: fix sparse warnings · 3f8b6201
      Felipe Balbi authored
      fix the following sparse warnings:
      
      drivers/usb/gadget/pch_udc.c:1483:9: warning: context imbalance in 'complete_req' - unexpected unlock
      drivers/usb/gadget/pch_udc.c:2408:28: warning: context imbalance in 'pch_udc_svc_control_out' - unexpected unlock
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      3f8b6201
    • Felipe Balbi's avatar
      usb: gadget: dummy: fix sparse warning · 814cf212
      Felipe Balbi authored
      fix the following sparse warning:
      
      drivers/usb/gadget/dummy_hcd.c:1912:12: warning: symbol 'usb3_bos_desc' was not declared. Should it be static?
      Acked-by: default avatarMichal Nazarewicz <mina86@mina86.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      814cf212
    • Felipe Balbi's avatar
      usb: gadget: net2280: fix sparse warnings · ad303db6
      Felipe Balbi authored
      fix the following sparse warnings:
      
      drivers/usb/gadget/net2280.c:2063:13: warning: Using plain integer as NULL pointer
      drivers/usb/gadget/net2280.c:2321:68: warning: Using plain integer as NULL pointer
      drivers/usb/gadget/net2280.c:2349:68: warning: Using plain integer as NULL pointer
      drivers/usb/gadget/net2280.c:2371:68: warning: Using plain integer as NULL pointer
      Acked-by: default avatarMichal Nazarewicz <mina86@mina86.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      ad303db6
    • Felipe Balbi's avatar
      usb: gadget: net2272: fix sparse warnings · 69147121
      Felipe Balbi authored
      Fix the following sparse warnings:
      
      drivers/usb/gadget/net2272.c:916:13: warning: Using plain integer as NULL pointer
      drivers/usb/gadget/net2272.c:1624:9: warning: Using plain integer as NULL pointer
      drivers/usb/gadget/net2272.c:1552:30: warning: right shift by bigger than source value
      
      Note that the last warning is an actual bug,
      since ep->dma is a one bit value which is
      shifted by one bit in code.
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      69147121
    • Felipe Balbi's avatar
      usb: gadget: mv_u3d: drop ARCH dependency · 60630c2e
      Felipe Balbi authored
      this driver compiles fine everywhere which
      means we can use linux-next to compile it
      for us frequently.
      
      By dropping the arch dependency, we also
      ensure driver writers don't add virtual
      arch-depdencies to the driver by e.g. using
      the wrong headers.
      
      While at that, fix Marvell's USB3 PHY dependency,
      that's the driver which depends on CPU_MM3, not
      mv_u3d_core.
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      60630c2e
  3. 22 Mar, 2013 7 commits
    • Felipe Balbi's avatar
      usb: gadget: mv_u3d: fix sparse warnings · e6667ef7
      Felipe Balbi authored
      Fix the following sparse warnings:
      
      drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_ep_queue’:
      drivers/usb/gadget/mv_u3d_core.c:812:2: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/mv_u3d_core.c:822:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/mv_u3d_core.c:823:4: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/mv_u3d_core.c:823:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_ep_dequeue’:
      drivers/usb/gadget/mv_u3d_core.c:905:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_probe’:
      drivers/usb/gadget/mv_u3d_core.c:1840:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/mv_u3d_core.c:1855:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/mv_u3d_core.c:1855:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      drivers/usb/gadget/mv_u3d_core.c:1858:53: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/mv_u3d_core.c:1858:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_irq_process_tr_complete’:
      drivers/usb/gadget/mv_u3d_core.c:163:21: warning: ‘remaining_length’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      drivers/usb/gadget/mv_u3d_core.c:125:28: note: ‘remaining_length’ was declared here
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      e6667ef7
    • Felipe Balbi's avatar
      usb: gadget: mv_u3d: remove outdated selects · af593da4
      Felipe Balbi authored
      USB_GADGET_{DUAL,SUPER}SPEED symbols have
      been removed by commit 85b8614d (usb: gadget:
      get rid of USB_GADGET_{DUAL,SUPER}SPEED), for
      some reason mv_u3d_core was lost.
      
      Remove those selects now.
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      af593da4
    • Felipe Balbi's avatar
      usb: gadget: mv_u3d: remove unused headers · a10713a5
      Felipe Balbi authored
      none of those headers are used by the driver,
      removing them still compiles fine.
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      a10713a5
    • Jingoo Han's avatar
      usb: gadget: mv_u3d: make mv_u3d_pm_ops static · 4895a2ee
      Jingoo Han authored
      Make mv_u3d_pm_ops static because mv_u3d_pm_ops is not exported.
      Also, CONFIG_PM_SLEEP is used to remove unnecessary ifdefs.
      Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      4895a2ee
    • Grazvydas Ignotas's avatar
      usb: musb: core: log VBUS error · 54485116
      Grazvydas Ignotas authored
      VBUS_ERROR is a serious error that the driver often doesn't recover from
      in my tests, so we should at least inform the user about it.
      Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      54485116
    • Grazvydas Ignotas's avatar
      usb: musb: gadget: clear gadget_driver when gadget is stopped · e21de10c
      Grazvydas Ignotas authored
      Some musb glue drivers use gadget_driver pointer to know if any gadget
      drivers are loaded at some moment and base further decisions on it,
      like to do runtime suspend/resume or not. Right now the pointer is
      left alone on stop and OMAP musb glue later does wrong runtime_pm
      decisions because of it.
      
      Clear the gadget_driver pointer on remove, it's invalid after stop
      anyway.
      Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      e21de10c
    • Grazvydas Ignotas's avatar
      usb: musb: core: honour initial transceiver state · e5615112
      Grazvydas Ignotas authored
      As the usb transceiver driver usually starts first, it should already
      have default_a variable set according to ID pin state, so don't
      override it. In case default_a was not changed by trasceiver, it will
      default to 0 and this code will work as before.
      Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      e5615112
  4. 21 Mar, 2013 5 commits
  5. 20 Mar, 2013 2 commits
  6. 19 Mar, 2013 1 commit
    • Felipe Balbi's avatar
      usb: phy: samsung: fix sparse warning · b64a1593
      Felipe Balbi authored
      Fix the following sparse warning:
      
      drivers/usb/phy/phy-samsung-usb2.c:50:26: sparse: incorrect type in argument 1 (different address spaces)
      drivers/usb/phy/phy-samsung-usb2.c:50:26:    expected void const volatile [noderef] <asn:2>*addr
      drivers/usb/phy/phy-samsung-usb2.c:50:26:    got void *
      
      Cc: Vivek Gautam <gautam.vivek@samsung.com>
      Cc: Kukjin Kim <kgene.kim@samsung.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      b64a1593
  7. 18 Mar, 2013 5 commits