Commits · d6ea9da0a2cfbe3144c6cc50e668d25657a783f3 · Kirill Smelkov / linux

02 Sep, 2004 24 commits

The coverity source checker is wrong. Revert some of the "leak fixes". · d6ea9da0

Linus Torvalds authored Sep 02, 2004

Thanks to Davem for noticing. We probably should _not_ trust the
coverity reports that much.

Cset exclude: davej@redhat.com[torvalds]|ChangeSet|20040902213928|62770
Cset exclude: davej@redhat.com[torvalds]|ChangeSet|20040902213829|63705

d6ea9da0

Merge davem@nuts.davemloft.net:/disk1/BK/net-2.6 · 232cebfb
David S. Miller authored Sep 02, 2004
```
into kernel.bkbits.net:/home/davem/net-2.6
```
232cebfb
[IPV4/IPV6]: Use csum_sub() instead of csum_block_sub() w/zero 3rd arg. · 7511efde
Herbert Xu authored Sep 02, 2004
```
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
7511efde

[PATCH] fixed pidhashing patch · 37cbd41d

Kirill Korotaev authored Sep 02, 2004

This patch fixes strange and obscure pid implementation in current kernels:
- it removes calling of put_task_struct() from detach_pid()
  under tasklist_lock. This allows to use blocking calls
  in security_task_free() hooks (in __put_task_struct()).
- it saves some space = 5*5 ints = 100 bytes in task_struct
- it's smaller and tidy, more straigthforward and doesn't use
  any knowledge about pids using and assignment.
- it removes pid_links and pid_struct doesn't hold reference counters
  on task_struct. instead, new pid_structs and linked altogether and
  only one of them is inserted in hash_list.

Signed-off-by: Kirill Korotaev (kksx@mail.ru)
Signed-off-by: William Irwin <wli@holomorphy.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

37cbd41d

[PATCH] i386 reduce spurious interrupt noise · 3345ee71

Chris Wedgwood authored Sep 02, 2004

i386 hardware can (and does) see spurious interrupts from time to
tome.  Ideally I would like the printk removed completely but this is
probably good enough for now.
Signed-off-by: Chris Wedgwood <cw@f00f.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

3345ee71

[PATCH] Fix possible leak in af_ax25 · 428877d3

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

428877d3

[PATCH] Check find_vma return code in make_pages_present() · 3e5583c1

Dave Jones authored Sep 02, 2004

It can return NULL, so check for it.

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

3e5583c1

[PATCH] More PNP leaks. · 6ff68725

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

6ff68725

[PATCH] Fix leak in ISAPNP core · fe64daa0

Dave Jones authored Sep 02, 2004

This looks odd, but there doesn't seem to be an
isapnp_free() or similar..

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

fe64daa0

[PATCH] Fix leak in atmel wireless driver. · 799cc2cf

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

799cc2cf

[PATCH] Fix leak in aty fb code. · 1c582040

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1c582040

[PATCH] Fix potential leaks in pc300_tty driver · 6468c98f

Dave Jones authored Sep 02, 2004

It appears that 'new' can be allocated, and next time around
the loop, if something goes wrong, we lose the reference..

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

6468c98f

[PATCH] Fix leaks in ISOFS. · e930d420

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

e930d420

[PATCH] Fix another PNP leak. · 2327d2ee

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

2327d2ee

[PATCH] Fix NULL dereference in OSS v_midi driver · 33fdf819

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

33fdf819

[PATCH] Remove pointless check in zlib · c1cd8a00

Dave Jones authored Sep 02, 2004

We dereference 'z' a few lines above this check.
If it was possible to hit this condition, it wouldve
triggered long ago, in the form of a crash.

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

c1cd8a00

[PATCH] Clean up failure path in DAC960 · d998729e

Dave Jones authored Sep 02, 2004

1. If the ScatterGatherPool allocation fails, its pointless
   trying to allocate a RequestSensePool.
2. Free up the ScatterGatherPool if the RequestSensePool allocation fails.

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

d998729e

[PATCH] Remove pointless code from ALSA emu10k1 midi driver. · f9785593

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

f9785593

[PATCH] Fix leak in PNP interface code. · 06e0d8ad

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

06e0d8ad

[PATCH] Fix NULL derefence in OSS MAUI driver. · a857acfe

Dave Jones authored Sep 02, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

a857acfe

[IPV4/IPV6]: Fix suboptimal fragment sizing for last fragment · 041d6e04

Patrick McHardy authored Sep 02, 2004

Yoshifuji's recent fragment patch prevents unnecessary fragmentation
when the data can be kept in a single packet, but only for the first
packet. When fragmenting, all fragments are still truncated to
multiples of 8 and we might end up creating an unnecessary fragment.

This dump shows the problem (MTU 1499):

172.16.1.123.32771 > 172.16.195.3.4135: udp 2937 (frag 7066:1472@0+)
172.16.1.123 > 172.16.195.3: udp (frag 7066:1472@1472+)
172.16.1.123 > 172.16.195.3: udp (frag 7066:1@2944)

This patch always builds mtu sized fragments and truncates the previous
fragment to a multiple of 8 bytes when allocating a new one. With the
patch the dump looks like this:


172.16.1.123.32772 > 172.16.195.3.4135: udp 2937 (frag 49641:1472@0+)
172.16.1.123 > 172.16.195.3: udp (frag 49641:1473@1472)
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

041d6e04

[NET]: Allow get/set of dev->weight via netlink. · 0dbf2dbb
Eric Lemoine authored Sep 01, 2004
```
Signed-off-by: David S. Miller <davem@davemloft.net>
```
0dbf2dbb

[IPV4]: Use nf_reset() in parp_redo(). · f6b652d8

Harald Welte authored Sep 01, 2004

Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

f6b652d8

[PATCH] Eicon ISDN: fix leak in eicon debug code. · db578ecc

Dave Jones authored Sep 01, 2004

Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Armin Schindler <armin@melware.de>

db578ecc

01 Sep, 2004 16 commits
- Merge bk://kernel.bkbits.net/davem/net-2.6 · 09c92cb8
  Linus Torvalds authored Sep 01, 2004
```
into ppc970.osdl.org:/home/torvalds/v2.6/linux
```
  09c92cb8
- Merge bk://cifs.bkbits.net/linux-2.5cifs · fa6ee3dd
  Linus Torvalds authored Sep 01, 2004
```
into ppc970.osdl.org:/home/torvalds/v2.6/linux
```
  fa6ee3dd
- [CIFS] Fix CIFS symlink regression when long symlink paths · 3aad7947
  Steve French authored Sep 01, 2004
```
Signed-of-by: Steve French (sfrench@us.ibm.com)
```
  3aad7947
- Merge davem@nuts.davemloft.net:/disk1/BK/sparc-2.6 · a0adf3b1
  David S. Miller authored Sep 01, 2004
```
into kernel.bkbits.net:/home/davem/sparc-2.6
```
  a0adf3b1
- Merge nuts.davemloft.net:/disk1/BK/network-2.6 · b022adc6
  David S. Miller authored Sep 01, 2004
```
into nuts.davemloft.net:/disk1/BK/net-2.6
```
  b022adc6
- [PKT_SCHED]: Kill bogus spaces in Kconfig strings. · e3009633
  David S. Miller authored Sep 01, 2004
```
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  e3009633
- [PKT_SCHED]: Add gact generic actions. · be84c7f6
  Jamal Hadi Salim authored Sep 01, 2004
```
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  be84c7f6
- [IPV4/IPV6]: Fixup checksums properly when fragmenting. · 5b82ac35
  Herbert Xu authored Sep 01, 2004
```
If we end up with a fraggap, when we copy the data
over to the next frag being built we must compute
a checksum for the bit we copy over for the new
fragment and subtract that checksum from the place
we are copying it from.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  5b82ac35
- [NET]: Free neigh_parms using RCU to fix neigh_create/inetdev_destroy race. · 58b31cc9
  David S. Miller authored Sep 01, 2004
```
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  58b31cc9
- [CIFS] fix recent cifs symlink change so as not call kfree on null path · 4da6e525
  Steve French authored Sep 01, 2004
```
Signed-off-by: Steve French (sfrench@us.ibm.com)  
```
  4da6e525
- [NETFILTER]: Sort Kconfig entries into reasonable order. · 5f9cf8d9
  Harald Welte authored Sep 01, 2004
```
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  5f9cf8d9
- [NETFILTER]: Add some missing help entries. · fa163a02
  Harald Welte authored Sep 01, 2004
```
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  fa163a02
- [IPV4]: Need to clear nf_debug parp_redo(). · 111cfdee
  Kirill Korotaev authored Sep 01, 2004
```
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  111cfdee
- [SPARC64]: Update defconfig. · 39e8d677
  David S. Miller authored Sep 01, 2004
  
  39e8d677
- [SPARC64]: Use list_for_each in pci_sabre.c · bafbedbf
  Maximilian Attems authored Sep 01, 2004
```
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  bafbedbf
- [SPARC64]: Initial KPROBES implementation. · 93d3379e
  David S. Miller authored Sep 01, 2004
```
Signed-off-by: David S. Miller <davem@davemloft.net>
```
  93d3379e