- 29 Mar, 2014 1 commit
-
-
Srinivas Pandruvada authored
Added capability so that this device can be enumerated via ACPI. Signed-off-by:
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
- 22 Mar, 2014 1 commit
-
-
Srinivas Pandruvada authored
AK8963 and AK8975 use same register definitions, except the range of X,Y,Z values. Added support of 8963 based on i2c_device_id. Unfortunately there is no way to detect the type via registers, both device registers return 0x48 as id of chipset. Signed-off-by:
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
- 16 Mar, 2014 8 commits
-
-
Jonathan Cameron authored
CHECK drivers/iio/gyro/itg3200_core.c drivers/iio/gyro/itg3200_core.c:114 itg3200_read_raw() info: ignoring unreachable code. Signed-off-by:
Jonathan Cameron <jic23@kernel.org> Cc: Neil Brown <neilb@suse.de> Cc: Dan Carpenter <dan.carpenter@oracle.com>
-
Jonathan Cameron authored
The unhandled bits case was highlighted by smatch: CHECK drivers/iio/industrialio-core.c drivers/iio/industrialio-core.c:719 iio_device_add_info_mask_type() error: buffer overflow 'iio_chan_info_postfix' 17 <= 31 CC [M] drivers/iio/industrialio-core.o CHECK drivers/iio/industrialio-event.c drivers/iio/industrialio-event.c:327 iio_device_add_event() error: buffer overflow 'iio_ev_info_text' 3 <= 3 The incorrect limit for the for_each_set_bit loop was noticed whilst fixing this other case. Note that as we only have 3 possible entries a the moment and the value was set to 4, the bug would not have any effect currently. It will bite fairly soon though, so best fix it now. Signed-off-by:
Jonathan Cameron <jic23@kernel.org> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Dan Carpenter <dan.carpenter@oracle.com>
-
Angelo Compagnucci authored
This patch extends previous mcp3422 driver to support missing members of the family, mcp3426/7/8. Signed-off-by:
Angelo Compagnucci <angelo.compagnucci@gmail.com> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Lars-Peter Clausen authored
The driver is now at a reasonable quality level. Move it out of staging. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
Hartmut Knaack <knaack.h@gmx.de> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Lars-Peter Clausen authored
The ad799x_ring.c file is pretty much only one function these days. No need to keep it in a separate file. Since there is then only one user of the header left also move everything from the header to the main file. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
Hartmut Knaack <knaack.h@gmx.de> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Sebastian Reichel authored
Add iio_read_channel_average_raw to support reading averaged raw values in consumer drivers. Signed-off-by:
Sebastian Reichel <sre@debian.org> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Sebastian Reichel authored
Add ABI documentation for in_*_mean_raw files, which are already supported and used in the kernel for some time. Signed-off-by:
Sebastian Reichel <sre@debian.org> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Matt Ranostay authored
AS3935 chipset can detect lightning strikes and reports those back as events and the estimated distance to the storm. Signed-off-by:
Matt Ranostay <mranostay@gmail.com> Reviewed-by:
Marek Vasut <marex@denx.de> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
- 15 Mar, 2014 2 commits
-
-
Matt Ranostay authored
Document compatible string, required and optional DT properties for AS3935 chipset driver. Signed-off-by:
Matt Ranostay <mranostay@gmail.com> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Kees Cook authored
This is a tiny preventative measure to make sure we can't write beyond PAGE_SIZE on the buffers being used in sysfs for iio. There is currently no way for this to happen, but the change makes this code more robust for the future. Signed-off-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
- 14 Mar, 2014 10 commits
-
-
Chi Pham authored
Assignments removed from if statements. Fixed checkpatch warning such as indentation and negative error returns in adjacent code. Coccinelle was used for this patch. The following script found the match: @simple@ expression E1, E2; statement S1, S2; @@ + E1 = E2; if ( - (E1 = E2) + E1 ) S1 else S2 @left@ expression E0, E1, E2; statement S1, S2; @@ + E1 = E2; if ( - (E1 = E2) + E1 == E0 ) S1 else S2 Signed-off-by:
Chi Pham <fempsci@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Andreea-Cristina Bernat authored
This patch adds fallthrough comments for the cases not preceded by break or fallthrough comment Signed-off-by:
Andreea-Cristina Bernat <bernat.ada@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
This patch fixes the following Sparse warnings in console.c : drivers/staging/lustre/lnet/selftest/console.c:65:1: warning: symbol 'lstcon_node_get' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:118:1: warning: symbol 'lstcon_node_put' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:348:1: warning: symbol 'lstcon_sesrpc_condition' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:377:1: warning: symbol 'lstcon_sesrpc_readent' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:834:1: warning: symbol 'lstcon_batch_find' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:1002:1: warning: symbol 'lstcon_batrpc_condition' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:1145:1: warning: symbol 'lstcon_testrpc_condition' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:1374:1: warning: symbol 'lstcon_test_find' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:1389:1: warning: symbol 'lstcon_tsbrpc_readent' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:1468:1: warning: symbol 'lstcon_statrpc_readent' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:1492:1: warning: symbol 'lstcon_ndlist_stat' was not declared. Should it be static? drivers/staging/lustre/lnet/selftest/console.c:1581:1: warning: symbol 'lstcon_debug_ndlist' was not declared. Should it be static? Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Gulsah Kose authored
Return is not a method and doesn't need parentheses. Removed unnecaasary parentheses. Signed-off-by:
Gulsah Kose <gulsah.1004@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/comedi/drivers/mite.c:343:44: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/mite.c:343:44: expected unsigned int [unsigned] [usertype] count drivers/staging/comedi/drivers/mite.c:343:44: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/mite.c:344:43: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/mite.c:344:43: expected unsigned int [unsigned] [usertype] addr drivers/staging/comedi/drivers/mite.c:344:43: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/mite.c:346:43: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/mite.c:346:43: expected unsigned int [unsigned] [usertype] next drivers/staging/comedi/drivers/mite.c:346:43: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/mite.c:351:45: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/mite.c:351:45: expected unsigned int [unsigned] [usertype] next drivers/staging/comedi/drivers/mite.c:351:45: got restricted __le32 [usertype] <noident> Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Gulsah Kose authored
Fix checkpatch.pl issues with line over 80 characters in rtsx.c Signed-off-by:
Gulsah Kose <gulsah.1004@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Andreea-Cristina Bernat authored
This patch solves the warning: "space prohibited before semicolon". Signed-off-by:
Andreea-Cristina Bernat <bernat.ada@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
This patch fixes the following sparse warning: drivers/staging/rtl8187se/r8180_core.c:1328:40: warning: right shift by bigger than source value by adding parenthesis. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Acked-by:
Bob Copeland <me@bobcopeland.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Andreea-Cristina Bernat authored
This patch solves the error of checkpatch.pl by deleting the extra paranthesis. Signed-off-by:
Andreea-Cristina Bernat <bernat.ada@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c:496:17: warning: cast to restricted __le16 drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c:540:12: warning: cast to restricted __le16 drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c:586:12: warning: cast to restricted __le16 Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Reviewed-by:
Bob Copeland <me@bobcopeland.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
- 13 Mar, 2014 18 commits
-
-
Elena Oat authored
This patch fixes following warnings produced by sparse: drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3867:31: expected void const *<noident> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3867:31: got void [noderef] <asn:1>*pointer drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: warning: incorrect type in argument 1 (different address spaces) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: expected void const *<noident> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: got void [noderef] <asn:1>*pointer drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: warning: incorrect type in argument 1 (different address spaces) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: expected void const *<noident> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: got void [noderef] <asn:1>*pointer drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: warning: incorrect type in argument 1 (different address spaces) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: expected void const *<noident> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: got void [noderef] <asn:1>*pointer drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: warning: incorrect type in argument 1 (different address spaces) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: expected void const *<noident> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: got void [noderef] <asn:1>*pointer drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: warning: incorrect type in argument 1 (different address spaces) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: expected void const *<noident> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: got void [noderef] <asn:1>*pointer drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: warning: incorrect type in argument 1 (different address spaces) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: expected void const *<noident> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: got void [noderef] <asn:1>*pointer drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: warning: incorrect type in argument 1 (different address spaces) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: expected void const *<noident> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: got void [noderef] <asn:1>*pointer drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3897:9: warning: cast removes address space of expression While at it, I have also fixed the warnings of lines over 80 characters. Signed-off-by:
Elena Oat <oat.elena@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Gulsah Kose authored
Remove unnecessary parentheses from rtl871x_cmd.c Signed-off-by:
Gulsah Kose <gulsah.1004@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
Fix coccinelle warnings of better allocation by using kzalloc. In these cases, kzalloc is preferred, as kmalloc may fail if it does not find contiguous memory. Signed-off-by:
Iulia Manda <iulia.manda21@gmail.com> Acked-by:
Luis R. Rodriguez <mcgrof@do-not-panic.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
Fix the following coccinelle warnings in ion.c: drivers/staging/android/ion/ion.c:511:9-16: WARNING: ERR_CAST can be used with buffer drivers/staging/android/ion/ion.c:218:9-16: WARNING: ERR_CAST can be used with table drivers/staging/android/ion/ion.c:1150:9-16: WARNING: ERR_CAST can be used with dmabuf Signed-off-by:
Iulia Manda <iulia.manda21@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
It is preferred to use seq_puts instead of seq_printf here, as it suffices string printing. Signed-off-by:
Iulia Manda <iulia.manda21@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
Join strings from two separated lines, even if this makes line longer than 80 characters. Signed-off-by:
Iulia Manda <iulia.manda21@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Kristina Martšenko authored
BA_para_set (of type __le16) is implicitly cast into an integer for bitwise operations, after which the result is converted back into a __le16. Make the initial cast explicit to make the code clearer. In addition, refactor the code for readability. This also removes five sparse warnings of the following type: drivers/staging/rtl8188eu//core/rtw_mlme_ext.c:6114:70: warning: restricted __le16 degrades to integer Signed-off-by:
Kristina Martšenko <kristina.martsenko@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Andreea-Cristina Bernat authored
This patch fixes the error "space required after that ';'" for the file /drivers/staging/media/solo6x10/solo6x10-tx28.c Signed-off-by:
Andreea-Cristina Bernat <bernat.ada@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ashley Smith authored
This patch fixes the checkpatch warning "that open brace { should be on the previous line" for a non-function statement block. Signed-off-by:
Ashley Smith <ashley@eclipso.ch> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
Align test parts in if statement on separate lines. Signed-off-by:
Iulia Manda <iulia.manda21@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
The functions musycc_del_chan and musycc_del_chan_stats are not being used at the moment and may not be required. Remove them for now (with #if 0) till it is decided whether it is really required. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Elena Oat authored
This patch fixes the warnings produced by checkpatch "unchecked sscanf return value" in file ioctl_linux.c. Signed-off-by:
Elena Oat <oat.elena@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
This patch fixes braces errors as the codingStyle of the kernel recommends. Thus, this patch fixes these errors and warning messages found by checkpatch.pl: WARNING: braces {} are not necessary for single statement blocks ERROR: that open brace { should be on the previous line Signed-off-by:
Ana Rey <anarey@gmail.com> Reviewed-by:
Bob Copeland <me@bobcopeland.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
This patch fixes whitespaces as the codingStyle of the kernel recommends. Thus, this patch fixes these errors found by checkpatch.pl: ERROR: space required before the open parenthesis '(' ERROR: space required before that '*' (ctx:OxV) ERROR: spaces required around that '=' (ctx:VxW) Signed-off-by:
Ana Rey <anarey@gmail.com> Reviewed-by:
Bob Copeland <me@bobcopeland.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
After the next warning messages by sparse tools: drivers/staging/rtl8187se/r8180_rtl8225z2.c:609:6: warning: symbol 'rtl8225z2_rf_set_mode' was not declared. Should it be static? drivers/staging/rtl8187se/r8180_rtl8225z2.c:609:13: warning: ‘rtl8225z2_rf_set_mode’ defined but not used [-Wunused-function] static void rtl8225z2_rf_set_mode(struct net_device *dev) And the next search: ~/opw/dev/staging/drivers/staging/rtl8187se (staging-next) $ git grep rtl8225z2_rf_set_mode r8180_rtl8225z2.c:void rtl8225z2_rf_set_mode(struct net_device *dev) I decided to delete rtl8225z2_rf_set_mode function. Signed-off-by:
Ana Rey <anarey@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
This patch deletes all commented code in r8180.h that is not necessary. Signed-off-by:
Ana Rey <anarey@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, convert this into an enum. While at it, I have also renamed the variable names that were used in this typedef not to use Hungarian notation. Signed-off-by:
Ana Rey <anarey@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
The typedef _LED_CTL_MODE (and the enum constants) is not used in the driver. I delete it. Signed-off-by:
Ana Rey <anarey@gmail.com> Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-