1. 10 Feb, 2017 40 commits
    • David S. Miller's avatar
      Merge branch 'bpf-selftests-improve-and-use-library' · daa5fc71
      David S. Miller authored
      Mickaël Salaün says:
      
      ====================
      Improve BPF selftests and use the library (net-next tree)
      
      This series brings some fixes to selftests, add the ability to test
      unprivileged BPF programs as root and replace bpf_sys.h with calls to the BPF
      library.
      
      This is intended for the net-next tree and apply on c0e4dadb ("net: dsa:
      mv88e6xxx: Move forward declaration to where it is needed").
      
      Changes since v4:
      * align text for function calls as requested by Daniel Borkmann
        (bpf_load_program and bpf_map_update_elem)
      * rebase
      
      Changes since v3:
      * keep the bzero() calls
      
      Changes since v2:
      * use the patches from two previous series (unprivileged tests and bpf_sys.h
        replacement)
      * include one more stdint.h
      * rebase on net-next
      * add this cover letter
      
      Changes since v1:
      * exclude patches not intended for the net-next tree
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      daa5fc71
    • Mickaël Salaün's avatar
      bpf: Add test_tag to .gitignore · bc6a3d99
      Mickaël Salaün authored
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bc6a3d99
    • Mickaël Salaün's avatar
      bpf: Remove bpf_sys.h from selftests · 702498a1
      Mickaël Salaün authored
      Add require dependency headers.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      702498a1
    • Mickaël Salaün's avatar
      bpf: Use bpf_create_map() from the library · f4874d01
      Mickaël Salaün authored
      Replace bpf_map_create() with bpf_create_map() calls.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f4874d01
    • Mickaël Salaün's avatar
      bpf: Use bpf_map_get_next_key() from the library · 5f155c25
      Mickaël Salaün authored
      Replace bpf_map_next_key() with bpf_map_get_next_key() calls.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5f155c25
    • Mickaël Salaün's avatar
      bpf: Use bpf_map_delete_elem() from the library · e58383b8
      Mickaël Salaün authored
      Replace bpf_map_delete() with bpf_map_delete_elem() calls.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e58383b8
    • Mickaël Salaün's avatar
      bpf: Use bpf_map_lookup_elem() from the library · e5ff7c40
      Mickaël Salaün authored
      Replace bpf_map_lookup() with bpf_map_lookup_elem() calls.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e5ff7c40
    • Mickaël Salaün's avatar
      bpf: Use bpf_map_update_elem() from the library · 10ecc728
      Mickaël Salaün authored
      Replace bpf_map_update() with bpf_map_update_elem() calls.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      10ecc728
    • Mickaël Salaün's avatar
      bpf: Use bpf_load_program() from the library · 2ee89fb9
      Mickaël Salaün authored
      Replace bpf_prog_load() with bpf_load_program() calls.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2ee89fb9
    • Mickaël Salaün's avatar
      bpf: Always test unprivileged programs · d02d8986
      Mickaël Salaün authored
      If selftests are run as root, then execute the unprivileged checks as
      well. This switch from 243 to 368 tests.
      
      The test numbers are suffixed with "/u" when executed as unprivileged or
      with "/p" when executed as privileged.
      
      The geteuid() check is replaced with a capability check.
      
      Handling capabilities requires the libcap dependency.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Acked-by: default avatarAlexei Starovoitov <ast@kernel.org>
      Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
      Cc: Shuah Khan <shuah@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d02d8986
    • Mickaël Salaün's avatar
      bpf: Change the include directory for selftest · 7f73f39a
      Mickaël Salaün authored
      Use the tools include directory instead of the installed one to allow
      builds from other kernels.
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: David S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7f73f39a
    • Mickaël Salaün's avatar
      tools: Sync {,tools/}include/uapi/linux/bpf.h · 9a738266
      Mickaël Salaün authored
      The tools version of this header is out of date; update it to the latest
      version from kernel header.
      
      Synchronize with the following commits:
      * b95a5c4d ("bpf: add a longest prefix match trie map implementation")
      * a5e8c070 ("bpf: add bpf_probe_read_str helper")
      * d1b662ad ("bpf: allow option for setting bpf_l4_csum_replace from scratch")
      Signed-off-by: default avatarMickaël Salaün <mic@digikod.net>
      Cc: Alexei Starovoitov <ast@fb.com>
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Daniel Mack <daniel@zonque.org>
      Cc: David S. Miller <davem@davemloft.net>
      Cc: Gianluca Borello <g.borello@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9a738266
    • David S. Miller's avatar
      Merge branch 'netronome-NFP4000-and-NFP6000-PF-driver' · e40d5d78
      David S. Miller authored
      Jakub Kicinski says:
      
      ====================
      Netronome NFP4000 and NFP6000 PF driver
      
      This is a base PF driver for Netronome NFP4000 and NFP6000 chips.  This
      series doesn't add any exciting new features, it provides a foundation
      for supporting more advanced firmware applications.
      
      Patch 1 moves a bitfield-related helper from our BPF code to the global
      header.
      
      Patch 2 renames the kernel module and adds a new main file.  We were
      considering 3-module approach (pf, vf, common netdev library) but
      ultimately settled on a single module to keep things simple.
      
      Patch 3 adds support for accessing chip internals.  It provides a way of
      configuring access windows to different parts of chip memory and issuing
      pretty much any commands on chip's NoC.
      
      Patches 4, 5, 6, 7, 8 provide support for accessing and interpreting
      various hardware and firmware information structures.
      
      Patch 9 introduces service processor (NSP) ABI.  This ABI gives us
      access to PHY/SFP module configuration and information as well as
      methods for unloading and loading application firmware.
      
      Patches 10 and 11 modify the existing netdev code to make it possible
      to support multi-port devices (sharing a PCI device).
      
      Patch 12 adds a new driver probe path which will be used for the PF
      PCI device IDs.  It utilizes the newly added infrastructure and is able
      to load application FW and spawn netdevs for all card's ports.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e40d5d78
    • Jakub Kicinski's avatar
      nfp: add the PF driver · 63461a02
      Jakub Kicinski authored
      Add PF driver for NFP4000 and NFP6000.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      63461a02
    • Jakub Kicinski's avatar
      nfp: allocate irqs in lower driver · fdace6c2
      Jakub Kicinski authored
      PF services multiple ports using single PCI device therefore
      IRQs can no longer be allocated in the netdev code.  Lower
      portion of the driver has to allocate the IRQs and hand them
      out to ports.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fdace6c2
    • Jakub Kicinski's avatar
      nfp: add port layer to debugfs directories · 6f1cd5ca
      Jakub Kicinski authored
      PF driver will support multiple ports per PCI device, add port
      number to DebugFS paths.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6f1cd5ca
    • Jakub Kicinski's avatar
      nfp: add support for service processor access · 1a64821c
      Jakub Kicinski authored
      NFP Service Processor (NSP) is an ARM core inside the chip which
      is responsible for management and control functions.  Add support
      for chip reset, FW load and external module access using the NSP.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1a64821c
    • Jakub Kicinski's avatar
      nfp: add rtsym support · 5f30fe4d
      Jakub Kicinski authored
      Add support for using application FW symbol table to look up
      location of information in device memory.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5f30fe4d
    • Jakub Kicinski's avatar
      nfp: add MIP reading support · ab78c1d2
      Jakub Kicinski authored
      MIP is a vector of information which linker can optionally include
      in application firmware.  It will be used to retrieve the location
      of symbol tables.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ab78c1d2
    • Jakub Kicinski's avatar
      nfp: add support for reading nffw info · a0d8e02c
      Jakub Kicinski authored
      NFFW info is a resource which contains information about
      the loaded application firmware.  Add code which will allow
      us to decode it and retrieve MIP location.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a0d8e02c
    • Jakub Kicinski's avatar
      nfp: add hwinfo support · 59a84748
      Jakub Kicinski authored
      Hwinfo is a simple key=value store of information which is read
      from the flash and populated during chip power on.  Add code to
      look up information in it.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      59a84748
    • Jakub Kicinski's avatar
      nfp: add support for resources · f01a2161
      Jakub Kicinski authored
      Resource table is an array placed in a well defined location
      in device's memory which describes device resources and contains
      locks which have to be acquired to use them.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f01a2161
    • Jakub Kicinski's avatar
      nfp: add CPP access core · 4cb584e0
      Jakub Kicinski authored
      Command Push Pull is the name of NFP's network on a chip.
      PCIe PF can access the interconnect through a number of mappings
      controlled via Base Access Registers.  BARs allow the PF to issue
      pretty much any command or address any memory on the chip.
      
      Add appropriate logic and a handful of helper for simple operations
      like reading scalars from memories.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4cb584e0
    • Jakub Kicinski's avatar
      nfp: rename the driver and add new main file · 2633beb9
      Jakub Kicinski authored
      Support for the PF driver is about to be added and will share
      much of the code.  When the VF driver was added we planned to
      maintain the PF driver as a separate module but have decided
      that for our simple use case just maintaining a single module
      is more reasonable.  Rename the driver to just "nfp" and update
      the Kconfig.
      
      While at it remove latent references to NFP3200.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2633beb9
    • Jakub Kicinski's avatar
      bitfield.h: add FIELD_FIT() helper · 1697599e
      Jakub Kicinski authored
      Add a helper for checking at runtime that a value will fit inside
      a specified field/mask.
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1697599e
    • David S. Miller's avatar
      Merge branch 'devlink-small-cleanups' · 4f2bd6b3
      David S. Miller authored
      Jiri Pirko says:
      
      ====================
      devlink: small cleanup around eswitch [sg]et
      
      Contains small devlink cleanup around eswitch get/set commands.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4f2bd6b3
    • Jiri Pirko's avatar
      devlink: allow to fillup eswitch attrs even if mode_get op does not exist · 4456f61c
      Jiri Pirko authored
      Even when mode_get op is not present, other eswitch attrs need to be
      filled-up.
      Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4456f61c
    • Jiri Pirko's avatar
      devlink: use nla_put_failure goto label instead of out · 1a6aa36b
      Jiri Pirko authored
      Be aligned with the rest of the code and use label named nla_put_failure.
      Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1a6aa36b
    • Jiri Pirko's avatar
      devlink: rename devlink_eswitch_fill to devlink_nl_eswitch_fill · 21e3d2dd
      Jiri Pirko authored
      Be aligned with the rest of the file and name the helper function
      accordingly.
      Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      21e3d2dd
    • Jiri Pirko's avatar
      devlink: fix the name of eswitch commands · adf200f3
      Jiri Pirko authored
      The eswitch_[gs]et command is supposed to be similar to port_[gs]et
      command - for multiple eswitch attributes. However, when it was introduced
      by 08f4b591 ("net/devlink: Add E-Switch mode control") it was wrongly
      named with the word "mode" in it. So fix this now, make the oririnal
      enum value existing but obsolete.
      Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      adf200f3
    • David S. Miller's avatar
      Merge tag 'mac80211-next-for-davem-2017-02-09' of... · 0d2164af
      David S. Miller authored
      Merge tag 'mac80211-next-for-davem-2017-02-09' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next
      
      Johannes Berg says:
      
      ====================
      Some more updates:
       * use shash in mac80211 crypto code where applicable
       * some documentation fixes
       * pass RSSI levels up in change notifications
       * remove unused rfkill-regulator
       * various other cleanups
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0d2164af
    • Ivan Khoronzhuk's avatar
      net: ethernet: ti: netcp_core: remove netif_trans_update · 1deeaa0b
      Ivan Khoronzhuk authored
      No need to update jiffies in txq->trans_start twice and only for tx 0,
      it's supposed to be done in netdev_start_xmit() and per tx queue.
      Signed-off-by: default avatarIvan Khoronzhuk <ivan.khoronzhuk@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1deeaa0b
    • David S. Miller's avatar
      Merge branch 'dsa-phy-include' · 1254856c
      David S. Miller authored
      Florian Fainelli says:
      
      ====================
      net: dsa: remove unnecessary phy.h include
      
      Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
      unnecessary dependency for quite a large amount of the kernel.  There's
      very little which actually requires definitions from phy.h in net/dsa.h
      - the include itself only wants the declaration of a couple of
      structures and IFNAMSIZ.
      
      Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
      mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
      and phy_fixed.h from net/dsa.h.
      
      This patch reduces from around 800 files rebuilt to around 40 - even
      with ccache, the time difference is noticable.
      
      In order to make this change, several drivers need to be updated to
      include necessary headers that they were picking up through this
      include.  This has resulted in a much larger patch series.
      
      I'm assuming the 0-day builder has had 24 hours with this series, and
      hasn't reported any further issues with it - the last issue was two
      weeks ago (before I became ill) which I fixed over the last weekend.
      
      I'm hoping this doesn't conflict with what's already in net-next...
      
      David, this should probably go via your tree considering the diffstat.
      
      Changes in v2:
      
      - took Russell's patch series
      - removed Qualcomm EMAC patch
      - rebased against net-next/master
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1254856c
    • Russell King's avatar
      net: dsa: remove unnecessary phy*.h includes · 4d56a29f
      Russell King authored
      Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
      unnecessary dependency for quite a large amount of the kernel.  There's
      very little which actually requires definitions from phy.h in net/dsa.h
      - the include itself only wants the declaration of a couple of
      structures and IFNAMSIZ.
      
      Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
      mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
      and phy_fixed.h from net/dsa.h.
      
      This patch reduces from around 800 files rebuilt to around 40 - even
      with ccache, the time difference is noticable.
      Tested-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
      Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4d56a29f
    • Russell King's avatar
      net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h · 7ecb6227
      Russell King authored
      Fix these errors reported by the 0-day builder by replacing the
      linux/export.h include with linux/module.h.
      
      In file included from include/linux/platform_device.h:14:0,
                       from drivers/net/wireless/ath/ath5k/ahb.c:20:
      include/linux/device.h:1463:1: warning: data definition has no type or storage class
       module_init(__driver##_init); \
       ^
      include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
        module_driver(__platform_driver, platform_driver_register, \
        ^~~~~~~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
       module_platform_driver(ath_ahb_driver);
       ^~~~~~~~~~~~~~~~~~~~~~
      include/linux/device.h:1463:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
       module_init(__driver##_init); \
       ^
      include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
        module_driver(__platform_driver, platform_driver_register, \
        ^~~~~~~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
       module_platform_driver(ath_ahb_driver);
       ^~~~~~~~~~~~~~~~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without types) in function declaration
      In file included from include/linux/platform_device.h:14:0,
                       from drivers/net/wireless/ath/ath5k/ahb.c:20:
      include/linux/device.h:1468:1: warning: data definition has no type or storage class
       module_exit(__driver##_exit);
       ^
      include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
        module_driver(__platform_driver, platform_driver_register, \
        ^~~~~~~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
       module_platform_driver(ath_ahb_driver);
       ^~~~~~~~~~~~~~~~~~~~~~
      include/linux/device.h:1468:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
       module_exit(__driver##_exit);
       ^
      include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
        module_driver(__platform_driver, platform_driver_register, \
        ^~~~~~~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
       module_platform_driver(ath_ahb_driver);
       ^~~~~~~~~~~~~~~~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without types) in function declaration
      In file included from include/linux/platform_device.h:14:0,
                       from drivers/net/wireless/ath/ath5k/ahb.c:20:
      drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_exit' defined but not used [-Wunused-function]
       module_platform_driver(ath_ahb_driver);
                              ^
      include/linux/device.h:1464:20: note: in definition of macro 'module_driver'
       static void __exit __driver##_exit(void) \
                          ^~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
       module_platform_driver(ath_ahb_driver);
       ^~~~~~~~~~~~~~~~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_init' defined but not used [-Wunused-function]
       module_platform_driver(ath_ahb_driver);
                              ^
      include/linux/device.h:1459:19: note: in definition of macro 'module_driver'
       static int __init __driver##_init(void) \
                         ^~~~~~~~
      drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
       module_platform_driver(ath_ahb_driver);
       ^~~~~~~~~~~~~~~~~~~~~~
      Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
      Acked-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7ecb6227
    • Russell King's avatar
      net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h · e3bfc6e7
      Russell King authored
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: type defaults to 'int' in declaration of 'MODULE_VERSION'
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:36: error: expected ')' before 'int'
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:37: error: expected ')' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: warning: parameter names (without types) in function declaration
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: error: type defaults to 'int' in declaration of 'module_init'
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: warning: parameter names (without types) in function declaration
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: error: type defaults to 'int' in declaration of 'module_exit'
      drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: warning: parameter names (without types) in function declaration
      drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:36: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:37: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:38: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:39: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: type defaults to 'int' in declaration of 'MODULE_VERSION'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:40: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:41: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:42: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: expected declaration specifiers or '...' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:43: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: function declaration isn't a prototype
      drivers/net/ethernet/cavium/liquidio/lio_main.c:46: error: expected ')' before 'int'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:48: error: expected ')' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:53: error: expected ')' before 'int'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:54: error: expected ')' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:57: error: expected ')' before 'sizeof'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:58: error: expected ')' before string constant
      drivers/net/ethernet/cavium/liquidio/lio_main.c:498: warning: data definitionhas no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:498: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:498: warning: parameter names (without types) in function declaration
      drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_recv_vf_drv_notice':
      drivers/net/ethernet/cavium/liquidio/lio_main.c:4393: error: implicit declaration of function 'try_module_get'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:4400: error: implicit declaration of function 'module_put'
      drivers/net/ethernet/cavium/liquidio/lio_main.c: At top level:
      drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: error: type defaults to 'int' in declaration of 'module_init'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: parameter names (without types) in function declaration
      drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: warning: data definition has no type or storage class
      drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: error: type defaults to 'int' in declaration of 'module_exit'
      drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: warning: parameter names (without types) in function declaration
      
      Add linux/module.h to both these files.
      
      drivers/net/ethernet/cavium/liquidio/octeon_console.c:40:31: error: expected ')' before 'int'
      drivers/net/ethernet/cavium/liquidio/octeon_console.c:42:4: error: expected ')' before string constant
      
      Add linux/moduleparam.h to this file.
      Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
      Acked-by: default avatarFelix Manlunas <felix.manlunas@cavium.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e3bfc6e7
    • Russell King's avatar
      MIPS: Octeon: Remove unnecessary MODULE_*() · 7ca2ea82
      Russell King authored
      octeon-platform.c can not be built as a module for two reasons:
      
      (a) the Makefile doesn't allow it:
          obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o
      
      (b) the multiple *_initcall() statements, each of which are translated
          to a module_init() call when attempting a module build, become
          aliases to init_module().  Having more than one alias will cause a
          build error.
      
      Hence, rather than adding a linux/module.h include, remove the redundant
      MODULE_*() from this file.
      Acked-by: default avatarDavid Daney <david.daney@cavium.com>
      Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7ca2ea82
    • Russell King's avatar
      iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h · da5df620
      Russell King authored
      drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
      
      Add linux/module.h to iscsi_target_login.c.
      Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
      Reviewed-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
      Acked-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      da5df620
    • Russell King's avatar
      net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h · 9303ab2b
      Russell King authored
      drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known
      drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known
      drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable 'changed' has initializer but incomplete type
      drivers/net/ethernet/marvell/mvneta.c:2709:2: error: implicit declaration of function 'fixed_phy_update_state' [-Werror=implicit-function-declaration]
      
      Add linux/phy_fixed.h to mvneta.c
      Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
      Acked-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9303ab2b
    • Russell King's avatar
      net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h · f225e4e6
      Russell King authored
      drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status'
      
      Add linux/phy_fixed.h to fman_memac.c
      Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f225e4e6