1. 16 Nov, 2020 40 commits
    • Lee Jones's avatar
      drm/radeon/evergreen_hdmi: Move 'evergreen_*()' and 'dce4_*()' HDMI prototypes to shared header · dc872ff5
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/evergreen_hdmi.c:37:6: warning: no previous prototype for ‘dce4_audio_enable’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:67:6: warning: no previous prototype for ‘evergreen_hdmi_update_acr’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:97:6: warning: no previous prototype for ‘dce4_afmt_write_latency_fields’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:119:6: warning: no previous prototype for ‘dce4_afmt_hdmi_write_speaker_allocation’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:137:6: warning: no previous prototype for ‘dce4_afmt_dp_write_speaker_allocation’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:155:6: warning: no previous prototype for ‘evergreen_hdmi_write_sad_regs’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:208:6: warning: no previous prototype for ‘evergreen_set_avi_packet’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:227:6: warning: no previous prototype for ‘dce4_hdmi_audio_set_dto’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:270:6: warning: no previous prototype for ‘dce4_dp_audio_set_dto’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:306:6: warning: no previous prototype for ‘dce4_set_vbi_packet’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:317:6: warning: no previous prototype for ‘dce4_hdmi_set_color_depth’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:354:6: warning: no previous prototype for ‘dce4_set_audio_packet’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:389:6: warning: no previous prototype for ‘dce4_set_mute’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:400:6: warning: no previous prototype for ‘evergreen_hdmi_enable’ [-Wmissing-prototypes]
       drivers/gpu/drm/radeon/evergreen_hdmi.c:440:6: warning: no previous prototype for ‘evergreen_dp_enable’ [-Wmissing-prototypes]
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      dc872ff5
    • Lee Jones's avatar
      drm/radeon/radeon_gem: Move 'radeon_gem_prime_*()'s prototypes to shared header · 5acfb44b
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_prime.c:34:18: warning: no previous prototype for ‘radeon_gem_prime_get_sg_table’ [-Wmissing-prototypes]
       34 | struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_prime.c:42:7: warning: no previous prototype for ‘radeon_gem_prime_vmap’ [-Wmissing-prototypes]
       42 | void *radeon_gem_prime_vmap(struct drm_gem_object *obj)
       | ^~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_prime.c:55:6: warning: no previous prototype for ‘radeon_gem_prime_vunmap’ [-Wmissing-prototypes]
       55 | void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
       | ^~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_prime.c:62:24: warning: no previous prototype for ‘radeon_gem_prime_import_sg_table’ [-Wmissing-prototypes]
       62 | struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_prime.c:86:5: warning: no previous prototype for ‘radeon_gem_prime_pin’ [-Wmissing-prototypes]
       86 | int radeon_gem_prime_pin(struct drm_gem_object *obj)
       | ^~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_prime.c:104:6: warning: no previous prototype for ‘radeon_gem_prime_unpin’ [-Wmissing-prototypes]
       104 | void radeon_gem_prime_unpin(struct drm_gem_object *obj)
       | ^~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_prime.c:120:17: warning: no previous prototype for ‘radeon_gem_prime_export’ [-Wmissing-prototypes]
       120 | struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
       | ^~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      5acfb44b
    • Lee Jones's avatar
      drm/radeon/atom: Move 'radeon_atom_hw_i2c_*()'s prototypes into shared header · f6a96afb
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/atombios_i2c.c:100:5: warning: no previous prototype for ‘radeon_atom_hw_i2c_xfer’ [-Wmissing-prototypes]
       100 | int radeon_atom_hw_i2c_xfer(struct i2c_adapter *i2c_adap,
       | ^~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/atombios_i2c.c:150:5: warning: no previous prototype for ‘radeon_atom_hw_i2c_func’ [-Wmissing-prototypes]
       150 | u32 radeon_atom_hw_i2c_func(struct i2c_adapter *adap)
       | ^~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      f6a96afb
    • Lee Jones's avatar
      drm/radeon/radeon_drv: Move 'radeon_driver_irq_handler_kms's prototype into shared header · f3723ad1
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_irq_kms.c:53:13: warning: no previous prototype for ‘radeon_driver_irq_handler_kms’ [-Wmissing-prototypes]
       53 | irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_irq_kms.c:120:6: warning: no previous prototype for ‘radeon_driver_irq_preinstall_kms’ [-Wmissing-prototypes]
       120 | void radeon_driver_irq_preinstall_kms(struct drm_device *dev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_irq_kms.c:152:5: warning: no previous prototype for ‘radeon_driver_irq_postinstall_kms’ [-Wmissing-prototypes]
       152 | int radeon_driver_irq_postinstall_kms(struct drm_device *dev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_irq_kms.c:171:6: warning: no previous prototype for ‘radeon_driver_irq_uninstall_kms’ [-Wmissing-prototypes]
       171 | void radeon_driver_irq_uninstall_kms(struct drm_device *dev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Gareth Hughes <gareth@valinux.com>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      f3723ad1
    • Lee Jones's avatar
      drm/radeon/radeon_drv: Move 'radeon_mmap()'s prototype to shared header · 0a2e8d51
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_ttm.c:931:5: warning: no previous prototype for ‘radeon_mmap’ [-Wmissing-prototypes]
       931 | int radeon_mmap(struct file *filp, struct vm_area_struct *vma)
       | ^~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Gareth Hughes <gareth@valinux.com>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      0a2e8d51
    • Lee Jones's avatar
      drm/radeon/evergreen: Move 'evergreen_*' and 'sumo_*' prototypes out to shared location · 4fe1999e
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/evergreen.c:1281:6: warning: no previous prototype for ‘evergreen_fix_pci_max_read_req_size’ [-Wmissing-prototypes]
       1281 | void evergreen_fix_pci_max_read_req_size(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:2664:6: warning: no previous prototype for ‘evergreen_mc_stop’ [-Wmissing-prototypes]
       2664 | void evergreen_mc_stop(struct radeon_device *rdev, struct evergreen_mc_save *save)
       | ^~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:2762:6: warning: no previous prototype for ‘evergreen_mc_resume’ [-Wmissing-prototypes]
       2762 | void evergreen_mc_resume(struct radeon_device *rdev, struct evergreen_mc_save *save)
       | ^~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:2850:6: warning: no previous prototype for ‘evergreen_mc_program’ [-Wmissing-prototypes]
       2850 | void evergreen_mc_program(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:3710:5: warning: no previous prototype for ‘evergreen_mc_init’ [-Wmissing-prototypes]
       3710 | int evergreen_mc_init(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:3769:6: warning: no previous prototype for ‘evergreen_print_gpu_status_regs’ [-Wmissing-prototypes]
       3769 | void evergreen_print_gpu_status_regs(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:3797:6: warning: no previous prototype for ‘evergreen_is_display_hung’ [-Wmissing-prototypes]
       3797 | bool evergreen_is_display_hung(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:4009:6: warning: no previous prototype for ‘evergreen_gpu_pci_config_reset’ [-Wmissing-prototypes]
       4009 | void evergreen_gpu_pci_config_reset(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:4110:6: warning: no previous prototype for ‘sumo_rlc_fini’ [-Wmissing-prototypes]
       4110 | void sumo_rlc_fini(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:4153:5: warning: no previous prototype for ‘sumo_rlc_init’ [-Wmissing-prototypes]
       4153 | int sumo_rlc_init(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:4381:5: warning: no previous prototype for ‘evergreen_rlc_resume’ [-Wmissing-prototypes]
       4381 | int evergreen_rlc_resume(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~
       drivers/gpu/drm/radeon/evergreen.c:4670:6: warning: no previous prototype for ‘evergreen_irq_suspend’ [-Wmissing-prototypes]
       4670 | void evergreen_irq_suspend(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~~~~~
      
      NB: Lots more of these - snipped for brevity
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      4fe1999e
    • Lee Jones's avatar
      drm/radeon/radeon_audio: Move 'dce3_2_*' prototypes to shared location · baa65242
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/dce3_1_afmt.c:30:6: warning: no previous prototype for ‘dce3_2_afmt_hdmi_write_speaker_allocation’ [-Wmissing-prototypes]
       30 | void dce3_2_afmt_hdmi_write_speaker_allocation(struct drm_encoder *encoder,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/dce3_1_afmt.c:48:6: warning: no previous prototype for ‘dce3_2_afmt_dp_write_speaker_allocation’ [-Wmissing-prototypes]
       48 | void dce3_2_afmt_dp_write_speaker_allocation(struct drm_encoder *encoder,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/dce3_1_afmt.c:66:6: warning: no previous prototype for ‘dce3_2_afmt_write_sad_regs’ [-Wmissing-prototypes]
       66 | void dce3_2_afmt_write_sad_regs(struct drm_encoder *encoder,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/dce3_1_afmt.c:116:6: warning: no previous prototype for ‘dce3_2_audio_set_dto’ [-Wmissing-prototypes]
       116 | void dce3_2_audio_set_dto(struct radeon_device *rdev,
       | ^~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/dce3_1_afmt.c:170:6: warning: no previous prototype for ‘dce3_2_hdmi_update_acr’ [-Wmissing-prototypes]
       170 | void dce3_2_hdmi_update_acr(struct drm_encoder *encoder, long offset,
       | ^~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/dce3_1_afmt.c:202:6: warning: no previous prototype for ‘dce3_2_set_audio_packet’ [-Wmissing-prototypes]
       202 | void dce3_2_set_audio_packet(struct drm_encoder *encoder, u32 offset)
       | ^~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/dce3_1_afmt.c:223:6: warning: no previous prototype for ‘dce3_2_set_mute’ [-Wmissing-prototypes]
       223 | void dce3_2_set_mute(struct drm_encoder *encoder, u32 offset, bool mute)
       | ^~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Slava Grigorev <slava.grigorev@amd.com>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      baa65242
    • Lee Jones's avatar
      drm/radeon/radeon_pm: Move 'radeon_pm_acpi_event_handler' prototype into shared header · bb29f896
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_pm.c:74:6: warning: no previous prototype for ‘radeon_pm_acpi_event_handler’ [-Wmissing-prototypes]
       74 | void radeon_pm_acpi_event_handler(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-media@vger.kernel.org
      Cc: linaro-mm-sig@lists.linaro.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      bb29f896
    • Lee Jones's avatar
      drm/radeon/rv770: Move 'rv770_set_clk_bypass_mode' prototype to shared location · a9f9851f
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/rv770.c:1138:6: warning: no previous prototype for ‘rv770_set_clk_bypass_mode’ [-Wmissing-prototypes]
       1138 | void rv770_set_clk_bypass_mode(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      a9f9851f
    • Lee Jones's avatar
      drm/radeon/radeon_irq_kms: Demote non-conformant kernel-doc fix another · d9353b38
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or member 'irq' not described in 'radeon_driver_irq_handler_kms'
       drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or member 'arg' not described in 'radeon_driver_irq_handler_kms'
       drivers/gpu/drm/radeon/radeon_irq_kms.c:571: warning: Function parameter or member 'n' not described in 'radeon_irq_kms_set_irq_n_enabled'
       drivers/gpu/drm/radeon/radeon_irq_kms.c:571: warning: Excess function parameter 'num' description in 'radeon_irq_kms_set_irq_n_enabled'
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      d9353b38
    • Lee Jones's avatar
      drm/radeon/radeon_legacy_encoders: Move 'radeon_add_legacy_encoder's prototype to shared location · 7ddfba01
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1746:1: warning: no previous prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes]
       1746 | radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum, uint32_t supported_device)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-media@vger.kernel.org
      Cc: linaro-mm-sig@lists.linaro.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      7ddfba01
    • Lee Jones's avatar
      drm/radeon/radeon_legacy_encoders: Move 'radeon_add_legacy_encoder' prototype to shared header · 1ae79be1
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
        drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1745:1: warning: no previous prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes]
       1745 | radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum, uint32_t supported_device)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-media@vger.kernel.org
      Cc: linaro-mm-sig@lists.linaro.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      1ae79be1
    • Lee Jones's avatar
      drm/radeon: Move radeon_ttm{init, fini} to shared location · afd90af8
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_ttm.c: At top level:
       drivers/gpu/drm/radeon/radeon_ttm.c:817:5: warning: no previous prototype for ‘radeon_ttm_init’ [-Wmissing-prototypes]
       817 | int radeon_ttm_init(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_ttm.c:878:6: warning: no previous prototype for ‘radeon_ttm_fini’ [-Wmissing-prototypes]
       878 | void radeon_ttm_fini(struct radeon_device *rdev)
       | ^~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-media@vger.kernel.org
      Cc: linaro-mm-sig@lists.linaro.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      afd90af8
    • Lee Jones's avatar
      drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param · f5194f70
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or member 'dev' not described in 'radeon_info_ioctl'
       drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function parameter 'rdev' description in 'radeon_info_ioctl'
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      f5194f70
    • Lee Jones's avatar
      drm/radeon/radeon_kms: Move 'radeon_*_kms' prototypes to shared header · 59718dbf
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_kms.c:756:5: warning: no previous prototype for ‘radeon_get_vblank_counter_kms’ [-Wmissing-prototypes]
       756 | u32 radeon_get_vblank_counter_kms(struct drm_crtc *crtc)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_kms.c:826:5: warning: no previous prototype for ‘radeon_enable_vblank_kms’ [-Wmissing-prototypes]
       826 | int radeon_enable_vblank_kms(struct drm_crtc *crtc)
       | ^~~~~~~~~~~~~~~~~~~~~~~~
       drivers/gpu/drm/radeon/radeon_kms.c:853:6: warning: no previous prototype for ‘radeon_disable_vblank_kms’ [-Wmissing-prototypes]
       853 | void radeon_disable_vblank_kms(struct drm_crtc *crtc)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-media@vger.kernel.org
      Cc: linaro-mm-sig@lists.linaro.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      59718dbf
    • Lee Jones's avatar
      drm/radeon/radeon: Move prototype into shared header · 4d3efadd
      Lee Jones authored
      Unfortunately, a suitable one didn't already exist.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype for ‘radeon_device_is_virtual’ [-Wmissing-prototypes]
       637 | bool radeon_device_is_virtual(void)
       | ^~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-media@vger.kernel.org
      Cc: linaro-mm-sig@lists.linaro.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      4d3efadd
    • Lee Jones's avatar
      drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location · 54ae7f99
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes]
       1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      54ae7f99
    • Alex Deucher's avatar
      drm/amdgpu: remove experimental flag from arcturus · 12c5365e
      Alex Deucher authored
      This has been stable for a while.
      Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      12c5365e
    • Simon Ser's avatar
      drm/fourcc: fix AMD modifiers PACKERS field doc · 09bec07b
      Simon Ser authored
      This field doesn't alias with BANK_XOR_BITS: PACKERS is bits 27:29 while
      BANK_XOR_BITS is bits 24:26.
      
      Fixes: 8ba16d59 ("drm/fourcc: Add AMD DRM modifiers.")
      Reviewed-by: default avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
      Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
      Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
      Cc: Alex Deucher <alexdeucher@gmail.com>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      09bec07b
    • Yongqiang Sun's avatar
      drm/amd/display: update vgh bounding box · c6ce6d19
      Yongqiang Sun authored
      [Why & How]
      Update bounding box as per spread sheet.
      Signed-off-by: default avatarYongqiang Sun <yongqiang.sun@amd.com>
      Acked-by: default avatarRoman Li <roman.li@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      c6ce6d19
    • Wyatt Wood's avatar
      drm/amd/display: Increase sr enter/exit in rn ddr4 watermark table · 54e5f12c
      Wyatt Wood authored
      [Why]
      After removing added latency for HostVM by default, DDR4 sr exit
      latencies were no longer large enough for some panels and caused
      underflow.
      
      [How]
      Add 1us to sr enter/exit watermark.
      Signed-off-by: default avatarWyatt Wood <wyatt.wood@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      54e5f12c
    • Aric Cyr's avatar
      drm/amd/display: 3.2.112 · 9a319960
      Aric Cyr authored
      Signed-off-by: default avatarAric Cyr <aric.cyr@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      9a319960
    • Raymond Yang's avatar
      drm/amd/display: correct data type · f1e1f272
      Raymond Yang authored
      [Why]
      We should use int for counting variable
      
      [How]
      Change type from bool to uint32_t
      Signed-off-by: default avatarRaymond Yang <rayyang@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      f1e1f272
    • Wayne Lin's avatar
      drm/amd/display: Expose new CRC window property · c920888c
      Wayne Lin authored
      [Why]
      Instead of calculating CRC on whole frame, add flexibility to calculate
      CRC on specific frame region.
      
      [How]
      Add few crc window coordinate properties. By default, CRC is calculated
      on whole frame unless user space specifies the CRC calculation window.
      Signed-off-by: default avatarWayne Lin <Wayne.Lin@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      c920888c
    • Anthony Koo's avatar
    • Yongqiang Sun's avatar
      drm/amd/display: Add dual edp optimization flag. · 175f0971
      Yongqiang Sun authored
      [Why & How]
      Add a dual edp power optimization flag, so driver will
      notify this flag to dmub FW to determine if apply the
      power optimization.
      Signed-off-by: default avatarYongqiang Sun <yongqiang.sun@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      175f0971
    • Yongqiang Sun's avatar
      drm/amd/display: set dpp dto as per requested clk for lower case. · e26c9d80
      Yongqiang Sun authored
      [Why]
      Blue screen when PNP with multiple monitor or hotplug external monitor when playing video
      due to dpp dto isn't programmed properly.
      If lower dpp clock, dpp dto need to be programmed first, and actual dpp clk not avalable yet.
      
      [How]
      set dpp dto as per request clk for lower case before dpp clk update, and after dpp clk updated
      set dpp dto again with actual dpp clk.
      Signed-off-by: default avatarYongqiang Sun <yongqiang.sun@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      e26c9d80
    • Jacky Liao's avatar
      drm/amd/display: Add I2C memory low power support · af435e3f
      Jacky Liao authored
      [Why]
      The I2C memory blocks should be powered down when they are not in use.
      This will reduce power consumption.
      
      [How]
      1. Write to I2C_LIGHT_SLEEP_FORCE to put memory in light sleep when
         released
      2. Added a debug option to allow this behaviour to be turned off
      Signed-off-by: default avatarJacky Liao <ziyu.liao@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      af435e3f
    • Roy Chan's avatar
      drm/amd/display: Detect dynamic backlight support in eDP sink · 65e870df
      Roy Chan authored
      [Why]
      Check if the eDP sink supports the dynamic backlight control
      
      [How]
      Query the dynamic backlight capability in DPCD (eDP case only)
      Signed-off-by: default avatarRoy Chan <roy.chan@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      65e870df
    • Wenjing Liu's avatar
    • Samson Tam's avatar
      drm/amd/display: fix cursor calculation for 1xnY rotated display groups · aceeeea3
      Samson Tam authored
      [Why]
      Cursor is missing on displays 2 and up when doing rotated
       display groups in 1xnY setup.  Calculation puts cursor
       out of bounds so it is not enabled.
      
      [How]
      In dcn10_set_cursor_position(), add in viewport.y into cursor
       calculations for 1xnY rotated display groups.
      For pipe split, check viewport.y for both pipes and use lower one
       to normalize cursor position before calculations.
      Add odm 2:1 support ( using same calculations as pipe split ).
      Signed-off-by: default avatarSamson Tam <Samson.Tam@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      aceeeea3
    • Dmytro Laktyushkin's avatar
    • Sung Lee's avatar
      drm/amd/display: Handle Unknown Result for SMU Periodic Retraining on DCN2.1 · 157cc885
      Sung Lee authored
      [WHY & HOW]
      Currently if VBIOSSMC_Result_UnknownCmd is returned as result of smu msg
      there is no way to know.  Put 1 in param so if 1 is returned, this unknown case is handled.
      Signed-off-by: default avatarSung Lee <sung.lee@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      157cc885
    • Sung Lee's avatar
      drm/amd/display: Populate hostvm parameter before DML calculation · 82df77ae
      Sung Lee authored
      [Why]
      If the system does not have hostvm enabled, disabling it for
      DML validation will allow more modes to pass at lower voltage
      levels.
      
      [How]
      When initializing HostVM save state to hubbub and read back
      when populating DML pipes from context.
      Signed-off-by: default avatarSung Lee <sung.lee@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      82df77ae
    • Wyatt Wood's avatar
      drm/amd/display: Hook up PSR residency command to DSAT · b8e0b3d6
      Wyatt Wood authored
      [Why]
      Use GPINT command to get PSR residency from FW.
      
      [How]
      Hook up PSR residency command to DSAT.
      Since PSR Count Request is deprecated, we will use this.
      Signed-off-by: default avatarWyatt Wood <wyatt.wood@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      b8e0b3d6
    • Yongqiang Sun's avatar
      drm/amd/display: Program dpp dto based on actual dpp clk · 58cae8ac
      Yongqiang Sun authored
      [Why]
      dpp dto phase and modulo are programmed with actual dpp global clk
      and pipe clk. Need to use actual dpp clk to prgoram dpp dto modulo
      to get more accuracy ratio.
      
      [How]
      assign actual dpp clk to dccg for dpp modulo programming.
      Signed-off-by: default avatarYongqiang Sun <yongqiang.sun@amd.com>
      Acked-by: default avatarBindu Ramamurthy <bindu.r@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      58cae8ac
    • Jane Jian's avatar
      drm/amdgpu/sriov: reopen sienna_child smu ip block under sriov · acf2740f
      Jane Jian authored
      open smu ip block meets with one-vf mode need
      Signed-off-by: default avatarJane Jian <Jane.Jian@amd.com>
      Reviewed-by: default avatarMonk Liu <monk.liu@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      acf2740f
    • Likun Gao's avatar
      drm/amdgpu: update golden setting for sienna_cichlid · 94d52a35
      Likun Gao authored
      Update golden setting for sienna_cichlid.
      Signed-off-by: default avatarLikun Gao <Likun.Gao@amd.com>
      Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      94d52a35
    • Likun Gao's avatar
      drm/amd/pm: update driver if file for sienna cichlid · 34d903d1
      Likun Gao authored
      Update driver if file for sienna cichlid.
      Signed-off-by: default avatarLikun Gao <Likun.Gao@amd.com>
      Reviewed-by: default avatarKenneth Feng <kenneth.feng@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      34d903d1
    • Xiaojian Du's avatar
      drm/amd/pm: enable the fine grain tuning function for vangogh · 93a80241
      Xiaojian Du authored
      This patch is to enale the fine grain tuning function for vangogh.
      Signed-off-by: default avatarXiaojian Du <Xiaojian.Du@amd.com>
      Reviewed-by: default avatarEvan Quan <evan.quan@amd.com>
      Reviewed-by: default avatarHuang Rui <ray.huang@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      93a80241