Commits · dce116ae86cb224a9dad787e91fb552dae67b2e8 · Kirill Smelkov / linux

03 Dec, 2006 40 commits

[SCTP]: Get rid of the last remnants of sin_port flipping. · dce116ae

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

dce116ae

[SCTP]: Annotate ->inaddr_any(). · 6fbfa9f9

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

6fbfa9f9

[SCTP]: flip_to_{h,n}() are not needed anymore. · c9c938cb

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

c9c938cb

[SCTP]: Don't bother setting sin_port in ->from_sk(). · 7dcdbd95

Al Viro authored Nov 20, 2006

... the only caller will overwrite immediately
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

7dcdbd95

[SCTP]: ->a_h is gone now. · 516b20ee

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

516b20ee

[SCTP]: ip6_send() doesn't need fl_ip_[sd]port. · 9fd76494

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

9fd76494

[SCTP]: sctp_sf_send_restart_abort() is endian-agnostic. · 7dd8a582

Al Viro authored Nov 20, 2006

... so caller can use ->ipaddr instead of ->ipaddr_h
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

7dd8a582

[SCTP]: We need to be careful when copying to sockaddr_storage. · 8cec6b80
Al Viro authored Nov 20, 2006
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
8cec6b80

[SCTP]: Trivial ->ipaddr_h -> ->ipaddr conversions. · b3f5b3b6

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b3f5b3b6

[SCTP]: ->a_h is gone now. · 74af924a

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

74af924a

[SCTP]: sctp_make_asconf_update_ip() and sctp_find_unmatch_addr(). · 5ae955cf

Al Viro authored Nov 20, 2006

... switched to taking and returning pointers to net-endian
sctp_addr resp.  Together, since the only user of sctp_find_unmatch_addr()
just passes its value to sctp_make_asconf_update_ip().
sctp_make_asconf_update_ip() is actually endian-agnostic.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

5ae955cf

[SCTP]: Trivial parts of a_h -> a switch. · 6244be4e

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

6244be4e

[SCTP]: ->source_h is not used anymore. · 80f15d62

Al Viro authored Nov 20, 2006

kill it
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

80f15d62

[SCTP]: Switch all remaining users of ->saddr_h to ->saddr. · a9266268

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a9266268

[SCTP]: Switch sctp_chunk ->dest to net-endian. · 16b0a030

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

16b0a030

[SCTP]: sctp_transport_route() switched to net-endian. · d448388b

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d448388b

[SCTP]: Pass net-endian to ->get_dst(). · cb7b4a0d

Al Viro authored Nov 20, 2006

all instances are actually endian-agnostic...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

cb7b4a0d

[SCTP]: ->get_saddr() switched to net-endian. · d3f7a54a

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d3f7a54a

[SCTP]: sctp_process_init() and sctp_source() switched to net-endian. · 6a1e5f33

Al Viro authored Nov 20, 2006

both are done in one go since almost always we have result of
the latter immediately passed to the former.  Possibly non-obvious
note: sctp_process_param() is endian-agnostic
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

6a1e5f33

[SCTP]: sctp_copy_one_addr() switched to net-endian. · 02a8a4db

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

02a8a4db

[SCTP]: sctp_has_association() switched to net-endian. · 6c7be55c

Al Viro authored Nov 20, 2006

Ditto for its only caller (sctp_endpoint_is_peeled_off)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

6c7be55c

[SCTP]: sctp_endpoint_lookup_assoc() switched to net-endian. · cd4ff034

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

cd4ff034

[SCTP]: Switch ->from_addr_param() to net-endian. · dd86d136

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

dd86d136

[SCTP]: Switch sctp_add_bind_addr() to net-endian. · 5ab7b859

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

5ab7b859

[SCTP]: Switch sctp_assoc_add_peer() to net-endian. · 4bdf4b5f

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

4bdf4b5f

[SCTP]: sctp_transport_{init,new}() switched to net-endian. · b488c7dd

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b488c7dd

[SCTP]: Switch ->from_skb() to net-endian. · d55c41b1

Al Viro authored Nov 20, 2006

All instances switched, callers updated.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d55c41b1

[SCTP]: Switch sctp_cookie ->peer_addr to net-endian. · 9b1dfad0

Al Viro authored Nov 20, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

9b1dfad0

[SCTP]: sctp_init_addrs() switched to net-endian. · f235fca3

Al Viro authored Nov 20, 2006

Caller adjusted.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

f235fca3

[SCTP]: Switch sctp_assoc_is_match to net-endian. · e2fccedb

Al Viro authored Nov 20, 2006

Along with it, statics in input.c that end up calling it
(__sctp_lookup_association, sctp_lookup_association,
__sctp_rcv_init_lookup, __sctp_rcv_lookup).  Callers
are adjusted.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

e2fccedb

[SCTP]: Switch sctp_endpoint_is_match() to net-endian. · 1c7d1fc1

Al Viro authored Nov 20, 2006

The only caller (__sctp_rcv_lookup_endpoint()) also switched,
its caller adjusted
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

1c7d1fc1

[SCTP]: Switch sctp_del_bind_addr() to net-endian. · c9a08505

Al Viro authored Nov 20, 2006

Callers adjusted.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

c9a08505

[SCTP]: Switch address inside the heartbeat opaque data to net-endian. · 63de08f4

Al Viro authored Nov 20, 2006

Its only use happens on the same host, when it gets quoted back to
us.  So we are free to flip to net-endian and avoid extra PITA.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

63de08f4

[SCTP]: Switch sctp_assoc_lookup_paddr() to net-endian. · be29681e

Al Viro authored Nov 20, 2006

Callers updated.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

be29681e

[SCTP]: sctp_assoc_del_peer() switched to net-endian. · 38a03145

Al Viro authored Nov 20, 2006

Callers adjusted.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

38a03145

[SCTP]: Annotate ->dst_saddr() · 854d43a4

Al Viro authored Nov 20, 2006

switched to taking a pointer to net-endian sctp_addr
and a net-endian port number.  Instances and callers
adjusted; interestingly enough, the only calls are
direct calls of specific instances - the method is not
used at all.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

854d43a4

[SCTP]: Switch ->primary_addr to net-endian. · acd2bc96

Al Viro authored Nov 20, 2006

Users adjusted.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

acd2bc96

[SCTP]: Switch sctp_bind_addr_match() to net-endian. · 7e1e4a2b

Al Viro authored Nov 20, 2006

Callers adjusted.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

7e1e4a2b

[SCTP]: Switch ->cmp_addr() and sctp_cmp_addr_exact() to net-endian. · 5f242a13

Al Viro authored Nov 20, 2006

instances of ->cmp_addr() are fine with switching both arguments
to net-endian; callers other than in sctp_cmp_addr_exact() (both
as ->cmp_addr(...) and direct calls of instances) adjusted;
sctp_cmp_addr_exact() switched to net-endian itself and adjustment
is done in its callers
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

5f242a13

[SCTP]: Pass net-endian to ->seq_dump_addr() · c604e368

Al Viro authored Nov 20, 2006

No actual modifications of method instances are needed -
they don't look at port numbers.  Switch callers...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

c604e368