Use the more current logging styles.

Add #define DEBUG to make netdev_dbg always active.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Commit bb900b27 ("bridge: allow
creating bridge devices with netlink") introduced a bug in net-next
because of a typo in notifier. Every device would have the sysfs
bridge directory (and files).
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Dimitris Michailidis <dm@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Thiago Farina <tfransosi@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Side effect: allow toggling of TX offloads.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Note: Driver modifies its struct net_device_ops. This will break if used for
multiple devices that are not all the same (if that HW config is possible).
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Side effect: allow toggling of TX offloads.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Remove be_set_flags() as it's already covered by hw_features.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Ajit Khaparde ajit.khaparde@emulex.com
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Side effect: don't reenable RXCSUM on every ifdown/ifup.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

As a side effect, make TX offloads changeable.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

This removes some of the remnants of LRO -> GRO conversion.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Not much of a conversion anyway - macvlan has no way to change the offload
settings independently to its base device.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

The variables 'tx_min' and 'tx_max' are set but not used in
be_set_coalesce().

Similarly for 'region' in be_do_flash().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'fcr' is set but not used in isdn_tty_change_speed().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'flowlabel' is set but unused in ip6t_mangle_out().

The intention here was to compare this key to the header value after
mangling, and trigger a route lookup on mismatch.

Make it so.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'target' is set but unused in compat_copy_entry_from_user().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ret' is set but unused in ct_seq_show().

This was obviously meant to be used to propagate error codes
to the caller, so make it so.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'tmp_uint' is set but unused in __build_packet_message().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'type_str' is set but unused in netlbl_cipsov4_add().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ret' is set but unused in l2tp_nl_register_ops().

This was obviously meant to maintain error codes which are
returned to the caller, make it so.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'd' is set but unused in irda_proc_register().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ret' is set but unused in irlap_state_sclose().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'caifdef' is set but unused in modemcmd().

Similarly for 'net' in receive(), and 'res' in
caif_device_notify() and caif_exit_net().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'rc' is set but unused in bnx2x_timer().

Similarly for 'hc_index_p' in bnx2x_init_sb(), and 'port' in
bnx2x_get_hwinfo().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'pgoff' is set but unused in bfa_nw_ioc_fwver_get()
and bfa_ioc_download_fw().

Similarly for 'cmd_h' in bna_mbox_flush_q and the entirety of
bna_rit_mod_uninit() is unused since variables are purely set but no
action is made using them.

Same for 'bna' in bna_rit_create() and 'ret' in bna_rx_create().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'len' is set but unused in data_sock_getsockopt().

The code should use 'len' to validate that the user's socket option is
indeed the right size.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'unused' is set but unused in
isdn_net_ciscohdlck_slarp_in().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ch' is set but unused in isdn_capi_rec_hl_msg().  Just
kill it off.

Similarly for 'chidx' in isdn_ioctl() and 'di' in
isdn_capi_rec_hl_msg().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'dev' is set but unused in teles_cs_config().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cause' is set but unused in ni1up().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cause' is set but unused in dss1up().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'i' is set but unused in JadeVersion().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cda2_cr' is set but unused in ctrl_complete().  Just
kill it off.

Keep the cs->readisac() call just in case the register read has side
effects.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'buf' is set but unused in
ctrl_complete().  Just kill it off.

Similarly for 'err' in hfc_usb_init().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'bits' is set but unused in
change_speed().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'dev' is set but unused in
elsa_cs_config().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'val' is set but unused in
send_arcofi().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>