An error occurred fetching the project authors.
- 18 Apr, 2016 5 commits
-
-
Andy Shevchenko authored
Sort IDs in groups to be easily found when needed. There is no functional change. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Felipe Balbi <felipe.balbi@linux.intel.com>
-
Andy Shevchenko authored
It seems there are leftovers of some assignments which are not used anymore. Compiler even warns us about: drivers/usb/gadget/udc/pch_udc.c:2022:22: warning: variable ‘dev’ set \ but not used [-Wunused-but-set-variable] drivers/usb/gadget/udc/pch_udc.c:2639:9: warning: variable ‘ret’ set \ but not used [-Wunused-but-set-variable] Remove them and shut compiler about. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Felipe Balbi <felipe.balbi@linux.intel.com>
-
Andy Shevchenko authored
Try to enable MSI in case hardware supports it. At least Intel Quark is known SoC which indeed does. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Felipe Balbi <felipe.balbi@linux.intel.com>
-
Andy Shevchenko authored
devres API allows to make error paths cleaner and less error prone. Convert the driver to use it. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Felipe Balbi <felipe.balbi@linux.intel.com>
-
Andy Shevchenko authored
There is no need to repeat the work that is already done in the PCI driver core. The patch removes excerpts from suspend and resume callbacks. Note that there is no more calls performed to enable or disable a PCI device during suspend-resume cycle. Nowadays they seems to be superfluous. Someone can read more in [1]. While here, convert PM ops to use modern API. [1] https://www.kernel.org/doc/ols/2009/ols2009-pages-319-330.pdfSigned-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> [felipe.balbi@linux.intel.com: fixed build break and checkpatch error ] Signed-off-by:
Felipe Balbi <felipe.balbi@linux.intel.com>
-
- 15 Mar, 2016 1 commit
-
-
Heikki Krogerus authored
PCI-SIG has defined Interface FEh for Base Class 0Ch, Sub-Class 03h as "USB Device (not host controller)". It is already being used in various USB device controller drivers for matching, so add PCI_CLASS_SERIAL_USB_DEVICE and use it. Signed-off-by:
Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by:
Bjorn Helgaas <bhelgaas@google.com>
-
- 19 Oct, 2015 1 commit
-
-
Geliang Tang authored
s/regsiter/register/ Signed-off-by:
Geliang Tang <geliangtang@163.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 28 Sep, 2015 1 commit
-
-
Felipe Balbi authored
gadget methods should be called without spinlocks held. Reported-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 04 Aug, 2015 1 commit
-
-
Robert Baldyga authored
Convert endpoint configuration to new capabilities model. Signed-off-by:
Robert Baldyga <r.baldyga@samsung.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 03 Aug, 2015 1 commit
-
-
Pengyu Ma authored
When remove module g_serial on quark platform, the following Warning on: Modules linked in: usb_f_acm u_serial g_serial(-) pch_udc libcomposite configfs udc_core ad7298 industrialio_triggered_buffer kfifo_buf tpm_i2c_infineon indus CPU: 0 PID: 369 Comm: modprobe Not tainted 3.14.29ltsi-WR7.0.0.0_standard #6 Hardware name: Intel Corp. QUARK/CrossHill, BIOS 0x010100F5 01/01/2014 f641df0c f641df0c f641dec8 c15ac7fa f641defc c103084f c16c2356 f641df28 00000171 c16b855c 000009dd c15b2d6f 000009dd c15b2d6f f6bd2000 faae5480 00000000 f641df14 c10308a3 00000009 f641df0c c16c2356 f641df28 f641df2c Call Trace: [<c15ac7fa>] dump_stack+0x16/0x18 [<c103084f>] warn_slowpath_common+0x7f/0xa0 [<c15b2d6f>] ? preempt_count_sub+0x6f/0xc0 [<c15b2d6f>] ? preempt_count_sub+0x6f/0xc0 [<c10308a3>] warn_slowpath_fmt+0x33/0x40 [<c15b2d6f>] preempt_count_sub+0x6f/0xc0 [<faadbc82>] pch_udc_pcd_pullup+0x32/0xa0 [pch_udc] [<fa9747d9>] usb_gadget_remove_driver+0x29/0x60 [udc_core] [<fa974869>] usb_gadget_unregister_driver+0x59/0x80 [udc_core] [<faa78310>] usb_composite_unregister+0x10/0x20 [libcomposite] [<faae50f1>] cleanup+0xd/0xf [g_serial] [<c1084c47>] SyS_delete_module+0xf7/0x150 [<c111f8dd>] ? ____fput+0xd/0x10 [<c104b2ae>] ? task_work_run+0x6e/0xa0 [<c15afda5>] syscall_call+0x7/0x7 g_serial module on quark is depended on pch_udc module, ttyGSX cann't recieve data and warning on when remove g_serial. It was unlocked before the modification of the structure it was protecting, fix it as "lock -> unlock" to resolve this. Signed-off-by:
Pengyu Ma <pengyu.ma@windriver.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 29 Jul, 2015 1 commit
-
-
Vaishali Thakkar authored
In big endian cases, the macro cpu_to_le{16,32} unfolds to __swab{16,32} which provides special case for constants. In little endian cases, __constant_cpu_to_le{16,32} and cpu_to_le{16,32} expand directly to the same expression. So, replace __constant_cpu_to_le{16,32} with cpu_to_le{16,32} with the goal of getting rid of the definition of __constant_cpu_to_le{16,32} completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ ( - __constant_cpu_to_le16(x) + cpu_to_le16(x) | - __constant_cpu_to_le32(x) + cpu_to_le32(x) ) Signed-off-by:
Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 29 Jan, 2015 1 commit
-
-
Peter Chen authored
Set value for common is_selfpowered. Signed-off-by:
Peter Chen <peter.chen@freescale.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 10 Nov, 2014 1 commit
-
-
Peter Chen authored
Replace usb_gadget_driver's disconnect with udc-core's reset notifier at bus reset handler. Signed-off-by:
Peter Chen <peter.chen@freescale.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 03 Nov, 2014 1 commit
-
-
Felipe Balbi authored
now that no UDC driver relies on the extra 'driver' argument to ->udc_stop(), we can safely remove it. This commit is based on previous work by Robert Baldyga <r.baldyga@samsung.com> which can be found at [1]; however that patch turned out to have a high probability of regressing many UDC drivers because of a blind search & replace s/driver/$udc->driver/ which caused the 'driver' argument to stop_activity() to be a valid non-NULL pointer when it should be NULL, thus causing UDCs to mistakenly call gadget driver's ->disconnect() callback. [1] http://markmail.org/message/x5zneg4xea4zntabAcked-by:
Peter Chen <peter.chen@freescale.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 25 Sep, 2014 1 commit
-
-
Michal Sojka authored
Use the recently introduced usb_gadget_giveback_request() in favor of direct invocation of the completion routine. All places in drivers/usb/ matching "[-.]complete(" were replaced with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by:
Michal Sojka <sojka@merica.cz> Acked-by:
Felipe Balbi <balbi@ti.com> Tested-by:
Felipe Balbi <balbi@ti.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 20 Aug, 2014 1 commit
-
-
Bryan O'Donoghue authored
This patch is to enable the USB gadget device for Intel Quark X1000 Signed-off-by:
Bryan O'Donoghue <bryan.odonoghue@intel.com> Signed-off-by:
Bing Niu <bing.niu@intel.com> Signed-off-by:
Alvin (Weike) Chen <alvin.chen@intel.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 16 Jul, 2014 1 commit
-
-
Andrzej Pietrasiewicz authored
The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the UDC drivers into a separate directory. Signed-off-by:
Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 17 Dec, 2013 1 commit
-
-
Robert Baldyga authored
This patch adds "maxpacket_limit" to struct usb_ep. This field contains maximum value of maxpacket supported by driver, and is set in driver probe. This value should be used by autoconfig() function, because value of field "maxpacket" is set to value from endpoint descriptor when endpoint becomes enabled. So when autoconfig() function will be called again for this endpoint, "maxpacket" value will contain wMaxPacketSize from descriptior instead of maximum packet size for this endpoint. For this reason this patch adds new field "maxpacket_limit" which contains value of maximum packet size (which defines maximum endpoint capabilities). This value is used in ep_matches() function used by autoconfig(). Value of "maxpacket_limit" should be set in UDC driver probe function, using usb_ep_set_maxpacket_limit() function, defined in gadget.h. This function set choosen value to both "maxpacket_limit" and "maxpacket" fields. This patch modifies UDC drivers by adding support for maxpacket_limit. Signed-off-by:
Robert Baldyga <r.baldyga@samsung.com> Signed-off-by:
Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 06 Dec, 2013 1 commit
-
-
Jingoo Han authored
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 05 Dec, 2013 1 commit
-
-
Jingoo Han authored
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 01 Oct, 2013 1 commit
-
-
Jingoo Han authored
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 26 Sep, 2013 1 commit
-
-
Sachin Kamat authored
Driver core sets driver data to NULL upon failure or remove. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 27 Mar, 2013 1 commit
-
-
Felipe Balbi authored
fix the following sparse warnings: drivers/usb/gadget/pch_udc.c:1483:9: warning: context imbalance in 'complete_req' - unexpected unlock drivers/usb/gadget/pch_udc.c:2408:28: warning: context imbalance in 'pch_udc_svc_control_out' - unexpected unlock Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 18 Mar, 2013 5 commits
-
-
Felipe Balbi authored
udc-core provides a better way to handle release methods, let's use it. Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
Felipe Balbi authored
udc-core now handles that for us, which means we can remove it from our driver. Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
Felipe Balbi authored
udc-core now sets dma-related and parent fields for us, we don't need to do it ourselves. Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
Felipe Balbi authored
We don't need the ->register_my_device flag anymore because all UDC drivers have been properly converted. Let's remove every history of it. Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
Felipe Balbi authored
By simply setting a flag, we can drop some boilerplate code. Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 24 Jan, 2013 1 commit
-
-
Felipe Balbi authored
Mechanical change making use of the new (can we still call it new ?) interface for registering UDC drivers. Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 10 Sep, 2012 1 commit
-
-
Sebastian Andrzej Siewior authored
This patch removes the global variable composite in composite.c. The private data which was saved there is now passed via an additional argument to the bind() function in struct usb_gadget_driver. Only the "old-style" UDC drivers have to be touched here, new style are doing it right because this change is made in udc-core. Acked-by:
Michal Nazarewicz <mina86@mina86.com> Signed-off-by:
Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 04 Jun, 2012 1 commit
-
-
Joe Perches authored
Using | with a constant is always true. Likely this should have be &. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 04 May, 2012 2 commits
-
-
Ido Shayevitz authored
Remove redundant pointer to struct usb_endpoint_descriptor. Signed-off-by:
Ido Shayevitz <idos@codeaurora.org> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
Axel Lin authored
This patch converts the drivers in drivers/usb/gadget/* to use module_pci_driver() macro which makes the code smaller and a bit simpler. Signed-off-by:
Axel Lin <axel.lin@gmail.com> Cc: Thomas Dahlmann <dahlmann.thomas@arcor.de> Cc: Xiaochen Shen <xiaochen.shen@intel.com> Cc: Pavankumar Kondeti <pkondeti@codeaurora.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 06 Mar, 2012 1 commit
-
-
Tomoya MORINAGA authored
Greg's e-mail address was old. So, I resend it. Though I've tested this patch, http://marc.info/?l=linux-usb&m=132825305710285&w=2, I've received the following reports. http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/ http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/ So, I added header file for these symbols. Using this patch, this compile error must be disappeared. Reported-by:
Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:
Tomoya MORINAGA <tomoya.rohm@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 24 Feb, 2012 1 commit
-
-
Ido Shayevitz authored
This fix a bug in f_serial, which expect the ep->desc to be NULL after disabling an endpoint. Cc: stable@vger.kernel.org Signed-off-by:
Ido Shayevitz <idos@codeaurora.org> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 09 Feb, 2012 2 commits
-
-
Tomoya MORINAGA authored
Problem: pch_udc continues operation even if VBUS becomes Low. pch_udc performs D+ pulling up before VBUS becomes High. USB device should be controlled according to VBUS state. Root cause: The current pch_udc is not always monitoring VBUS. Solution: The change of VBUS is detected using an interrupt of GPIO. If VBUS became Low, pch_udc handles 'disconnect'. After VBUS became High, a pull improves D+, and pch_udc handles 'connect'. [ balbi@ti.com : make it actually compile ] Signed-off-by:
Tomoya MORINAGA <tomoya.rohm@gmail.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
Tomoya MORINAGA authored
Problem: In USB Suspend, pch_udc handles 'disconnect'. Root cause: The current pch_udc is not monitoring VBUS. When USB cable is disconnected, USB Device Controller generates an interrupt of USB Suspend. pch_udc cannot distinguish it is USB Suspend or disconnect. Therefore, pch_udc handles 'disconnect' after an interrupt of USB Suspend happend. Solution: VBUS is detected through GPIO. After an interrupt produced USB Suspend, if VBUS is Low, pch_udc handles 'disconnect'. If VBUS is High, pch_udc handles 'suspend'. Signed-off-by:
Tomoya MORINAGA <tomoya.rohm@gmail.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
- 24 Jan, 2012 3 commits
-
-
Tomoya MORINAGA authored
ISSUE: Adding debugging messages. CAUSE: The debugging messages are added to make sure of that major interrupt events are occurring. Signed-off-by:
Tomoya MORINAGA <tomoya.rohm@gmail.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
Tomoya MORINAGA authored
ISSUE: USB Suspend interrupts occur frequently. CAUSE: When it is called pch_udc_reconnect() in USB Suspend, it repeats reset and Suspend. SOLUTION: pch_udc_reconnect() does not enable all interrupts. When an enumeration event occurred the driver enables all interrupts. Signed-off-by:
Tomoya MORINAGA <tomoya.rohm@gmail.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-
Tomoya MORINAGA authored
ISSUE: After a USB cable is connect/disconnected, the system rarely freezes. CAUSE: Since the USB device controller cannot know to disconnect the USB cable, when it is used without detecting VBUS by GPIO, the UDC driver does not notify to USB Gadget. Since USB Gadget cannot know to disconnect, a false setting occurred when the USB cable is connected/disconnect repeatedly. Signed-off-by:
Tomoya MORINAGA <tomoya.rohm@gmail.com> Signed-off-by:
Felipe Balbi <balbi@ti.com>
-