- 28 Sep, 2017 10 commits
-
-
Dave Airlie authored
This is unused code. Signed-off-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Harry Wentland <harry.wentland@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Dave Airlie authored
This reduces code size. Signed-off-by:
-
Dave Airlie authored
This reduces code size for the bw calcs code. Signed-off-by:
-
Dave Airlie authored
This code isn't used at all in the kernel tree, perhaps it can wait to be imported when it is. It also does a lot of floating point calcs, so probably good to drop it until it's needed and we can ensure proper fpu accessors. Signed-off-by:
-
Dave Airlie authored
This just adds two accessor methods, and moves all the data to static const. v2: fix dcn build. Signed-off-by:
-
Dave Airlie authored
There was a global construct symbol in the module symbols, kill it. Signed-off-by:
-
Harry Wentland authored
Signed-off-by:
-
Harry Wentland authored
While reviewing I2C in DC identified a few places. Added a couple to the TODO list. 1) Connector info read See get_ext_display_connection_info On some boards the connector information has to be read through a special I2C channel. This line is only used for this purpose and only on driver init. 2) SCDC stuff This should all be reworked to go through DRM's SCDC code. When this is done some unnecessary I2C code can be retired as well. 3) Max TMDS clock read See dal_ddc_service_i2c_query_dp_dual_mode_adaptor This should happen in DRM as well. I haven't checked if there's currently functionality in DRM. If not we can propose something. 4) HDMI retimer programming Some boards have an HDMI retimer that we need to program to pass PHY compliance. 1 & 3 might be a good exercise if someone is looking for things to do. v2: Merge dp_dual_mode_adaptor TODO Acked-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by:
-
Harry Wentland authored
Abstractions are frowned upon. cocci script: virtual context virtual patch virtual org virtual report @@ expression ptr; @@ - dm_alloc(ptr) + kzalloc(ptr, GFP_KERNEL) @@ expression ptr, size; @@ - dm_realloc(ptr, size) + krealloc(ptr, size, GFP_KERNEL) @@ expression ptr; @@ - dm_free(ptr) + kfree(ptr) v2: use GFP_KERNEL, not GFP_ATOMIC. add cocci script Reviewed-by:
-
Daniel Vetter authored
Ok, here's one more attempt at scrolling through 130k diff. Overall verdict from me is that DC is big project, and like any big project it's never done. So at least for me the goal isn't to make things perfect, becaue if that's the hoop to jump through we wouldn't have any gpu drivers at all. More important is whether merging a new driver base will benefit the overall subsystem, and here this primarily means whether the DC team understands how upstream works and is designed, and whether the code is largely aligned with upstream (especially the atomic modeset) architecture. Looking back over the last two years I think that's the case now, so Acked-by:
Daniel Vetter <daniel.vetter@intel.com> Reviewed-by:
-
- 26 Sep, 2017 30 commits
-
-
Alex Deucher authored
Signed-off-by: -
Bhawanpreet Lakha authored
The pflip registor index was incorrect, this was overriding the macro and caused a dummy irq call. Signed-off-by:
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> Reviewed-by:
-
Shirish S authored
In the scenario of setting underlay, dc_validate_global_state() is called after constructing the context with all relevant bottom_pipe related configurations in dm_update_planes_state(). Currently, in dc_validate_global_state(), without checking for bottom_pipe's existence, the pipe_ctx structure is initialised to 0, hence nullyfying the plane_state of bottom_pipe which shall be accessed in populate_initial_data() called from bw_calcs(). Due to this null pointer access kernel panics and leads to reboot when underlay is tried to set. This patch fixes the issue by no longer clearing the top_pipe. This workaround is no longer required. Signed-off-by:
Shirish S <shirish.s@amd.com> Reviewed-by:
-
Harry Wentland authored
It got refactored away and was never cleaned. Signed-off-by:
-
Harry Wentland authored
Log DC init but default log level to 0 (default for amdgpu_dc_log) otherwise. Bug reporters can still make DC more chatty by using the dc_log module param. amdgpu.dc_log = 1 v2: Only provide runtime option, no compile time config Signed-off-by: -
Harry Wentland authored
Linux and Windows often desire different log levels. Signed-off-by:
-
Harry Wentland authored
We want to make DC less chatty but still allow bug reporters to provide more detailed logs. Signed-off-by:
-
Harry Wentland authored
Signed-off-by:
-
Harry Wentland authored
Signed-off-by:
-
Harry Wentland authored
Signed-off-by:
-
Harry Wentland authored
Signed-off-by:
-
Roman Li authored
- Fixing text console on FBC-enabled builds Signed-off-by:
Roman Li <Roman.Li@amd.com> Reviewed-by:
-
Vitaly Prosyak authored
Signed-off-by:
Vitaly Prosyak <vitaly.prosyak@amd.com> Reviewed-by:
Charlene Liu <Charlene.Liu@amd.com> Reviewed-by:
Tony Cheng <Tony.Cheng@amd.com> Acked-by:
-
Harry Wentland authored
The problem we're trying to fix is this (and similar): 1) X Desktop with single display 2) VT switch 3) Unplug display 4) VT switch back to X 5) re-plug same display Before this we'd fail at step 4 when trying to create a dc_stream_state because of a missing sink. This change will fake a sink in this case. The same scenario applies to S3 resume. Signed-off-by:
Andrey Grodzovsky <Andrey.Grodzovsky@amd.com> Acked-by:
-
Harry Wentland authored
Stop using amdgpu_connector and roll our own. There is no overlap with amdgpu. Signed-off-by:
-
pana authored
Signed-off-by:
Pandey, Arun <Arun.Pandey@amd.com> Reviewed-by:
-
Harry Wentland authored
This simplifies clock source reprogramming a bit. Signed-off-by:
-
Yue Hin Lau authored
Signed-off-by:
Yue Hin Lau <Yuehin.Lau@amd.com> Reviewed-by:
-
Eric Bernstein authored
Signed-off-by:
Eric Bernstein <eric.bernstein@amd.com> Reviewed-by:
-
Harry Wentland authored
This should be taken care of in validate now. All of timing sync is quite broken at the moment anyways. Will submit another patch set to address that. Signed-off-by:
-
Harry Wentland authored
Still one more in dc_validate_global Signed-off-by:
-
Harry Wentland authored
Powering down the clock source during unref is unsafe as we might want to unref during atomic_check Signed-off-by:
-
Yue Hin Lau authored
Signed-off-by:
-
Andrew Jiang authored
Since there was no return statement in the fail block immediately preceding the context_alloc_fail block, any failure within the function caused a context alloc failed error message to be printed. Since the context_alloc_fail block is only used once, move it to where the goto is directly and accompany it with a return statement. Signed-off-by:
Andrew Jiang <Andrew.Jiang@amd.com> Reviewed-by:
-
Tony Cheng authored
bug: default is mapped to no dithering. default to spatial dithering based on color depth Signed-off-by:
-
Harry Wentland authored
This should only happen on full update. If this ever happens on regular pageflips it needs to be debugged. Signed-off-by:
-
Charlene Liu authored
Signed-off-by:
-
Wenjing Liu authored
Signed-off-by:
Wenjing Liu <Wenjing.Liu@amd.com> Reviewed-by:
-
Hersen Wu authored
RV1 support only USB-C active DP-2-HDMI dongle. HPD short pulse is generated only for DP signal. When processing HPD short pulse, it must be DP active dongle. No need for I2C-Over-AUX detection. v2: Add description Signed-off-by:
Hersen Wu <hersenxs.wu@amd.com> Reviewed-by:
-
Shirish S authored
For MPO to work with per surface rendering and flipping, the previous logic of restricting plane[1] only as underlay needs to be removed. validate_surface_sets() now checks only the width and height bounds in case of underlay rather than checking format. Without this patch one cannot set underlay only. Signed-off-by:
-
