1. 07 Jan, 2024 15 commits
  2. 06 Jan, 2024 5 commits
    • Ahmed Zaki's avatar
      net: ethtool: reject unsupported RSS input xfrm values · 948f97f9
      Ahmed Zaki authored
      RXFH input_xfrm currently has three supported values: 0 (clear all),
      symmetric_xor and NO_CHANGE.
      
      Reject any other value sent from user-space.
      
      Fixes: 13e59344 ("net: ethtool: add support for symmetric-xor RSS hash")
      Suggested-by: default avatarJakub Kicinski <kuba@kernel.org>
      Signed-off-by: default avatarAhmed Zaki <ahmed.zaki@intel.com>
      Link: https://lore.kernel.org/r/20240104212653.394424-1-ahmed.zaki@intel.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      948f97f9
    • Benjamin Poirier's avatar
      selftests: forwarding: Avoid failures to source net/lib.sh · 2114e833
      Benjamin Poirier authored
      The expression "source ../lib.sh" added to net/forwarding/lib.sh in commit
      25ae948b ("selftests/net: add lib.sh") does not work for tests outside
      net/forwarding which source net/forwarding/lib.sh (1). It also does not
      work in some cases where only a subset of tests are exported (2).
      
      Avoid the problems mentioned above by replacing the faulty expression with
      a copy of the content from net/lib.sh which is used by files under
      net/forwarding.
      
      A more thorough solution which avoids duplicating content between
      net/lib.sh and net/forwarding/lib.sh has been posted here:
      https://lore.kernel.org/netdev/20231222135836.992841-1-bpoirier@nvidia.com/
      
      The approach in the current patch is a stopgap solution to avoid submitting
      large changes at the eleventh hour of this development cycle.
      
      Example of problem 1)
      
      tools/testing/selftests/drivers/net/bonding$ ./dev_addr_lists.sh
      ./net_forwarding_lib.sh: line 41: ../lib.sh: No such file or directory
      TEST: bonding cleanup mode active-backup                            [ OK ]
      TEST: bonding cleanup mode 802.3ad                                  [ OK ]
      TEST: bonding LACPDU multicast address to slave (from bond down)    [ OK ]
      TEST: bonding LACPDU multicast address to slave (from bond up)      [ OK ]
      
      An error message is printed but since the test does not use functions from
      net/lib.sh, the test results are not affected.
      
      Example of problem 2)
      
      tools/testing/selftests$ make install TARGETS="net/forwarding"
      tools/testing/selftests$ cd kselftest_install/net/forwarding/
      tools/testing/selftests/kselftest_install/net/forwarding$ ./pedit_ip.sh veth{0..3}
      lib.sh: line 41: ../lib.sh: No such file or directory
      TEST: ping                                                          [ OK ]
      TEST: ping6                                                         [ OK ]
      ./pedit_ip.sh: line 135: busywait: command not found
      TEST: dev veth1 ingress pedit ip src set 198.51.100.1               [FAIL]
              Expected to get 10 packets, but got .
      ./pedit_ip.sh: line 135: busywait: command not found
      TEST: dev veth2 egress pedit ip src set 198.51.100.1                [FAIL]
              Expected to get 10 packets, but got .
      ./pedit_ip.sh: line 135: busywait: command not found
      TEST: dev veth1 ingress pedit ip dst set 198.51.100.1               [FAIL]
              Expected to get 10 packets, but got .
      ./pedit_ip.sh: line 135: busywait: command not found
      TEST: dev veth2 egress pedit ip dst set 198.51.100.1                [FAIL]
              Expected to get 10 packets, but got .
      ./pedit_ip.sh: line 135: busywait: command not found
      TEST: dev veth1 ingress pedit ip6 src set 2001:db8:2::1             [FAIL]
              Expected to get 10 packets, but got .
      ./pedit_ip.sh: line 135: busywait: command not found
      TEST: dev veth2 egress pedit ip6 src set 2001:db8:2::1              [FAIL]
              Expected to get 10 packets, but got .
      ./pedit_ip.sh: line 135: busywait: command not found
      TEST: dev veth1 ingress pedit ip6 dst set 2001:db8:2::1             [FAIL]
              Expected to get 10 packets, but got .
      ./pedit_ip.sh: line 135: busywait: command not found
      TEST: dev veth2 egress pedit ip6 dst set 2001:db8:2::1              [FAIL]
              Expected to get 10 packets, but got .
      
      In this case, the test results are affected.
      
      Fixes: 25ae948b ("selftests/net: add lib.sh")
      Suggested-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Suggested-by: default avatarPetr Machata <petrm@nvidia.com>
      Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Tested-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarBenjamin Poirier <bpoirier@nvidia.com>
      Reviewed-by: default avatarHangbin Liu <liuhangbin@gmail.com>
      Link: https://lore.kernel.org/r/20240104141109.100672-1-bpoirier@nvidia.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      2114e833
    • Jakub Kicinski's avatar
      Merge tag 'for-netdev' of https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next · 8158a50f
      Jakub Kicinski authored
      Daniel Borkmann says:
      
      ====================
      pull-request: bpf-next 2024-01-05
      
      We've added 40 non-merge commits during the last 2 day(s) which contain
      a total of 73 files changed, 1526 insertions(+), 951 deletions(-).
      
      The main changes are:
      
      1) Fix a memory leak when streaming AF_UNIX sockets were inserted
         into multiple sockmap slots/maps, from John Fastabend.
      
      2) Fix gotol in s390 BPF JIT with large offsets, from Ilya Leoshkevich.
      
      3) Fix reattachment branch in bpf_tracing_prog_attach() and reject
         the request if there is no valid attach_btf, from Jiri Olsa.
      
      4) Remove deprecated bpfilter kernel leftovers given the project
         is developed in user space (https://github.com/facebook/bpfilter),
         from Quentin Deslandes.
      
      5) Relax tracing BPF program recursive attach rules given right now
         it is not possible to create tracing program call cycles,
         from Dmitrii Dolgov.
      
      6) Fix excessive memory consumption for the bpf_global_percpu_ma
         for systems with a large number of CPUs, from Yonghong Song.
      
      7) Small x86 BPF JIT cleanup to reuse emit_nops instead of open-coding
         memcpy of x86_nops, from Leon Hwang.
      
      8) Follow-up for libbpf to support __arg_ctx global function argument tag
         semantics to complement the merged kernel side, from Andrii Nakryiko.
      
      9) Introduce "volatile compare" macros for BPF selftests in order
         to make the latter more robust against compiler optimization,
         from Alexei Starovoitov.
      
      10) Small simplification in verifier's size checking of helper accesses
          along with additional selftests, from Andrei Matei.
      
      * tag 'for-netdev' of https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next: (40 commits)
        selftests/bpf: Test re-attachment fix for bpf_tracing_prog_attach
        bpf: Fix re-attachment branch in bpf_tracing_prog_attach
        selftests/bpf: Add test for recursive attachment of tracing progs
        bpf: Relax tracing prog recursive attach rules
        bpf, x86: Use emit_nops to replace memcpy x86_nops
        selftests/bpf: Test gotol with large offsets
        selftests/bpf: Double the size of test_loader log
        s390/bpf: Fix gotol with large offsets
        bpfilter: remove bpfilter
        bpf: Remove unnecessary cpu == 0 check in memalloc
        selftests/bpf: add __arg_ctx BTF rewrite test
        selftests/bpf: add arg:ctx cases to test_global_funcs tests
        libbpf: implement __arg_ctx fallback logic
        libbpf: move BTF loading step after relocation step
        libbpf: move exception callbacks assignment logic into relocation step
        libbpf: use stable map placeholder FDs
        libbpf: don't rely on map->fd as an indicator of map being created
        libbpf: use explicit map reuse flag to skip map creation steps
        libbpf: make uniform use of btf__fd() accessor inside libbpf
        selftests/bpf: Add a selftest with > 512-byte percpu allocation size
        ...
      ====================
      
      Link: https://lore.kernel.org/r/20240105170105.21070-1-daniel@iogearbox.netSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      8158a50f
    • Vadim Fedorenko's avatar
      ptp_ocp: adjust MAINTAINERS and mailmap · 795fd934
      Vadim Fedorenko authored
      The fb.com domain is going to be deprecated.
      Use personal one for kernel contributions.
      Signed-off-by: default avatarVadim Fedorenko <vadfed@fb.com>
      Reviewed-by: default avatarSimon Horman <horms@kernel.org>
      Link: https://lore.kernel.org/r/20240104172540.2379128-1-vadfed@meta.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      795fd934
    • Eric Dumazet's avatar
      geneve: use DEV_STATS_INC() · c72a657b
      Eric Dumazet authored
      geneve updates dev->stats fields locklessly.
      
      Adopt DEV_STATS_INC() to avoid races.
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Reviewed-by: default avatarSimon Horman <horms@kernel.org>
      Link: https://lore.kernel.org/r/20240104163633.2070538-1-edumazet@google.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      c72a657b
  3. 05 Jan, 2024 20 commits