Commits · eb162e1772f85231dabc789fb4bfea63d2d9df79 · Kirill Smelkov / linux

09 Dec, 2020 4 commits

NFSD: Fix sparse warning in nfs4proc.c · eb162e17

Chuck Lever authored Nov 30, 2020

linux/fs/nfsd/nfs4proc.c:1542:24: warning: incorrect type in assignment (different base types)
linux/fs/nfsd/nfs4proc.c:1542:24: expected restricted __be32 [assigned] [usertype] status
linux/fs/nfsd/nfs4proc.c:1542:24: got int

Clean-up: The dup_copy_fields() function returns only zero, so make
it return void for now, and get rid of the return code check.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

eb162e17

SUNRPC: Remove XDRBUF_SPARSE_PAGES flag in gss_proxy upcall · 5e54dafb

Chuck Lever authored Nov 24, 2020

There's no need to defer allocation of pages for the receive buffer.

- This upcall is quite infrequent
- gssp_alloc_receive_pages() can allocate the pages with GFP_KERNEL,
  unlike the transport
- gssp_alloc_receive_pages() knows exactly how many pages are needed
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Olga Kornievskaia <kolga@netapp.com>

5e54dafb

sunrpc: clean-up cache downcall · 4b5cff7e

Roberto Bergantinos Corpas authored Nov 27, 2020

We can simplify code around cache_downcall unifying memory
allocations using kvmalloc. This has the benefit of getting rid of
cache_slow_downcall (and queue_io_mutex), and also matches userland
allocation size and limits.
Signed-off-by: Roberto Bergantinos Corpas <rbergant@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

4b5cff7e

nfsd: Fix message level for normal termination · 4420440c

kazuo ito authored Nov 27, 2020

The warning message from nfsd terminating normally
can confuse system adminstrators or monitoring software.

Though it's not exactly fair to pin-point a commit where it
originated, the current form in the current place started
to appear in:

Fixes: e096bbc6 ("knfsd: remove special handling for SIGHUP")
Signed-off-by: kazuo ito <kzpn200@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

4420440c

30 Nov, 2020 36 commits
- NFSD: Remove macros that are no longer used · 5cfc822f
  Chuck Lever authored Nov 04, 2020
```
Now that all the NFSv4 decoder functions have been converted to
make direct calls to the xdr helpers, remove the unused C macros.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  5cfc822f
- NFSD: Replace READ* macros in nfsd4_decode_compound() · d9b74bda
  Chuck Lever authored Nov 04, 2020
```
And clean-up: Now that we have removed the DECODE_TAIL macro from
nfsd4_decode_compound(), we observe that there's no benefit for
nfsd4_decode_compound() to return nfs_ok or nfserr_bad_xdr only to
have its sole caller convert those values to one or zero,
respectively. Have nfsd4_decode_compound() return 1/0 instead.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  d9b74bda
- NFSD: Make nfsd4_ops::opnum a u32 · 3a237b4a
  Chuck Lever authored Nov 22, 2020
```
Avoid passing a "pointer to int" argument to xdr_stream_decode_u32.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  3a237b4a
- NFSD: Replace READ* macros in nfsd4_decode_listxattrs() · 2212036c
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  2212036c
- NFSD: Replace READ* macros in nfsd4_decode_setxattr() · 403366a7
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  403366a7
- NFSD: Replace READ* macros in nfsd4_decode_xattr_name() · 830c7150
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  830c7150
- NFSD: Replace READ* macros in nfsd4_decode_clone() · 3dfd0b0e
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  3dfd0b0e
- NFSD: Replace READ* macros in nfsd4_decode_seek() · 9d32b412
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  9d32b412
- NFSD: Replace READ* macros in nfsd4_decode_offload_status() · 2846bb05
  Chuck Lever authored Nov 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  2846bb05
- NFSD: Replace READ* macros in nfsd4_decode_copy_notify() · f9a953fb
  Chuck Lever authored Nov 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  f9a953fb
- NFSD: Replace READ* macros in nfsd4_decode_copy() · e8febea7
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  e8febea7
- NFSD: Replace READ* macros in nfsd4_decode_nl4_server() · f49e4b4d
  Chuck Lever authored Nov 16, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  f49e4b4d
- NFSD: Replace READ* macros in nfsd4_decode_fallocate() · 6aef27aa
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  6aef27aa
- NFSD: Replace READ* macros in nfsd4_decode_reclaim_complete() · 0d646784
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  0d646784
- NFSD: Replace READ* macros in nfsd4_decode_destroy_clientid() · c95f2ec3
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  c95f2ec3
- NFSD: Replace READ* macros in nfsd4_decode_test_stateid() · b7a0c8f6
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  b7a0c8f6
- NFSD: Replace READ* macros in nfsd4_decode_sequence() · cf907b11
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  cf907b11
- NFSD: Replace READ* macros in nfsd4_decode_secinfo_no_name() · 53d70873
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  53d70873
- NFSD: Replace READ* macros in nfsd4_decode_layoutreturn() · 645fcad3
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  645fcad3
- NFSD: Replace READ* macros in nfsd4_decode_layoutget() · c8e88e3a
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  c8e88e3a
- NFSD: Replace READ* macros in nfsd4_decode_layoutcommit() · 5185980d
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  5185980d
- NFSD: Replace READ* macros in nfsd4_decode_getdeviceinfo() · 04495971
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  04495971
- NFSD: Replace READ* macros in nfsd4_decode_free_stateid() · aec387d5
  Chuck Lever authored Nov 01, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  aec387d5
- NFSD: Replace READ* macros in nfsd4_decode_destroy_session() · 94e254af
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  94e254af
- NFSD: Replace READ* macros in nfsd4_decode_create_session() · 81243e3f
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  81243e3f
- NFSD: Add a helper to decode channel_attrs4 · 3a3f1fba
  Chuck Lever authored Nov 16, 2020
```
De-duplicate some code.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  3a3f1fba
- NFSD: Add a helper to decode nfs_impl_id4 · 10ff8422
  Chuck Lever authored Nov 16, 2020
```
Refactor for clarity.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  10ff8422
- NFSD: Add a helper to decode state_protect4_a · 523ec6ed
  Chuck Lever authored Nov 02, 2020
```
Refactor for clarity.

Also, remove a stale comment. Commit ed941643 ("nfsd: implement
machine credential support for some operations") added support for
SP4_MACH_CRED, so state_protect_a is no longer completely ignored.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  523ec6ed
- NFSD: Add a separate decoder for ssv_sp_parms · 547bfeb4
  Chuck Lever authored Nov 03, 2020
```
Refactor for clarity.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  547bfeb4
- NFSD: Add a separate decoder to handle state_protect_ops · 2548aa78
  Chuck Lever authored Nov 03, 2020
```
Refactor for clarity and de-duplication of code.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  2548aa78
- NFSD: Replace READ* macros in nfsd4_decode_bind_conn_to_session() · 571e0451
  Chuck Lever authored Nov 03, 2020
```
A dedicated sessionid4 decoder is introduced that will be used by
other operation decoders in subsequent patches.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  571e0451
- NFSD: Replace READ* macros in nfsd4_decode_backchannel_ctl() · 0f81d960
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  0f81d960
- NFSD: Replace READ* macros in nfsd4_decode_cb_sec() · 1a994408
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  1a994408
- NFSD: Replace READ* macros in nfsd4_decode_release_lockowner() · a4a80c15
  Chuck Lever authored Nov 04, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  a4a80c15
- NFSD: Replace READ* macros in nfsd4_decode_write() · 244e2bef
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  244e2bef
- NFSD: Replace READ* macros in nfsd4_decode_verify() · 67cd453e
  Chuck Lever authored Nov 03, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
  67cd453e