1. 11 Aug, 2014 2 commits
    • Arend van Spriel's avatar
      brcmfmac: fix curly brace mistake in brcmf_pcie_handle_mb_data() · ebcc2f51
      Arend van Spriel authored
      Running coccicheck on brcm80211 drivers resulted in following report:
      
      $ make coccicheck MODE=report M=drivers/net/wireless/brcm80211
      
        drivers/net/wireless/brcm80211/brcmfmac/pcie.c:595:2-43:
          code aligned with following code on line 596
      
      It revealed that due to a merge failure a block statement lost its
      curly braces where it should not.
      Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      ebcc2f51
    • Ronald Wahl's avatar
      carl9170: fix sending URBs with wrong type when using full-speed · 671796dd
      Ronald Wahl authored
      The driver assumes that endpoint 4 is always an interrupt endpoint.
      Unfortunately the type differs between high-speed and full-speed
      configurations while in the former case it is indeed an interrupt
      endpoint this is not true for the latter case - here it is a bulk
      endpoint. When sending URBs with the wrong type the kernel will
      generate a warning message including backtrace. In this specific
      case there will be a huge amount of warnings which can bring the system
      to freeze.
      
      To fix this we are now sending URBs to endpoint 4 using the type
      found in the endpoint descriptor.
      
      A side note: The carl9170 firmware currently specifies endpoint 4 as
      interrupt endpoint even in the full-speed configuration but this has
      no relevance because before this firmware is loaded the endpoint type
      is as described above and after the firmware is running the stick is not
      reenumerated and so the old descriptor is used.
      Signed-off-by: default avatarRonald Wahl <ronald.wahl@raritan.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      671796dd
  2. 07 Aug, 2014 38 commits